From: "Mylène Josserand" <mylene.josserand@bootlin.com> To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Cc: linux@armlinux.org.uk, maxime.ripard@bootlin.com, wens@csie.org, marc.zyngier@arm.com, mark.rutland@arm.com, robh+dt@kernel.org, horms@verge.net.au, geert@linux-m68k.org, magnus.damm@gmail.com, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, clabbe.montjoie@gmail.com, quentin.schulz@bootlin.com, thomas.petazzoni@bootlin.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 07/11] ARM: sun9i: smp: Rename clusters's power-off Date: Wed, 18 Apr 2018 07:51:51 +0200 [thread overview] Message-ID: <20180418075151.3542f7cd@dell-desktop.home> (raw) In-Reply-To: <fd19ec26-9240-5ae2-fc6e-d3918ab91d01@cogentembedded.com> Hello, On Tue, 17 Apr 2018 11:21:02 +0300 Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote: > Hello! > > On 4/17/2018 12:50 AM, Mylène Josserand wrote: > > > To prepare the support for sun8i-a83t, rename the variable name > > s/variable/macro/ maybe? Also "rename the ... name" sounds tautological... Thank you for the correction. Best regards, Mylène -- Mylène Josserand, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering http://bootlin.com > > > that handles the power-off of clusters because it is different from > > sun9i-a80 to sun8i-a83t. > > > > The power off register for clusters are different from a80 and a83t. > > > > Signed-off-by: Mylène Josserand <mylene.josserand@bootlin.com> > > Acked-by: Maxime Ripard <maxime.ripard@bootlin.com> > > Reviewed-by: Chen-Yu Tsai <wens@csie.org> > > --- > > arch/arm/mach-sunxi/mc_smp.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/arch/arm/mach-sunxi/mc_smp.c b/arch/arm/mach-sunxi/mc_smp.c > > index 727968d6a3e5..03f021d0c73e 100644 > > --- a/arch/arm/mach-sunxi/mc_smp.c > > +++ b/arch/arm/mach-sunxi/mc_smp.c > > @@ -60,7 +60,7 @@ > > #define PRCM_CPU_PO_RST_CTRL_CORE(n) BIT(n) > > #define PRCM_CPU_PO_RST_CTRL_CORE_ALL 0xf > > #define PRCM_PWROFF_GATING_REG(c) (0x100 + 0x4 * (c)) > > -#define PRCM_PWROFF_GATING_REG_CLUSTER BIT(4) > > +#define PRCM_PWROFF_GATING_REG_CLUSTER_SUN9I BIT(4) > > #define PRCM_PWROFF_GATING_REG_CORE(n) BIT(n) > > #define PRCM_PWR_SWITCH_REG(c, cpu) (0x140 + 0x10 * (c) + 0x4 * (cpu)) > > #define PRCM_CPU_SOFT_ENTRY_REG 0x164 > > @@ -255,7 +255,7 @@ static int sunxi_cluster_powerup(unsigned int cluster) > > > > /* clear cluster power gate */ > > reg = readl(prcm_base + PRCM_PWROFF_GATING_REG(cluster)); > > - reg &= ~PRCM_PWROFF_GATING_REG_CLUSTER; > > + reg &= ~PRCM_PWROFF_GATING_REG_CLUSTER_SUN9I; > > writel(reg, prcm_base + PRCM_PWROFF_GATING_REG(cluster)); > > udelay(20); > > > > @@ -452,7 +452,7 @@ static int sunxi_cluster_powerdown(unsigned int cluster) > > /* gate cluster power */ > > pr_debug("%s: gate cluster power\n", __func__); > > reg = readl(prcm_base + PRCM_PWROFF_GATING_REG(cluster)); > > - reg |= PRCM_PWROFF_GATING_REG_CLUSTER; > > + reg |= PRCM_PWROFF_GATING_REG_CLUSTER_SUN9I; > > writel(reg, prcm_base + PRCM_PWROFF_GATING_REG(cluster)); > > udelay(20); > > > > MBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: mylene.josserand@bootlin.com (Mylène Josserand) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v6 07/11] ARM: sun9i: smp: Rename clusters's power-off Date: Wed, 18 Apr 2018 07:51:51 +0200 [thread overview] Message-ID: <20180418075151.3542f7cd@dell-desktop.home> (raw) In-Reply-To: <fd19ec26-9240-5ae2-fc6e-d3918ab91d01@cogentembedded.com> Hello, On Tue, 17 Apr 2018 11:21:02 +0300 Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote: > Hello! > > On 4/17/2018 12:50 AM, Myl?ne Josserand wrote: > > > To prepare the support for sun8i-a83t, rename the variable name > > s/variable/macro/ maybe? Also "rename the ... name" sounds tautological... Thank you for the correction. Best regards, Myl?ne -- Myl?ne Josserand, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering http://bootlin.com > > > that handles the power-off of clusters because it is different from > > sun9i-a80 to sun8i-a83t. > > > > The power off register for clusters are different from a80 and a83t. > > > > Signed-off-by: Myl?ne Josserand <mylene.josserand@bootlin.com> > > Acked-by: Maxime Ripard <maxime.ripard@bootlin.com> > > Reviewed-by: Chen-Yu Tsai <wens@csie.org> > > --- > > arch/arm/mach-sunxi/mc_smp.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/arch/arm/mach-sunxi/mc_smp.c b/arch/arm/mach-sunxi/mc_smp.c > > index 727968d6a3e5..03f021d0c73e 100644 > > --- a/arch/arm/mach-sunxi/mc_smp.c > > +++ b/arch/arm/mach-sunxi/mc_smp.c > > @@ -60,7 +60,7 @@ > > #define PRCM_CPU_PO_RST_CTRL_CORE(n) BIT(n) > > #define PRCM_CPU_PO_RST_CTRL_CORE_ALL 0xf > > #define PRCM_PWROFF_GATING_REG(c) (0x100 + 0x4 * (c)) > > -#define PRCM_PWROFF_GATING_REG_CLUSTER BIT(4) > > +#define PRCM_PWROFF_GATING_REG_CLUSTER_SUN9I BIT(4) > > #define PRCM_PWROFF_GATING_REG_CORE(n) BIT(n) > > #define PRCM_PWR_SWITCH_REG(c, cpu) (0x140 + 0x10 * (c) + 0x4 * (cpu)) > > #define PRCM_CPU_SOFT_ENTRY_REG 0x164 > > @@ -255,7 +255,7 @@ static int sunxi_cluster_powerup(unsigned int cluster) > > > > /* clear cluster power gate */ > > reg = readl(prcm_base + PRCM_PWROFF_GATING_REG(cluster)); > > - reg &= ~PRCM_PWROFF_GATING_REG_CLUSTER; > > + reg &= ~PRCM_PWROFF_GATING_REG_CLUSTER_SUN9I; > > writel(reg, prcm_base + PRCM_PWROFF_GATING_REG(cluster)); > > udelay(20); > > > > @@ -452,7 +452,7 @@ static int sunxi_cluster_powerdown(unsigned int cluster) > > /* gate cluster power */ > > pr_debug("%s: gate cluster power\n", __func__); > > reg = readl(prcm_base + PRCM_PWROFF_GATING_REG(cluster)); > > - reg |= PRCM_PWROFF_GATING_REG_CLUSTER; > > + reg |= PRCM_PWROFF_GATING_REG_CLUSTER_SUN9I; > > writel(reg, prcm_base + PRCM_PWROFF_GATING_REG(cluster)); > > udelay(20); > > > > MBR, Sergei
next prev parent reply other threads:[~2018-04-18 5:52 UTC|newest] Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-16 21:50 [PATCH v6 00/11] Sunxi: Add SMP support on A83T Mylène Josserand 2018-04-16 21:50 ` Mylène Josserand 2018-04-16 21:50 ` [PATCH v6 01/11] ARM: sunxi: smp: Move assembly code into a file Mylène Josserand 2018-04-16 21:50 ` Mylène Josserand 2018-04-16 21:50 ` Mylène Josserand 2018-04-17 3:12 ` Chen-Yu Tsai 2018-04-17 3:12 ` Chen-Yu Tsai 2018-04-17 11:17 ` Maxime Ripard 2018-04-17 11:17 ` Maxime Ripard 2018-04-17 11:25 ` Chen-Yu Tsai 2018-04-17 11:25 ` Chen-Yu Tsai 2018-04-18 8:45 ` Maxime Ripard 2018-04-18 8:45 ` Maxime Ripard 2018-04-18 10:05 ` Chen-Yu Tsai 2018-04-18 10:05 ` Chen-Yu Tsai 2018-04-19 6:53 ` Mylène Josserand 2018-04-19 6:53 ` Mylène Josserand 2018-04-17 6:36 ` kbuild test robot 2018-04-17 6:36 ` kbuild test robot 2018-04-17 6:36 ` kbuild test robot 2018-04-17 6:36 ` kbuild test robot 2018-04-17 10:46 ` kbuild test robot 2018-04-17 10:46 ` kbuild test robot 2018-04-17 10:46 ` kbuild test robot 2018-04-17 10:46 ` kbuild test robot 2018-04-16 21:50 ` [PATCH v6 02/11] ARM: dts: sun8i: Add CPUCFG device node for A83T dtsi Mylène Josserand 2018-04-16 21:50 ` Mylène Josserand 2018-04-16 21:50 ` [PATCH v6 03/11] ARM: dts: sun8i: Add R_CPUCFG device node for the " Mylène Josserand 2018-04-16 21:50 ` Mylène Josserand 2018-04-17 3:13 ` Chen-Yu Tsai 2018-04-17 3:13 ` Chen-Yu Tsai 2018-04-16 21:50 ` [PATCH v6 04/11] ARM: dts: sun8i: a83t: Add CCI-400 node Mylène Josserand 2018-04-16 21:50 ` Mylène Josserand 2018-04-16 21:50 ` [PATCH v6 05/11] ARM: smp: Add initialization of CNTVOFF Mylène Josserand 2018-04-16 21:50 ` Mylène Josserand 2018-04-18 9:30 ` Geert Uytterhoeven 2018-04-18 9:30 ` Geert Uytterhoeven 2018-04-18 10:01 ` Mylène Josserand 2018-04-18 10:01 ` Mylène Josserand 2018-04-16 21:50 ` [PATCH v6 06/11] ARM: sunxi: " Mylène Josserand 2018-04-16 21:50 ` Mylène Josserand 2018-04-16 21:50 ` [PATCH v6 07/11] ARM: sun9i: smp: Rename clusters's power-off Mylène Josserand 2018-04-16 21:50 ` Mylène Josserand 2018-04-17 8:21 ` Sergei Shtylyov 2018-04-17 8:21 ` Sergei Shtylyov 2018-04-17 8:21 ` Sergei Shtylyov 2018-04-18 5:51 ` Mylène Josserand [this message] 2018-04-18 5:51 ` Mylène Josserand 2018-04-16 21:50 ` [PATCH v6 08/11] ARM: sun9i: smp: Add is_sun8i field Mylène Josserand 2018-04-16 21:50 ` Mylène Josserand 2018-04-17 7:52 ` Maxime Ripard 2018-04-17 7:52 ` Maxime Ripard 2018-04-17 7:57 ` Chen-Yu Tsai 2018-04-17 7:57 ` Chen-Yu Tsai 2018-04-17 11:19 ` Maxime Ripard 2018-04-17 11:19 ` Maxime Ripard 2018-04-16 21:50 ` [PATCH v6 09/11] ARM: sun8i: smp: Add support for A83T Mylène Josserand 2018-04-16 21:50 ` Mylène Josserand 2018-04-17 11:20 ` Maxime Ripard 2018-04-17 11:20 ` Maxime Ripard 2018-04-18 5:46 ` Mylène Josserand 2018-04-18 5:46 ` Mylène Josserand 2018-04-16 21:50 ` [PATCH v6 10/11] ARM: dts: sun8i: Add enable-method for SMP support for the A83T SoC Mylène Josserand 2018-04-16 21:50 ` Mylène Josserand 2018-04-16 21:50 ` [PATCH v6 11/11] ARM: shmobile: Convert file to use cntvoff Mylène Josserand 2018-04-16 21:50 ` Mylène Josserand 2018-04-18 9:36 ` Geert Uytterhoeven 2018-04-18 9:36 ` Geert Uytterhoeven 2018-04-18 10:03 ` Mylène Josserand 2018-04-18 10:03 ` Mylène Josserand 2018-04-18 13:48 ` Simon Horman 2018-04-18 13:48 ` Simon Horman 2018-04-19 6:40 ` Mylène Josserand 2018-04-19 6:40 ` Mylène Josserand 2018-04-17 2:15 ` [PATCH v6 00/11] Sunxi: Add SMP support on A83T Ondřej Jirman 2018-04-17 2:15 ` Ondřej Jirman 2018-04-17 2:15 ` Ondřej Jirman 2018-04-17 2:15 ` Ondřej Jirman 2018-04-18 5:50 ` Mylène Josserand 2018-04-18 5:50 ` Mylène Josserand
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180418075151.3542f7cd@dell-desktop.home \ --to=mylene.josserand@bootlin.com \ --cc=clabbe.montjoie@gmail.com \ --cc=devicetree@vger.kernel.org \ --cc=geert@linux-m68k.org \ --cc=horms@verge.net.au \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=magnus.damm@gmail.com \ --cc=marc.zyngier@arm.com \ --cc=mark.rutland@arm.com \ --cc=maxime.ripard@bootlin.com \ --cc=quentin.schulz@bootlin.com \ --cc=robh+dt@kernel.org \ --cc=sergei.shtylyov@cogentembedded.com \ --cc=thomas.petazzoni@bootlin.com \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.