From: jacopo mondi <jacopo@jmondi.org> To: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> Cc: Jacopo Mondi <jacopo+renesas@jmondi.org>, architt@codeaurora.org, a.hajda@samsung.com, Laurent.pinchart@ideasonboard.com, airlied@linux.ie, horms@verge.net.au, magnus.damm@gmail.com, geert@linux-m68k.org, niklas.soderlund@ragnatech.se, sergei.shtylyov@cogentembedded.com, robh+dt@kernel.org, mark.rutland@arm.com, dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 2/2] drm: bridge: Add thc63lvd1024 LVDS decoder driver Date: Thu, 19 Apr 2018 14:33:55 +0200 [thread overview] Message-ID: <20180419123355.GB4235@w540> (raw) In-Reply-To: <241462f3-0396-c763-6fb4-aff8fc5d29bd@mentor.com> [-- Attachment #1: Type: text/plain, Size: 2219 bytes --] Hi Vladimir, On Thu, Apr 19, 2018 at 02:18:30PM +0300, Vladimir Zapolskiy wrote: > Hi Jacopo, > > On 04/10/2018 01:53 PM, Jacopo Mondi wrote: > > Add DRM bridge driver for Thine THC63LVD1024 LVDS to digital parallel > > output converter. > > > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > > Reviewed-by: Andrzej Hajda <a.hajda@samsung.com> > > Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > > Reviewed-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> > Thanks. FYI I sent v9 yesterday with a minimal change compared to v8. > Generally I have only one pretty ignorable comment. > > > + > > +enum thc63_ports { > > + THC63_LVDS_IN0, > > + THC63_LVDS_IN1, > > + THC63_RGB_OUT0, > > + THC63_RGB_OUT1, > > +}; > > + > > The driver uses only THC63_RGB_OUT0 value, or port@2, and MODE{0,1,2} IC > configuration is ignored. > > I don't know if right from the beginning it would be better to support > dual-out modes, preferably both single-in and dual-in ones. Will it > impact port enumeration? The bindings have been designed to support dual in/out modes, as you can see there are 4 possible ports described there: Required video port nodes: - port@0: First LVDS input port - port@2: First digital CMOS/TTL parallel output Optional video port nodes: - port@1: Second LVDS input port - port@3: Second digital CMOS/TTL parallel output Future extension should not require changing the port enumeration, just add a property to specify the selected mode. > > I do understand that the extension is possible, and likely only hardware > accessibility postpones it. Yes, hardware on one side, but also what I think is a shortcoming of DRM (which exists in other sub-systems, say v4l2) that matches devices on their OF device nodes and makes cumbersome handling drivers wanting to register on 'port' nodes instead, as it would happen if you have 2 input endpoints. See my [1] note here: https://lkml.org/lkml/2018/3/9/422 And this reply to Archit's comment which has been left floating as it is not a real issue (yet): https://lkml.org/lkml/2018/3/10/214 Thanks j > > -- > With best wishes, > Vladimir [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: jacopo mondi <jacopo@jmondi.org> To: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, sergei.shtylyov@cogentembedded.com, airlied@linux.ie, dri-devel@lists.freedesktop.org, magnus.damm@gmail.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-renesas-soc@vger.kernel.org, horms@verge.net.au, Jacopo Mondi <jacopo+renesas@jmondi.org>, Laurent.pinchart@ideasonboard.com, niklas.soderlund@ragnatech.se, geert@linux-m68k.org Subject: Re: [PATCH v8 2/2] drm: bridge: Add thc63lvd1024 LVDS decoder driver Date: Thu, 19 Apr 2018 14:33:55 +0200 [thread overview] Message-ID: <20180419123355.GB4235@w540> (raw) In-Reply-To: <241462f3-0396-c763-6fb4-aff8fc5d29bd@mentor.com> [-- Attachment #1.1: Type: text/plain, Size: 2219 bytes --] Hi Vladimir, On Thu, Apr 19, 2018 at 02:18:30PM +0300, Vladimir Zapolskiy wrote: > Hi Jacopo, > > On 04/10/2018 01:53 PM, Jacopo Mondi wrote: > > Add DRM bridge driver for Thine THC63LVD1024 LVDS to digital parallel > > output converter. > > > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > > Reviewed-by: Andrzej Hajda <a.hajda@samsung.com> > > Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > > Reviewed-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> > Thanks. FYI I sent v9 yesterday with a minimal change compared to v8. > Generally I have only one pretty ignorable comment. > > > + > > +enum thc63_ports { > > + THC63_LVDS_IN0, > > + THC63_LVDS_IN1, > > + THC63_RGB_OUT0, > > + THC63_RGB_OUT1, > > +}; > > + > > The driver uses only THC63_RGB_OUT0 value, or port@2, and MODE{0,1,2} IC > configuration is ignored. > > I don't know if right from the beginning it would be better to support > dual-out modes, preferably both single-in and dual-in ones. Will it > impact port enumeration? The bindings have been designed to support dual in/out modes, as you can see there are 4 possible ports described there: Required video port nodes: - port@0: First LVDS input port - port@2: First digital CMOS/TTL parallel output Optional video port nodes: - port@1: Second LVDS input port - port@3: Second digital CMOS/TTL parallel output Future extension should not require changing the port enumeration, just add a property to specify the selected mode. > > I do understand that the extension is possible, and likely only hardware > accessibility postpones it. Yes, hardware on one side, but also what I think is a shortcoming of DRM (which exists in other sub-systems, say v4l2) that matches devices on their OF device nodes and makes cumbersome handling drivers wanting to register on 'port' nodes instead, as it would happen if you have 2 input endpoints. See my [1] note here: https://lkml.org/lkml/2018/3/9/422 And this reply to Archit's comment which has been left floating as it is not a real issue (yet): https://lkml.org/lkml/2018/3/10/214 Thanks j > > -- > With best wishes, > Vladimir [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 819 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-04-19 12:34 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-10 10:53 [PATCH v8 0/2] drm: Add Thine THC63LVD1024 LVDS decoder bridge Jacopo Mondi 2018-04-10 10:53 ` [PATCH v8 1/2] dt-bindings: display: bridge: Document THC63LVD1024 LVDS decoder Jacopo Mondi 2018-04-13 21:12 ` Rob Herring 2018-04-13 21:12 ` Rob Herring 2018-04-19 9:44 ` Vladimir Zapolskiy 2018-04-19 9:44 ` Vladimir Zapolskiy 2018-04-19 9:48 ` Vladimir Zapolskiy 2018-04-19 9:48 ` Vladimir Zapolskiy 2018-04-19 10:10 ` Vladimir Zapolskiy 2018-04-19 10:10 ` Vladimir Zapolskiy 2018-04-19 10:32 ` jacopo mondi 2018-04-19 10:32 ` jacopo mondi 2018-04-10 10:53 ` [PATCH v8 2/2] drm: bridge: Add thc63lvd1024 LVDS decoder driver Jacopo Mondi 2018-04-13 16:28 ` jacopo mondi 2018-04-13 16:28 ` jacopo mondi 2018-04-19 11:18 ` Vladimir Zapolskiy 2018-04-19 11:18 ` Vladimir Zapolskiy 2018-04-19 12:33 ` jacopo mondi [this message] 2018-04-19 12:33 ` jacopo mondi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180419123355.GB4235@w540 \ --to=jacopo@jmondi.org \ --cc=Laurent.pinchart@ideasonboard.com \ --cc=a.hajda@samsung.com \ --cc=airlied@linux.ie \ --cc=architt@codeaurora.org \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=geert@linux-m68k.org \ --cc=horms@verge.net.au \ --cc=jacopo+renesas@jmondi.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=magnus.damm@gmail.com \ --cc=mark.rutland@arm.com \ --cc=niklas.soderlund@ragnatech.se \ --cc=robh+dt@kernel.org \ --cc=sergei.shtylyov@cogentembedded.com \ --cc=vladimir_zapolskiy@mentor.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.