Re: [PATCH] KVM: s390: reset crypto attributes for all vcpus

From: kbuild test robot <lkp@intel.com>
To: Tony Krowiak <akrowiak@linux.vnet.ibm.com>
Cc: kbuild-all@01.org, linux-s390@vger.kernel.org,
	linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
	borntraeger@de.ibm.com, cohuck@redhat.com,
	pmorel@linux.vnet.ibm.com, pasic@linux.vnet.ibm.com,
	akrowiak@linux.vnet.ibm.com, pbonzini@redhat.com,
	rkrcmar@redhat.com
Subject: Re: [PATCH] KVM: s390: reset crypto attributes for all vcpus
Date: Sat, 21 Apr 2018 08:11:00 +0800	[thread overview]
Message-ID: <201804210852.eaNyyLPe%fengguang.wu@intel.com> (raw)
In-Reply-To: <1524172432-26211-1-git-send-email-akrowiak@linux.vnet.ibm.com>

[-- Attachment #1: Type: text/plain, Size: 2790 bytes --]

Hi Tony,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on s390/features]
[also build test ERROR on v4.17-rc1 next-20180420]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Tony-Krowiak/KVM-s390-reset-crypto-attributes-for-all-vcpus/20180421-050734
base:   https://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git features
config: s390-allyesconfig (attached as .config)
compiler: s390x-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=s390 

All error/warnings (new ones prefixed by >>):

   arch/s390/kvm/kvm-s390.c: In function 'kvm_s390_vcpu_crypto_reset_all':
>> arch/s390/kvm/kvm-s390.c:800:10: error: implicit declaration of function 'kvm_s390_vcpu_crypto_setup'; did you mean 'kvm_s390_vcpu_crypto_reset_all'? [-Werror=implicit-function-declaration]
             kvm_s390_vcpu_crypto_setup(vcpu);
             ^~~~~~~~~~~~~~~~~~~~~~~~~~
             kvm_s390_vcpu_crypto_reset_all
   arch/s390/kvm/kvm-s390.c: At top level:
>> arch/s390/kvm/kvm-s390.c:805:13: warning: conflicting types for 'kvm_s390_vcpu_crypto_setup'
    static void kvm_s390_vcpu_crypto_setup(struct kvm_vcpu *vcpu);
                ^~~~~~~~~~~~~~~~~~~~~~~~~~
>> arch/s390/kvm/kvm-s390.c:805:13: error: static declaration of 'kvm_s390_vcpu_crypto_setup' follows non-static declaration
   arch/s390/kvm/kvm-s390.c:800:10: note: previous implicit declaration of 'kvm_s390_vcpu_crypto_setup' was here
             kvm_s390_vcpu_crypto_setup(vcpu);
             ^~~~~~~~~~~~~~~~~~~~~~~~~~
   arch/s390/kvm/kvm-s390.c: In function 'kvm_s390_vm_set_crypto':
   arch/s390/kvm/kvm-s390.c:810:6: warning: unused variable 'i' [-Wunused-variable]
     int i;
         ^
   arch/s390/kvm/kvm-s390.c:809:19: warning: unused variable 'vcpu' [-Wunused-variable]
     struct kvm_vcpu *vcpu;
                      ^~~~
   cc1: some warnings being treated as errors

vim +800 arch/s390/kvm/kvm-s390.c

   791	
   792	void kvm_s390_vcpu_crypto_reset_all(struct kvm *kvm)
   793	 {
   794		int i;
   795		struct kvm_vcpu *vcpu;
   796	
   797		kvm_s390_vcpu_block_all(kvm);
   798	
   799		kvm_for_each_vcpu(i, vcpu, kvm)
 > 800		        kvm_s390_vcpu_crypto_setup(vcpu);
   801	
   802		kvm_s390_vcpu_unblock_all(kvm);
   803	}
   804	
 > 805	static void kvm_s390_vcpu_crypto_setup(struct kvm_vcpu *vcpu);
   806	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 49275 bytes --]