From: Jonathan Cameron <jic23@kernel.org> To: Brian Masney <masneyb@onstation.org> Cc: devel@driverdev.osuosl.org, lars@metafoo.de, linux-iio@vger.kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, Jon.Brenner@ams.com, pmeerw@pmeerw.net, knaack.h@gmx.de Subject: Re: [PATCH 01/13] staging: iio: tsl2x7x: move integration_time* attributes to IIO_INTENSITY channel Date: Sat, 21 Apr 2018 17:13:08 +0100 [thread overview] Message-ID: <20180421171308.3f67c3f8@archlinux> (raw) In-Reply-To: <20180421004153.19073-2-masneyb@onstation.org> On Fri, 20 Apr 2018 20:41:41 -0400 Brian Masney <masneyb@onstation.org> wrote: > The integration_time* attributes are currently associated with the > IIO_LIGHT channel but should be associated with the IIO_INTENSITY > channel. Directory listing of the sysfs attributes for a TSL2772 > with this patch applied: > > dev > events > in_illuminance0_calibrate > in_illuminance0_calibscale_available > in_illuminance0_input > in_illuminance0_lux_table > in_illuminance0_target_input > in_intensity0_calibbias > in_intensity0_calibscale > in_intensity0_integration_time > in_intensity0_integration_time_available > in_intensity0_raw > in_intensity1_raw > in_proximity0_calibrate > in_proximity0_calibscale > in_proximity0_calibscale_available > in_proximity0_raw > name > of_node > power > subsystem > uevent > > Signed-off-by: Brian Masney <masneyb@onstation.org> Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > --- > drivers/staging/iio/light/tsl2x7x.c | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/drivers/staging/iio/light/tsl2x7x.c b/drivers/staging/iio/light/tsl2x7x.c > index 9991b0483956..eeccfbb0eb1f 100644 > --- a/drivers/staging/iio/light/tsl2x7x.c > +++ b/drivers/staging/iio/light/tsl2x7x.c > @@ -827,7 +827,7 @@ in_illuminance0_calibscale_available_show(struct device *dev, > > static IIO_CONST_ATTR(in_proximity0_calibscale_available, "1 2 4 8"); > > -static IIO_CONST_ATTR(in_illuminance0_integration_time_available, > +static IIO_CONST_ATTR(in_intensity0_integration_time_available, > ".00272 - .696"); > > static ssize_t in_illuminance0_target_input_show(struct device *dev, > @@ -1358,7 +1358,7 @@ static irqreturn_t tsl2x7x_event_handler(int irq, void *private) > > static struct attribute *tsl2x7x_ALS_device_attrs[] = { > &dev_attr_in_illuminance0_calibscale_available.attr, > - &iio_const_attr_in_illuminance0_integration_time_available > + &iio_const_attr_in_intensity0_integration_time_available > .dev_attr.attr, > &dev_attr_in_illuminance0_target_input.attr, > &dev_attr_in_illuminance0_calibrate.attr, > @@ -1373,7 +1373,7 @@ static struct attribute *tsl2x7x_PRX_device_attrs[] = { > > static struct attribute *tsl2x7x_ALSPRX_device_attrs[] = { > &dev_attr_in_illuminance0_calibscale_available.attr, > - &iio_const_attr_in_illuminance0_integration_time_available > + &iio_const_attr_in_intensity0_integration_time_available > .dev_attr.attr, > &dev_attr_in_illuminance0_target_input.attr, > &dev_attr_in_illuminance0_calibrate.attr, > @@ -1389,7 +1389,7 @@ static struct attribute *tsl2x7x_PRX2_device_attrs[] = { > > static struct attribute *tsl2x7x_ALSPRX2_device_attrs[] = { > &dev_attr_in_illuminance0_calibscale_available.attr, > - &iio_const_attr_in_illuminance0_integration_time_available > + &iio_const_attr_in_intensity0_integration_time_available > .dev_attr.attr, > &dev_attr_in_illuminance0_target_input.attr, > &dev_attr_in_illuminance0_calibrate.attr, > @@ -1489,13 +1489,13 @@ static const struct tsl2x7x_chip_info tsl2x7x_chip_info_tbl[] = { > .type = IIO_LIGHT, > .indexed = 1, > .channel = 0, > - .info_mask_separate = BIT(IIO_CHAN_INFO_PROCESSED) | > - BIT(IIO_CHAN_INFO_INT_TIME), > + .info_mask_separate = BIT(IIO_CHAN_INFO_PROCESSED), > }, { > .type = IIO_INTENSITY, > .indexed = 1, > .channel = 0, > .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | > + BIT(IIO_CHAN_INFO_INT_TIME) | > BIT(IIO_CHAN_INFO_CALIBSCALE) | > BIT(IIO_CHAN_INFO_CALIBBIAS), > .event_spec = tsl2x7x_events, > @@ -1529,13 +1529,13 @@ static const struct tsl2x7x_chip_info tsl2x7x_chip_info_tbl[] = { > .type = IIO_LIGHT, > .indexed = 1, > .channel = 0, > - .info_mask_separate = BIT(IIO_CHAN_INFO_PROCESSED) | > - BIT(IIO_CHAN_INFO_INT_TIME), > + .info_mask_separate = BIT(IIO_CHAN_INFO_PROCESSED), > }, { > .type = IIO_INTENSITY, > .indexed = 1, > .channel = 0, > .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | > + BIT(IIO_CHAN_INFO_INT_TIME) | > BIT(IIO_CHAN_INFO_CALIBSCALE) | > BIT(IIO_CHAN_INFO_CALIBBIAS), > .event_spec = tsl2x7x_events, > @@ -1578,13 +1578,13 @@ static const struct tsl2x7x_chip_info tsl2x7x_chip_info_tbl[] = { > .type = IIO_LIGHT, > .indexed = 1, > .channel = 0, > - .info_mask_separate = BIT(IIO_CHAN_INFO_PROCESSED) | > - BIT(IIO_CHAN_INFO_INT_TIME), > + .info_mask_separate = BIT(IIO_CHAN_INFO_PROCESSED), > }, { > .type = IIO_INTENSITY, > .indexed = 1, > .channel = 0, > .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | > + BIT(IIO_CHAN_INFO_INT_TIME) | > BIT(IIO_CHAN_INFO_CALIBSCALE) | > BIT(IIO_CHAN_INFO_CALIBBIAS), > .event_spec = tsl2x7x_events, _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23@kernel.org> To: Brian Masney <masneyb@onstation.org> Cc: linux-iio@vger.kernel.org, gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, linux-kernel@vger.kernel.org, Jon.Brenner@ams.com Subject: Re: [PATCH 01/13] staging: iio: tsl2x7x: move integration_time* attributes to IIO_INTENSITY channel Date: Sat, 21 Apr 2018 17:13:08 +0100 [thread overview] Message-ID: <20180421171308.3f67c3f8@archlinux> (raw) In-Reply-To: <20180421004153.19073-2-masneyb@onstation.org> On Fri, 20 Apr 2018 20:41:41 -0400 Brian Masney <masneyb@onstation.org> wrote: > The integration_time* attributes are currently associated with the > IIO_LIGHT channel but should be associated with the IIO_INTENSITY > channel. Directory listing of the sysfs attributes for a TSL2772 > with this patch applied: > > dev > events > in_illuminance0_calibrate > in_illuminance0_calibscale_available > in_illuminance0_input > in_illuminance0_lux_table > in_illuminance0_target_input > in_intensity0_calibbias > in_intensity0_calibscale > in_intensity0_integration_time > in_intensity0_integration_time_available > in_intensity0_raw > in_intensity1_raw > in_proximity0_calibrate > in_proximity0_calibscale > in_proximity0_calibscale_available > in_proximity0_raw > name > of_node > power > subsystem > uevent > > Signed-off-by: Brian Masney <masneyb@onstation.org> Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > --- > drivers/staging/iio/light/tsl2x7x.c | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/drivers/staging/iio/light/tsl2x7x.c b/drivers/staging/iio/light/tsl2x7x.c > index 9991b0483956..eeccfbb0eb1f 100644 > --- a/drivers/staging/iio/light/tsl2x7x.c > +++ b/drivers/staging/iio/light/tsl2x7x.c > @@ -827,7 +827,7 @@ in_illuminance0_calibscale_available_show(struct device *dev, > > static IIO_CONST_ATTR(in_proximity0_calibscale_available, "1 2 4 8"); > > -static IIO_CONST_ATTR(in_illuminance0_integration_time_available, > +static IIO_CONST_ATTR(in_intensity0_integration_time_available, > ".00272 - .696"); > > static ssize_t in_illuminance0_target_input_show(struct device *dev, > @@ -1358,7 +1358,7 @@ static irqreturn_t tsl2x7x_event_handler(int irq, void *private) > > static struct attribute *tsl2x7x_ALS_device_attrs[] = { > &dev_attr_in_illuminance0_calibscale_available.attr, > - &iio_const_attr_in_illuminance0_integration_time_available > + &iio_const_attr_in_intensity0_integration_time_available > .dev_attr.attr, > &dev_attr_in_illuminance0_target_input.attr, > &dev_attr_in_illuminance0_calibrate.attr, > @@ -1373,7 +1373,7 @@ static struct attribute *tsl2x7x_PRX_device_attrs[] = { > > static struct attribute *tsl2x7x_ALSPRX_device_attrs[] = { > &dev_attr_in_illuminance0_calibscale_available.attr, > - &iio_const_attr_in_illuminance0_integration_time_available > + &iio_const_attr_in_intensity0_integration_time_available > .dev_attr.attr, > &dev_attr_in_illuminance0_target_input.attr, > &dev_attr_in_illuminance0_calibrate.attr, > @@ -1389,7 +1389,7 @@ static struct attribute *tsl2x7x_PRX2_device_attrs[] = { > > static struct attribute *tsl2x7x_ALSPRX2_device_attrs[] = { > &dev_attr_in_illuminance0_calibscale_available.attr, > - &iio_const_attr_in_illuminance0_integration_time_available > + &iio_const_attr_in_intensity0_integration_time_available > .dev_attr.attr, > &dev_attr_in_illuminance0_target_input.attr, > &dev_attr_in_illuminance0_calibrate.attr, > @@ -1489,13 +1489,13 @@ static const struct tsl2x7x_chip_info tsl2x7x_chip_info_tbl[] = { > .type = IIO_LIGHT, > .indexed = 1, > .channel = 0, > - .info_mask_separate = BIT(IIO_CHAN_INFO_PROCESSED) | > - BIT(IIO_CHAN_INFO_INT_TIME), > + .info_mask_separate = BIT(IIO_CHAN_INFO_PROCESSED), > }, { > .type = IIO_INTENSITY, > .indexed = 1, > .channel = 0, > .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | > + BIT(IIO_CHAN_INFO_INT_TIME) | > BIT(IIO_CHAN_INFO_CALIBSCALE) | > BIT(IIO_CHAN_INFO_CALIBBIAS), > .event_spec = tsl2x7x_events, > @@ -1529,13 +1529,13 @@ static const struct tsl2x7x_chip_info tsl2x7x_chip_info_tbl[] = { > .type = IIO_LIGHT, > .indexed = 1, > .channel = 0, > - .info_mask_separate = BIT(IIO_CHAN_INFO_PROCESSED) | > - BIT(IIO_CHAN_INFO_INT_TIME), > + .info_mask_separate = BIT(IIO_CHAN_INFO_PROCESSED), > }, { > .type = IIO_INTENSITY, > .indexed = 1, > .channel = 0, > .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | > + BIT(IIO_CHAN_INFO_INT_TIME) | > BIT(IIO_CHAN_INFO_CALIBSCALE) | > BIT(IIO_CHAN_INFO_CALIBBIAS), > .event_spec = tsl2x7x_events, > @@ -1578,13 +1578,13 @@ static const struct tsl2x7x_chip_info tsl2x7x_chip_info_tbl[] = { > .type = IIO_LIGHT, > .indexed = 1, > .channel = 0, > - .info_mask_separate = BIT(IIO_CHAN_INFO_PROCESSED) | > - BIT(IIO_CHAN_INFO_INT_TIME), > + .info_mask_separate = BIT(IIO_CHAN_INFO_PROCESSED), > }, { > .type = IIO_INTENSITY, > .indexed = 1, > .channel = 0, > .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | > + BIT(IIO_CHAN_INFO_INT_TIME) | > BIT(IIO_CHAN_INFO_CALIBSCALE) | > BIT(IIO_CHAN_INFO_CALIBBIAS), > .event_spec = tsl2x7x_events,
next prev parent reply other threads:[~2018-04-21 16:13 UTC|newest] Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-21 0:41 [PATCH 00/13] iio: tsl2x7x: staging cleanups Brian Masney 2018-04-21 0:41 ` Brian Masney 2018-04-21 0:41 ` [PATCH 01/13] staging: iio: tsl2x7x: move integration_time* attributes to IIO_INTENSITY channel Brian Masney 2018-04-21 0:41 ` Brian Masney 2018-04-21 16:13 ` Jonathan Cameron [this message] 2018-04-21 16:13 ` Jonathan Cameron 2018-04-21 0:41 ` [PATCH 02/13] staging: iio: tsl2x7x: use GPL-2.0+ SPDX license identifier Brian Masney 2018-04-21 0:41 ` Brian Masney 2018-04-21 16:16 ` Jonathan Cameron 2018-04-21 16:16 ` Jonathan Cameron 2018-04-21 17:04 ` Brian Masney 2018-04-21 17:04 ` Brian Masney 2018-04-21 0:41 ` [PATCH 03/13] staging: iio: tsl2x7x: don't return error in IRQ handler Brian Masney 2018-04-21 0:41 ` Brian Masney 2018-04-21 16:18 ` Jonathan Cameron 2018-04-21 16:18 ` Jonathan Cameron 2018-04-21 0:41 ` [PATCH 04/13] staging: iio: tsl2x7x: simplify tsl2x7x_clear_interrupts function Brian Masney 2018-04-21 0:41 ` Brian Masney 2018-04-21 16:20 ` Jonathan Cameron 2018-04-21 16:20 ` Jonathan Cameron 2018-04-21 0:41 ` [PATCH 05/13] staging: iio: tsl2x7x: remove unnecessary chip status checks in suspend/resume Brian Masney 2018-04-21 0:41 ` Brian Masney 2018-04-21 16:23 ` Jonathan Cameron 2018-04-21 16:23 ` Jonathan Cameron 2018-04-21 0:41 ` [PATCH 06/13] staging: iio: tsl2x7x: simplify tsl2x7x_write_interrupt_config return Brian Masney 2018-04-21 0:41 ` Brian Masney 2018-04-21 16:25 ` Jonathan Cameron 2018-04-21 16:25 ` Jonathan Cameron 2018-04-21 0:41 ` [PATCH 07/13] staging: iio: tsl2x7x: simplify device id verification Brian Masney 2018-04-21 0:41 ` Brian Masney 2018-04-21 16:26 ` Jonathan Cameron 2018-04-21 16:26 ` Jonathan Cameron 2018-04-21 0:41 ` [PATCH 08/13] staging: iio: tsl2x7x: add range checking to three sysfs attributes Brian Masney 2018-04-21 0:41 ` Brian Masney 2018-04-21 16:31 ` Jonathan Cameron 2018-04-21 16:31 ` Jonathan Cameron 2018-04-21 0:41 ` [PATCH 09/13] staging: iio: tsl2x7x: move power and diode settings into header file Brian Masney 2018-04-21 0:41 ` Brian Masney 2018-04-21 16:33 ` Jonathan Cameron 2018-04-21 16:33 ` Jonathan Cameron 2018-04-21 0:41 ` [PATCH 10/13] staging: iio: tsl2x7x: rename prx to prox for consistency Brian Masney 2018-04-21 0:41 ` Brian Masney 2018-04-21 16:33 ` Jonathan Cameron 2018-04-21 16:33 ` Jonathan Cameron 2018-04-21 0:41 ` [PATCH 11/13] staging: iio: tsl2x7x: use device defaults for als_time, prox_time and wait_time Brian Masney 2018-04-21 0:41 ` Brian Masney 2018-04-21 16:39 ` Jonathan Cameron 2018-04-21 16:39 ` Jonathan Cameron 2018-04-21 0:41 ` [PATCH 12/13] staging: iio: tsl2x7x: various comment cleanups Brian Masney 2018-04-21 0:41 ` Brian Masney 2018-04-21 16:37 ` Jonathan Cameron 2018-04-21 16:37 ` Jonathan Cameron 2018-04-21 0:41 ` [PATCH 13/13] staging: iio: tsl2x7x: rename prox_config to als_prox_config Brian Masney 2018-04-21 0:41 ` Brian Masney 2018-04-21 16:38 ` Jonathan Cameron 2018-04-21 16:38 ` Jonathan Cameron
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180421171308.3f67c3f8@archlinux \ --to=jic23@kernel.org \ --cc=Jon.Brenner@ams.com \ --cc=devel@driverdev.osuosl.org \ --cc=gregkh@linuxfoundation.org \ --cc=knaack.h@gmx.de \ --cc=lars@metafoo.de \ --cc=linux-iio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=masneyb@onstation.org \ --cc=pmeerw@pmeerw.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.