From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
To: Andrey Konovalov <andreyknvl@google.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Jonathan Corbet <corbet@lwn.net>,
Mark Rutland <mark.rutland@arm.com>,
Robin Murphy <robin.murphy@arm.com>,
Al Viro <viro@zeniv.linux.org.uk>,
James Morse <james.morse@arm.com>,
Kees Cook <keescook@chromium.org>,
Bart Van Assche <bart.vanassche@wdc.com>,
Kate Stewart <kstewart@linuxfoundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Philippe Ombredanne <pombredanne@nexb.com>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>,
Dan Williams <dan.j.williams@intel.com>,
"Aneesh Kumar K . V" <aneesh.kumar@linux.vnet.ibm.com>,
Zi Yan <zi.yan@cs.rutgers.edu>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-doc@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Linux Memory Management List <linux-mm@kvack.org>,
Jacob Bramley <Jacob.Bramley@arm.com>,
Ruben Ayrapetyan <Ruben.Ayrapetyan@arm.com>,
Lee Smith <Lee.Smith@arm.com>, Kostya Serebryany <kcc@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
Ramana Radhakrishnan <Ramana.Radhakrishnan@arm.com>,
Evgeniy Stepanov <eugenis@google.com>
Subject: Re: [PATCH 4/6] mm, arm64: untag user addresses in mm/gup.c
Date: Wed, 2 May 2018 18:36:46 +0300 [thread overview]
Message-ID: <20180502153645.fui4ju3scsze3zkq@black.fi.intel.com> (raw)
In-Reply-To: <CAAeHK+zY8p9E4FZa7mbdgR=wR0u-RDS552dn=h9fKRC-ArYLdw@mail.gmail.com>
On Wed, May 02, 2018 at 02:38:42PM +0000, Andrey Konovalov wrote:
> > Does having a tagged address here makes any difference? I couldn't hit a
> > failure with my simple tests (LD_PRELOAD a library that randomly adds
> > tags to pointers returned by malloc).
>
> I think you're right, follow_page_mask is only called from
> __get_user_pages, which already untagged the address. I'll remove
> untagging here.
It also called from follow_page(). Have you covered all its callers?
--
Kirill A. Shutemov
WARNING: multiple messages have this Message-ID (diff)
From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
To: Andrey Konovalov <andreyknvl@google.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Jonathan Corbet <corbet@lwn.net>,
Mark Rutland <mark.rutland@arm.com>,
Robin Murphy <robin.murphy@arm.com>,
Al Viro <viro@zeniv.linux.org.uk>,
James Morse <james.morse@arm.com>,
Kees Cook <keescook@chromium.org>,
Bart Van Assche <bart.vanassche@wdc.com>,
Kate Stewart <kstewart@linuxfoundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Philippe Ombredanne <pombredanne@nexb.com>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>,
Dan Williams <dan.j.williams@intel.com>,
"Aneesh Kumar K . V" <aneesh.kumar@linux.vnet.ibm.com>,
Zi Yan <zi.yan@cs.rutgers.edu>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-doc@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Linux Memory Management List <linux-mm@kvack.org>,
Jacob Bramley <Jacob.Bramley@arm.com>,
Ruben Ayrapetyan <Ruben.Ayrapetyan@arm.com>,
Lee Smith <Lee.Smith@arm.com>, Kostya Serebryany <kcc@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
Ramana Radhakrishnan <Ramana.Radhakrishnan@arm.com>,
Evgeniy Stepanov <eugenis@google.com>
Subject: Re: [PATCH 4/6] mm, arm64: untag user addresses in mm/gup.c
Date: Wed, 2 May 2018 18:36:46 +0300 [thread overview]
Message-ID: <20180502153645.fui4ju3scsze3zkq@black.fi.intel.com> (raw)
In-Reply-To: <CAAeHK+zY8p9E4FZa7mbdgR=wR0u-RDS552dn=h9fKRC-ArYLdw@mail.gmail.com>
On Wed, May 02, 2018 at 02:38:42PM +0000, Andrey Konovalov wrote:
> > Does having a tagged address here makes any difference? I couldn't hit a
> > failure with my simple tests (LD_PRELOAD a library that randomly adds
> > tags to pointers returned by malloc).
>
> I think you're right, follow_page_mask is only called from
> __get_user_pages, which already untagged the address. I'll remove
> untagging here.
It also called from follow_page(). Have you covered all its callers?
--
Kirill A. Shutemov
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: kirill.shutemov@linux.intel.com (Kirill A. Shutemov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/6] mm, arm64: untag user addresses in mm/gup.c
Date: Wed, 2 May 2018 18:36:46 +0300 [thread overview]
Message-ID: <20180502153645.fui4ju3scsze3zkq@black.fi.intel.com> (raw)
In-Reply-To: <CAAeHK+zY8p9E4FZa7mbdgR=wR0u-RDS552dn=h9fKRC-ArYLdw@mail.gmail.com>
On Wed, May 02, 2018 at 02:38:42PM +0000, Andrey Konovalov wrote:
> > Does having a tagged address here makes any difference? I couldn't hit a
> > failure with my simple tests (LD_PRELOAD a library that randomly adds
> > tags to pointers returned by malloc).
>
> I think you're right, follow_page_mask is only called from
> __get_user_pages, which already untagged the address. I'll remove
> untagging here.
It also called from follow_page(). Have you covered all its callers?
--
Kirill A. Shutemov
next prev parent reply other threads:[~2018-05-02 15:36 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-18 18:53 [PATCH 0/6] arm64: untag user pointers passed to the kernel Andrey Konovalov
2018-04-18 18:53 ` Andrey Konovalov
2018-04-18 18:53 ` Andrey Konovalov
2018-04-18 18:53 ` Andrey Konovalov
2018-04-18 18:53 ` [PATCH 1/6] arm64: add type casts to untagged_addr macro Andrey Konovalov
2018-04-18 18:53 ` Andrey Konovalov
2018-04-18 18:53 ` Andrey Konovalov
2018-04-18 18:53 ` Andrey Konovalov
2018-04-18 18:53 ` [PATCH 2/6] uaccess: add untagged_addr definition for other arches Andrey Konovalov
2018-04-18 18:53 ` Andrey Konovalov
2018-04-18 18:53 ` Andrey Konovalov
2018-04-18 18:53 ` Andrey Konovalov
2018-04-18 18:53 ` [PATCH 3/6] arm64: untag user addresses in copy_from_user and others Andrey Konovalov
2018-04-18 18:53 ` Andrey Konovalov
2018-04-18 18:53 ` Andrey Konovalov
2018-04-26 15:47 ` Catalin Marinas
2018-04-26 15:47 ` Catalin Marinas
2018-04-26 15:47 ` Catalin Marinas
2018-05-02 15:29 ` Andrey Konovalov
2018-05-02 15:29 ` Andrey Konovalov
2018-05-02 15:29 ` Andrey Konovalov
2018-04-18 18:53 ` Andrey Konovalov
2018-04-18 18:53 ` [PATCH 4/6] mm, arm64: untag user addresses in mm/gup.c Andrey Konovalov
2018-04-18 18:53 ` Andrey Konovalov
2018-04-18 18:53 ` Andrey Konovalov
2018-04-26 17:47 ` Catalin Marinas
2018-04-26 17:47 ` Catalin Marinas
2018-04-26 17:47 ` Catalin Marinas
2018-05-02 14:38 ` Andrey Konovalov
2018-05-02 14:38 ` Andrey Konovalov
2018-05-02 14:38 ` Andrey Konovalov
2018-05-02 15:36 ` Kirill A. Shutemov [this message]
2018-05-02 15:36 ` Kirill A. Shutemov
2018-05-02 15:36 ` Kirill A. Shutemov
2018-05-02 17:25 ` Andrey Konovalov
2018-05-02 17:25 ` Andrey Konovalov
2018-05-02 17:25 ` Andrey Konovalov
2018-05-03 14:09 ` Andrey Konovalov
2018-05-03 14:09 ` Andrey Konovalov
2018-05-03 14:09 ` Andrey Konovalov
2018-05-03 15:24 ` Kirill A. Shutemov
2018-05-03 15:24 ` Kirill A. Shutemov
2018-05-03 15:24 ` Kirill A. Shutemov
2018-05-03 16:51 ` Andrey Konovalov
2018-05-03 16:51 ` Andrey Konovalov
2018-05-03 16:51 ` Andrey Konovalov
2018-05-08 15:11 ` Catalin Marinas
2018-05-08 15:11 ` Catalin Marinas
2018-05-08 15:11 ` Catalin Marinas
2018-05-11 12:36 ` Andrey Konovalov
2018-05-11 12:36 ` Andrey Konovalov
2018-05-11 12:36 ` Andrey Konovalov
2018-04-18 18:53 ` Andrey Konovalov
2018-04-18 18:53 ` [PATCH 5/6] lib, arm64: untag addrs passed to strncpy_from_user and strnlen_user Andrey Konovalov
2018-04-18 18:53 ` Andrey Konovalov
2018-04-18 18:53 ` Andrey Konovalov
2018-04-18 18:53 ` Andrey Konovalov
2018-04-18 18:53 ` [PATCH 6/6] arm64: update Documentation/arm64/tagged-pointers.txt Andrey Konovalov
2018-04-18 18:53 ` Andrey Konovalov
2018-04-18 18:53 ` Andrey Konovalov
2018-04-18 18:53 ` Andrey Konovalov
2018-04-19 9:33 ` [PATCH 0/6] arm64: untag user pointers passed to the kernel Kirill A. Shutemov
2018-04-19 9:33 ` Kirill A. Shutemov
2018-04-19 9:33 ` Kirill A. Shutemov
2018-04-25 14:45 ` Andrey Konovalov
2018-04-25 14:45 ` Andrey Konovalov
2018-04-25 14:45 ` Andrey Konovalov
2018-04-26 17:56 ` Catalin Marinas
2018-04-26 17:56 ` Catalin Marinas
2018-04-26 17:56 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180502153645.fui4ju3scsze3zkq@black.fi.intel.com \
--to=kirill.shutemov@linux.intel.com \
--cc=Jacob.Bramley@arm.com \
--cc=Lee.Smith@arm.com \
--cc=Ramana.Radhakrishnan@arm.com \
--cc=Ruben.Ayrapetyan@arm.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@google.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=bart.vanassche@wdc.com \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=dan.j.williams@intel.com \
--cc=dvyukov@google.com \
--cc=eugenis@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=james.morse@arm.com \
--cc=kcc@google.com \
--cc=keescook@chromium.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=pombredanne@nexb.com \
--cc=robin.murphy@arm.com \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
--cc=will.deacon@arm.com \
--cc=zi.yan@cs.rutgers.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.