From: Mark Brown <broonie@kernel.org>
To: Yixun Lan <yixun.lan@amlogic.com>
Cc: Sunny Luo <sunny.luo@amlogic.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Carlo Caione <carlo@caione.org>,
linux-spi@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] spi: meson-axg: support MAX 80M clock
Date: Fri, 4 May 2018 08:13:05 +0900 [thread overview]
Message-ID: <20180503231305.GC13402@sirena.org.uk> (raw)
In-Reply-To: <20180503213645.20694-2-yixun.lan@amlogic.com>
[-- Attachment #1: Type: text/plain, Size: 608 bytes --]
On Thu, May 03, 2018 at 09:36:42PM +0000, Yixun Lan wrote:
> static const struct of_device_id meson_spicc_of_match[] = {
> - { .compatible = "amlogic,meson-gx-spicc", },
> - { .compatible = "amlogic,meson-axg-spicc", },
> + {
> + .compatible = "amlogic,meson-gx-spicc",
> + .data = &meson_spicc_gx_data,
> + },
> + {
> + .compatible = "amlogic,meson-axg-spicc",
> + .data = &meson_spicc_axg_data,
> + },
> { /* sentinel */ }
> };
> MODULE_DEVICE_TABLE(of, meson_spicc_of_match);
This is changing the DT bindings but there's no update to the DT binding
documentation, please add an update there.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] spi: meson-axg: support MAX 80M clock
Date: Fri, 4 May 2018 08:13:05 +0900 [thread overview]
Message-ID: <20180503231305.GC13402@sirena.org.uk> (raw)
In-Reply-To: <20180503213645.20694-2-yixun.lan@amlogic.com>
On Thu, May 03, 2018 at 09:36:42PM +0000, Yixun Lan wrote:
> static const struct of_device_id meson_spicc_of_match[] = {
> - { .compatible = "amlogic,meson-gx-spicc", },
> - { .compatible = "amlogic,meson-axg-spicc", },
> + {
> + .compatible = "amlogic,meson-gx-spicc",
> + .data = &meson_spicc_gx_data,
> + },
> + {
> + .compatible = "amlogic,meson-axg-spicc",
> + .data = &meson_spicc_axg_data,
> + },
> { /* sentinel */ }
> };
> MODULE_DEVICE_TABLE(of, meson_spicc_of_match);
This is changing the DT bindings but there's no update to the DT binding
documentation, please add an update there.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180504/bfd45740/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 1/3] spi: meson-axg: support MAX 80M clock
Date: Fri, 4 May 2018 08:13:05 +0900 [thread overview]
Message-ID: <20180503231305.GC13402@sirena.org.uk> (raw)
In-Reply-To: <20180503213645.20694-2-yixun.lan@amlogic.com>
On Thu, May 03, 2018 at 09:36:42PM +0000, Yixun Lan wrote:
> static const struct of_device_id meson_spicc_of_match[] = {
> - { .compatible = "amlogic,meson-gx-spicc", },
> - { .compatible = "amlogic,meson-axg-spicc", },
> + {
> + .compatible = "amlogic,meson-gx-spicc",
> + .data = &meson_spicc_gx_data,
> + },
> + {
> + .compatible = "amlogic,meson-axg-spicc",
> + .data = &meson_spicc_axg_data,
> + },
> { /* sentinel */ }
> };
> MODULE_DEVICE_TABLE(of, meson_spicc_of_match);
This is changing the DT bindings but there's no update to the DT binding
documentation, please add an update there.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-amlogic/attachments/20180504/bfd45740/attachment.sig>
next prev parent reply other threads:[~2018-05-03 23:13 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-03 21:36 [PATCH 0/3] spi: meson-axg: add few enhanced features Yixun Lan
2018-05-03 21:36 ` Yixun Lan
2018-05-03 21:36 ` Yixun Lan
2018-05-03 21:36 ` [PATCH 1/3] spi: meson-axg: support MAX 80M clock Yixun Lan
2018-05-03 21:36 ` Yixun Lan
2018-05-03 21:36 ` Yixun Lan
2018-05-03 23:13 ` Mark Brown [this message]
2018-05-03 23:13 ` Mark Brown
2018-05-03 23:13 ` Mark Brown
2018-05-04 1:56 ` Yixun Lan
2018-05-04 1:56 ` Yixun Lan
2018-05-04 1:56 ` Yixun Lan
2018-05-05 0:58 ` Mark Brown
2018-05-05 0:58 ` Mark Brown
2018-05-05 0:58 ` Mark Brown
2018-05-03 21:36 ` [PATCH 2/3] spi: meson-axg: enhance output enable feature Yixun Lan
2018-05-03 21:36 ` Yixun Lan
2018-05-03 21:36 ` Yixun Lan
2018-05-03 21:36 ` [PATCH 3/3] spi: meson-axg: add a linear clock divider support Yixun Lan
2018-05-03 21:36 ` Yixun Lan
2018-05-03 21:36 ` Yixun Lan
2018-05-03 23:16 ` Mark Brown
2018-05-03 23:16 ` Mark Brown
2018-05-03 23:16 ` Mark Brown
2018-05-04 2:07 ` Yixun Lan
2018-05-04 2:07 ` Yixun Lan
2018-05-04 2:07 ` Yixun Lan
2018-05-04 2:07 ` Yixun Lan
2018-05-04 2:22 ` kbuild test robot
2018-05-04 2:22 ` kbuild test robot
2018-05-04 2:22 ` kbuild test robot
2018-05-04 2:46 ` kbuild test robot
2018-05-04 2:46 ` kbuild test robot
2018-05-04 2:46 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180503231305.GC13402@sirena.org.uk \
--to=broonie@kernel.org \
--cc=carlo@caione.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=sunny.luo@amlogic.com \
--cc=yixun.lan@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.