From: "Luis R. Rodriguez" <mcgrof@kernel.org> To: gregkh@linuxfoundation.org Cc: akpm@linux-foundation.org, keescook@chromium.org, josh@joshtriplett.org, maco@android.com, andy.gross@linaro.org, david.brown@linaro.org, bjorn.andersson@linaro.org, teg@jklm.no, wagi@monom.org, hdegoede@redhat.com, andresx7@gmail.com, zohar@linux.vnet.ibm.com, kubakici@wp.pl, shuah@kernel.org, mfuzzey@parkeon.com, dhowells@redhat.com, pali.rohar@gmail.com, tiwai@suse.de, kvalo@codeaurora.org, arend.vanspriel@broadcom.com, zajec5@gmail.com, nbroeking@me.com, markivx@codeaurora.org, broonie@kernel.org, dmitry.torokhov@gmail.com, dwmw2@infradead.org, torvalds@linux-foundation.org, Abhay_Salunke@dell.com, jewalt@lgsinnovations.com, oneukum@suse.com, cantabile.desu@gmail.com, ast@fb.com, hare@suse.com, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, khc@pm.waw.pl, davem@davemloft.net, arve@android.com, tkjos@android.com, corbet@lwn.net, mchehab+samsung@kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, "Luis R. Rodriguez" <mcgrof@kernel.org> Subject: [PATCH v6 07/13] firmware_loader: make firmware_fallback_sysfs() print more useful Date: Tue, 8 May 2018 11:12:41 -0700 [thread overview] Message-ID: <20180508181247.19431-8-mcgrof@kernel.org> (raw) In-Reply-To: <20180508181247.19431-1-mcgrof@kernel.org> If we resort to using the sysfs fallback mechanism we don't print the filename. This can be deceiving given we could have a series of callers intertwined and it'd be unclear exactly for what firmware this was meant for. Additionally, although we don't currently use FW_OPT_NO_WARN when dealing with the fallback mechanism, we will soon, so just respect its use consistently. And even if you *don't* want to print always on failure, you may want to print when debugging so enable dynamic debug print when FW_OPT_NO_WARN is used. Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org> --- drivers/base/firmware_loader/fallback.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/base/firmware_loader/fallback.c b/drivers/base/firmware_loader/fallback.c index 9169e7b9800c..b676a99c469c 100644 --- a/drivers/base/firmware_loader/fallback.c +++ b/drivers/base/firmware_loader/fallback.c @@ -690,6 +690,11 @@ int firmware_fallback_sysfs(struct firmware *fw, const char *name, if (!fw_run_sysfs_fallback(opt_flags)) return ret; - dev_warn(device, "Falling back to user helper\n"); + if (!(opt_flags & FW_OPT_NO_WARN)) + dev_warn(device, "Falling back to syfs fallback for: %s\n", + name); + else + dev_dbg(device, "Falling back to sysfs fallback for: %s\n", + name); return fw_load_from_user_helper(fw, name, device, opt_flags); } -- 2.17.0
WARNING: multiple messages have this Message-ID (diff)
From: "Luis R. Rodriguez" <mcgrof@kernel.org> To: gregkh@linuxfoundation.org Cc: akpm@linux-foundation.org, keescook@chromium.org, josh@joshtriplett.org, maco@android.com, andy.gross@linaro.org, david.brown@linaro.org, bjorn.andersson@linaro.org, teg@jklm.no, wagi@monom.org, hdegoede@redhat.com, andresx7@gmail.com, zohar@linux.vnet.ibm.com, kubakici@wp.pl, shuah@kernel.org, mfuzzey@parkeon.com, dhowells@redhat.com, pali.rohar@gmail.com, tiwai@suse.de, kvalo@codeaurora.org, arend.vanspriel@broadcom.com, zajec5@gmail.com, nbroeking@me.com, markivx@codeaurora.org, broonie@kernel.org, dmitry.torokhov@gmail.com, dwmw2@infradead.org, torvalds@linux-foundation.org, Abhay_Salunke@dell.com, jewalt@lgsinnovations.com, oneukum@suse.com, cantabile.desu@gmail.com, ast@fb.com, hare@suse.com, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, khc@pm.waw.pl, davem@davemloft. Subject: [PATCH v6 07/13] firmware_loader: make firmware_fallback_sysfs() print more useful Date: Tue, 8 May 2018 11:12:41 -0700 [thread overview] Message-ID: <20180508181247.19431-8-mcgrof@kernel.org> (raw) In-Reply-To: <20180508181247.19431-1-mcgrof@kernel.org> If we resort to using the sysfs fallback mechanism we don't print the filename. This can be deceiving given we could have a series of callers intertwined and it'd be unclear exactly for what firmware this was meant for. Additionally, although we don't currently use FW_OPT_NO_WARN when dealing with the fallback mechanism, we will soon, so just respect its use consistently. And even if you *don't* want to print always on failure, you may want to print when debugging so enable dynamic debug print when FW_OPT_NO_WARN is used. Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org> --- drivers/base/firmware_loader/fallback.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/base/firmware_loader/fallback.c b/drivers/base/firmware_loader/fallback.c index 9169e7b9800c..b676a99c469c 100644 --- a/drivers/base/firmware_loader/fallback.c +++ b/drivers/base/firmware_loader/fallback.c @@ -690,6 +690,11 @@ int firmware_fallback_sysfs(struct firmware *fw, const char *name, if (!fw_run_sysfs_fallback(opt_flags)) return ret; - dev_warn(device, "Falling back to user helper\n"); + if (!(opt_flags & FW_OPT_NO_WARN)) + dev_warn(device, "Falling back to syfs fallback for: %s\n", + name); + else + dev_dbg(device, "Falling back to sysfs fallback for: %s\n", + name); return fw_load_from_user_helper(fw, name, device, opt_flags); } -- 2.17.0
next prev parent reply other threads:[~2018-05-08 18:13 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-08 18:12 [PATCH v6 00/13] firmware_loader changes for v4.18 Luis R. Rodriguez 2018-05-08 18:12 ` Luis R. Rodriguez 2018-05-08 18:12 ` [PATCH v6 01/13] firmware: wrap FW_OPT_* into an enum Luis R. Rodriguez 2018-05-08 18:12 ` Luis R. Rodriguez 2018-05-08 18:12 ` [PATCH v6 02/13] firmware: use () to terminate kernel-doc function names Luis R. Rodriguez 2018-05-08 18:12 ` Luis R. Rodriguez 2018-05-08 18:12 ` [PATCH v6 03/13] firmware: rename fw_sysfs_fallback to firmware_fallback_sysfs() Luis R. Rodriguez 2018-05-08 18:12 ` Luis R. Rodriguez 2018-05-08 18:12 ` [PATCH v6 04/13] firmware_loader: document firmware_sysfs_fallback() Luis R. Rodriguez 2018-05-08 18:12 ` Luis R. Rodriguez 2018-05-08 18:12 ` [PATCH v6 05/13] firmware_loader: enhance Kconfig documentation over FW_LOADER Luis R. Rodriguez 2018-05-08 18:12 ` Luis R. Rodriguez 2018-05-08 22:42 ` Kees Cook 2018-05-08 22:42 ` Kees Cook 2018-05-09 20:55 ` Luis R. Rodriguez 2018-05-09 20:55 ` Luis R. Rodriguez 2018-05-09 23:01 ` Kees Cook 2018-05-09 23:01 ` Kees Cook 2018-05-08 18:12 ` [PATCH v6 06/13] firmware_loader: move kconfig FW_LOADER entries to its own file Luis R. Rodriguez 2018-05-08 18:12 ` Luis R. Rodriguez 2018-05-08 18:12 ` Luis R. Rodriguez [this message] 2018-05-08 18:12 ` [PATCH v6 07/13] firmware_loader: make firmware_fallback_sysfs() print more useful Luis R. Rodriguez 2018-05-08 18:12 ` [PATCH v6 08/13] firmware: add firmware_request_nowarn() - load firmware without warnings Luis R. Rodriguez 2018-05-08 18:12 ` Luis R. Rodriguez 2018-05-08 18:12 ` [PATCH v6 09/13] ath10k: use firmware_request_nowarn() to load firmware Luis R. Rodriguez 2018-05-08 18:12 ` Luis R. Rodriguez 2018-05-08 18:12 ` [PATCH v6 10/13] ath10k: re-enable the firmware fallback mechanism for testmode Luis R. Rodriguez 2018-05-08 18:12 ` Luis R. Rodriguez 2018-05-08 18:12 ` [PATCH v6 11/13] Documentation: fix few typos and clarifications for the firmware loader Luis R. Rodriguez 2018-05-08 18:12 ` Luis R. Rodriguez 2018-05-08 18:12 ` [PATCH v6 12/13] Documentation: remove stale firmware API reference Luis R. Rodriguez 2018-05-08 18:12 ` Luis R. Rodriguez 2018-05-09 15:12 ` Mauro Carvalho Chehab 2018-05-09 15:12 ` Mauro Carvalho Chehab 2018-05-09 19:43 ` Luis R. Rodriguez 2018-05-09 19:43 ` Luis R. Rodriguez 2018-05-08 18:12 ` [PATCH v6 13/13] Documentation: clarify firmware_class provenance and why we can't rename the module Luis R. Rodriguez 2018-05-08 18:12 ` Luis R. Rodriguez 2018-05-08 18:53 ` Andres Rodriguez 2018-05-08 18:53 ` Andres Rodriguez 2018-05-09 13:21 ` Mauro Carvalho Chehab 2018-05-09 13:21 ` Mauro Carvalho Chehab 2018-05-08 22:45 ` [PATCH v6 00/13] firmware_loader changes for v4.18 Kees Cook 2018-05-08 22:45 ` Kees Cook
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180508181247.19431-8-mcgrof@kernel.org \ --to=mcgrof@kernel.org \ --cc=Abhay_Salunke@dell.com \ --cc=akpm@linux-foundation.org \ --cc=andresx7@gmail.com \ --cc=andy.gross@linaro.org \ --cc=arend.vanspriel@broadcom.com \ --cc=arve@android.com \ --cc=ast@fb.com \ --cc=bjorn.andersson@linaro.org \ --cc=broonie@kernel.org \ --cc=cantabile.desu@gmail.com \ --cc=corbet@lwn.net \ --cc=davem@davemloft.net \ --cc=david.brown@linaro.org \ --cc=dhowells@redhat.com \ --cc=dmitry.torokhov@gmail.com \ --cc=dwmw2@infradead.org \ --cc=gregkh@linuxfoundation.org \ --cc=hare@suse.com \ --cc=hdegoede@redhat.com \ --cc=jejb@linux.vnet.ibm.com \ --cc=jewalt@lgsinnovations.com \ --cc=josh@joshtriplett.org \ --cc=keescook@chromium.org \ --cc=khc@pm.waw.pl \ --cc=kubakici@wp.pl \ --cc=kvalo@codeaurora.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-scsi@vger.kernel.org \ --cc=linux-wireless@vger.kernel.org \ --cc=maco@android.com \ --cc=markivx@codeaurora.org \ --cc=martin.petersen@oracle.com \ --cc=mchehab+samsung@kernel.org \ --cc=mfuzzey@parkeon.com \ --cc=nbroeking@me.com \ --cc=netdev@vger.kernel.org \ --cc=oneukum@suse.com \ --cc=pali.rohar@gmail.com \ --cc=shuah@kernel.org \ --cc=teg@jklm.no \ --cc=tiwai@suse.de \ --cc=tkjos@android.com \ --cc=torvalds@linux-foundation.org \ --cc=wagi@monom.org \ --cc=zajec5@gmail.com \ --cc=zohar@linux.vnet.ibm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.