From: Mike Snitzer <snitzer@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: peterz@infradead.org, wagi@monom.org, dm-devel@redhat.com,
Mikulas Patocka <mpatocka@redhat.com>,
Dan Williams <dan.j.williams@intel.com>,
tglx@linutronix.de
Subject: Re: [patch 2/4] swait: export the symbols __prepare_to_swait and __finish_swait
Date: Tue, 22 May 2018 14:52:54 -0400 [thread overview]
Message-ID: <20180522185037.GB25826@redhat.com> (raw)
In-Reply-To: <20180522063425.GA7854@infradead.org>
On Tue, May 22 2018 at 2:34am -0400,
Christoph Hellwig <hch@infradead.org> wrote:
> On Sat, May 19, 2018 at 07:25:05AM +0200, Mikulas Patocka wrote:
> > In order to reduce locking overhead, I use the spinlock in
> > swait_queue_head to protect not only the wait queue, but also the list of
> > events. Consequently, I need to use unlocked functions __prepare_to_swait
> > and __finish_swait. These functions are declared in the file
> > include/linux/swait.h, but they are not exported, and so they are not
> > useable from kernel modules.
>
> Please CC the author and maintainers of the swait code.
>
> My impression is that this is the wrong thing to do. The swait code
> is supposed to be simple and self contained, and if you want to do
> anything else use normal waitqueues.
You said the same thing last time around. I've since cc'd Peter and
Thomas and haven't heard back, see:
https://www.redhat.com/archives/dm-devel/2018-May/msg00048.html
The entire point of exporting these symbols is to allow use of the
"simple waitqueue" code to optimize -- without resorting to using normal
waitqueues.
Mike
next prev parent reply other threads:[~2018-05-22 18:52 UTC|newest]
Thread overview: 109+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-19 5:25 [patch 0/4] dm-writecache patches Mikulas Patocka
2018-05-19 5:25 ` [patch 1/4] x86: optimize memcpy_flushcache Mikulas Patocka
2018-05-19 14:21 ` Dan Williams
2018-05-24 18:20 ` [PATCH v2] " Mike Snitzer
2018-06-18 13:23 ` [PATCH v2 RESEND] " Mike Snitzer
2018-06-18 13:23 ` Mike Snitzer
2018-06-21 14:31 ` Ingo Molnar
2018-06-22 1:19 ` Mikulas Patocka
2018-06-22 1:19 ` Mikulas Patocka
2018-06-22 1:30 ` Ingo Molnar
2018-08-08 21:22 ` [PATCH v3 " Mikulas Patocka
2018-09-10 13:18 ` Ingo Molnar
2018-09-11 6:22 ` [tip:x86/asm] x86/asm: Optimize memcpy_flushcache() tip-bot for Mikulas Patocka
2018-05-19 5:25 ` [patch 2/4] swait: export the symbols __prepare_to_swait and __finish_swait Mikulas Patocka
2018-05-22 6:34 ` Christoph Hellwig
2018-05-22 18:52 ` Mike Snitzer [this message]
2018-05-23 9:21 ` Peter Zijlstra
2018-05-23 15:10 ` Mike Snitzer
2018-05-23 18:10 ` [PATCH v2] swait: export " Mike Snitzer
2018-05-23 20:38 ` Mikulas Patocka
2018-05-23 21:51 ` Mike Snitzer
2018-05-24 14:10 ` Peter Zijlstra
2018-05-24 15:09 ` Mike Snitzer
2018-05-19 5:25 ` [patch 3/4] dm-writecache Mikulas Patocka
2018-05-22 6:37 ` Christoph Hellwig
2018-05-19 5:25 ` [patch 4/4] dm-writecache: use new API for flushing Mikulas Patocka
2018-05-22 6:39 ` [dm-devel] " Christoph Hellwig
2018-05-22 6:39 ` Christoph Hellwig
2018-05-22 18:41 ` Mike Snitzer
2018-05-22 18:41 ` Mike Snitzer
2018-05-22 19:00 ` Dan Williams
2018-05-22 19:00 ` Dan Williams
2018-05-22 19:19 ` Mike Snitzer
2018-05-22 19:19 ` Mike Snitzer
2018-05-22 19:27 ` Dan Williams
2018-05-22 19:27 ` Dan Williams
2018-05-22 20:52 ` Mike Snitzer
2018-05-22 20:52 ` Mike Snitzer
2018-05-22 22:53 ` [dm-devel] " Jeff Moyer
2018-05-22 22:53 ` Jeff Moyer
2018-05-23 20:57 ` Mikulas Patocka
2018-05-23 20:57 ` Mikulas Patocka
2018-05-28 13:52 ` Mikulas Patocka
2018-05-28 13:52 ` Mikulas Patocka
2018-05-28 17:41 ` Dan Williams
2018-05-28 17:41 ` Dan Williams
2018-05-30 13:42 ` [dm-devel] " Jeff Moyer
2018-05-30 13:42 ` Jeff Moyer
2018-05-30 13:51 ` Mikulas Patocka
2018-05-30 13:51 ` Mikulas Patocka
2018-05-30 13:52 ` Jeff Moyer
2018-05-30 13:52 ` Jeff Moyer
2018-05-24 8:15 ` Mikulas Patocka
2018-05-24 8:15 ` Mikulas Patocka
2018-05-25 3:12 ` Dan Williams
2018-05-25 6:17 ` Mikulas Patocka
2018-05-25 12:51 ` Mike Snitzer
2018-05-25 12:51 ` Mike Snitzer
2018-05-25 15:57 ` Dan Williams
2018-05-25 15:57 ` Dan Williams
2018-05-26 7:02 ` Mikulas Patocka
2018-05-26 7:02 ` Mikulas Patocka
2018-05-26 15:26 ` Dan Williams
2018-05-26 15:26 ` Dan Williams
2018-05-28 13:32 ` Mikulas Patocka
2018-05-28 13:32 ` Mikulas Patocka
2018-05-28 18:14 ` Dan Williams
2018-05-28 18:14 ` Dan Williams
2018-05-30 13:07 ` Mikulas Patocka
2018-05-30 13:07 ` Mikulas Patocka
2018-05-30 13:16 ` Mike Snitzer
2018-05-30 13:16 ` Mike Snitzer
2018-05-30 13:21 ` Mikulas Patocka
2018-05-30 13:21 ` Mikulas Patocka
2018-05-30 13:26 ` Mike Snitzer
2018-05-30 13:26 ` Mike Snitzer
2018-05-30 13:33 ` Mikulas Patocka
2018-05-30 13:33 ` Mikulas Patocka
2018-05-30 13:54 ` Mike Snitzer
2018-05-30 13:54 ` Mike Snitzer
2018-05-30 14:09 ` Mikulas Patocka
2018-05-30 14:09 ` Mikulas Patocka
2018-05-30 14:21 ` Mike Snitzer
2018-05-30 14:21 ` Mike Snitzer
2018-05-30 14:46 ` Mikulas Patocka
2018-05-30 14:46 ` Mikulas Patocka
2018-05-31 3:42 ` Mike Snitzer
2018-05-31 3:42 ` Mike Snitzer
2018-06-03 15:03 ` Mikulas Patocka
2018-06-03 15:03 ` Mikulas Patocka
2018-05-31 3:39 ` Mike Snitzer
2018-05-31 3:39 ` Mike Snitzer
2018-05-31 8:16 ` Mikulas Patocka
2018-05-31 8:16 ` Mikulas Patocka
2018-05-31 12:09 ` Mike Snitzer
2018-05-31 12:09 ` Mike Snitzer
2018-05-30 15:58 ` Dan Williams
2018-05-30 15:58 ` Dan Williams
2018-05-30 22:39 ` Dan Williams
2018-05-30 22:39 ` Dan Williams
2018-05-31 8:19 ` Mikulas Patocka
2018-05-31 8:19 ` Mikulas Patocka
2018-05-31 14:51 ` Dan Williams
2018-05-31 14:51 ` Dan Williams
2018-05-31 15:31 ` Mikulas Patocka
2018-05-31 15:31 ` Mikulas Patocka
2018-05-31 16:39 ` Dan Williams
2018-05-31 16:39 ` Dan Williams
2018-05-30 13:16 [PATCH 2/4] swait: export the symbols __prepare_to_swait and __finish_swait Mikulas Patocka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180522185037.GB25826@redhat.com \
--to=snitzer@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=dm-devel@redhat.com \
--cc=hch@infradead.org \
--cc=mpatocka@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=wagi@monom.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.