From: "Niklas Söderlund" <niklas.soderlund@ragnatech.se> To: Jacopo Mondi <jacopo+renesas@jmondi.org> Cc: laurent.pinchart@ideasonboard.com, linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH v3 6/9] media: rcar-vin: Link parallel input media entities Date: Thu, 24 May 2018 12:32:18 +0200 [thread overview] Message-ID: <20180524103218.GF31036@bigcity.dyn.berto.se> (raw) In-Reply-To: <1526654445-10702-7-git-send-email-jacopo+renesas@jmondi.org> Hi Jacopo, Thanks for your patch. On 2018-05-18 16:40:42 +0200, Jacopo Mondi wrote: > When running with media-controller link the parallel input > media entities with the VIN entities at 'complete' callback time. > > To create media links the v4l2_device should be registered first. > Check if the device is already registered, to avoid double registrations. > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> Acked-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > --- > drivers/media/platform/rcar-vin/rcar-core.c | 26 ++++++++++++++++++++++++-- > 1 file changed, 24 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/rcar-vin/rcar-core.c b/drivers/media/platform/rcar-vin/rcar-core.c > index 745e8ee..d13bbcf 100644 > --- a/drivers/media/platform/rcar-vin/rcar-core.c > +++ b/drivers/media/platform/rcar-vin/rcar-core.c > @@ -478,6 +478,8 @@ static void rvin_parallel_subdevice_detach(struct rvin_dev *vin) > static int rvin_parallel_notify_complete(struct v4l2_async_notifier *notifier) > { > struct rvin_dev *vin = notifier_to_vin(notifier); > + struct media_entity *source; > + struct media_entity *sink; > int ret; > > ret = v4l2_device_register_subdev_nodes(&vin->v4l2_dev); > @@ -486,7 +488,26 @@ static int rvin_parallel_notify_complete(struct v4l2_async_notifier *notifier) > return ret; > } > > - return rvin_v4l2_register(vin); > + if (!video_is_registered(&vin->vdev)) { > + ret = rvin_v4l2_register(vin); > + if (ret < 0) > + return ret; > + } > + > + if (!vin->info->use_mc) > + return 0; > + > + /* If we're running with media-controller, link the subdevs. */ > + source = &vin->parallel->subdev->entity; > + sink = &vin->vdev.entity; > + > + ret = media_create_pad_link(source, vin->parallel->source_pad, > + sink, vin->parallel->sink_pad, 0); > + if (ret) > + vin_err(vin, "Error adding link from %s to %s: %d\n", > + source->name, sink->name, ret); > + > + return ret; > } > > static void rvin_parallel_notify_unbind(struct v4l2_async_notifier *notifier, > @@ -611,7 +632,8 @@ static int rvin_group_notify_complete(struct v4l2_async_notifier *notifier) > > /* Register all video nodes for the group. */ > for (i = 0; i < RCAR_VIN_NUM; i++) { > - if (vin->group->vin[i]) { > + if (vin->group->vin[i] && > + !video_is_registered(&vin->group->vin[i]->vdev)) { > ret = rvin_v4l2_register(vin->group->vin[i]); > if (ret) > return ret; > -- > 2.7.4 > -- Regards, Niklas Söderlund
WARNING: multiple messages have this Message-ID (diff)
From: "Niklas Söderlund" <niklas.soderlund@ragnatech.se> To: Jacopo Mondi <jacopo+renesas@jmondi.org> Cc: laurent.pinchart@ideasonboard.com, linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH v3 6/9] media: rcar-vin: Link parallel input media entities Date: Thu, 24 May 2018 12:32:18 +0200 [thread overview] Message-ID: <20180524103218.GF31036@bigcity.dyn.berto.se> (raw) In-Reply-To: <1526654445-10702-7-git-send-email-jacopo+renesas@jmondi.org> Hi Jacopo, Thanks for your patch. On 2018-05-18 16:40:42 +0200, Jacopo Mondi wrote: > When running with media-controller link the parallel input > media entities with the VIN entities at 'complete' callback time. > > To create media links the v4l2_device should be registered first. > Check if the device is already registered, to avoid double registrations. > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> Acked-by: Niklas S�derlund <niklas.soderlund+renesas@ragnatech.se> > --- > drivers/media/platform/rcar-vin/rcar-core.c | 26 ++++++++++++++++++++++++-- > 1 file changed, 24 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/rcar-vin/rcar-core.c b/drivers/media/platform/rcar-vin/rcar-core.c > index 745e8ee..d13bbcf 100644 > --- a/drivers/media/platform/rcar-vin/rcar-core.c > +++ b/drivers/media/platform/rcar-vin/rcar-core.c > @@ -478,6 +478,8 @@ static void rvin_parallel_subdevice_detach(struct rvin_dev *vin) > static int rvin_parallel_notify_complete(struct v4l2_async_notifier *notifier) > { > struct rvin_dev *vin = notifier_to_vin(notifier); > + struct media_entity *source; > + struct media_entity *sink; > int ret; > > ret = v4l2_device_register_subdev_nodes(&vin->v4l2_dev); > @@ -486,7 +488,26 @@ static int rvin_parallel_notify_complete(struct v4l2_async_notifier *notifier) > return ret; > } > > - return rvin_v4l2_register(vin); > + if (!video_is_registered(&vin->vdev)) { > + ret = rvin_v4l2_register(vin); > + if (ret < 0) > + return ret; > + } > + > + if (!vin->info->use_mc) > + return 0; > + > + /* If we're running with media-controller, link the subdevs. */ > + source = &vin->parallel->subdev->entity; > + sink = &vin->vdev.entity; > + > + ret = media_create_pad_link(source, vin->parallel->source_pad, > + sink, vin->parallel->sink_pad, 0); > + if (ret) > + vin_err(vin, "Error adding link from %s to %s: %d\n", > + source->name, sink->name, ret); > + > + return ret; > } > > static void rvin_parallel_notify_unbind(struct v4l2_async_notifier *notifier, > @@ -611,7 +632,8 @@ static int rvin_group_notify_complete(struct v4l2_async_notifier *notifier) > > /* Register all video nodes for the group. */ > for (i = 0; i < RCAR_VIN_NUM; i++) { > - if (vin->group->vin[i]) { > + if (vin->group->vin[i] && > + !video_is_registered(&vin->group->vin[i]->vdev)) { > ret = rvin_v4l2_register(vin->group->vin[i]); > if (ret) > return ret; > -- > 2.7.4 > -- Regards, Niklas S�derlund
next prev parent reply other threads:[~2018-05-24 10:32 UTC|newest] Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-18 14:40 [PATCH v3 0/9] rcar-vin: Add support for parallel input on Gen3 Jacopo Mondi 2018-05-18 14:40 ` [PATCH v3 1/9] media: rcar-vin: Rename 'digital' to 'parallel' Jacopo Mondi 2018-05-23 22:42 ` Niklas Söderlund 2018-05-23 22:42 ` Niklas Söderlund 2018-05-24 20:19 ` jacopo mondi 2018-05-18 14:40 ` [PATCH v3 2/9] media: rcar-vin: Remove two empty lines Jacopo Mondi 2018-05-23 22:43 ` Niklas Söderlund 2018-05-23 22:43 ` Niklas Söderlund 2018-05-18 14:40 ` [PATCH v3 3/9] media: rcar-vin: Create a group notifier Jacopo Mondi 2018-05-24 10:14 ` Niklas Söderlund 2018-05-24 10:14 ` Niklas Söderlund 2019-04-05 16:16 ` Eugeniu Rosca 2019-04-06 0:04 ` Steve Longerbeam 2019-04-08 11:12 ` Niklas Söderlund 2019-04-09 3:58 ` Steve Longerbeam 2019-04-09 9:10 ` Kieran Bingham 2019-04-09 13:25 ` Niklas Söderlund 2019-04-09 22:52 ` Steve Longerbeam 2019-04-09 20:57 ` Laurent Pinchart 2019-04-09 22:22 ` Steve Longerbeam 2019-04-09 22:59 ` Laurent Pinchart 2019-04-09 23:29 ` Steve Longerbeam 2019-04-11 20:28 ` Eugeniu Rosca 2019-04-11 20:42 ` Niklas Söderlund 2019-04-12 14:12 ` Eugeniu Rosca 2019-04-12 15:10 ` Niklas Söderlund 2018-05-18 14:40 ` [PATCH v3 4/9] media: rcar-vin: Cache the mbus configuration flags Jacopo Mondi 2018-05-24 10:20 ` Niklas Söderlund 2018-05-24 10:20 ` Niklas Söderlund 2018-05-18 14:40 ` [PATCH v3 5/9] media: rcar-vin: Parse parallel input on Gen3 Jacopo Mondi 2018-05-24 10:30 ` Niklas Söderlund 2018-05-24 10:30 ` Niklas Söderlund 2018-05-18 14:40 ` [PATCH v3 6/9] media: rcar-vin: Link parallel input media entities Jacopo Mondi 2018-05-24 10:32 ` Niklas Söderlund [this message] 2018-05-24 10:32 ` Niklas Söderlund 2018-05-18 14:40 ` [PATCH v3 7/9] media: rcar-vin: Handle parallel subdev in link_notify Jacopo Mondi 2018-05-24 10:37 ` Niklas Söderlund 2018-05-24 10:37 ` Niklas Söderlund 2018-05-18 14:40 ` [PATCH v3 8/9] media: rcar-vin: Rename _rcar_info to rcar_info Jacopo Mondi 2018-05-19 9:33 ` Sergei Shtylyov 2018-05-24 10:38 ` Niklas Söderlund 2018-05-24 10:38 ` Niklas Söderlund 2018-05-18 14:40 ` [PATCH v3 9/9] media: rcar-vin: Add support for R-Car R8A77995 SoC Jacopo Mondi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180524103218.GF31036@bigcity.dyn.berto.se \ --to=niklas.soderlund@ragnatech.se \ --cc=jacopo+renesas@jmondi.org \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-media@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.