From: Mike Snitzer <snitzer@redhat.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Alasdair Kergon <agk@redhat.com>,
dm-devel@redhat.com, Mikulas Patocka <mpatocka@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: dm: writecache: fix format string warning
Date: Tue, 29 May 2018 14:09:26 -0400 [thread overview]
Message-ID: <20180529180926.GC32763@redhat.com> (raw)
In-Reply-To: <20180528155432.2864616-1-arnd@arndb.de>
On Mon, May 28 2018 at 11:54am -0400,
Arnd Bergmann <arnd@arndb.de> wrote:
> The return type of ACCESS_ONCE is configuration dependent and may be either
> 'int' or 'long int' for the writecache_has_error() macro, so we get a warning
> like this for either format string:
>
> In file included from drivers/md/dm-writecache.c:8:
> drivers/md/dm-writecache.c: In function 'writecache_status':
> drivers/md/dm-writecache.c:2227:10: error: format '%ld' expects argument of type 'long int', but argument 4 has type 'int' [-Werror=format=]
> DMEMIT("%ld %llu %llu %llu", writecache_has_error(wc),
> ^~~~~~~~~~~~~~~~~~~~
> include/linux/device-mapper.h:549:46: note: in definition of macro 'DMEMIT'
> 0 : scnprintf(result + sz, maxlen - sz, x))
> ^
>
> The code is otherwise correct, so we just need to shut up the warning,
> which can be done using an extra type cast.
>
> Fixes: bb15b431d650 ("dm: add writecache target")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks, I've picked this up.
next prev parent reply other threads:[~2018-05-29 18:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-28 15:54 [PATCH] dm: writecache: fix format string warning Arnd Bergmann
2018-05-28 15:54 ` Arnd Bergmann
2018-05-29 18:09 ` Mike Snitzer [this message]
2018-05-30 12:13 ` Mikulas Patocka
2018-05-30 12:19 ` [PATCH] branch-check: fix long->int truncation when profiling branches Mikulas Patocka
2018-06-04 20:50 ` Steven Rostedt
2018-06-04 20:50 ` Steven Rostedt
2018-06-04 20:54 ` Mikulas Patocka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180529180926.GC32763@redhat.com \
--to=snitzer@redhat.com \
--cc=agk@redhat.com \
--cc=arnd@arndb.de \
--cc=dm-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpatocka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.