From: Arnd Bergmann <arnd@arndb.de> To: Alasdair Kergon <agk@redhat.com>, Mike Snitzer <snitzer@redhat.com>, dm-devel@redhat.com Cc: Arnd Bergmann <arnd@arndb.de>, Mikulas Patocka <mpatocka@redhat.com>, linux-kernel@vger.kernel.org Subject: [PATCH] dm: writecache: fix format string warning Date: Mon, 28 May 2018 17:54:08 +0200 [thread overview] Message-ID: <20180528155432.2864616-1-arnd@arndb.de> (raw) The return type of ACCESS_ONCE is configuration dependent and may be either 'int' or 'long int' for the writecache_has_error() macro, so we get a warning like this for either format string: In file included from drivers/md/dm-writecache.c:8: drivers/md/dm-writecache.c: In function 'writecache_status': drivers/md/dm-writecache.c:2227:10: error: format '%ld' expects argument of type 'long int', but argument 4 has type 'int' [-Werror=format=] DMEMIT("%ld %llu %llu %llu", writecache_has_error(wc), ^~~~~~~~~~~~~~~~~~~~ include/linux/device-mapper.h:549:46: note: in definition of macro 'DMEMIT' 0 : scnprintf(result + sz, maxlen - sz, x)) ^ The code is otherwise correct, so we just need to shut up the warning, which can be done using an extra type cast. Fixes: bb15b431d650 ("dm: add writecache target") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/md/dm-writecache.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/dm-writecache.c b/drivers/md/dm-writecache.c index 1ef06e738eb6..772ac3a57287 100644 --- a/drivers/md/dm-writecache.c +++ b/drivers/md/dm-writecache.c @@ -2224,7 +2224,7 @@ static void writecache_status(struct dm_target *ti, status_type_t type, switch (type) { case STATUSTYPE_INFO: - DMEMIT("%ld %llu %llu %llu", writecache_has_error(wc), + DMEMIT("%ld %llu %llu %llu", (long)writecache_has_error(wc), (unsigned long long)wc->n_blocks, (unsigned long long)wc->freelist_size, (unsigned long long)wc->writeback_size); break; -- 2.9.0
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de> To: Alasdair Kergon <agk@redhat.com>, Mike Snitzer <snitzer@redhat.com>, dm-devel@redhat.com Cc: Mikulas Patocka <mpatocka@redhat.com>, linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de> Subject: [PATCH] dm: writecache: fix format string warning Date: Mon, 28 May 2018 17:54:08 +0200 [thread overview] Message-ID: <20180528155432.2864616-1-arnd@arndb.de> (raw) The return type of ACCESS_ONCE is configuration dependent and may be either 'int' or 'long int' for the writecache_has_error() macro, so we get a warning like this for either format string: In file included from drivers/md/dm-writecache.c:8: drivers/md/dm-writecache.c: In function 'writecache_status': drivers/md/dm-writecache.c:2227:10: error: format '%ld' expects argument of type 'long int', but argument 4 has type 'int' [-Werror=format=] DMEMIT("%ld %llu %llu %llu", writecache_has_error(wc), ^~~~~~~~~~~~~~~~~~~~ include/linux/device-mapper.h:549:46: note: in definition of macro 'DMEMIT' 0 : scnprintf(result + sz, maxlen - sz, x)) ^ The code is otherwise correct, so we just need to shut up the warning, which can be done using an extra type cast. Fixes: bb15b431d650 ("dm: add writecache target") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/md/dm-writecache.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/dm-writecache.c b/drivers/md/dm-writecache.c index 1ef06e738eb6..772ac3a57287 100644 --- a/drivers/md/dm-writecache.c +++ b/drivers/md/dm-writecache.c @@ -2224,7 +2224,7 @@ static void writecache_status(struct dm_target *ti, status_type_t type, switch (type) { case STATUSTYPE_INFO: - DMEMIT("%ld %llu %llu %llu", writecache_has_error(wc), + DMEMIT("%ld %llu %llu %llu", (long)writecache_has_error(wc), (unsigned long long)wc->n_blocks, (unsigned long long)wc->freelist_size, (unsigned long long)wc->writeback_size); break; -- 2.9.0
next reply other threads:[~2018-05-28 15:55 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-28 15:54 Arnd Bergmann [this message] 2018-05-28 15:54 ` [PATCH] dm: writecache: fix format string warning Arnd Bergmann 2018-05-29 18:09 ` Mike Snitzer 2018-05-30 12:13 ` [PATCH] " Mikulas Patocka 2018-05-30 12:19 ` [PATCH] branch-check: fix long->int truncation when profiling branches Mikulas Patocka 2018-06-04 20:50 ` Steven Rostedt 2018-06-04 20:50 ` Steven Rostedt 2018-06-04 20:54 ` Mikulas Patocka
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180528155432.2864616-1-arnd@arndb.de \ --to=arnd@arndb.de \ --cc=agk@redhat.com \ --cc=dm-devel@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=mpatocka@redhat.com \ --cc=snitzer@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.