All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Christian Lamparter <chunkeey@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, David Brown <david.brown@linaro.org>,
	Stephen Boyd <sboyd@kernel.org>,
	linux-arm-msm@vger.kernel.org,
	Linus Walleij <linus.walleij@linaro.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	linux-gpio@vger.kernel.org,
	Sven Eckelmann <sven.eckelmann@openmesh.com>,
	Andy Gross <andy.gross@linaro.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 1/2] dt-bindings: pinctrl: qcom: add gpio-ranges, gpio-reserved-ranges
Date: Wed, 30 May 2018 19:14:54 -0500	[thread overview]
Message-ID: <20180531001454.GA8422@rob-hp-laptop> (raw)
In-Reply-To: <6dbaadee4bb22638a2c2e6433e8d1740884ecfd9.1527505307.git.chunkeey@gmail.com>

On Mon, May 28, 2018 at 01:06:01PM +0200, Christian Lamparter wrote:
> This patch adds the gpio-ranges and gpio-reserved-ranges property
> definitions to the binding text files supported by the pinctrl-msm
> driver framework.
> 
> gpio-ranges:
> For DT-based platforms the pinctrl-msm framework currently relies
> on the deprecated-for-DT gpiochip_add_pin_range() function to add
> the range of GPIOs to be handled by the pin controller. Due to
> interactions within gpiolib code, this causes the pinctrl-msm
> driver to bail out (-517) during boot when a gpio-hog is declared.
> This can be fatal and cause the system to not boot or reset
> (for a detailed explanation and call-trace, refer to patch:
> "pinctrl: msm: fix gpio-hog related boot issues" in this series).
> 
> gpio-reserved-ranges:
> The binding has been added as a precaution since the TrustZone
> firmware (aka QSEE), which is running as the hypervisor, might
> have reserved certain, but undisclosed pins. Hence reading or
> writing to the registers for those pins will cause an
> XPU violation and this subsequently crashes the kernel.
> 
> Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
> ---
>  .../devicetree/bindings/pinctrl/qcom,apq8064-pinctrl.txt | 6 ++++++
>  .../devicetree/bindings/pinctrl/qcom,apq8084-pinctrl.txt | 9 +++++++++
>  .../devicetree/bindings/pinctrl/qcom,ipq4019-pinctrl.txt | 6 ++++++
>  .../devicetree/bindings/pinctrl/qcom,ipq8064-pinctrl.txt | 6 ++++++
>  .../devicetree/bindings/pinctrl/qcom,ipq8074-pinctrl.txt | 9 +++++++++
>  .../devicetree/bindings/pinctrl/qcom,mdm9615-pinctrl.txt | 9 +++++++++
>  .../devicetree/bindings/pinctrl/qcom,msm8660-pinctrl.txt | 6 ++++++
>  .../devicetree/bindings/pinctrl/qcom,msm8916-pinctrl.txt | 9 +++++++++
>  .../devicetree/bindings/pinctrl/qcom,msm8960-pinctrl.txt | 9 +++++++++
>  .../devicetree/bindings/pinctrl/qcom,msm8974-pinctrl.txt | 6 ++++++
>  .../devicetree/bindings/pinctrl/qcom,msm8994-pinctrl.txt | 9 +++++++++
>  .../devicetree/bindings/pinctrl/qcom,msm8996-pinctrl.txt | 9 +++++++++
>  12 files changed, 93 insertions(+)

Reviewed-by: Rob Herring <robh@kernel.org>

WARNING: multiple messages have this Message-ID (diff)
From: robh@kernel.org (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 1/2] dt-bindings: pinctrl: qcom: add gpio-ranges, gpio-reserved-ranges
Date: Wed, 30 May 2018 19:14:54 -0500	[thread overview]
Message-ID: <20180531001454.GA8422@rob-hp-laptop> (raw)
In-Reply-To: <6dbaadee4bb22638a2c2e6433e8d1740884ecfd9.1527505307.git.chunkeey@gmail.com>

On Mon, May 28, 2018 at 01:06:01PM +0200, Christian Lamparter wrote:
> This patch adds the gpio-ranges and gpio-reserved-ranges property
> definitions to the binding text files supported by the pinctrl-msm
> driver framework.
> 
> gpio-ranges:
> For DT-based platforms the pinctrl-msm framework currently relies
> on the deprecated-for-DT gpiochip_add_pin_range() function to add
> the range of GPIOs to be handled by the pin controller. Due to
> interactions within gpiolib code, this causes the pinctrl-msm
> driver to bail out (-517) during boot when a gpio-hog is declared.
> This can be fatal and cause the system to not boot or reset
> (for a detailed explanation and call-trace, refer to patch:
> "pinctrl: msm: fix gpio-hog related boot issues" in this series).
> 
> gpio-reserved-ranges:
> The binding has been added as a precaution since the TrustZone
> firmware (aka QSEE), which is running as the hypervisor, might
> have reserved certain, but undisclosed pins. Hence reading or
> writing to the registers for those pins will cause an
> XPU violation and this subsequently crashes the kernel.
> 
> Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
> ---
>  .../devicetree/bindings/pinctrl/qcom,apq8064-pinctrl.txt | 6 ++++++
>  .../devicetree/bindings/pinctrl/qcom,apq8084-pinctrl.txt | 9 +++++++++
>  .../devicetree/bindings/pinctrl/qcom,ipq4019-pinctrl.txt | 6 ++++++
>  .../devicetree/bindings/pinctrl/qcom,ipq8064-pinctrl.txt | 6 ++++++
>  .../devicetree/bindings/pinctrl/qcom,ipq8074-pinctrl.txt | 9 +++++++++
>  .../devicetree/bindings/pinctrl/qcom,mdm9615-pinctrl.txt | 9 +++++++++
>  .../devicetree/bindings/pinctrl/qcom,msm8660-pinctrl.txt | 6 ++++++
>  .../devicetree/bindings/pinctrl/qcom,msm8916-pinctrl.txt | 9 +++++++++
>  .../devicetree/bindings/pinctrl/qcom,msm8960-pinctrl.txt | 9 +++++++++
>  .../devicetree/bindings/pinctrl/qcom,msm8974-pinctrl.txt | 6 ++++++
>  .../devicetree/bindings/pinctrl/qcom,msm8994-pinctrl.txt | 9 +++++++++
>  .../devicetree/bindings/pinctrl/qcom,msm8996-pinctrl.txt | 9 +++++++++
>  12 files changed, 93 insertions(+)

Reviewed-by: Rob Herring <robh@kernel.org>

  parent reply	other threads:[~2018-05-31  0:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-28 11:06 [PATCH v6 1/2] dt-bindings: pinctrl: qcom: add gpio-ranges, gpio-reserved-ranges Christian Lamparter
2018-05-28 11:06 ` Christian Lamparter
2018-05-28 11:06 ` [PATCH v6 2/2] ARM: dts: qcom: add gpio-ranges property Christian Lamparter
2018-05-28 11:06   ` Christian Lamparter
2018-05-31  0:14 ` Rob Herring [this message]
2018-05-31  0:14   ` [PATCH v6 1/2] dt-bindings: pinctrl: qcom: add gpio-ranges, gpio-reserved-ranges Rob Herring
2018-06-28 14:29 ` Linus Walleij
2018-06-28 14:29   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180531001454.GA8422@rob-hp-laptop \
    --to=robh@kernel.org \
    --cc=andy.gross@linaro.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=chunkeey@gmail.com \
    --cc=david.brown@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=sboyd@kernel.org \
    --cc=sven.eckelmann@openmesh.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.