From: Christoph Hellwig <hch@lst.de>
To: Andreas Gruenbacher <agruenba@redhat.com>
Cc: cluster-devel@redhat.com, Christoph Hellwig <hch@lst.de>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v7 12/12] iomap: Put struct iomap_ops into struct iomap
Date: Mon, 4 Jun 2018 14:52:27 +0200 [thread overview]
Message-ID: <20180604125227.GC30780@lst.de> (raw)
In-Reply-To: <20180604123729.23414-13-agruenba@redhat.com>
On Mon, Jun 04, 2018 at 02:37:29PM +0200, Andreas Gruenbacher wrote:
> We need access to the struct iomap_ops in iomap_write_end to call the
> (optional) page_write_end hook, so instead of passing the operators to
> iomap_write_end differently depending on the code path, add an ops field
> to struct iomap.
I don't really like this. We already pass the iomap_ops to the
function we call from iomap.c, and in fact ->iomap_begin is called
through the ops.
But what we could do is to move the page_write_end callback out of
iomap_ops and just attached it to the iomap, especially given that
it isn't really as generic as the other ops.
Can't say I like the implications of this callback in general, but
the use case is real, so..
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH v7 12/12] iomap: Put struct iomap_ops into struct iomap
Date: Mon, 4 Jun 2018 14:52:27 +0200 [thread overview]
Message-ID: <20180604125227.GC30780@lst.de> (raw)
In-Reply-To: <20180604123729.23414-13-agruenba@redhat.com>
On Mon, Jun 04, 2018 at 02:37:29PM +0200, Andreas Gruenbacher wrote:
> We need access to the struct iomap_ops in iomap_write_end to call the
> (optional) page_write_end hook, so instead of passing the operators to
> iomap_write_end differently depending on the code path, add an ops field
> to struct iomap.
I don't really like this. We already pass the iomap_ops to the
function we call from iomap.c, and in fact ->iomap_begin is called
through the ops.
But what we could do is to move the page_write_end callback out of
iomap_ops and just attached it to the iomap, especially given that
it isn't really as generic as the other ops.
Can't say I like the implications of this callback in general, but
the use case is real, so..
next prev parent reply other threads:[~2018-06-04 12:45 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-04 12:37 [PATCH v7 00/12] gfs2 iomap write support Andreas Gruenbacher
2018-06-04 12:37 ` [Cluster-devel] " Andreas Gruenbacher
2018-06-04 12:37 ` [PATCH v7 01/12] iomap: inline data should be an iomap type, not a flag Andreas Gruenbacher
2018-06-04 12:37 ` [Cluster-devel] " Andreas Gruenbacher
2018-06-04 12:37 ` [PATCH v7 02/12] iomap: Mark newly allocated buffer heads as new Andreas Gruenbacher
2018-06-04 12:37 ` [Cluster-devel] " Andreas Gruenbacher
2018-06-04 12:37 ` [PATCH v7 03/12] iomap: Complete partial direct I/O writes synchronously Andreas Gruenbacher
2018-06-04 12:37 ` [Cluster-devel] " Andreas Gruenbacher
2018-06-04 12:37 ` [PATCH v7 04/12] fs: factor out a __generic_write_end helper Andreas Gruenbacher
2018-06-04 12:37 ` [Cluster-devel] " Andreas Gruenbacher
2018-06-04 12:37 ` [PATCH v7 05/12] fs: allow to always dirty inode in __generic_write_end Andreas Gruenbacher
2018-06-04 12:37 ` [Cluster-devel] " Andreas Gruenbacher
2018-06-04 12:48 ` Christoph Hellwig
2018-06-04 12:48 ` [Cluster-devel] " Christoph Hellwig
2018-06-04 16:24 ` Andreas Grünbacher
2018-06-04 16:24 ` [Cluster-devel] " Andreas Grünbacher
2018-06-04 12:37 ` [PATCH v7 06/12] iomap: Generic inline data handling Andreas Gruenbacher
2018-06-04 12:37 ` [Cluster-devel] " Andreas Gruenbacher
2018-06-04 12:37 ` [PATCH v7 07/12] iomap: Add page_write_end iomap hook Andreas Gruenbacher
2018-06-04 12:37 ` [Cluster-devel] " Andreas Gruenbacher
2018-06-04 12:50 ` Christoph Hellwig
2018-06-04 12:50 ` [Cluster-devel] " Christoph Hellwig
2018-06-04 16:40 ` Andreas Grünbacher
2018-06-04 16:40 ` [Cluster-devel] " Andreas Grünbacher
2018-06-04 12:37 ` [PATCH v7 08/12] gfs2: iomap buffered write support Andreas Gruenbacher
2018-06-04 12:37 ` [Cluster-devel] " Andreas Gruenbacher
2018-06-04 12:37 ` [PATCH v7 09/12] gfs2: gfs2_extent_length cleanup Andreas Gruenbacher
2018-06-04 12:37 ` [Cluster-devel] " Andreas Gruenbacher
2018-06-04 12:37 ` [PATCH v7 10/12] gfs2: iomap direct I/O support Andreas Gruenbacher
2018-06-04 12:37 ` [Cluster-devel] " Andreas Gruenbacher
2018-06-04 12:37 ` [PATCH v7 11/12] gfs2: Remove gfs2_write_{begin,end} Andreas Gruenbacher
2018-06-04 12:37 ` [Cluster-devel] [PATCH v7 11/12] gfs2: Remove gfs2_write_{begin, end} Andreas Gruenbacher
2018-06-04 12:37 ` [PATCH v7 12/12] iomap: Put struct iomap_ops into struct iomap Andreas Gruenbacher
2018-06-04 12:37 ` [Cluster-devel] " Andreas Gruenbacher
2018-06-04 12:52 ` Christoph Hellwig [this message]
2018-06-04 12:52 ` Christoph Hellwig
2018-06-04 17:00 ` Andreas Grünbacher
2018-06-04 17:00 ` [Cluster-devel] " Andreas Grünbacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180604125227.GC30780@lst.de \
--to=hch@lst.de \
--cc=agruenba@redhat.com \
--cc=cluster-devel@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.