From: Michal Hocko <mhocko@kernel.org>
To: 禹舟键 <ufo19890607@gmail.com>
Cc: akpm@linux-foundation.org, rientjes@google.com,
kirill.shutemov@linux.intel.com, aarcange@redhat.com,
penguin-kernel@i-love.sakura.ne.jp, guro@fb.com,
yang.s@alibaba-inc.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
Wind Yu <yuzhoujian@didichuxing.com>
Subject: Re: [PATCH v9] Refactor part of the oom report in dump_header
Date: Fri, 22 Jun 2018 14:19:36 +0200 [thread overview]
Message-ID: <20180622121936.GX10465@dhcp22.suse.cz> (raw)
In-Reply-To: <CAHCio2j-z5y8sQrZ9ENLH2sOzuoH=vsC+q9Nj5DbSXUnQK-uPw@mail.gmail.com>
On Fri 22-06-18 19:40:54, 禹舟键 wrote:
> Hi Michal
> > You misunderstood my suggestion. Let me be more specific. Please
> > separate the whole new oom_constraint including its _usage_.
>
> Sorry for misunderstanding your words. I think you want me to separate
> enum oom_constraint and static const char * const
> oom_constraint_text[] to two parts, am I right ?
Just split the patch into two parts. The first to add oom_constraint*
and use it. And the second which adds the missing memcg information to
the oom report.
--
Michal Hocko
SUSE Labs
WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@kernel.org>
To: 禹舟键 <ufo19890607@gmail.com>
Cc: akpm@linux-foundation.org, rientjes@google.com,
kirill.shutemov@linux.intel.com, aarcange@redhat.com,
penguin-kernel@i-love.sakura.ne.jp, guro@fb.com,
yang.s@alibaba-inc.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
Wind Yu <yuzhoujian@didichuxing.com>
Subject: Re: [PATCH v9] Refactor part of the oom report in dump_header
Date: Fri, 22 Jun 2018 14:19:36 +0200 [thread overview]
Message-ID: <20180622121936.GX10465@dhcp22.suse.cz> (raw)
In-Reply-To: <CAHCio2j-z5y8sQrZ9ENLH2sOzuoH=vsC+q9Nj5DbSXUnQK-uPw@mail.gmail.com>
On Fri 22-06-18 19:40:54, c|1e??e?(R) wrote:
> Hi Michal
> > You misunderstood my suggestion. Let me be more specific. Please
> > separate the whole new oom_constraint including its _usage_.
>
> Sorry for misunderstanding your words. I think you want me to separate
> enum oom_constraint and static const char * const
> oom_constraint_text[] to two parts, am I right ?
Just split the patch into two parts. The first to add oom_constraint*
and use it. And the second which adds the missing memcg information to
the oom report.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2018-06-22 12:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-15 9:52 [PATCH v9] Refactor part of the oom report in dump_header ufo19890607
2018-06-22 6:33 ` 禹舟键
2018-06-22 8:39 ` Michal Hocko
2018-06-22 9:33 ` 禹舟键
2018-06-22 10:42 ` Michal Hocko
2018-06-22 10:42 ` Michal Hocko
2018-06-22 11:40 ` 禹舟键
2018-06-22 12:19 ` Michal Hocko [this message]
2018-06-22 12:19 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180622121936.GX10465@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=guro@fb.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=rientjes@google.com \
--cc=ufo19890607@gmail.com \
--cc=yang.s@alibaba-inc.com \
--cc=yuzhoujian@didichuxing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.