All of lore.kernel.org
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: Roman Gushchin <guro@fb.com>
Cc: kbuild-all@01.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, shakeelb@google.com,
	hannes@cmpxchg.org, mhocko@kernel.org, akpm@linux-foundation.org,
	Roman Gushchin <guro@fb.com>
Subject: Re: [PATCH 1/2] mm: revert mem_cgroup_put() introduction
Date: Sat, 23 Jun 2018 08:47:13 +0800	[thread overview]
Message-ID: <201806230844.RXx55fMi%fengguang.wu@intel.com> (raw)
In-Reply-To: <20180623000600.5818-1-guro@fb.com>

[-- Attachment #1: Type: text/plain, Size: 3828 bytes --]

Hi Roman,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on next-20180622]
[cannot apply to linus/master v4.18-rc1 v4.17 v4.17-rc7 v4.18-rc1]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Roman-Gushchin/mm-revert-mem_cgroup_put-introduction/20180623-080942
config: i386-tinyconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

Note: the linux-review/Roman-Gushchin/mm-revert-mem_cgroup_put-introduction/20180623-080942 HEAD 76214420a3e55c42797f5f22cb04d1a3331c1ece builds fine.
      It only hurts bisectibility.

All errors (new ones prefixed by >>):

   mm/oom_kill.c: In function 'oom_kill_memcg_victim':
>> mm/oom_kill.c:1026:2: error: implicit declaration of function 'mem_cgroup_put'; did you mean 'mem_cgroup_id'? [-Werror=implicit-function-declaration]
     mem_cgroup_put(oc->chosen_memcg);
     ^~~~~~~~~~~~~~
     mem_cgroup_id
   cc1: some warnings being treated as errors

vim +1026 mm/oom_kill.c

4ac2c83a Roman Gushchin 2018-06-15   997  
7388c5c4 Roman Gushchin 2018-06-15   998  static bool oom_kill_memcg_victim(struct oom_control *oc)
7388c5c4 Roman Gushchin 2018-06-15   999  {
4ac2c83a Roman Gushchin 2018-06-15  1000  	if (oc->chosen_memcg == NULL || oc->chosen_memcg == INFLIGHT_VICTIM)
4ac2c83a Roman Gushchin 2018-06-15  1001  		return oc->chosen_memcg;
4ac2c83a Roman Gushchin 2018-06-15  1002  
7388c5c4 Roman Gushchin 2018-06-15  1003  	/*
7388c5c4 Roman Gushchin 2018-06-15  1004  	 * If memory.oom_group is set, kill all tasks belonging to the sub-tree
7388c5c4 Roman Gushchin 2018-06-15  1005  	 * of the chosen memory cgroup, otherwise kill the task with the biggest
7388c5c4 Roman Gushchin 2018-06-15  1006  	 * memory footprint.
7388c5c4 Roman Gushchin 2018-06-15  1007  	 */
7388c5c4 Roman Gushchin 2018-06-15  1008  	if (mem_cgroup_oom_group(oc->chosen_memcg)) {
7388c5c4 Roman Gushchin 2018-06-15  1009  		mem_cgroup_scan_tasks(oc->chosen_memcg, oom_kill_memcg_member,
7388c5c4 Roman Gushchin 2018-06-15  1010  				      NULL);
7388c5c4 Roman Gushchin 2018-06-15  1011  		/* We have one or more terminating processes at this point. */
7388c5c4 Roman Gushchin 2018-06-15  1012  		oc->chosen_task = INFLIGHT_VICTIM;
7388c5c4 Roman Gushchin 2018-06-15  1013  	} else {
4ac2c83a Roman Gushchin 2018-06-15  1014  		oc->chosen_points = 0;
4ac2c83a Roman Gushchin 2018-06-15  1015  		oc->chosen_task = NULL;
4ac2c83a Roman Gushchin 2018-06-15  1016  		mem_cgroup_scan_tasks(oc->chosen_memcg, oom_evaluate_task, oc);
4ac2c83a Roman Gushchin 2018-06-15  1017  
7388c5c4 Roman Gushchin 2018-06-15  1018  		if (oc->chosen_task == NULL ||
7388c5c4 Roman Gushchin 2018-06-15  1019  		    oc->chosen_task == INFLIGHT_VICTIM)
4ac2c83a Roman Gushchin 2018-06-15  1020  			goto out;
4ac2c83a Roman Gushchin 2018-06-15  1021  
4ac2c83a Roman Gushchin 2018-06-15  1022  		__oom_kill_process(oc->chosen_task);
7388c5c4 Roman Gushchin 2018-06-15  1023  	}
4ac2c83a Roman Gushchin 2018-06-15  1024  
4ac2c83a Roman Gushchin 2018-06-15  1025  out:
4ac2c83a Roman Gushchin 2018-06-15 @1026  	mem_cgroup_put(oc->chosen_memcg);
4ac2c83a Roman Gushchin 2018-06-15  1027  	return oc->chosen_task;
4ac2c83a Roman Gushchin 2018-06-15  1028  }
4ac2c83a Roman Gushchin 2018-06-15  1029  

:::::: The code at line 1026 was first introduced by commit
:::::: 4ac2c83a8e8a0708278b6f2bb44dc4c880fdcaf6 mm, oom: cgroup-aware OOM killer

:::::: TO: Roman Gushchin <guro@fb.com>
:::::: CC: Stephen Rothwell <sfr@canb.auug.org.au>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 6356 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: kbuild test robot <lkp@intel.com>
To: Roman Gushchin <guro@fb.com>
Cc: kbuild-all@01.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, shakeelb@google.com,
	hannes@cmpxchg.org, mhocko@kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH 1/2] mm: revert mem_cgroup_put() introduction
Date: Sat, 23 Jun 2018 08:47:13 +0800	[thread overview]
Message-ID: <201806230844.RXx55fMi%fengguang.wu@intel.com> (raw)
In-Reply-To: <20180623000600.5818-1-guro@fb.com>

[-- Attachment #1: Type: text/plain, Size: 3828 bytes --]

Hi Roman,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on next-20180622]
[cannot apply to linus/master v4.18-rc1 v4.17 v4.17-rc7 v4.18-rc1]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Roman-Gushchin/mm-revert-mem_cgroup_put-introduction/20180623-080942
config: i386-tinyconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

Note: the linux-review/Roman-Gushchin/mm-revert-mem_cgroup_put-introduction/20180623-080942 HEAD 76214420a3e55c42797f5f22cb04d1a3331c1ece builds fine.
      It only hurts bisectibility.

All errors (new ones prefixed by >>):

   mm/oom_kill.c: In function 'oom_kill_memcg_victim':
>> mm/oom_kill.c:1026:2: error: implicit declaration of function 'mem_cgroup_put'; did you mean 'mem_cgroup_id'? [-Werror=implicit-function-declaration]
     mem_cgroup_put(oc->chosen_memcg);
     ^~~~~~~~~~~~~~
     mem_cgroup_id
   cc1: some warnings being treated as errors

vim +1026 mm/oom_kill.c

4ac2c83a Roman Gushchin 2018-06-15   997  
7388c5c4 Roman Gushchin 2018-06-15   998  static bool oom_kill_memcg_victim(struct oom_control *oc)
7388c5c4 Roman Gushchin 2018-06-15   999  {
4ac2c83a Roman Gushchin 2018-06-15  1000  	if (oc->chosen_memcg == NULL || oc->chosen_memcg == INFLIGHT_VICTIM)
4ac2c83a Roman Gushchin 2018-06-15  1001  		return oc->chosen_memcg;
4ac2c83a Roman Gushchin 2018-06-15  1002  
7388c5c4 Roman Gushchin 2018-06-15  1003  	/*
7388c5c4 Roman Gushchin 2018-06-15  1004  	 * If memory.oom_group is set, kill all tasks belonging to the sub-tree
7388c5c4 Roman Gushchin 2018-06-15  1005  	 * of the chosen memory cgroup, otherwise kill the task with the biggest
7388c5c4 Roman Gushchin 2018-06-15  1006  	 * memory footprint.
7388c5c4 Roman Gushchin 2018-06-15  1007  	 */
7388c5c4 Roman Gushchin 2018-06-15  1008  	if (mem_cgroup_oom_group(oc->chosen_memcg)) {
7388c5c4 Roman Gushchin 2018-06-15  1009  		mem_cgroup_scan_tasks(oc->chosen_memcg, oom_kill_memcg_member,
7388c5c4 Roman Gushchin 2018-06-15  1010  				      NULL);
7388c5c4 Roman Gushchin 2018-06-15  1011  		/* We have one or more terminating processes at this point. */
7388c5c4 Roman Gushchin 2018-06-15  1012  		oc->chosen_task = INFLIGHT_VICTIM;
7388c5c4 Roman Gushchin 2018-06-15  1013  	} else {
4ac2c83a Roman Gushchin 2018-06-15  1014  		oc->chosen_points = 0;
4ac2c83a Roman Gushchin 2018-06-15  1015  		oc->chosen_task = NULL;
4ac2c83a Roman Gushchin 2018-06-15  1016  		mem_cgroup_scan_tasks(oc->chosen_memcg, oom_evaluate_task, oc);
4ac2c83a Roman Gushchin 2018-06-15  1017  
7388c5c4 Roman Gushchin 2018-06-15  1018  		if (oc->chosen_task == NULL ||
7388c5c4 Roman Gushchin 2018-06-15  1019  		    oc->chosen_task == INFLIGHT_VICTIM)
4ac2c83a Roman Gushchin 2018-06-15  1020  			goto out;
4ac2c83a Roman Gushchin 2018-06-15  1021  
4ac2c83a Roman Gushchin 2018-06-15  1022  		__oom_kill_process(oc->chosen_task);
7388c5c4 Roman Gushchin 2018-06-15  1023  	}
4ac2c83a Roman Gushchin 2018-06-15  1024  
4ac2c83a Roman Gushchin 2018-06-15  1025  out:
4ac2c83a Roman Gushchin 2018-06-15 @1026  	mem_cgroup_put(oc->chosen_memcg);
4ac2c83a Roman Gushchin 2018-06-15  1027  	return oc->chosen_task;
4ac2c83a Roman Gushchin 2018-06-15  1028  }
4ac2c83a Roman Gushchin 2018-06-15  1029  

:::::: The code at line 1026 was first introduced by commit
:::::: 4ac2c83a8e8a0708278b6f2bb44dc4c880fdcaf6 mm, oom: cgroup-aware OOM killer

:::::: TO: Roman Gushchin <guro@fb.com>
:::::: CC: Stephen Rothwell <sfr@canb.auug.org.au>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 6356 bytes --]

  parent reply	other threads:[~2018-06-23  0:47 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-19  5:13 [PATCH v6 0/3] Directed kmem charging Shakeel Butt
2018-06-19  5:13 ` [PATCH 1/3] mm: memcg: remote memcg charging for kmem allocations Shakeel Butt
2018-06-19 16:24   ` Johannes Weiner
2018-06-19 23:31     ` Shakeel Butt
2018-06-20 15:22       ` Johannes Weiner
2018-06-19  5:13 ` [PATCH 2/3] fs: fsnotify: account fsnotify metadata to kmemcg Shakeel Butt
2018-06-19  7:20   ` Amir Goldstein
2018-06-19 14:15     ` Shakeel Butt
2018-06-19  5:13 ` [PATCH 3/3] fs, mm: account buffer_head " Shakeel Butt
2018-06-19 16:27   ` Johannes Weiner
2018-06-19 17:40     ` Roman Gushchin
2018-06-19 17:40       ` Roman Gushchin
2018-06-19 19:51       ` Shakeel Butt
2018-06-19 19:55         ` Roman Gushchin
2018-06-22 23:33           ` Shakeel Butt
2018-06-23  0:05             ` [PATCH 1/2] mm: revert mem_cgroup_put() introduction Roman Gushchin
2018-06-23  0:05               ` Roman Gushchin
2018-06-23  0:06               ` [PATCH 2/2] mm: introduce mem_cgroup_put() helper Roman Gushchin
2018-06-23  0:06                 ` Roman Gushchin
2018-06-23  0:10                 ` Shakeel Butt
2018-06-23  0:47               ` kbuild test robot [this message]
2018-06-23  0:47                 ` [PATCH 1/2] mm: revert mem_cgroup_put() introduction kbuild test robot
2018-06-19 16:11 ` [PATCH v6 0/3] Directed kmem charging Johannes Weiner
2018-06-19 22:58   ` Shakeel Butt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201806230844.RXx55fMi%fengguang.wu@intel.com \
    --to=lkp@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=guro@fb.com \
    --cc=hannes@cmpxchg.org \
    --cc=kbuild-all@01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=shakeelb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.