From: Christoph Hellwig <hch@lst.de>
To: Andreas Gruenbacher <agruenba@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>,
cluster-devel <cluster-devel@redhat.com>,
linux-ext4 <linux-ext4@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH 0/1] iomap: Direct I/O for inline data
Date: Fri, 29 Jun 2018 10:43:13 +0200 [thread overview]
Message-ID: <20180629084313.GA16042@lst.de> (raw)
In-Reply-To: <CAHc6FU7gJUcaKRr6He8Te0wcMYMQjriwbz58pC-ie1m-WJOw0g@mail.gmail.com>
> A possible fix is to change the alignment check in iomap_dio_actor as follows:
>
> - if ((pos | length | align) & ((1 << blkbits) - 1))
> + if ((pos | align) & ((1 << blkbits) - 1))
> + return -EINVAL;
> + if (length & ((1 << blkbits) - 1) &&
> + pos + length != iomap->offset + iomap->length)
> return -EINVAL;
>
> Moving the alignment check from iomap_dio_actor to iomap_dio_rw isn't
> that easy because iomap->bdev isn't known there.
Just make the check conditional on iomap->type != IOMAP_INLINE
as alignment checks on inline data don't make much sense.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Andreas Gruenbacher <agruenba@redhat.com>
Cc: cluster-devel <cluster-devel@redhat.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-ext4 <linux-ext4@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 0/1] iomap: Direct I/O for inline data
Date: Fri, 29 Jun 2018 10:43:13 +0200 [thread overview]
Message-ID: <20180629084313.GA16042@lst.de> (raw)
In-Reply-To: <CAHc6FU7gJUcaKRr6He8Te0wcMYMQjriwbz58pC-ie1m-WJOw0g@mail.gmail.com>
> A possible fix is to change the alignment check in iomap_dio_actor as follows:
>
> - if ((pos | length | align) & ((1 << blkbits) - 1))
> + if ((pos | align) & ((1 << blkbits) - 1))
> + return -EINVAL;
> + if (length & ((1 << blkbits) - 1) &&
> + pos + length != iomap->offset + iomap->length)
> return -EINVAL;
>
> Moving the alignment check from iomap_dio_actor to iomap_dio_rw isn't
> that easy because iomap->bdev isn't known there.
Just make the check conditional on iomap->type != IOMAP_INLINE
as alignment checks on inline data don't make much sense.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 0/1] iomap: Direct I/O for inline data
Date: Fri, 29 Jun 2018 10:43:13 +0200 [thread overview]
Message-ID: <20180629084313.GA16042@lst.de> (raw)
In-Reply-To: <CAHc6FU7gJUcaKRr6He8Te0wcMYMQjriwbz58pC-ie1m-WJOw0g@mail.gmail.com>
> A possible fix is to change the alignment check in iomap_dio_actor as follows:
>
> - if ((pos | length | align) & ((1 << blkbits) - 1))
> + if ((pos | align) & ((1 << blkbits) - 1))
> + return -EINVAL;
> + if (length & ((1 << blkbits) - 1) &&
> + pos + length != iomap->offset + iomap->length)
> return -EINVAL;
>
> Moving the alignment check from iomap_dio_actor to iomap_dio_rw isn't
> that easy because iomap->bdev isn't known there.
Just make the check conditional on iomap->type != IOMAP_INLINE
as alignment checks on inline data don't make much sense.
next prev parent reply other threads:[~2018-06-29 8:43 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-27 0:39 [PATCH 0/1] iomap: Direct I/O for inline data Andreas Gruenbacher
2018-06-27 0:39 ` [Cluster-devel] " Andreas Gruenbacher
2018-06-27 0:39 ` Andreas Gruenbacher
2018-06-27 0:39 ` [PATCH 1/1] " Andreas Gruenbacher
2018-06-27 0:39 ` [Cluster-devel] " Andreas Gruenbacher
2018-06-27 0:39 ` Andreas Gruenbacher
2018-06-27 1:44 ` kbuild test robot
2018-06-27 1:44 ` [Cluster-devel] " kbuild test robot
2018-06-27 1:44 ` kbuild test robot
2018-06-29 8:56 ` Christoph Hellwig
2018-06-29 8:56 ` [Cluster-devel] " Christoph Hellwig
2018-06-29 8:56 ` Christoph Hellwig
2018-06-29 14:40 ` Andreas Gruenbacher
2018-06-29 14:40 ` [Cluster-devel] " Andreas Gruenbacher
2018-06-29 14:40 ` Andreas Gruenbacher
2018-06-29 16:01 ` Christoph Hellwig
2018-06-29 16:01 ` [Cluster-devel] " Christoph Hellwig
2018-06-29 16:01 ` Christoph Hellwig
2018-06-29 17:02 ` Andreas Gruenbacher
2018-06-29 17:02 ` [Cluster-devel] " Andreas Gruenbacher
2018-06-29 17:02 ` Andreas Gruenbacher
2018-07-01 6:13 ` Christoph Hellwig
2018-07-01 6:13 ` [Cluster-devel] " Christoph Hellwig
2018-07-01 6:13 ` Christoph Hellwig
2018-07-01 6:29 ` Christoph Hellwig
2018-07-01 6:29 ` [Cluster-devel] " Christoph Hellwig
2018-07-01 6:29 ` Christoph Hellwig
2018-07-01 21:44 ` Andreas Gruenbacher
2018-07-01 21:44 ` [Cluster-devel] " Andreas Gruenbacher
2018-07-01 21:44 ` Andreas Gruenbacher
2018-06-27 11:14 ` [PATCH 0/1] " Andreas Gruenbacher
2018-06-27 11:14 ` [Cluster-devel] " Andreas Gruenbacher
2018-06-27 11:14 ` Andreas Gruenbacher
2018-06-29 8:43 ` Christoph Hellwig [this message]
2018-06-29 8:43 ` [Cluster-devel] " Christoph Hellwig
2018-06-29 8:43 ` Christoph Hellwig
2018-06-29 11:01 ` Andreas Gruenbacher
2018-06-29 11:01 ` [Cluster-devel] " Andreas Gruenbacher
2018-06-29 11:01 ` Andreas Gruenbacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180629084313.GA16042@lst.de \
--to=hch@lst.de \
--cc=agruenba@redhat.com \
--cc=cluster-devel@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.