From: Michal Hocko <mhocko@kernel.org>
To: "Christian König" <christian.koenig@amd.com>
Cc: kvm@vger.kernel.org, "Radim Krčmář" <rkrcmar@redhat.com>,
"David Airlie" <airlied@linux.ie>,
"Sudeep Dutt" <sudeep.dutt@intel.com>,
dri-devel@lists.freedesktop.org, linux-mm@kvack.org,
"Andrea Arcangeli" <aarcange@redhat.com>,
"David (ChunMing) Zhou" <David1.Zhou@amd.com>,
"Dimitri Sivanich" <sivanich@sgi.com>,
linux-rdma@vger.kernel.org, amd-gfx@lists.freedesktop.org,
"Jason Gunthorpe" <jgg@ziepe.ca>,
"Doug Ledford" <dledford@redhat.com>,
"David Rientjes" <rientjes@google.com>,
xen-devel@lists.xenproject.org, intel-gfx@lists.freedesktop.org,
"Jérôme Glisse" <jglisse@redhat.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Boris Ostrovsky" <boris.ostrovsky@oracle.com>,
"Juergen Gross" <jgross@suse.com>,
"Mike Marciniszyn" <mike.marciniszyn@intel.com>,
"Dennis Dalessandro" <dennis.dalessandro@intel.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] mm, oom: distinguish blockable mode for mmu notifiers
Date: Mon, 2 Jul 2018 13:54:23 +0200 [thread overview]
Message-ID: <20180702115423.GK19043@dhcp22.suse.cz> (raw)
In-Reply-To: <71f4184c-21ea-5af1-eeb6-bf7787614e2d@amd.com>
On Mon 02-07-18 11:14:58, Christian König wrote:
> Am 27.06.2018 um 09:44 schrieb Michal Hocko:
> > This is the v2 of RFC based on the feedback I've received so far. The
> > code even compiles as a bonus ;) I haven't runtime tested it yet, mostly
> > because I have no idea how.
> >
> > Any further feedback is highly appreciated of course.
>
> That sounds like it should work and at least the amdgpu changes now look
> good to me on first glance.
>
> Can you split that up further in the usual way? E.g. adding the blockable
> flag in one patch and fixing all implementations of the MMU notifier in
> follow up patches.
But such a code would be broken, no? Ignoring the blockable state will
simply lead to lockups until the fixup parts get applied.
Is the split up really worth it? I was thinking about that but had hard
times to end up with something that would be bisectable. Well, except
for returning -EBUSY until all notifiers are implemented. Which I found
confusing.
> This way I'm pretty sure Felix and I can give an rb on the amdgpu/amdkfd
> changes.
If you are worried to give r-b only for those then this can be done even
for larger patches. Just make your Reviewd-by more specific
R-b: name # For BLA BLA
--
Michal Hocko
SUSE Labs
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@kernel.org>
To: "Christian König" <christian.koenig@amd.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
"David (ChunMing) Zhou" <David1.Zhou@amd.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"David Airlie" <airlied@linux.ie>,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Doug Ledford" <dledford@redhat.com>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
"Mike Marciniszyn" <mike.marciniszyn@intel.com>,
"Dennis Dalessandro" <dennis.dalessandro@intel.com>,
"Sudeep Dutt" <sudeep.dutt@intel.com>,
"Ashutosh Dixit" <ashutosh.dixit@intel.com>,
"Dimitri Sivanich" <sivanich@sgi.com>,
"Boris Ostrovsky" <boris.ostrovsky@oracle.com>,
"Juergen Gross" <jgross@suse.com>,
"Jérôme Glisse" <jglisse@redhat.com>,
"Andrea Arcangeli" <aarcange@redhat.com>,
kvm@vger.kernel.org, amd-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
linux-rdma@vger.kernel.org, xen-devel@lists.xenproject.org,
linux-mm@kvack.org, "David Rientjes" <rientjes@google.com>,
"Felix Kuehling" <felix.kuehling@amd.com>
Subject: Re: [RFC PATCH] mm, oom: distinguish blockable mode for mmu notifiers
Date: Mon, 2 Jul 2018 13:54:23 +0200 [thread overview]
Message-ID: <20180702115423.GK19043@dhcp22.suse.cz> (raw)
In-Reply-To: <71f4184c-21ea-5af1-eeb6-bf7787614e2d@amd.com>
On Mon 02-07-18 11:14:58, Christian König wrote:
> Am 27.06.2018 um 09:44 schrieb Michal Hocko:
> > This is the v2 of RFC based on the feedback I've received so far. The
> > code even compiles as a bonus ;) I haven't runtime tested it yet, mostly
> > because I have no idea how.
> >
> > Any further feedback is highly appreciated of course.
>
> That sounds like it should work and at least the amdgpu changes now look
> good to me on first glance.
>
> Can you split that up further in the usual way? E.g. adding the blockable
> flag in one patch and fixing all implementations of the MMU notifier in
> follow up patches.
But such a code would be broken, no? Ignoring the blockable state will
simply lead to lockups until the fixup parts get applied.
Is the split up really worth it? I was thinking about that but had hard
times to end up with something that would be bisectable. Well, except
for returning -EBUSY until all notifiers are implemented. Which I found
confusing.
> This way I'm pretty sure Felix and I can give an rb on the amdgpu/amdkfd
> changes.
If you are worried to give r-b only for those then this can be done even
for larger patches. Just make your Reviewd-by more specific
R-b: name # For BLA BLA
--
Michal Hocko
SUSE Labs
WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@kernel.org>
To: "Christian König" <christian.koenig@amd.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
"David (ChunMing) Zhou" <David1.Zhou@amd.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"David Airlie" <airlied@linux.ie>,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Doug Ledford" <dledford@redhat.com>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
"Mike Marciniszyn" <mike.marciniszyn@intel.com>,
"Dennis Dalessandro" <dennis.dalessandro@intel.com>,
"Sudeep Dutt" <sudeep.dutt@intel.com>,
"Ashutosh Dixit" <ashutosh.dixit@intel.com>,
"Dimitri Sivanich" <sivanich@sgi.com>,
"Boris Ostrovsky" <boris.ostrovsky@oracle.com>,
"Juergen Gross" <jgross@suse.com>,
"Jérôme Glisse" <jglisse@redhat.com>,
"Andrea Arcangeli" <aarcange@redhat.com>,
kvm@vger.kernel.org, amd-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
linux-rdma@vger.kernel.org, xen-devel@lists.xenproject.org,
linux-mm@kvack.org, "David Rientjes" <rientjes@google.com>,
"Felix Kuehling" <felix.kuehling@amd.com>
Subject: Re: [RFC PATCH] mm, oom: distinguish blockable mode for mmu notifiers
Date: Mon, 2 Jul 2018 13:54:23 +0200 [thread overview]
Message-ID: <20180702115423.GK19043@dhcp22.suse.cz> (raw)
In-Reply-To: <71f4184c-21ea-5af1-eeb6-bf7787614e2d@amd.com>
On Mon 02-07-18 11:14:58, Christian Konig wrote:
> Am 27.06.2018 um 09:44 schrieb Michal Hocko:
> > This is the v2 of RFC based on the feedback I've received so far. The
> > code even compiles as a bonus ;) I haven't runtime tested it yet, mostly
> > because I have no idea how.
> >
> > Any further feedback is highly appreciated of course.
>
> That sounds like it should work and at least the amdgpu changes now look
> good to me on first glance.
>
> Can you split that up further in the usual way? E.g. adding the blockable
> flag in one patch and fixing all implementations of the MMU notifier in
> follow up patches.
But such a code would be broken, no? Ignoring the blockable state will
simply lead to lockups until the fixup parts get applied.
Is the split up really worth it? I was thinking about that but had hard
times to end up with something that would be bisectable. Well, except
for returning -EBUSY until all notifiers are implemented. Which I found
confusing.
> This way I'm pretty sure Felix and I can give an rb on the amdgpu/amdkfd
> changes.
If you are worried to give r-b only for those then this can be done even
for larger patches. Just make your Reviewd-by more specific
R-b: name # For BLA BLA
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2018-07-02 11:54 UTC|newest]
Thread overview: 125+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-22 15:02 [RFC PATCH] mm, oom: distinguish blockable mode for mmu notifiers Michal Hocko
2018-06-22 15:02 ` Michal Hocko
2018-06-22 15:02 ` Michal Hocko
2018-06-22 15:06 ` ✗ Fi.CI.BAT: failure for " Patchwork
2018-06-22 15:13 ` [RFC PATCH] " Christian König
2018-06-22 15:13 ` Christian König
2018-06-22 15:13 ` Christian König
2018-06-22 15:24 ` Michal Hocko
2018-06-22 15:24 ` Michal Hocko
2018-06-22 15:24 ` Michal Hocko
2018-06-22 15:24 ` Michal Hocko
2018-06-22 20:09 ` Felix Kuehling
[not found] ` <20180622152444.GC10465-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2018-06-22 20:09 ` Felix Kuehling
2018-06-22 20:09 ` Felix Kuehling
2018-06-22 20:09 ` Felix Kuehling
2018-06-25 8:01 ` Michal Hocko
2018-06-25 8:01 ` Michal Hocko
2018-06-25 8:01 ` Michal Hocko
2018-06-25 8:01 ` Michal Hocko
2018-06-25 13:31 ` Michal Hocko
[not found] ` <20180625080103.GB28965-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2018-06-25 13:31 ` Michal Hocko
2018-06-25 13:31 ` Michal Hocko
2018-06-25 13:31 ` Michal Hocko
2018-06-22 15:13 ` Christian König
2018-06-22 15:36 ` [Intel-gfx] " Chris Wilson
2018-06-22 16:01 ` ✗ Fi.CI.BAT: failure for mm, oom: distinguish blockable mode for mmu notifiers (rev2) Patchwork
2018-06-24 8:11 ` [RFC PATCH] mm, oom: distinguish blockable mode for mmu notifiers Paolo Bonzini
2018-06-25 7:57 ` Michal Hocko
2018-06-25 8:10 ` Paolo Bonzini
2018-06-25 8:45 ` Michal Hocko
2018-06-25 10:34 ` Paolo Bonzini
2018-06-25 11:08 ` Michal Hocko
2018-06-25 10:23 ` ✗ Fi.CI.CHECKPATCH: warning for mm, oom: distinguish blockable mode for mmu notifiers (rev3) Patchwork
2018-06-25 10:56 ` ✓ Fi.CI.BAT: success " Patchwork
2018-06-25 13:50 ` ✗ Fi.CI.CHECKPATCH: warning for mm, oom: distinguish blockable mode for mmu notifiers (rev4) Patchwork
2018-06-25 14:00 ` ✓ Fi.CI.IGT: success for mm, oom: distinguish blockable mode for mmu notifiers (rev3) Patchwork
2018-06-25 14:10 ` ✓ Fi.CI.BAT: success for mm, oom: distinguish blockable mode for mmu notifiers (rev4) Patchwork
2018-06-25 19:22 ` ✓ Fi.CI.IGT: " Patchwork
[not found] ` <20180622150242.16558-1-mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2018-06-22 15:36 ` [Intel-gfx] [RFC PATCH] mm, oom: distinguish blockable mode for mmu notifiers Chris Wilson
2018-06-22 15:36 ` Chris Wilson
2018-06-22 15:57 ` Michal Hocko
2018-06-22 15:57 ` Michal Hocko
2018-06-22 15:57 ` Michal Hocko
2018-06-22 16:18 ` Jerome Glisse
2018-06-22 16:18 ` Jerome Glisse
2018-06-22 16:18 ` Jerome Glisse
2018-06-22 16:18 ` Jerome Glisse
[not found] ` <20180622164026.GA23674@dhcp22.suse.cz>
2018-06-22 16:42 ` Michal Hocko
2018-06-22 16:42 ` [Intel-gfx] " Michal Hocko
2018-06-22 16:42 ` Michal Hocko
2018-06-22 17:26 ` [Intel-gfx] " Jerome Glisse
2018-06-22 17:26 ` Jerome Glisse
2018-06-22 17:26 ` [Intel-gfx] " Jerome Glisse
2018-06-22 16:42 ` Michal Hocko
[not found] ` <152968364170.11773.4392861266443293819@mail.alporthouse.com>
2018-06-22 16:19 ` Michal Hocko
2018-06-22 16:19 ` Michal Hocko
2018-06-22 16:19 ` Michal Hocko
2018-06-22 16:25 ` Jerome Glisse
2018-06-27 7:44 ` Michal Hocko
2018-06-27 7:44 ` Michal Hocko
2018-06-27 7:44 ` Michal Hocko
[not found] ` <20180627074421.GF32348-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2018-07-02 9:14 ` Christian König
2018-07-02 9:14 ` Christian König
2018-07-02 9:14 ` Christian König
2018-07-02 11:54 ` Michal Hocko
2018-07-02 11:54 ` Michal Hocko [this message]
2018-07-02 11:54 ` Michal Hocko
2018-07-02 11:54 ` Michal Hocko
2018-07-02 12:13 ` Christian König
2018-07-02 12:13 ` Christian König
2018-07-02 12:13 ` Christian König
2018-07-02 12:13 ` Christian König
2018-07-02 12:20 ` Michal Hocko
2018-07-02 12:20 ` Michal Hocko
2018-07-02 12:20 ` Michal Hocko
2018-07-02 12:20 ` Michal Hocko
2018-07-02 12:24 ` Christian König
2018-07-02 12:24 ` Christian König
2018-07-02 12:24 ` Christian König
2018-07-02 12:35 ` Michal Hocko
[not found] ` <02d1d52c-f534-f899-a18c-a3169123ac7c-5C7GfCeVMHo@public.gmane.org>
2018-07-02 12:35 ` Michal Hocko
2018-07-02 12:35 ` Michal Hocko
2018-07-02 12:35 ` Michal Hocko
2018-07-02 12:39 ` Christian König
[not found] ` <20180702123521.GO19043-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2018-07-02 12:39 ` Christian König
2018-07-02 12:39 ` Christian König
2018-07-02 12:39 ` Christian König
[not found] ` <91ad1106-6bd4-7d2c-4d40-7c5be945ba36-5C7GfCeVMHo@public.gmane.org>
2018-07-02 12:56 ` Michal Hocko
2018-07-02 12:56 ` Michal Hocko
2018-07-02 12:56 ` Michal Hocko
2018-07-02 12:56 ` Michal Hocko
2018-07-02 12:24 ` Christian König
2018-07-09 12:29 ` Michal Hocko
2018-07-09 12:29 ` Michal Hocko
2018-07-09 12:29 ` Michal Hocko
[not found] ` <20180709122908.GJ22049-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2018-07-10 13:40 ` Leon Romanovsky
2018-07-10 13:40 ` Leon Romanovsky
2018-07-10 14:14 ` Michal Hocko
2018-07-10 14:14 ` Michal Hocko
2018-07-10 16:20 ` Leon Romanovsky
2018-07-10 16:20 ` Leon Romanovsky
[not found] ` <20180710162020.GJ3014-U/DQcQFIOTAkZy+6dPanYNBPR1lH4CV8@public.gmane.org>
2018-07-11 9:03 ` Michal Hocko
2018-07-11 9:03 ` Michal Hocko
2018-07-11 10:14 ` Leon Romanovsky
2018-07-11 10:14 ` Leon Romanovsky
2018-07-11 11:13 ` Michal Hocko
2018-07-11 11:13 ` Michal Hocko
2018-07-11 11:13 ` Michal Hocko
2018-07-11 12:08 ` Leon Romanovsky
[not found] ` <20180711111318.GL20050-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2018-07-11 12:08 ` Leon Romanovsky
2018-07-11 12:08 ` Leon Romanovsky
2018-07-11 10:14 ` Leon Romanovsky
2018-07-11 9:03 ` Michal Hocko
2018-07-10 16:20 ` Leon Romanovsky
[not found] ` <20180710141410.GP14284-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2018-07-16 7:59 ` Leon Romanovsky
2018-07-16 7:59 ` Leon Romanovsky
2018-07-16 7:59 ` Leon Romanovsky
2018-07-10 14:14 ` Michal Hocko
2018-07-10 13:40 ` Leon Romanovsky
2018-07-02 9:14 ` Christian König
2018-07-09 12:29 ` Michal Hocko
2018-06-27 7:44 ` Michal Hocko
2018-06-27 9:05 ` ✗ Fi.CI.BAT: failure for mm, oom: distinguish blockable mode for mmu notifiers (rev5) Patchwork
2018-07-11 10:57 ` ✗ Fi.CI.BAT: failure for mm, oom: distinguish blockable mode for mmu notifiers (rev6) Patchwork
-- strict thread matches above, loose matches on Subject: below --
2018-06-22 15:02 [RFC PATCH] mm, oom: distinguish blockable mode for mmu notifiers Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180702115423.GK19043@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=David1.Zhou@amd.com \
--cc=aarcange@redhat.com \
--cc=airlied@linux.ie \
--cc=amd-gfx@lists.freedesktop.org \
--cc=boris.ostrovsky@oracle.com \
--cc=christian.koenig@amd.com \
--cc=dennis.dalessandro@intel.com \
--cc=dledford@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jgg@ziepe.ca \
--cc=jglisse@redhat.com \
--cc=jgross@suse.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mike.marciniszyn@intel.com \
--cc=rientjes@google.com \
--cc=rkrcmar@redhat.com \
--cc=rodrigo.vivi@intel.com \
--cc=sivanich@sgi.com \
--cc=sudeep.dutt@intel.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.