From: Matthew Wilcox <willy@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-nvdimm <linux-nvdimm@lists.01.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>, Linux MM <linux-mm@kvack.org>
Subject: Re: [PATCH 13/13] libnvdimm, namespace: Publish page structure init state / control
Date: Thu, 5 Jul 2018 14:00:07 -0700 [thread overview]
Message-ID: <20180705210007.GC28447@bombadil.infradead.org> (raw)
In-Reply-To: <20180705132455.2a40de08dbe3a9bb384fb870@linux-foundation.org>
On Thu, Jul 05, 2018 at 01:24:55PM -0700, Andrew Morton wrote:
> On Thu, 5 Jul 2018 16:49:41 +0200 Johannes Thumshirn <jthumshirn@suse.de> wrote:
>
> > On Thu, Jul 05, 2018 at 07:46:05AM -0700, Dan Williams wrote:
> > > ...but that also allows 'echo "syncAndThenSomeGarbage" >
> > > /sys/.../memmap_state' to succeed.
> >
> > Yep it does :-(.
> >
> > Damn
>
> sysfs_streq()
Thanks! I didn't know that one existed.
It's kind of a shame that we realised this was a problem and decided
to solve it this way back in 2008 instead of realising that no driver
actually cares whether there's a \n or not and stripping off the \n
before the driver gets to see it. Probably too late to fix that now.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <willy@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Johannes Thumshirn <jthumshirn@suse.de>,
Dan Williams <dan.j.williams@intel.com>,
Ross Zwisler <ross.zwisler@linux.intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Dave Jiang <dave.jiang@intel.com>, Jeff Moyer <jmoyer@redhat.com>,
Christoph Hellwig <hch@lst.de>,
linux-nvdimm <linux-nvdimm@lists.01.org>,
Linux MM <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 13/13] libnvdimm, namespace: Publish page structure init state / control
Date: Thu, 5 Jul 2018 14:00:07 -0700 [thread overview]
Message-ID: <20180705210007.GC28447@bombadil.infradead.org> (raw)
In-Reply-To: <20180705132455.2a40de08dbe3a9bb384fb870@linux-foundation.org>
On Thu, Jul 05, 2018 at 01:24:55PM -0700, Andrew Morton wrote:
> On Thu, 5 Jul 2018 16:49:41 +0200 Johannes Thumshirn <jthumshirn@suse.de> wrote:
>
> > On Thu, Jul 05, 2018 at 07:46:05AM -0700, Dan Williams wrote:
> > > ...but that also allows 'echo "syncAndThenSomeGarbage" >
> > > /sys/.../memmap_state' to succeed.
> >
> > Yep it does :-(.
> >
> > Damn
>
> sysfs_streq()
Thanks! I didn't know that one existed.
It's kind of a shame that we realised this was a problem and decided
to solve it this way back in 2008 instead of realising that no driver
actually cares whether there's a \n or not and stripping off the \n
before the driver gets to see it. Probably too late to fix that now.
next prev parent reply other threads:[~2018-07-05 21:00 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-05 6:49 [PATCH 00/13] mm: Asynchronous + multithreaded memmap init for ZONE_DEVICE Dan Williams
2018-07-05 6:49 ` Dan Williams
2018-07-05 6:49 ` [PATCH 01/13] mm: Plumb dev_pagemap instead of vmem_altmap to memmap_init_zone() Dan Williams
2018-07-05 6:49 ` Dan Williams
2018-07-05 6:49 ` [PATCH 02/13] mm: Enable asynchronous __add_pages() and vmemmap_populate_hugepages() Dan Williams
2018-07-05 6:49 ` Dan Williams
2018-07-05 6:49 ` [PATCH 03/13] mm: Teach memmap_init_zone() to initialize ZONE_DEVICE pages Dan Williams
2018-07-05 6:49 ` Dan Williams
2018-07-05 6:49 ` Dan Williams
2018-07-05 6:49 ` [PATCH 04/13] mm: Multithread ZONE_DEVICE initialization Dan Williams
2018-07-05 6:49 ` Dan Williams
2018-07-05 6:49 ` [PATCH 05/13] mm: Allow an external agent to wait for memmap initialization Dan Williams
2018-07-05 6:49 ` Dan Williams
2018-07-05 6:49 ` Dan Williams
2018-07-05 6:49 ` [PATCH 06/13] nvdimm/pmem: check the validity of the pointer pfn Dan Williams
2018-07-05 6:49 ` Dan Williams
2018-07-05 6:49 ` [PATCH 07/13] nvdimm/pmem-dax: " Dan Williams
2018-07-05 6:49 ` Dan Williams
2018-07-05 6:49 ` [PATCH 08/13] s390/block/dcssblk: " Dan Williams
2018-07-05 6:49 ` Dan Williams
2018-07-05 6:49 ` [PATCH 09/13] fs/dax: Assign NULL to pfn of dax_direct_access if useless Dan Williams
2018-07-05 6:49 ` Dan Williams
2018-07-05 6:49 ` [PATCH 10/13] filesystem-dax: Make mount time pfn validation a debug check Dan Williams
2018-07-05 6:49 ` Dan Williams
2018-07-05 6:50 ` [PATCH 11/13] libnvdimm, pmem: Initialize the memmap in the background Dan Williams
2018-07-05 6:50 ` Dan Williams
2018-07-05 6:50 ` [PATCH 12/13] device-dax: " Dan Williams
2018-07-05 6:50 ` Dan Williams
2018-07-05 6:50 ` [PATCH 13/13] libnvdimm, namespace: Publish page structure init state / control Dan Williams
2018-07-05 6:50 ` Dan Williams
2018-07-05 8:29 ` Johannes Thumshirn
2018-07-05 8:29 ` Johannes Thumshirn
2018-07-05 8:29 ` Johannes Thumshirn
2018-07-05 14:46 ` Dan Williams
2018-07-05 14:46 ` Dan Williams
2018-07-05 14:49 ` Johannes Thumshirn
2018-07-05 14:49 ` Johannes Thumshirn
2018-07-05 14:49 ` Johannes Thumshirn
2018-07-05 20:24 ` Andrew Morton
2018-07-05 20:24 ` Andrew Morton
2018-07-05 20:34 ` Dan Williams
2018-07-05 20:34 ` Dan Williams
2018-07-06 8:18 ` Johannes Thumshirn
2018-07-06 8:18 ` Johannes Thumshirn
2018-07-06 8:18 ` Johannes Thumshirn
2018-07-05 21:00 ` Matthew Wilcox [this message]
2018-07-05 21:00 ` Matthew Wilcox
2018-07-05 19:49 ` Matthew Wilcox
2018-07-05 19:49 ` Matthew Wilcox
2018-07-05 19:52 ` Dan Williams
2018-07-05 19:52 ` Dan Williams
2018-07-05 20:00 ` Jeff Moyer
2018-07-09 12:56 ` [PATCH 00/13] mm: Asynchronous + multithreaded memmap init for ZONE_DEVICE Jan Kara
2018-07-09 12:56 ` Jan Kara
2018-07-09 16:53 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180705210007.GC28447@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.