All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Cc: linux-wireless@vger.kernel.org, Felix Fietkau <nbd@nbd.name>,
	Hans Ulli Kroll <ulli.kroll@googlemail.com>,
	Jakub Kicinski <kubakici@wp.pl>,
	Michal Schmidt <mschmidt@redhat.com>,
	linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 11/11] mt76: Kconfig and Makefile for mt76x0 driver
Date: Fri, 6 Jul 2018 12:32:44 +0200	[thread overview]
Message-ID: <20180706103244.GA2033@redhat.com> (raw)
In-Reply-To: <20180705145018.GA17524@localhost.localdomain>

On Thu, Jul 05, 2018 at 04:50:19PM +0200, Lorenzo Bianconi wrote:
> On Jul 05, Stanislaw Gruszka wrote:
> > +obj-$(CONFIG_MT76x0U)    += mt76x0.o
> > +
> > +mt76x0-objs	= \
> > +	usb.o init.o main.o mcu.o trace.o dma.o eeprom.o phy.o \
> 
> There is no main.c source file, is it a leftover from previous implementation?
> Moreover compiling the driver (and fixing conflicts with mt76x2u) I have:
> 
> ERROR: "mt76x0_ops" [drivers/net/wireless/mediatek/mt76/mt76x0/mt76x0.ko] undefined!

I somehow missed the patch adding main.c .

Stanislaw

WARNING: multiple messages have this Message-ID (diff)
From: Stanislaw Gruszka <sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Lorenzo Bianconi
	<lorenzo.bianconi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Felix Fietkau <nbd-Vt+b4OUoWG0@public.gmane.org>,
	Hans Ulli Kroll
	<ulli.kroll-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>,
	Jakub Kicinski <kubakici-5tc4TXWwyLM@public.gmane.org>,
	Michal Schmidt <mschmidt-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 11/11] mt76: Kconfig and Makefile for mt76x0 driver
Date: Fri, 6 Jul 2018 12:32:44 +0200	[thread overview]
Message-ID: <20180706103244.GA2033@redhat.com> (raw)
In-Reply-To: <20180705145018.GA17524-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>

On Thu, Jul 05, 2018 at 04:50:19PM +0200, Lorenzo Bianconi wrote:
> On Jul 05, Stanislaw Gruszka wrote:
> > +obj-$(CONFIG_MT76x0U)    += mt76x0.o
> > +
> > +mt76x0-objs	= \
> > +	usb.o init.o main.o mcu.o trace.o dma.o eeprom.o phy.o \
> 
> There is no main.c source file, is it a leftover from previous implementation?
> Moreover compiling the driver (and fixing conflicts with mt76x2u) I have:
> 
> ERROR: "mt76x0_ops" [drivers/net/wireless/mediatek/mt76/mt76x0/mt76x0.ko] undefined!

I somehow missed the patch adding main.c .

Stanislaw

  reply	other threads:[~2018-07-06 10:32 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-05  6:12 [PATCH 00/11] Add mt76x0 driver Stanislaw Gruszka
2018-07-05  6:12 ` Stanislaw Gruszka
2018-07-05  6:12 ` [PATCH 01/11] mt76: add more states Stanislaw Gruszka
2018-07-05  6:12   ` Stanislaw Gruszka
2018-07-05  6:12 ` [PATCH 02/11] mt76x0: core files Stanislaw Gruszka
2018-07-05  6:12   ` Stanislaw Gruszka
2018-07-05  6:12 ` [PATCH 03/11] mt76x0: mac files Stanislaw Gruszka
2018-07-05  6:12   ` Stanislaw Gruszka
2018-07-05 15:17   ` Lorenzo Bianconi
2018-07-05 15:17     ` Lorenzo Bianconi
2018-07-05  6:12 ` [PATCH 04/11] mt76x0: usb files Stanislaw Gruszka
2018-07-05  6:12   ` Stanislaw Gruszka
2018-07-05 15:05   ` Lorenzo Bianconi
2018-07-05 15:05     ` Lorenzo Bianconi
2018-07-06 10:42     ` Stanislaw Gruszka
2018-07-06 10:42       ` Stanislaw Gruszka
2018-07-23  6:38     ` Kalle Valo
2018-07-23  6:38       ` Kalle Valo
2018-07-23  8:57       ` Lorenzo Bianconi
2018-07-23  8:57         ` Lorenzo Bianconi
2018-07-23  9:07         ` Kalle Valo
2018-07-23  9:07           ` Kalle Valo
2018-07-23  9:31           ` Lorenzo Bianconi
2018-07-23  9:31             ` Lorenzo Bianconi
2018-07-05  6:12 ` [PATCH 05/11] mt76x0: mcu files Stanislaw Gruszka
2018-07-05  6:12   ` Stanislaw Gruszka
2018-07-05 15:13   ` Lorenzo Bianconi
2018-07-05 15:13     ` Lorenzo Bianconi
2018-07-05  6:12 ` [PATCH 06/11] mt76x0: phy files Stanislaw Gruszka
2018-07-05  6:12   ` Stanislaw Gruszka
2018-07-05  6:12 ` [PATCH 07/11] mt76x0: init files Stanislaw Gruszka
2018-07-05  6:12   ` Stanislaw Gruszka
2018-07-05  6:12 ` [PATCH 08/11] mt76x0: eeprom files Stanislaw Gruszka
2018-07-05  6:12   ` Stanislaw Gruszka
2018-07-05  6:12 ` [PATCH 09/11] mt76x0: trace and debugfs files Stanislaw Gruszka
2018-07-05  6:12   ` Stanislaw Gruszka
2018-07-05  6:12 ` [PATCH 10/11] mt76x0: dma and tx files Stanislaw Gruszka
2018-07-05  6:12   ` Stanislaw Gruszka
2018-07-05  6:12 ` [PATCH 11/11] mt76: Kconfig and Makefile for mt76x0 driver Stanislaw Gruszka
2018-07-05  6:12   ` Stanislaw Gruszka
2018-07-05  8:40   ` kbuild test robot
2018-07-05  8:40     ` kbuild test robot
2018-07-05 14:50   ` Lorenzo Bianconi
2018-07-05 14:50     ` Lorenzo Bianconi
2018-07-06 10:32     ` Stanislaw Gruszka [this message]
2018-07-06 10:32       ` Stanislaw Gruszka
2018-07-05 15:32 ` [PATCH 00/11] Add " Lorenzo Bianconi
2018-07-05 15:32   ` Lorenzo Bianconi
2018-07-06 10:36   ` Stanislaw Gruszka
2018-07-06 10:36     ` Stanislaw Gruszka
2018-07-06 11:37     ` Lorenzo Bianconi
2018-07-06 11:37       ` Lorenzo Bianconi
2018-07-07  8:38   ` Hans Ulli Kroll
2018-07-07  8:38     ` Hans Ulli Kroll
2018-07-20 10:30     ` Stanislaw Gruszka
2018-07-20 10:30       ` Stanislaw Gruszka
2018-07-20 10:36       ` Stanislaw Gruszka
2018-07-20 10:36         ` Stanislaw Gruszka
2018-07-20 12:18       ` Lorenzo Bianconi
2018-07-20 12:18         ` Lorenzo Bianconi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180706103244.GA2033@redhat.com \
    --to=sgruszka@redhat.com \
    --cc=kubakici@wp.pl \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lorenzo.bianconi@redhat.com \
    --cc=mschmidt@redhat.com \
    --cc=nbd@nbd.name \
    --cc=ulli.kroll@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.