Re: [PATCH 2/3] kernel-shark-qt: Consolidate load_data_entries and load_data_records

From: Steven Rostedt <rostedt@goodmis.org>
To: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH 2/3] kernel-shark-qt: Consolidate load_data_entries and load_data_records
Date: Fri, 6 Jul 2018 14:24:40 -0400	[thread overview]
Message-ID: <20180706142440.4d913909@gandalf.local.home> (raw)
In-Reply-To: <415f299e-9cb1-5044-927f-0a653bf0b356@gmail.com>

On Fri, 6 Jul 2018 15:46:54 +0300
"Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote:

> > --- trace-cmd.git.orig/kernel-shark-qt/src/libkshark.h
> > +++ trace-cmd.git/kernel-shark-qt/src/libkshark.h
> > @@ -33,6 +33,9 @@ extern "C" {
> >    * info etc.) is available on-demand via the offset into the trace file.
> >    */
> >   struct kshark_entry {
> > +	/** Pointer to the next (in time) kshark_entry on the same CPU core. */
> > +	struct kshark_entry *next; /* MUST BE FIRST ENTRY */
> > +  
> Correct, thanks!

BTW, I was going to ask. Do you use entry->next elsewhere (to get per
cpu lists)?

-- Steve