From: Rob Herring <robh@kernel.org> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Linus Walleij <linus.walleij@linaro.org>, Alexander Graf <agraf@suse.de>, Bjorn Andersson <bjorn.andersson@linaro.org>, "Rafael J. Wysocki" <rjw@rjwysocki.net>, Kevin Hilman <khilman@kernel.org>, Ulf Hansson <ulf.hansson@linaro.org>, Joerg Roedel <joro@8bytes.org>, Robin Murphy <robin.murphy@arm.com>, Mark Brown <broonie@kernel.org>, Frank Rowand <frowand.list@gmail.com>, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, boot-architecture@lists.linaro.org, linux-arm-kernel@lists.infradead.org, Pavel Machek <pavel@ucw.cz>, Len Brown <len.brown@intel.com>, linux-pm@vger.kernel.org Subject: [PATCH v4 6/6] PM / Domains: Stop deferring probe at the end of initcall Date: Mon, 9 Jul 2018 09:41:53 -0600 [thread overview] Message-ID: <20180709154153.15742-7-robh@kernel.org> (raw) In-Reply-To: <20180709154153.15742-1-robh@kernel.org> All PM domain drivers must be built-in (at least those using DT), so there is no point deferring probe after initcalls are done. Continuing to defer probe may prevent booting successfully even if managing PM domains is not required. This can happen if the user failed to enable the driver or if power-domains are added to a platform's DT, but there is not yet a driver (e.g. a new DTB with an old kernel). Call the driver core function driver_deferred_probe_check_init_done() instead of just returning -EPROBE_DEFER to stop deferring probe when initcalls are done. Acked-by: "Rafael J. Wysocki" <rjw@rjwysocki.net> Cc: Kevin Hilman <khilman@kernel.org> Cc: Ulf Hansson <ulf.hansson@linaro.org> Cc: Pavel Machek <pavel@ucw.cz> Cc: Len Brown <len.brown@intel.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: linux-pm@vger.kernel.org Signed-off-by: Rob Herring <robh@kernel.org> --- v4: - Add Rafael's ack v3: - Update to new function name drivers/base/power/domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index 4925af5c4cf0..8c12213875c6 100644 --- a/drivers/base/power/domain.c +++ b/drivers/base/power/domain.c @@ -2253,7 +2253,7 @@ static int __genpd_dev_pm_attach(struct device *dev, struct device_node *np, mutex_unlock(&gpd_list_lock); dev_dbg(dev, "%s() failed to find PM domain: %ld\n", __func__, PTR_ERR(pd)); - return -EPROBE_DEFER; + return driver_deferred_probe_check_state(dev); } dev_dbg(dev, "adding to PM domain %s\n", pd->name); -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: robh@kernel.org (Rob Herring) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v4 6/6] PM / Domains: Stop deferring probe at the end of initcall Date: Mon, 9 Jul 2018 09:41:53 -0600 [thread overview] Message-ID: <20180709154153.15742-7-robh@kernel.org> (raw) In-Reply-To: <20180709154153.15742-1-robh@kernel.org> All PM domain drivers must be built-in (at least those using DT), so there is no point deferring probe after initcalls are done. Continuing to defer probe may prevent booting successfully even if managing PM domains is not required. This can happen if the user failed to enable the driver or if power-domains are added to a platform's DT, but there is not yet a driver (e.g. a new DTB with an old kernel). Call the driver core function driver_deferred_probe_check_init_done() instead of just returning -EPROBE_DEFER to stop deferring probe when initcalls are done. Acked-by: "Rafael J. Wysocki" <rjw@rjwysocki.net> Cc: Kevin Hilman <khilman@kernel.org> Cc: Ulf Hansson <ulf.hansson@linaro.org> Cc: Pavel Machek <pavel@ucw.cz> Cc: Len Brown <len.brown@intel.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: linux-pm at vger.kernel.org Signed-off-by: Rob Herring <robh@kernel.org> --- v4: - Add Rafael's ack v3: - Update to new function name drivers/base/power/domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index 4925af5c4cf0..8c12213875c6 100644 --- a/drivers/base/power/domain.c +++ b/drivers/base/power/domain.c @@ -2253,7 +2253,7 @@ static int __genpd_dev_pm_attach(struct device *dev, struct device_node *np, mutex_unlock(&gpd_list_lock); dev_dbg(dev, "%s() failed to find PM domain: %ld\n", __func__, PTR_ERR(pd)); - return -EPROBE_DEFER; + return driver_deferred_probe_check_state(dev); } dev_dbg(dev, "adding to PM domain %s\n", pd->name); -- 2.17.1
next prev parent reply other threads:[~2018-07-09 15:42 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-07-09 15:41 [PATCH v4 0/6] Make deferring probe forever optional Rob Herring 2018-07-09 15:41 ` Rob Herring 2018-07-09 15:41 ` [PATCH v4 1/6] driver core: allow stopping deferred probe after init Rob Herring 2018-07-09 15:41 ` Rob Herring 2018-07-09 15:52 ` Russell King - ARM Linux 2018-07-09 15:52 ` Russell King - ARM Linux 2018-07-09 17:47 ` Rob Herring 2018-07-09 17:47 ` Rob Herring 2018-07-09 17:47 ` Rob Herring 2018-07-09 15:41 ` [PATCH v4 2/6] dt-bindings: pinctrl: add a 'pinctrl-use-default' property Rob Herring 2018-07-09 15:41 ` Rob Herring 2018-07-09 15:41 ` Rob Herring 2018-07-09 15:41 ` [PATCH v4 3/6] pinctrl: Support stopping deferred probe after initcalls Rob Herring 2018-07-09 15:41 ` Rob Herring 2018-07-09 15:41 ` [PATCH v4 4/6] iommu: Stop deferring probe at end of initcalls Rob Herring 2018-07-09 15:41 ` Rob Herring 2018-07-09 15:41 ` Rob Herring [not found] ` <20180709154153.15742-1-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> 2018-07-09 15:41 ` [PATCH v4 5/6] iommu: Remove IOMMU_OF_DECLARE Rob Herring 2018-07-09 15:41 ` Rob Herring 2018-07-09 15:41 ` Rob Herring 2018-07-09 15:41 ` Rob Herring [this message] 2018-07-09 15:41 ` [PATCH v4 6/6] PM / Domains: Stop deferring probe at the end of initcall Rob Herring 2018-07-09 22:49 ` Ulf Hansson 2018-07-09 22:49 ` Ulf Hansson 2018-07-10 14:25 ` Rob Herring 2018-07-10 14:25 ` Rob Herring 2018-07-10 14:25 ` Rob Herring 2018-07-11 9:41 ` Ulf Hansson 2018-07-11 9:41 ` Ulf Hansson 2018-07-11 9:41 ` Ulf Hansson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180709154153.15742-7-robh@kernel.org \ --to=robh@kernel.org \ --cc=agraf@suse.de \ --cc=bjorn.andersson@linaro.org \ --cc=boot-architecture@lists.linaro.org \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=frowand.list@gmail.com \ --cc=gregkh@linuxfoundation.org \ --cc=joro@8bytes.org \ --cc=khilman@kernel.org \ --cc=len.brown@intel.com \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=pavel@ucw.cz \ --cc=rjw@rjwysocki.net \ --cc=robin.murphy@arm.com \ --cc=ulf.hansson@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.