From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-media@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-usb@vger.kernel.org, tglx@linutronix.de,
Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH RFC] usb: add usb_fill_iso_urb()
Date: Fri, 13 Jul 2018 09:29:23 +0200 [thread overview]
Message-ID: <20180713072923.GA31191@kroah.com> (raw)
In-Reply-To: <20180712223527.5nmxndignujo7smt@linutronix.de>
On Fri, Jul 13, 2018 at 12:35:27AM +0200, Sebastian Andrzej Siewior wrote:
> Provide usb_fill_iso_urb() for the initialisation of isochronous URBs.
> We already have one of this helpers for control, bulk and interruptible
> URB types. This helps to keep the initialisation of the URB members in
> one place.
> Update the documentation by adding this to the available init functions
> and remove the suggestion to use the `_int_' helper which might provide
> wrong encoding for the `interval' member.
>
> This looks like it would cover most users nicely. The sound subsystem
> initialises the ->iso_frame_desc[].offset + length member (often) at a
> different location and I'm not sure ->interval will work always as
> expected. So we might need to overwrite those two in worst case.
>
> Some users also initialise ->iso_frame_desc[].actual_length but I don't
> this is required since it is the return value.
>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> ---
> Documentation/driver-api/usb/URB.rst | 12 +++----
> include/linux/usb.h | 53 ++++++++++++++++++++++++++++
> 2 files changed, 59 insertions(+), 6 deletions(-)
Do you have a few example patches of using this new function? Many many
years ago we tried to create this function, but we gave up as it just
didn't seem to work for the majority of the users of ISO packets. Maybe
things have changed since then and people do it all more in a "standard"
way and we can take advantage of this. But it would be nice to see
proof it can be used before taking this patch.
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-media@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-usb@vger.kernel.org, tglx@linutronix.de,
Takashi Iwai <tiwai@suse.de>
Subject: [RFC] usb: add usb_fill_iso_urb()
Date: Fri, 13 Jul 2018 09:29:23 +0200 [thread overview]
Message-ID: <20180713072923.GA31191@kroah.com> (raw)
On Fri, Jul 13, 2018 at 12:35:27AM +0200, Sebastian Andrzej Siewior wrote:
> Provide usb_fill_iso_urb() for the initialisation of isochronous URBs.
> We already have one of this helpers for control, bulk and interruptible
> URB types. This helps to keep the initialisation of the URB members in
> one place.
> Update the documentation by adding this to the available init functions
> and remove the suggestion to use the `_int_' helper which might provide
> wrong encoding for the `interval' member.
>
> This looks like it would cover most users nicely. The sound subsystem
> initialises the ->iso_frame_desc[].offset + length member (often) at a
> different location and I'm not sure ->interval will work always as
> expected. So we might need to overwrite those two in worst case.
>
> Some users also initialise ->iso_frame_desc[].actual_length but I don't
> this is required since it is the return value.
>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> ---
> Documentation/driver-api/usb/URB.rst | 12 +++----
> include/linux/usb.h | 53 ++++++++++++++++++++++++++++
> 2 files changed, 59 insertions(+), 6 deletions(-)
Do you have a few example patches of using this new function? Many many
years ago we tried to create this function, but we gave up as it just
didn't seem to work for the majority of the users of ISO packets. Maybe
things have changed since then and people do it all more in a "standard"
way and we can take advantage of this. But it would be nice to see
proof it can be used before taking this patch.
thanks,
greg k-h
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-07-13 7:42 UTC|newest]
Thread overview: 100+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-20 11:00 medial: use irqsave() in URB completion + usb_fill_int_urb Sebastian Andrzej Siewior
2018-06-20 11:00 ` [PATCH 01/27] media: b2c2: use usb_fill_int_urb() Sebastian Andrzej Siewior
2018-06-20 11:00 ` [01/27] " Sebastian Andrzej Siewior
2018-06-20 11:00 ` [PATCH 02/27] media: cpia2_usb: " Sebastian Andrzej Siewior
2018-06-20 11:00 ` [02/27] " Sebastian Andrzej Siewior
2018-06-20 11:00 ` [PATCH 03/27] media: cx231xx: use usb_fill_XXX_urb() Sebastian Andrzej Siewior
2018-06-20 11:00 ` [03/27] " Sebastian Andrzej Siewior
2018-06-20 11:00 ` [PATCH 04/27] media: cx231xx: use irqsave() in USB's complete callback Sebastian Andrzej Siewior
2018-06-20 11:00 ` [04/27] " Sebastian Andrzej Siewior
2018-06-20 11:00 ` [PATCH 05/27] media: dvb-usb: use usb_fill_int_urb() Sebastian Andrzej Siewior
2018-06-20 11:00 ` [05/27] " Sebastian Andrzej Siewior
2018-06-20 11:00 ` [PATCH 06/27] media: dvb_usb_v2: " Sebastian Andrzej Siewior
2018-06-20 11:00 ` [06/27] " Sebastian Andrzej Siewior
2018-06-20 11:00 ` [PATCH 07/27] media: em28xx-audio: use GFP_KERNEL for memory allocation during init Sebastian Andrzej Siewior
2018-06-20 11:00 ` [07/27] " Sebastian Andrzej Siewior
2018-06-20 11:00 ` [PATCH 08/27] media: em28xx-audio: use irqsave() in USB's complete callback Sebastian Andrzej Siewior
2018-06-20 11:00 ` [08/27] " Sebastian Andrzej Siewior
2018-06-20 11:00 ` [PATCH 09/27] media: em28xx-audio: use usb_fill_int_urb() Sebastian Andrzej Siewior
2018-06-20 11:00 ` [09/27] " Sebastian Andrzej Siewior
2018-06-20 11:00 ` [PATCH 10/27] media: go7007: use irqsave() in USB's complete callback Sebastian Andrzej Siewior
2018-06-20 11:00 ` [10/27] " Sebastian Andrzej Siewior
2018-06-20 11:00 ` [PATCH 11/27] media: gspca: benq: use usb_fill_int_urb() Sebastian Andrzej Siewior
2018-06-20 11:00 ` [11/27] " Sebastian Andrzej Siewior
2018-06-20 11:00 ` [PATCH 12/27] media: gspca: gspca: use usb_fill_XXX_urb() Sebastian Andrzej Siewior
2018-06-20 11:00 ` [12/27] " Sebastian Andrzej Siewior
2018-06-20 11:00 ` [PATCH 13/27] media: gspca: konica: use usb_fill_int_urb() Sebastian Andrzej Siewior
2018-06-20 11:00 ` [13/27] " Sebastian Andrzej Siewior
2018-06-20 11:00 ` [PATCH 14/27] media: gspca: sq930x: use GFP_KERNEL in sd_dq_callback() Sebastian Andrzej Siewior
2018-06-20 11:00 ` [14/27] " Sebastian Andrzej Siewior
2018-06-20 11:00 ` [PATCH 15/27] media: msi2500: use usb_fill_int_urb() Sebastian Andrzej Siewior
2018-06-20 11:00 ` [15/27] " Sebastian Andrzej Siewior
2018-06-20 11:00 ` [PATCH 16/27] media: pwc: " Sebastian Andrzej Siewior
2018-06-20 11:00 ` [16/27] " Sebastian Andrzej Siewior
2018-06-20 11:00 ` [PATCH 17/27] media: stk1160: " Sebastian Andrzej Siewior
2018-06-20 11:00 ` [17/27] " Sebastian Andrzej Siewior
2018-06-20 11:00 ` [PATCH 18/27] media: stkwebcam: " Sebastian Andrzej Siewior
2018-06-20 11:00 ` [18/27] " Sebastian Andrzej Siewior
2018-06-20 11:00 ` [PATCH 19/27] media: tm6000: use irqsave() in USB's complete callback Sebastian Andrzej Siewior
2018-06-20 11:00 ` [19/27] " Sebastian Andrzej Siewior
2018-06-20 11:00 ` [PATCH 20/27] media: ttusb-budget: use usb_fill_int_urb() Sebastian Andrzej Siewior
2018-06-20 11:00 ` [20/27] " Sebastian Andrzej Siewior
2018-06-20 11:00 ` [PATCH 21/27] media: ttusb-dec: " Sebastian Andrzej Siewior
2018-06-20 11:00 ` [21/27] " Sebastian Andrzej Siewior
2018-06-20 11:01 ` [PATCH 22/27] media: ttusbir: " Sebastian Andrzej Siewior
2018-06-20 11:01 ` [22/27] " Sebastian Andrzej Siewior
2018-06-20 20:50 ` [PATCH 22/27] " Sean Young
2018-06-20 20:50 ` [22/27] " Sean Young
2018-06-21 7:37 ` [PATCH 22/27] " Sebastian Andrzej Siewior
2018-06-21 7:37 ` [22/27] " Sebastian Andrzej Siewior
2018-06-20 11:01 ` [PATCH 23/27] media: usbtv: use irqsave() in USB's complete callback Sebastian Andrzej Siewior
2018-06-20 11:01 ` [23/27] " Sebastian Andrzej Siewior
2018-06-20 11:01 ` [PATCH 24/27] media: usbtv: use usb_fill_int_urb() Sebastian Andrzej Siewior
2018-06-20 11:01 ` [24/27] " Sebastian Andrzej Siewior
2018-06-20 11:01 ` [PATCH 25/27] media: usbvision: remove time_in_irq Sebastian Andrzej Siewior
2018-06-20 11:01 ` [25/27] " Sebastian Andrzej Siewior
2018-06-20 11:01 ` [PATCH 26/27] media: usbvision: use usb_fill_int_urb() Sebastian Andrzej Siewior
2018-06-20 11:01 ` [26/27] " Sebastian Andrzej Siewior
2018-06-20 11:01 ` [PATCH 27/27] media: uvcvideo: " Sebastian Andrzej Siewior
2018-06-20 11:01 ` [27/27] " Sebastian Andrzej Siewior
2018-06-20 11:55 ` [PATCH 27/27] " Laurent Pinchart
2018-06-20 11:55 ` [27/27] " Laurent Pinchart
2018-06-20 13:21 ` [PATCH 27/27] " Sebastian Andrzej Siewior
2018-06-20 13:21 ` [27/27] " Sebastian Andrzej Siewior
2018-06-20 14:14 ` [PATCH 27/27] " Laurent Pinchart
2018-06-20 14:14 ` [27/27] " Laurent Pinchart
2018-06-20 15:20 ` [PATCH] USB: note that usb_fill_int_urb() can be used used for ISOC urbs Sebastian Andrzej Siewior
2018-06-20 15:20 ` Sebastian Andrzej Siewior
2018-06-20 15:35 ` [PATCH] " Alan Stern
2018-06-20 15:35 ` Alan Stern
2018-06-20 16:02 ` [PATCH] " Sebastian Andrzej Siewior
2018-06-20 16:02 ` Sebastian Andrzej Siewior
2018-06-20 16:21 ` [PATCH] " Alan Stern
2018-06-20 16:21 ` Alan Stern
2018-06-20 16:49 ` [PATCH] " Sebastian Andrzej Siewior
2018-06-20 16:49 ` Sebastian Andrzej Siewior
2018-06-20 17:23 ` [PATCH] " Alan Stern
2018-06-20 17:23 ` Alan Stern
2018-07-12 22:35 ` [PATCH RFC] usb: add usb_fill_iso_urb() Sebastian Andrzej Siewior
2018-07-12 22:35 ` [RFC] " Sebastian Andrzej Siewior
2018-07-13 7:29 ` Greg Kroah-Hartman [this message]
2018-07-13 7:29 ` Greg Kroah-Hartman
2018-07-13 7:47 ` [PATCH RFC] " Sebastian Andrzej Siewior
2018-07-13 7:47 ` [RFC] " Sebastian Andrzej Siewior
2018-07-16 22:53 ` [PATCH RFC] " Sebastian Andrzej Siewior
2018-07-16 22:53 ` [RFC] " Sebastian Andrzej Siewior
2018-07-17 6:54 ` [PATCH RFC] " Clemens Ladisch
2018-07-17 6:54 ` Clemens Ladisch
2018-07-17 6:54 ` [RFC] " Clemens Ladisch
2018-08-06 21:21 ` [PATCH RFC] " Laurent Pinchart
2018-08-06 21:21 ` [RFC] " Laurent Pinchart
2018-08-06 22:02 ` [PATCH RFC] " Sebastian Andrzej Siewior
2018-08-06 22:02 ` [RFC] " Sebastian Andrzej Siewior
2018-07-13 8:01 ` [PATCH RFC] " Laurent Pinchart
2018-07-13 8:01 ` [RFC] " Laurent Pinchart
2018-07-13 20:12 ` [PATCH RFC] " Alan Stern
2018-07-13 20:12 ` [RFC] " Alan Stern
2018-06-20 15:21 ` [PATCH 27/27 v2] media: uvcvideo: use usb_fill_int_urb() for the ->intarval value Sebastian Andrzej Siewior
2018-06-20 15:21 ` [27/27,v2] " Sebastian Andrzej Siewior
2018-06-20 15:40 ` [PATCH 27/27 v2] " Alan Stern
2018-06-20 15:40 ` [27/27,v2] " Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180713072923.GA31191@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bigeasy@linutronix.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=tglx@linutronix.de \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.