From: Miquel Raynal <miquel.raynal@bootlin.com> To: Gregory Clement <gregory.clement@bootlin.com>, Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>, Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>, Zhang Rui <rui.zhang@intel.com>, Eduardo Valentin <edubezval@gmail.com> Cc: Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, Antoine Tenart <antoine.tenart@bootlin.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will.deacon@arm.com>, Maxime Chevallier <maxime.chevallier@bootlin.com>, Nadav Haklai <nadavh@marvell.com>, David Sniatkiwicz <davidsn@marvell.com>, Rob Herring <robh+dt@kernel.org>, Thomas Petazzoni <thomas.petazzoni@bootlin.com>, Miquel Raynal <miquel.raynal@bootlin.com>, linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 10/23] thermal: armada: remove sensors validity from the IP initialization Date: Mon, 16 Jul 2018 16:41:53 +0200 [thread overview] Message-ID: <20180716144206.30985-11-miquel.raynal@bootlin.com> (raw) In-Reply-To: <20180716144206.30985-1-miquel.raynal@bootlin.com> When using new bindings with multiple sensors, sensor validity is checked twice because sensor selection also checks for the validity. Remove the redundant call from the IP initialization helper and move it to the legacy probe section where it is still needed. Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> --- drivers/thermal/armada_thermal.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/thermal/armada_thermal.c b/drivers/thermal/armada_thermal.c index eef8947b9b20..7eafc9400fbe 100644 --- a/drivers/thermal/armada_thermal.c +++ b/drivers/thermal/armada_thermal.c @@ -221,9 +221,6 @@ static void armada380_init(struct platform_device *pdev, reg &= ~CONTROL0_TSEN_TC_TRIM_MASK; reg |= CONTROL0_TSEN_TC_TRIM_VAL; regmap_write(priv->syscon, data->syscon_control0_off, reg); - - /* Wait the sensors to be valid or the core will warn the user */ - armada_wait_sensor_validity(priv); } static void armada_ap806_init(struct platform_device *pdev, @@ -243,9 +240,6 @@ static void armada_ap806_init(struct platform_device *pdev, reg &= ~CONTROL0_TSEN_AVG_BYPASS; regmap_write(priv->syscon, data->syscon_control0_off, reg); - - /* Wait the sensors to be valid or the core will warn the user */ - armada_wait_sensor_validity(priv); } static void armada_cp110_init(struct platform_device *pdev, @@ -650,6 +644,9 @@ static int armada_thermal_probe(struct platform_device *pdev) priv->data->init(pdev, priv); + /* Wait the sensors to be valid */ + armada_wait_sensor_validity(priv); + tz = thermal_zone_device_register(priv->zone_name, 0, 0, priv, &legacy_ops, NULL, 0, 0); if (IS_ERR(tz)) { -- 2.14.1
WARNING: multiple messages have this Message-ID (diff)
From: miquel.raynal@bootlin.com (Miquel Raynal) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 10/23] thermal: armada: remove sensors validity from the IP initialization Date: Mon, 16 Jul 2018 16:41:53 +0200 [thread overview] Message-ID: <20180716144206.30985-11-miquel.raynal@bootlin.com> (raw) In-Reply-To: <20180716144206.30985-1-miquel.raynal@bootlin.com> When using new bindings with multiple sensors, sensor validity is checked twice because sensor selection also checks for the validity. Remove the redundant call from the IP initialization helper and move it to the legacy probe section where it is still needed. Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> --- drivers/thermal/armada_thermal.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/thermal/armada_thermal.c b/drivers/thermal/armada_thermal.c index eef8947b9b20..7eafc9400fbe 100644 --- a/drivers/thermal/armada_thermal.c +++ b/drivers/thermal/armada_thermal.c @@ -221,9 +221,6 @@ static void armada380_init(struct platform_device *pdev, reg &= ~CONTROL0_TSEN_TC_TRIM_MASK; reg |= CONTROL0_TSEN_TC_TRIM_VAL; regmap_write(priv->syscon, data->syscon_control0_off, reg); - - /* Wait the sensors to be valid or the core will warn the user */ - armada_wait_sensor_validity(priv); } static void armada_ap806_init(struct platform_device *pdev, @@ -243,9 +240,6 @@ static void armada_ap806_init(struct platform_device *pdev, reg &= ~CONTROL0_TSEN_AVG_BYPASS; regmap_write(priv->syscon, data->syscon_control0_off, reg); - - /* Wait the sensors to be valid or the core will warn the user */ - armada_wait_sensor_validity(priv); } static void armada_cp110_init(struct platform_device *pdev, @@ -650,6 +644,9 @@ static int armada_thermal_probe(struct platform_device *pdev) priv->data->init(pdev, priv); + /* Wait the sensors to be valid */ + armada_wait_sensor_validity(priv); + tz = thermal_zone_device_register(priv->zone_name, 0, 0, priv, &legacy_ops, NULL, 0, 0); if (IS_ERR(tz)) { -- 2.14.1
next prev parent reply other threads:[~2018-07-16 14:41 UTC|newest] Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-07-16 14:41 [PATCH v3 00/23] Add multi-channel support to Armada thermal driver Miquel Raynal 2018-07-16 14:41 ` Miquel Raynal 2018-07-16 14:41 ` [PATCH v3 01/23] thermal: armada: add a function that sanitizes the thermal zone name Miquel Raynal 2018-07-16 14:41 ` Miquel Raynal 2018-07-27 11:34 ` Daniel Lezcano 2018-07-27 11:34 ` Daniel Lezcano 2018-07-27 11:52 ` Miquel Raynal 2018-07-27 11:52 ` Miquel Raynal 2018-07-27 15:29 ` Daniel Lezcano 2018-07-27 15:29 ` Daniel Lezcano 2018-07-29 19:27 ` Miquel Raynal 2018-07-29 19:27 ` Miquel Raynal 2018-07-30 6:16 ` Daniel Lezcano 2018-07-30 6:16 ` Daniel Lezcano 2018-07-16 14:41 ` [PATCH v3 02/23] thermal: armada: remove useless register accesses Miquel Raynal 2018-07-16 14:41 ` Miquel Raynal 2018-07-27 15:56 ` Daniel Lezcano 2018-07-27 15:56 ` Daniel Lezcano 2018-07-27 16:13 ` Ezequiel Garcia 2018-07-27 16:13 ` Ezequiel Garcia 2018-07-29 19:23 ` Miquel Raynal 2018-07-29 19:23 ` Miquel Raynal 2018-07-16 14:41 ` [PATCH v3 03/23] thermal: armada: remove misleading comments Miquel Raynal 2018-07-16 14:41 ` Miquel Raynal 2018-07-27 16:03 ` Daniel Lezcano 2018-07-27 16:03 ` Daniel Lezcano 2018-07-16 14:41 ` [PATCH v3 04/23] thermal: armada: rename the initialization routine Miquel Raynal 2018-07-16 14:41 ` Miquel Raynal 2018-07-27 16:02 ` Daniel Lezcano 2018-07-27 16:02 ` Daniel Lezcano 2018-07-16 14:41 ` [PATCH v3 05/23] thermal: armada: dissociate a380 and cp110 ->init() hooks Miquel Raynal 2018-07-16 14:41 ` Miquel Raynal 2018-07-27 16:09 ` Daniel Lezcano 2018-07-27 16:09 ` Daniel Lezcano 2018-07-16 14:41 ` [PATCH v3 06/23] thermal: armada: average over samples to avoid glitches Miquel Raynal 2018-07-16 14:41 ` Miquel Raynal 2018-07-27 16:29 ` Daniel Lezcano 2018-07-27 16:29 ` Daniel Lezcano 2018-07-29 19:30 ` Miquel Raynal 2018-07-29 19:30 ` Miquel Raynal 2018-07-16 14:41 ` [PATCH v3 07/23] thermal: armada: convert driver to syscon register accesses Miquel Raynal 2018-07-16 14:41 ` Miquel Raynal 2018-07-16 14:41 ` [PATCH v3 08/23] thermal: armada: use the resource managed registration helper alternative Miquel Raynal 2018-07-16 14:41 ` Miquel Raynal 2018-07-26 21:37 ` Eduardo Valentin 2018-07-26 21:37 ` Eduardo Valentin 2018-07-16 14:41 ` [PATCH v3 09/23] thermal: armada: add multi-channel sensors support Miquel Raynal 2018-07-16 14:41 ` Miquel Raynal 2018-07-16 14:41 ` Miquel Raynal [this message] 2018-07-16 14:41 ` [PATCH v3 10/23] thermal: armada: remove sensors validity from the IP initialization Miquel Raynal 2018-07-16 14:41 ` [PATCH v3 11/23] thermal: armada: move validity check out of the read function Miquel Raynal 2018-07-16 14:41 ` Miquel Raynal 2018-07-16 14:41 ` [PATCH v3 12/23] thermal: armada: get rid of the ->is_valid() pointer Miquel Raynal 2018-07-16 14:41 ` Miquel Raynal 2018-07-16 14:41 ` [PATCH v3 13/23] dt-bindings: cp110: rename cp110 syscon file Miquel Raynal 2018-07-16 14:41 ` Miquel Raynal 2018-07-16 14:41 ` [PATCH v3 14/23] dt-bindings: ap806: prepare the syscon file to list other syscons nodes Miquel Raynal 2018-07-16 14:41 ` Miquel Raynal 2018-07-16 14:41 ` [PATCH v3 15/23] dt-bindings: cp110: " Miquel Raynal 2018-07-16 14:41 ` Miquel Raynal 2018-07-16 14:41 ` [PATCH v3 16/23] dt-bindings: ap806: add the thermal node in the syscon file Miquel Raynal 2018-07-16 14:41 ` Miquel Raynal 2018-07-16 14:42 ` [PATCH v3 17/23] dt-bindings: cp110: update documentation since DT de-duplication Miquel Raynal 2018-07-16 14:42 ` Miquel Raynal 2018-07-16 14:42 ` [PATCH v3 18/23] dt-bindings: cp110: add the thermal node in the syscon file Miquel Raynal 2018-07-16 14:42 ` Miquel Raynal 2018-07-16 14:42 ` [PATCH v3 19/23] dt-bindings: thermal: armada: add reference to new bindings Miquel Raynal 2018-07-16 14:42 ` Miquel Raynal 2018-07-16 16:03 ` Rob Herring 2018-07-16 16:03 ` Rob Herring 2018-07-16 14:42 ` [PATCH v3 20/23] arm64: dts: marvell: move AP806/CP110 thermal nodes into a new syscon Miquel Raynal 2018-07-16 14:42 ` Miquel Raynal 2018-07-16 14:42 ` [PATCH v3 21/23] arm64: dts: marvell: add thermal-zone node in ap806 DTSI file Miquel Raynal 2018-07-16 14:42 ` Miquel Raynal 2018-07-16 14:42 ` [PATCH v3 22/23] arm64: dts: marvell: add macro to make distinction between node names Miquel Raynal 2018-07-16 14:42 ` Miquel Raynal 2018-07-16 14:42 ` [PATCH v3 23/23] arm64: dts: marvell: add thermal-zone node in cp110 DTSI file Miquel Raynal 2018-07-16 14:42 ` Miquel Raynal 2018-07-18 15:28 ` [PATCH v3 00/23] Add multi-channel support to Armada thermal driver Miquel Raynal 2018-07-18 15:28 ` Miquel Raynal 2018-07-25 7:52 ` Miquel Raynal 2018-07-25 7:52 ` Miquel Raynal 2018-07-26 2:00 ` Zhang Rui 2018-07-26 2:00 ` Zhang Rui 2018-07-26 21:14 ` Eduardo Valentin 2018-07-26 21:14 ` Eduardo Valentin 2018-07-26 21:35 ` Eduardo Valentin 2018-07-26 21:35 ` Eduardo Valentin 2018-07-26 22:14 ` Eduardo Valentin 2018-07-26 22:14 ` Eduardo Valentin 2018-07-26 22:59 ` Miquel Raynal 2018-07-26 22:59 ` Miquel Raynal 2018-07-27 21:15 ` Eduardo Valentin 2018-07-27 21:15 ` Eduardo Valentin -- strict thread matches above, loose matches on Subject: below -- 2018-07-05 16:04 Miquel Raynal 2018-07-05 16:04 ` [PATCH v3 10/23] thermal: armada: remove sensors validity from the IP initialization Miquel Raynal 2018-07-05 16:04 ` Miquel Raynal
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180716144206.30985-11-miquel.raynal@bootlin.com \ --to=miquel.raynal@bootlin.com \ --cc=andrew@lunn.ch \ --cc=antoine.tenart@bootlin.com \ --cc=catalin.marinas@arm.com \ --cc=davidsn@marvell.com \ --cc=devicetree@vger.kernel.org \ --cc=edubezval@gmail.com \ --cc=gregory.clement@bootlin.com \ --cc=jason@lakedaemon.net \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-pm@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=maxime.chevallier@bootlin.com \ --cc=nadavh@marvell.com \ --cc=robh+dt@kernel.org \ --cc=rui.zhang@intel.com \ --cc=sebastian.hesselbarth@gmail.com \ --cc=thomas.petazzoni@bootlin.com \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.