From: Patchwork <patchwork@emeril.freedesktop.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for Make the audio component binding more generic
Date: Tue, 17 Jul 2018 06:34:55 -0000 [thread overview]
Message-ID: <20180717063455.8215.25530@emeril.freedesktop.org> (raw)
In-Reply-To: <20180716134815.21365-1-tiwai@suse.de>
== Series Details ==
Series: Make the audio component binding more generic
URL : https://patchwork.freedesktop.org/series/46603/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
801f1d8533a3 drm/i915: Split audio component to a generic type
-:89: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#89:
new file mode 100644
-:94: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#94: FILE: include/drm/drm_audio_component.h:1:
+/*
-:133: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct device *' should also have an identifier name
#133: FILE: include/drm/drm_audio_component.h:40:
+ void (*get_power)(struct device *);
-:139: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct device *' should also have an identifier name
#139: FILE: include/drm/drm_audio_component.h:46:
+ void (*put_power)(struct device *);
-:143: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct device *' should also have an identifier name
#143: FILE: include/drm/drm_audio_component.h:50:
+ void (*codec_wake_override)(struct device *, bool enable);
-:147: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct device *' should also have an identifier name
#147: FILE: include/drm/drm_audio_component.h:54:
+ int (*get_cdclk_freq)(struct device *);
-:154: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct device *' should also have an identifier name
#154: FILE: include/drm/drm_audio_component.h:61:
+ int (*sync_audio_rate)(struct device *, int port, int pipe, int rate);
-:167: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct device *' should also have an identifier name
#167: FILE: include/drm/drm_audio_component.h:74:
+ int (*get_eld)(struct device *, int port, int pipe, bool *enabled,
-:338: WARNING:FUNCTION_ARGUMENTS: function definition argument 'const struct drm_audio_component_audio_ops *' should also have an identifier name
#338: FILE: include/sound/hda_i915.h:20:
+int snd_hdac_i915_register_notifier(const struct drm_audio_component_audio_ops *);
-:347: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#347: FILE: include/sound/hda_i915.h:52:
}
+static inline int snd_hdac_i915_register_notifier(const struct drm_audio_component_audio_ops *ops)
total: 0 errors, 9 warnings, 1 checks, 484 lines checked
702f221ef481 ALSA: hda/i915: Associate audio component with devres
-:47: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#47: FILE: include/sound/hda_i915.h:53:
}
+static inline int snd_hdac_i915_register_notifier(struct hdac_bus *bus,
total: 0 errors, 0 warnings, 1 checks, 139 lines checked
0d7235cdb8c0 ALSA: hda: Make audio component support more generic
-:72: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct drm_audio_component *' should also have an identifier name
#72: FILE: include/drm/drm_audio_component.h:110:
+ int (*master_bind)(struct device *dev, struct drm_audio_component *);
-:79: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct drm_audio_component *' should also have an identifier name
#79: FILE: include/drm/drm_audio_component.h:117:
+ void (*master_unbind)(struct device *dev, struct drm_audio_component *);
-:84: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#84:
new file mode 100644
-:89: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#89: FILE: include/sound/hda_component.h:1:
+// SPDX-License-Identifier: GPL-2.0
-:110: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#110: FILE: include/sound/hda_component.h:22:
+int snd_hdac_acomp_register_notifier(struct hdac_bus *bus,
+ const struct drm_audio_component_audio_ops *ops);
-:116: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#116: FILE: include/sound/hda_component.h:28:
+}
+static inline int snd_hdac_display_power(struct hdac_bus *bus, bool enable)
-:120: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#120: FILE: include/sound/hda_component.h:32:
+}
+static inline int snd_hdac_sync_audio_rate(struct hdac_device *codec,
-:125: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#125: FILE: include/sound/hda_component.h:37:
+}
+static inline int snd_hdac_acomp_get_eld(struct hdac_device *codec, hda_nid_t nid,
-:131: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#131: FILE: include/sound/hda_component.h:43:
+}
+static inline int snd_hdac_acomp_init(struct hdac_bus *bus,
-:138: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#138: FILE: include/sound/hda_component.h:50:
+}
+static inline int snd_hdac_acomp_exit(struct hdac_bus *bus)
-:142: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#142: FILE: include/sound/hda_component.h:54:
+}
+static inline int snd_hdac_acomp_register_notifier(struct hdac_bus *bus,
-:143: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#143: FILE: include/sound/hda_component.h:55:
+static inline int snd_hdac_acomp_register_notifier(struct hdac_bus *bus,
+ const struct drm_audio_component_audio_ops *ops)
-:487: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#487: FILE: sound/hda/hdac_component.c:236:
+int snd_hdac_acomp_register_notifier(struct hdac_bus *bus,
+ const struct drm_audio_component_audio_ops *aops)
-:1055: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1055: FILE: sound/pci/hda/patch_hdmi.c:2546:
+ snd_hdac_acomp_register_notifier(&codec->bus->core,
&spec->drm_audio_ops);
total: 0 errors, 4 warnings, 10 checks, 968 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2018-07-17 6:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-16 13:48 [PATCH 0/3] Make the audio component binding more generic Takashi Iwai
2018-07-16 13:48 ` [PATCH 1/3] drm/i915: Split audio component to a generic type Takashi Iwai
2018-07-16 17:22 ` [Intel-gfx] " Rodrigo Vivi
2018-07-16 17:50 ` Takashi Iwai
2018-07-16 20:35 ` Takashi Iwai
2018-07-16 13:48 ` [PATCH 2/3] ALSA: hda/i915: Associate audio component with devres Takashi Iwai
2018-07-16 13:48 ` [PATCH 3/3] ALSA: hda: Make audio component support more generic Takashi Iwai
2018-07-16 20:33 ` Takashi Iwai
2018-07-16 19:02 ` ✗ Fi.CI.BAT: failure for Make the audio component binding " Patchwork
2018-07-17 6:34 ` Patchwork [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180717063455.8215.25530@emeril.freedesktop.org \
--to=patchwork@emeril.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.