Re: [PATCH 3/3] ALSA: hda: Make audio component support more generic

From: Takashi Iwai <tiwai@suse.de>
To: alsa-devel@alsa-project.org
Cc: Jim Qu <Jim.Qu@amd.com>,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 3/3] ALSA: hda: Make audio component support more generic
Date: Mon, 16 Jul 2018 22:33:05 +0200	[thread overview]
Message-ID: <s5h4lgyly4e.wl-tiwai@suse.de> (raw)
In-Reply-To: <20180716134815.21365-4-tiwai@suse.de>

On Mon, 16 Jul 2018 15:48:15 +0200,
Takashi Iwai wrote:
> 
> +static int hdac_component_master_bind(struct device *dev)
> +{
> +	struct drm_audio_component *acomp = hdac_get_acomp(dev);
> +	int ret;
> +
> +	ret = component_bind_all(dev, acomp);
> +	if (ret < 0)
> +		return ret;
> +
> +	if (WARN_ON(!(acomp->dev && acomp->ops))) {
> +		ret = -EINVAL;
> +		goto out_unbind;
> +	}
> +
> +	/* pin the module to avoid dynamic unbinding, but only if given */
> +	if (!try_module_get(acomp->ops->owner)) {
> +		ret = -ENODEV;
> +		goto out_unbind;
> +	}
> +
> +	if (acomp->audio_ops->master_bind) {

Here misses the NULL check of acomp->audio_ops, which is caught by the
intel CI.  I overlooked it since the upcoming patch will set audio_ops
initially for i915 as well.  Will fix it in v2.

thanks,

Takashi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx