From: Alexandru Gheorghe <alexandru-cosmin.gheorghe@arm.com>
To: seanpaul@chromium.org, airlied@linux.ie,
dri-devel@lists.freedesktop.org, liviu.dudau@arm.com,
brian.starkey@arm.com, malidp@foss.arm.com,
ville.syrjala@linux.intel.com, daniel@ffwll.ch,
gustavo@padovan.org, maarten.lankhorst@linux.intel.com,
alexander.deucher@amd.com, christian.koenig@amd.com,
David1.Zhou@amd.com, harry.wentland@amd.com,
andrey.grodzovsky@amd.com, Tony.Cheng@amd.com,
sunpeng.li@amd.com, shirish.s@amd.com,
boris.brezillon@bootlin.com, nicolas.ferre@microchip.com,
alexandre.belloni@bootlin.com, inki.dae@samsung.com,
jy0922.shim@samsung.com, sw0312.kim@samsung.com,
kyungmin.park@samsung.com, kgene@kernel.org, krzk@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, p.zabel@pengutronix.de,
laurent.pinchart@ideasonboard.com, maxime.ripard@bootlin.com,
wens@csie.org, eric@anholt.net,
linux-graphics-maintainer@vmware.com, syeh@
Cc: nd@arm.com, Alexandru Gheorghe <alexandru-cosmin.gheorghe@arm.com>
Subject: [PATCH v2 00/10] Add helper for plane reset
Date: Thu, 26 Jul 2018 17:17:46 +0100 [thread overview]
Message-ID: <20180726161756.1794-1-alexandru-cosmin.gheorghe@arm.com> (raw)
Changes since v1:
- Make __drm_atomic_helper_plane_reset consistent with the other
helpers and require that both plane and state not be NULL,
suggested by Boris Brezillon and Philipp Zabel. Drivers already
check for that.
- Add a proper commit message for driver changes.
Drivers that subclass drm_plane need to copy the logic for linking the
drm_plane with its state and to initialize core properties to their
default values. E.g (alpha and rotation)
Having a helper to reset the plane_state makes sense because of multiple
reasons:
1. Eliminate code duplication.
2. Add a single place for initializing core properties to their
default values, no need for driver to do it if what the helper sets
makes sense for them.
3. No need to debug the driver when you enable a core property and
observe it doesn't have a proper default value.
Tested with mali-dp the other drivers are just built-tested.
Alexandru Gheorghe (10):
drm/atomic: Add __drm_atomic_helper_plane_reset
drm/amd/display: Use __drm_atomic_helper_plane_reset instead of
copying the logic
drm: mali-dp: Use __drm_atomic_helper_plane_reset instead of copying
the logic
drm: atmel-hlcdc: Use __drm_atomic_helper_plane_reset instead of
copying the logic
drm/exynos: Use __drm_atomic_helper_plane_reset instead of copying the
logic
drm/imx: Use __drm_atomic_helper_plane_reset instead of copying the
logic
drm: rcar-du: Use __drm_atomic_helper_plane_reset instead of copying
the logic
drm/sun4i: Use __drm_atomic_helper_plane_reset instead of copying the
logic
drm/vc4: Use __drm_atomic_helper_plane_reset instead of copying the
logic
drm/vmwgfx: Use __drm_atomic_helper_plane_reset instead of copying the
logic
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 7 ++---
drivers/gpu/drm/arm/malidp_planes.c | 7 ++---
.../gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 5 +--
drivers/gpu/drm/drm_atomic_helper.c | 31 +++++++++++++------
drivers/gpu/drm/exynos/exynos_drm_plane.c | 3 +-
drivers/gpu/drm/imx/ipuv3-plane.c | 8 ++---
drivers/gpu/drm/rcar-du/rcar_du_plane.c | 4 +--
drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 4 +--
drivers/gpu/drm/sun4i/sun4i_layer.c | 4 +--
drivers/gpu/drm/vc4/vc4_plane.c | 4 +--
drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 4 +--
include/drm/drm_atomic_helper.h | 2 ++
12 files changed, 38 insertions(+), 45 deletions(-)
--
2.18.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: alexandru-cosmin.gheorghe@arm.com (Alexandru Gheorghe)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 00/10] Add helper for plane reset
Date: Thu, 26 Jul 2018 17:17:46 +0100 [thread overview]
Message-ID: <20180726161756.1794-1-alexandru-cosmin.gheorghe@arm.com> (raw)
Changes since v1:
- Make __drm_atomic_helper_plane_reset consistent with the other
helpers and require that both plane and state not be NULL,
suggested by Boris Brezillon and Philipp Zabel. Drivers already
check for that.
- Add a proper commit message for driver changes.
Drivers that subclass drm_plane need to copy the logic for linking the
drm_plane with its state and to initialize core properties to their
default values. E.g (alpha and rotation)
Having a helper to reset the plane_state makes sense because of multiple
reasons:
1. Eliminate code duplication.
2. Add a single place for initializing core properties to their
default values, no need for driver to do it if what the helper sets
makes sense for them.
3. No need to debug the driver when you enable a core property and
observe it doesn't have a proper default value.
Tested with mali-dp the other drivers are just built-tested.
Alexandru Gheorghe (10):
drm/atomic: Add __drm_atomic_helper_plane_reset
drm/amd/display: Use __drm_atomic_helper_plane_reset instead of
copying the logic
drm: mali-dp: Use __drm_atomic_helper_plane_reset instead of copying
the logic
drm: atmel-hlcdc: Use __drm_atomic_helper_plane_reset instead of
copying the logic
drm/exynos: Use __drm_atomic_helper_plane_reset instead of copying the
logic
drm/imx: Use __drm_atomic_helper_plane_reset instead of copying the
logic
drm: rcar-du: Use __drm_atomic_helper_plane_reset instead of copying
the logic
drm/sun4i: Use __drm_atomic_helper_plane_reset instead of copying the
logic
drm/vc4: Use __drm_atomic_helper_plane_reset instead of copying the
logic
drm/vmwgfx: Use __drm_atomic_helper_plane_reset instead of copying the
logic
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 7 ++---
drivers/gpu/drm/arm/malidp_planes.c | 7 ++---
.../gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 5 +--
drivers/gpu/drm/drm_atomic_helper.c | 31 +++++++++++++------
drivers/gpu/drm/exynos/exynos_drm_plane.c | 3 +-
drivers/gpu/drm/imx/ipuv3-plane.c | 8 ++---
drivers/gpu/drm/rcar-du/rcar_du_plane.c | 4 +--
drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 4 +--
drivers/gpu/drm/sun4i/sun4i_layer.c | 4 +--
drivers/gpu/drm/vc4/vc4_plane.c | 4 +--
drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 4 +--
include/drm/drm_atomic_helper.h | 2 ++
12 files changed, 38 insertions(+), 45 deletions(-)
--
2.18.0
next reply other threads:[~2018-07-26 16:17 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-26 16:17 Alexandru Gheorghe [this message]
2018-07-26 16:17 ` [PATCH v2 00/10] Add helper for plane reset Alexandru Gheorghe
2018-07-26 16:17 ` [PATCH v2 01/10] drm/atomic: Add __drm_atomic_helper_plane_reset Alexandru Gheorghe
2018-07-26 16:17 ` Alexandru Gheorghe
2018-07-26 20:20 ` Laurent Pinchart
2018-07-26 20:20 ` Laurent Pinchart
2018-07-26 16:17 ` [PATCH v2 02/10] drm/amd/display: Use __drm_atomic_helper_plane_reset instead of copying the logic Alexandru Gheorghe
2018-07-26 16:17 ` Alexandru Gheorghe
2018-07-26 16:17 ` [PATCH v2 03/10] drm: mali-dp: " Alexandru Gheorghe
2018-07-26 16:17 ` Alexandru Gheorghe
2018-07-26 16:17 ` [PATCH v2 04/10] drm: atmel-hlcdc: " Alexandru Gheorghe
2018-07-26 16:17 ` Alexandru Gheorghe
2018-07-26 16:17 ` [PATCH v2 05/10] drm/exynos: " Alexandru Gheorghe
2018-07-26 16:17 ` Alexandru Gheorghe
2018-07-26 16:17 ` [PATCH v2 06/10] drm/imx: " Alexandru Gheorghe
2018-07-26 16:17 ` Alexandru Gheorghe
2018-07-26 16:17 ` [PATCH v2 07/10] drm: rcar-du: " Alexandru Gheorghe
2018-07-26 16:17 ` Alexandru Gheorghe
2018-07-26 20:17 ` Laurent Pinchart
2018-07-26 20:17 ` Laurent Pinchart
2018-07-26 16:17 ` [PATCH v2 08/10] drm/sun4i: " Alexandru Gheorghe
2018-07-26 16:17 ` Alexandru Gheorghe
2018-07-27 12:54 ` Maxime Ripard
2018-07-27 12:54 ` Maxime Ripard
2018-07-26 16:17 ` [PATCH v2 09/10] drm/vc4: " Alexandru Gheorghe
2018-07-26 16:17 ` Alexandru Gheorghe
2018-07-26 16:17 ` [PATCH v2 10/10] drm/vmwgfx: " Alexandru Gheorghe
2018-07-26 16:17 ` Alexandru Gheorghe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180726161756.1794-1-alexandru-cosmin.gheorghe@arm.com \
--to=alexandru-cosmin.gheorghe@arm.com \
--cc=David1.Zhou@amd.com \
--cc=Tony.Cheng@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrey.grodzovsky@amd.com \
--cc=boris.brezillon@bootlin.com \
--cc=brian.starkey@arm.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric@anholt.net \
--cc=gustavo@padovan.org \
--cc=harry.wentland@amd.com \
--cc=inki.dae@samsung.com \
--cc=jy0922.shim@samsung.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-graphics-maintainer@vmware.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=malidp@foss.arm.com \
--cc=maxime.ripard@bootlin.com \
--cc=nd@arm.com \
--cc=nicolas.ferre@microchip.com \
--cc=p.zabel@pengutronix.de \
--cc=seanpaul@chromium.org \
--cc=shirish.s@amd.com \
--cc=sunpeng.li@amd.com \
--cc=sw0312.kim@samsung.com \
--cc=ville.syrjala@linux.intel.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.