From: Huaisheng Ye <yehs2007@zoho.com>
To: linux-nvdimm@lists.01.org, dan.j.williams@intel.com
Cc: jack@suse.cz, snitzer@redhat.com, heiko.carstens@de.ibm.com,
dm-devel@redhat.com, agk@redhat.com, linux-s390@vger.kernel.org,
willy@infradead.org, bart.vanassche@wdc.com,
keescook@chromium.org, chengnt@lenovo.com, colyli@suse.de,
schwidefsky@de.ibm.com, viro@zeniv.linux.org.uk, axboe@kernel.dk,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: [PATCH v3 5/6] md/dm-writecache: Don't request pointer dummy_addr when not required
Date: Mon, 30 Jul 2018 15:15:47 +0800 [thread overview]
Message-ID: <20180730071548.9172-6-yehs2007@zoho.com> (raw)
In-Reply-To: <20180730071548.9172-1-yehs2007@zoho.com>
From: Huaisheng Ye <yehs1@lenovo.com>
Function persistent_memory_claim doesn't need to get local pointer
dummy_addr from direct_access. Using NULL instead of having to pass
in a useless local pointer that caller then just throw away.
Suggested-by: Ross Zwisler <ross.zwisler@linux.intel.com>
Signed-off-by: Huaisheng Ye <yehs1@lenovo.com>
Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>
Acked-by: Mike Snitzer <snitzer@redhat.com>
---
drivers/md/dm-writecache.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/md/dm-writecache.c b/drivers/md/dm-writecache.c
index 87107c9..9d79084 100644
--- a/drivers/md/dm-writecache.c
+++ b/drivers/md/dm-writecache.c
@@ -268,9 +268,8 @@ static int persistent_memory_claim(struct dm_writecache *wc)
i = 0;
do {
long daa;
- void *dummy_addr;
daa = dax_direct_access(wc->ssd_dev->dax_dev, i, p - i,
- &dummy_addr, &pfn);
+ NULL, &pfn);
if (daa <= 0) {
r = daa ? daa : -EINVAL;
goto err3;
--
1.8.3.1
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Huaisheng Ye <yehs2007@zoho.com>
To: linux-nvdimm@lists.01.org, dan.j.williams@intel.com
Cc: ross.zwisler@linux.intel.com, willy@infradead.org,
vishal.l.verma@intel.com, dave.jiang@intel.com,
schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com,
viro@zeniv.linux.org.uk, martin.petersen@oracle.com,
axboe@kernel.dk, gregkh@linuxfoundation.org,
bart.vanassche@wdc.com, jack@suse.cz, agk@redhat.com,
snitzer@redhat.com, keescook@chromium.org, dm-devel@redhat.com,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
linux-fsdevel@vger.kernel.org, colyli@suse.de,
chengnt@lenovo.com, Huaisheng Ye <yehs1@lenovo.com>
Subject: [PATCH v3 5/6] md/dm-writecache: Don't request pointer dummy_addr when not required
Date: Mon, 30 Jul 2018 15:15:47 +0800 [thread overview]
Message-ID: <20180730071548.9172-6-yehs2007@zoho.com> (raw)
In-Reply-To: <20180730071548.9172-1-yehs2007@zoho.com>
From: Huaisheng Ye <yehs1@lenovo.com>
Function persistent_memory_claim doesn't need to get local pointer
dummy_addr from direct_access. Using NULL instead of having to pass
in a useless local pointer that caller then just throw away.
Suggested-by: Ross Zwisler <ross.zwisler@linux.intel.com>
Signed-off-by: Huaisheng Ye <yehs1@lenovo.com>
Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>
Acked-by: Mike Snitzer <snitzer@redhat.com>
---
drivers/md/dm-writecache.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/md/dm-writecache.c b/drivers/md/dm-writecache.c
index 87107c9..9d79084 100644
--- a/drivers/md/dm-writecache.c
+++ b/drivers/md/dm-writecache.c
@@ -268,9 +268,8 @@ static int persistent_memory_claim(struct dm_writecache *wc)
i = 0;
do {
long daa;
- void *dummy_addr;
daa = dax_direct_access(wc->ssd_dev->dax_dev, i, p - i,
- &dummy_addr, &pfn);
+ NULL, &pfn);
if (daa <= 0) {
r = daa ? daa : -EINVAL;
goto err3;
--
1.8.3.1
WARNING: multiple messages have this Message-ID (diff)
From: Huaisheng Ye <yehs2007-ytc+IHgoah0@public.gmane.org>
To: linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org,
dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Cc: jack-AlSwsSmVLrQ@public.gmane.org,
snitzer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
heiko.carstens-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org,
dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
agk-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
linux-s390-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
willy-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
bart.vanassche-Sjgp3cTcYWE@public.gmane.org,
keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
chengnt-6jq1YtArVR3QT0dZR+AlfA@public.gmane.org,
colyli-l3A5Bk7waGM@public.gmane.org,
schwidefsky-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org,
viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org,
axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH v3 5/6] md/dm-writecache: Don't request pointer dummy_addr when not required
Date: Mon, 30 Jul 2018 15:15:47 +0800 [thread overview]
Message-ID: <20180730071548.9172-6-yehs2007@zoho.com> (raw)
In-Reply-To: <20180730071548.9172-1-yehs2007-ytc+IHgoah0@public.gmane.org>
From: Huaisheng Ye <yehs1-6jq1YtArVR3QT0dZR+AlfA@public.gmane.org>
Function persistent_memory_claim doesn't need to get local pointer
dummy_addr from direct_access. Using NULL instead of having to pass
in a useless local pointer that caller then just throw away.
Suggested-by: Ross Zwisler <ross.zwisler-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Signed-off-by: Huaisheng Ye <yehs1-6jq1YtArVR3QT0dZR+AlfA@public.gmane.org>
Reviewed-by: Ross Zwisler <ross.zwisler-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Acked-by: Mike Snitzer <snitzer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
---
drivers/md/dm-writecache.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/md/dm-writecache.c b/drivers/md/dm-writecache.c
index 87107c9..9d79084 100644
--- a/drivers/md/dm-writecache.c
+++ b/drivers/md/dm-writecache.c
@@ -268,9 +268,8 @@ static int persistent_memory_claim(struct dm_writecache *wc)
i = 0;
do {
long daa;
- void *dummy_addr;
daa = dax_direct_access(wc->ssd_dev->dax_dev, i, p - i,
- &dummy_addr, &pfn);
+ NULL, &pfn);
if (daa <= 0) {
r = daa ? daa : -EINVAL;
goto err3;
--
1.8.3.1
next prev parent reply other threads:[~2018-07-30 7:17 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 7:15 [PATCH v3 0/6] kaddr and pfn can be NULL to ->direct_access() Huaisheng Ye
2018-07-30 7:15 ` Huaisheng Ye
2018-07-30 7:15 ` Huaisheng Ye
2018-07-30 7:15 ` [PATCH v3 1/6] libnvdimm, pmem: " Huaisheng Ye
2018-07-30 7:15 ` Huaisheng Ye
2018-07-30 7:15 ` Huaisheng Ye
2018-07-30 7:15 ` [PATCH v3 2/6] s390, dcssblk: " Huaisheng Ye
2018-07-30 7:15 ` Huaisheng Ye
2018-07-30 7:15 ` Huaisheng Ye
2018-07-30 7:15 ` [PATCH v3 3/6] tools/testing/nvdimm: " Huaisheng Ye
2018-07-30 7:15 ` Huaisheng Ye
2018-07-30 7:15 ` Huaisheng Ye
2018-07-30 7:15 ` [PATCH v3 4/6] dax/super: Do not request a pointer kaddr when not required Huaisheng Ye
2018-07-30 7:15 ` Huaisheng Ye
2018-07-30 7:15 ` Huaisheng Ye
2018-07-30 7:15 ` Huaisheng Ye [this message]
2018-07-30 7:15 ` [PATCH v3 5/6] md/dm-writecache: Don't request pointer dummy_addr " Huaisheng Ye
2018-07-30 7:15 ` Huaisheng Ye
2018-07-30 7:15 ` [PATCH v3 6/6] filesystem-dax: Do not request kaddr and pfn " Huaisheng Ye
2018-07-30 7:15 ` Huaisheng Ye
2018-07-30 7:15 ` Huaisheng Ye
2018-07-30 7:30 ` [External] [PATCH v3 0/6] kaddr and pfn can be NULL to ->direct_access() Huaisheng HS1 Ye
2018-07-30 7:30 ` Huaisheng HS1 Ye
2018-07-30 7:30 ` Huaisheng HS1 Ye
2018-07-31 15:35 ` Dave Jiang
2018-07-31 15:35 ` Dave Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180730071548.9172-6-yehs2007@zoho.com \
--to=yehs2007@zoho.com \
--cc=agk@redhat.com \
--cc=axboe@kernel.dk \
--cc=bart.vanassche@wdc.com \
--cc=chengnt@lenovo.com \
--cc=colyli@suse.de \
--cc=dan.j.williams@intel.com \
--cc=dm-devel@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko.carstens@de.ibm.com \
--cc=jack@suse.cz \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-s390@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=snitzer@redhat.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.