From: Sam Ravnborg <sam@ravnborg.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
linux-pwm@vger.kernel.org,
Boris Brezillon <boris.brezillon@free-electrons.com>,
dri-devel@lists.freedesktop.org,
Boris Brezillon <boris.brezillon@bootlin.com>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1 3/7] mfd: add atmel-lcdc driver
Date: Wed, 15 Aug 2018 22:40:41 +0200 [thread overview]
Message-ID: <20180815204041.GA29041@ravnborg.org> (raw)
In-Reply-To: <20180815052435.GA6412@dell>
Hi Lee.
> > +
> > +static const struct mfd_cell lcdc_cells[] = {
> > + {
> > + .name = "atmel-lcdc-pwm",
> > + .of_compatible = "atmel,lcdc-pwm",
> > + },
> > + {
> > + .name = "atmel-lcdc-dc",
> > + .of_compatible = "atmel,lcdc-display-controller",
> > + },
> > +};
>
> Will you be adding any more devices, or is this the entirety of the
> device? If the latter, I suggest that this doesn't warrant being an
> MFD.
Thats it. And others agree with you that this is not a good approach.
So in v2 there will be no MFD.
Thanks for confirming that the non-mfd way is the better approach.
Sam
WARNING: multiple messages have this Message-ID (diff)
From: sam@ravnborg.org (Sam Ravnborg)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v1 3/7] mfd: add atmel-lcdc driver
Date: Wed, 15 Aug 2018 22:40:41 +0200 [thread overview]
Message-ID: <20180815204041.GA29041@ravnborg.org> (raw)
In-Reply-To: <20180815052435.GA6412@dell>
Hi Lee.
> > +
> > +static const struct mfd_cell lcdc_cells[] = {
> > + {
> > + .name = "atmel-lcdc-pwm",
> > + .of_compatible = "atmel,lcdc-pwm",
> > + },
> > + {
> > + .name = "atmel-lcdc-dc",
> > + .of_compatible = "atmel,lcdc-display-controller",
> > + },
> > +};
>
> Will you be adding any more devices, or is this the entirety of the
> device? If the latter, I suggest that this doesn't warrant being an
> MFD.
Thats it. And others agree with you that this is not a good approach.
So in v2 there will be no MFD.
Thanks for confirming that the non-mfd way is the better approach.
Sam
next prev parent reply other threads:[~2018-08-15 20:40 UTC|newest]
Thread overview: 100+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-12 18:41 [RFC PATCH 0/7] add at91sam9 LCDC DRM driver Sam Ravnborg
2018-08-12 18:41 ` Sam Ravnborg
2018-08-12 18:46 ` [PATCH v1 1/7] atmel-hlcdc: renamed directory to drm/atmel/ Sam Ravnborg
2018-08-12 18:46 ` Sam Ravnborg
2018-08-14 8:39 ` Daniel Vetter
2018-08-14 8:39 ` Daniel Vetter
2018-08-14 16:19 ` Sam Ravnborg
2018-08-14 16:19 ` Sam Ravnborg
2018-08-16 7:41 ` Daniel Vetter
2018-08-16 7:41 ` Daniel Vetter
2018-08-22 20:09 ` Sam Ravnborg
2018-08-22 20:09 ` Sam Ravnborg
2018-08-22 20:22 ` Daniel Vetter
2018-08-22 20:22 ` Daniel Vetter
2018-08-24 8:28 ` Boris Brezillon
2018-08-24 8:28 ` Boris Brezillon
2018-08-24 15:43 ` Sam Ravnborg
2018-08-24 15:43 ` Sam Ravnborg
2018-08-12 18:46 ` [PATCH v1 2/7] dt-binding: add bindings for Atmel LCDC mfd Sam Ravnborg
2018-08-12 18:46 ` Sam Ravnborg
2018-08-24 8:45 ` Boris Brezillon
2018-08-24 8:45 ` Boris Brezillon
2018-08-24 15:58 ` Sam Ravnborg
2018-08-24 15:58 ` Sam Ravnborg
2018-08-12 18:46 ` [PATCH v1 3/7] mfd: add atmel-lcdc driver Sam Ravnborg
2018-08-12 18:46 ` Sam Ravnborg
2018-08-14 11:09 ` kbuild test robot
2018-08-14 11:09 ` kbuild test robot
2018-08-15 5:24 ` Lee Jones
2018-08-15 5:24 ` Lee Jones
2018-08-15 20:40 ` Sam Ravnborg [this message]
2018-08-15 20:40 ` Sam Ravnborg
2018-08-16 8:28 ` Nicolas Ferre
2018-08-16 8:28 ` Nicolas Ferre
2018-08-16 8:42 ` Lee Jones
2018-08-16 8:42 ` Lee Jones
2018-08-24 8:37 ` Boris Brezillon
2018-08-24 8:37 ` Boris Brezillon
2018-08-24 8:15 ` Boris Brezillon
2018-08-24 8:15 ` Boris Brezillon
2018-08-24 10:58 ` Lee Jones
2018-08-24 10:58 ` Lee Jones
2018-08-15 8:11 ` kbuild test robot
2018-08-15 8:11 ` kbuild test robot
2018-08-24 8:48 ` Boris Brezillon
2018-08-24 8:48 ` Boris Brezillon
2018-08-12 18:46 ` [PATCH v1 4/7] dt-bindings: add bindings for Atmel LCDC pwm Sam Ravnborg
2018-08-12 18:46 ` Sam Ravnborg
2018-08-12 18:46 ` [PATCH v1 5/7] pwm: add pwm-atmel-lcdc driver Sam Ravnborg
2018-08-12 18:46 ` Sam Ravnborg
2018-08-12 18:46 ` [PATCH v1 6/7] dt-bindings: add bindings for Atmel lcdc-display-controller Sam Ravnborg
2018-08-12 18:46 ` Sam Ravnborg
2018-08-12 18:46 ` [PATCH v1 7/7] drm: add Atmel LCDC display controller support Sam Ravnborg
2018-08-12 18:46 ` Sam Ravnborg
2018-08-24 12:31 ` Boris Brezillon
2018-08-24 12:31 ` Boris Brezillon
2018-08-26 18:41 ` Sam Ravnborg
2018-08-26 18:41 ` Sam Ravnborg
2018-08-26 14:28 ` Noralf Trønnes
2018-08-26 14:28 ` Noralf Trønnes
2018-08-26 14:58 ` Sam Ravnborg
2018-08-26 14:58 ` Sam Ravnborg
2018-08-12 19:55 ` [RFC PATCH 0/7] add at91sam9 LCDC DRM driver Sam Ravnborg
2018-08-12 19:55 ` Sam Ravnborg
2018-08-13 14:47 ` Nicolas Ferre
2018-08-13 14:47 ` Nicolas Ferre
2018-08-14 8:41 ` Daniel Vetter
2018-08-14 8:41 ` Daniel Vetter
2018-08-22 20:12 ` Sam Ravnborg
2018-08-22 20:12 ` Sam Ravnborg
2018-08-23 6:16 ` Daniel Vetter
2018-08-23 6:16 ` Daniel Vetter
2018-08-13 15:54 ` Nicolas Ferre
2018-08-13 15:54 ` Nicolas Ferre
2018-08-13 18:18 ` Sam Ravnborg
2018-08-13 18:18 ` Sam Ravnborg
2018-08-13 22:04 ` Rob Herring
2018-08-13 22:04 ` Rob Herring
2018-08-14 16:43 ` Sam Ravnborg
2018-08-14 16:43 ` Sam Ravnborg
2018-08-14 22:42 ` Rob Herring
2018-08-14 22:42 ` Rob Herring
2018-08-15 4:48 ` Sam Ravnborg
2018-08-15 4:48 ` Sam Ravnborg
2018-08-15 14:45 ` Rob Herring
2018-08-15 14:45 ` Rob Herring
2018-08-15 15:04 ` Daniel Vetter
2018-08-15 15:04 ` Daniel Vetter
2018-08-15 15:41 ` Peter Rosin
2018-08-15 15:41 ` Peter Rosin
2018-08-15 20:48 ` Sam Ravnborg
2018-08-15 20:48 ` Sam Ravnborg
2018-08-14 14:36 ` Alexandre Belloni
2018-08-14 14:36 ` Alexandre Belloni
2018-08-14 16:16 ` Sam Ravnborg
2018-08-14 16:16 ` Sam Ravnborg
2018-08-24 8:22 ` Boris Brezillon
2018-08-24 8:22 ` Boris Brezillon
2018-08-24 15:52 ` Sam Ravnborg
2018-08-24 15:52 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180815204041.GA29041@ravnborg.org \
--to=sam@ravnborg.org \
--cc=alexandre.belloni@bootlin.com \
--cc=boris.brezillon@bootlin.com \
--cc=boris.brezillon@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.