From: Jonathan Cameron <jic23@kernel.org> To: Colin King <colin.king@canonical.com> Cc: Hartmut Knaack <knaack.h@gmx.de>, Lars-Peter Clausen <lars@metafoo.de>, Peter Meerwald-Stadler <pmeerw@pmeerw.net>, linux-iio@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iio: max44000: remove unused variable max44000_alstim_shift Date: Sun, 19 Aug 2018 18:28:53 +0100 [thread overview] Message-ID: <20180819182853.2eda699d@archlinux> (raw) In-Reply-To: <20180809135338.10868-1-colin.king@canonical.com> On Thu, 9 Aug 2018 14:53:38 +0100 Colin King <colin.king@canonical.com> wrote: > From: Colin Ian King <colin.king@canonical.com> > > Variable max44000_alstim_shift is defined but is never used hence it is > redundant and can be removed. This variable has been like this since > the driver was added back in 2016. > > Cleans up clang warning: > warning: 'max44000_alstim_shift' defined but not used [-Wunused-const-variable=] > > Signed-off-by: Colin Ian King <colin.king@canonical.com> Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > --- > drivers/iio/light/max44000.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/iio/light/max44000.c b/drivers/iio/light/max44000.c > index bcdb0eb9e537..b9b0bd341be8 100644 > --- a/drivers/iio/light/max44000.c > +++ b/drivers/iio/light/max44000.c > @@ -99,7 +99,6 @@ static const int max44000_alspga_shift[] = {0, 2, 4, 7}; > * Handling this internally is also required for buffer support because the > * channel's scan_type can't be modified dynamically. > */ > -static const int max44000_alstim_shift[] = {0, 2, 4, 6}; > #define MAX44000_ALSTIM_SHIFT(alstim) (2 * (alstim)) > > /* Available integration times with pretty manual alignment: */
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23@kernel.org> To: Colin King <colin.king@canonical.com> Cc: Hartmut Knaack <knaack.h@gmx.de>, Lars-Peter Clausen <lars@metafoo.de>, Peter Meerwald-Stadler <pmeerw@pmeerw.net>, linux-iio@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iio: max44000: remove unused variable max44000_alstim_shift Date: Sun, 19 Aug 2018 17:28:53 +0000 [thread overview] Message-ID: <20180819182853.2eda699d@archlinux> (raw) In-Reply-To: <20180809135338.10868-1-colin.king@canonical.com> On Thu, 9 Aug 2018 14:53:38 +0100 Colin King <colin.king@canonical.com> wrote: > From: Colin Ian King <colin.king@canonical.com> > > Variable max44000_alstim_shift is defined but is never used hence it is > redundant and can be removed. This variable has been like this since > the driver was added back in 2016. > > Cleans up clang warning: > warning: 'max44000_alstim_shift' defined but not used [-Wunused-const-variable=] > > Signed-off-by: Colin Ian King <colin.king@canonical.com> Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > --- > drivers/iio/light/max44000.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/iio/light/max44000.c b/drivers/iio/light/max44000.c > index bcdb0eb9e537..b9b0bd341be8 100644 > --- a/drivers/iio/light/max44000.c > +++ b/drivers/iio/light/max44000.c > @@ -99,7 +99,6 @@ static const int max44000_alspga_shift[] = {0, 2, 4, 7}; > * Handling this internally is also required for buffer support because the > * channel's scan_type can't be modified dynamically. > */ > -static const int max44000_alstim_shift[] = {0, 2, 4, 6}; > #define MAX44000_ALSTIM_SHIFT(alstim) (2 * (alstim)) > > /* Available integration times with pretty manual alignment: */
next prev parent reply other threads:[~2018-08-19 17:29 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-08-09 13:53 [PATCH] iio: max44000: remove unused variable max44000_alstim_shift Colin King 2018-08-09 13:53 ` Colin King 2018-08-19 17:28 ` Jonathan Cameron [this message] 2018-08-19 17:28 ` Jonathan Cameron
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180819182853.2eda699d@archlinux \ --to=jic23@kernel.org \ --cc=colin.king@canonical.com \ --cc=kernel-janitors@vger.kernel.org \ --cc=knaack.h@gmx.de \ --cc=lars@metafoo.de \ --cc=linux-iio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=pmeerw@pmeerw.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.