Re: [PATCH] crypto: xts - Drop use of auxiliary buffer

From: Herbert Xu <herbert@gondor.apana.org.au>
To: Ondrej Mosnacek <omosnace@redhat.com>
Cc: dm-devel@redhat.com, mpatocka@redhat.com,
	linux-crypto@vger.kernel.org, omosnace@redhat.com
Subject: Re: [PATCH] crypto: xts - Drop use of auxiliary buffer
Date: Tue, 4 Sep 2018 11:38:16 +0800	[thread overview]
Message-ID: <20180904033815.3titfipifya2zg7r@gondor.apana.org.au> (raw)
In-Reply-To: <20180903112942.18979-1-omosnace@redhat.com>

Ondrej Mosnacek <omosnace@redhat.com> wrote:
> Hi Herbert, Mikulas,
> 
> I noticed the discussion about using kmalloc() inside crypto code and it
> made me wonder if the code in xts.c can actually be simplified to not
> require kmalloc() at all, while not badly affecting performace. I played
> around with it a little and it turns out we can drop the whole caching
> of tweak blocks, reducing code size by ~200 lines and not only preserve,
> but even improve the performance in some cases. See the full patch
> below.
> 
> Obviously, this doesn't solve the general issue of using kmalloc() in
> crypto API routines, but it does resolve the original reported problem
> and also makes the XTS code easier to maintain.

Nice work.  Unfortunately it doesn't apply against the latest
cryptodev tree.  Please rebase and resubmit.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt