From: Rob Herring <robh@kernel.org> To: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Simon Horman <horms@verge.net.au>, Magnus Damm <magnus.damm@gmail.com>, Russell King <linux@armlinux.org.uk>, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org Subject: [PATCH 05/21] ARM: shmobile: use for_each_of_cpu_node iterator Date: Wed, 5 Sep 2018 14:37:22 -0500 [thread overview] Message-ID: <20180905193738.19325-6-robh@kernel.org> (raw) In-Reply-To: <20180905193738.19325-1-robh@kernel.org> Use the for_each_of_cpu_node iterator to iterate over cpu nodes. This has the side effect of defaulting to iterating using "cpu" node names in preference to the deprecated (for FDT) device_type == "cpu". Cc: Simon Horman <horms@verge.net.au> Cc: Magnus Damm <magnus.damm@gmail.com> Cc: Russell King <linux@armlinux.org.uk> Cc: linux-arm-kernel@lists.infradead.org Cc: linux-renesas-soc@vger.kernel.org Signed-off-by: Rob Herring <robh@kernel.org> --- Please ack and I will take via the DT tree. This is dependent on the first 2 patches. arch/arm/mach-shmobile/pm-rcar-gen2.c | 8 ++------ arch/arm/mach-shmobile/pm-rmobile.c | 2 +- arch/arm/mach-shmobile/timer.c | 10 ++-------- 3 files changed, 5 insertions(+), 15 deletions(-) diff --git a/arch/arm/mach-shmobile/pm-rcar-gen2.c b/arch/arm/mach-shmobile/pm-rcar-gen2.c index 345af3ebcc3a..7efe95bd584f 100644 --- a/arch/arm/mach-shmobile/pm-rcar-gen2.c +++ b/arch/arm/mach-shmobile/pm-rcar-gen2.c @@ -50,7 +50,7 @@ void __init rcar_gen2_pm_init(void) void __iomem *p; u32 bar; static int once; - struct device_node *np, *cpus; + struct device_node *np; bool has_a7 = false; bool has_a15 = false; struct resource res; @@ -59,11 +59,7 @@ void __init rcar_gen2_pm_init(void) if (once++) return; - cpus = of_find_node_by_path("/cpus"); - if (!cpus) - return; - - for_each_child_of_node(cpus, np) { + for_each_of_cpu_node(np) { if (of_device_is_compatible(np, "arm,cortex-a15")) has_a15 = true; else if (of_device_is_compatible(np, "arm,cortex-a7")) diff --git a/arch/arm/mach-shmobile/pm-rmobile.c b/arch/arm/mach-shmobile/pm-rmobile.c index e348bcfe389d..94fdeef11b81 100644 --- a/arch/arm/mach-shmobile/pm-rmobile.c +++ b/arch/arm/mach-shmobile/pm-rmobile.c @@ -202,7 +202,7 @@ static void __init get_special_pds(void) const struct of_device_id *id; /* PM domains containing CPUs */ - for_each_node_by_type(np, "cpu") + for_each_of_cpu_node(np) add_special_pd(np, PD_CPU); /* PM domain containing console */ diff --git a/arch/arm/mach-shmobile/timer.c b/arch/arm/mach-shmobile/timer.c index 828e8aea037e..e48b0939693f 100644 --- a/arch/arm/mach-shmobile/timer.c +++ b/arch/arm/mach-shmobile/timer.c @@ -22,22 +22,16 @@ void __init shmobile_init_delay(void) { - struct device_node *np, *cpus; + struct device_node *np; u32 max_freq = 0; - cpus = of_find_node_by_path("/cpus"); - if (!cpus) - return; - - for_each_child_of_node(cpus, np) { + for_each_of_cpu_node(np) { u32 freq; if (!of_property_read_u32(np, "clock-frequency", &freq)) max_freq = max(max_freq, freq); } - of_node_put(cpus); - if (!max_freq) return; -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: robh@kernel.org (Rob Herring) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 05/21] ARM: shmobile: use for_each_of_cpu_node iterator Date: Wed, 5 Sep 2018 14:37:22 -0500 [thread overview] Message-ID: <20180905193738.19325-6-robh@kernel.org> (raw) In-Reply-To: <20180905193738.19325-1-robh@kernel.org> Use the for_each_of_cpu_node iterator to iterate over cpu nodes. This has the side effect of defaulting to iterating using "cpu" node names in preference to the deprecated (for FDT) device_type == "cpu". Cc: Simon Horman <horms@verge.net.au> Cc: Magnus Damm <magnus.damm@gmail.com> Cc: Russell King <linux@armlinux.org.uk> Cc: linux-arm-kernel at lists.infradead.org Cc: linux-renesas-soc at vger.kernel.org Signed-off-by: Rob Herring <robh@kernel.org> --- Please ack and I will take via the DT tree. This is dependent on the first 2 patches. arch/arm/mach-shmobile/pm-rcar-gen2.c | 8 ++------ arch/arm/mach-shmobile/pm-rmobile.c | 2 +- arch/arm/mach-shmobile/timer.c | 10 ++-------- 3 files changed, 5 insertions(+), 15 deletions(-) diff --git a/arch/arm/mach-shmobile/pm-rcar-gen2.c b/arch/arm/mach-shmobile/pm-rcar-gen2.c index 345af3ebcc3a..7efe95bd584f 100644 --- a/arch/arm/mach-shmobile/pm-rcar-gen2.c +++ b/arch/arm/mach-shmobile/pm-rcar-gen2.c @@ -50,7 +50,7 @@ void __init rcar_gen2_pm_init(void) void __iomem *p; u32 bar; static int once; - struct device_node *np, *cpus; + struct device_node *np; bool has_a7 = false; bool has_a15 = false; struct resource res; @@ -59,11 +59,7 @@ void __init rcar_gen2_pm_init(void) if (once++) return; - cpus = of_find_node_by_path("/cpus"); - if (!cpus) - return; - - for_each_child_of_node(cpus, np) { + for_each_of_cpu_node(np) { if (of_device_is_compatible(np, "arm,cortex-a15")) has_a15 = true; else if (of_device_is_compatible(np, "arm,cortex-a7")) diff --git a/arch/arm/mach-shmobile/pm-rmobile.c b/arch/arm/mach-shmobile/pm-rmobile.c index e348bcfe389d..94fdeef11b81 100644 --- a/arch/arm/mach-shmobile/pm-rmobile.c +++ b/arch/arm/mach-shmobile/pm-rmobile.c @@ -202,7 +202,7 @@ static void __init get_special_pds(void) const struct of_device_id *id; /* PM domains containing CPUs */ - for_each_node_by_type(np, "cpu") + for_each_of_cpu_node(np) add_special_pd(np, PD_CPU); /* PM domain containing console */ diff --git a/arch/arm/mach-shmobile/timer.c b/arch/arm/mach-shmobile/timer.c index 828e8aea037e..e48b0939693f 100644 --- a/arch/arm/mach-shmobile/timer.c +++ b/arch/arm/mach-shmobile/timer.c @@ -22,22 +22,16 @@ void __init shmobile_init_delay(void) { - struct device_node *np, *cpus; + struct device_node *np; u32 max_freq = 0; - cpus = of_find_node_by_path("/cpus"); - if (!cpus) - return; - - for_each_child_of_node(cpus, np) { + for_each_of_cpu_node(np) { u32 freq; if (!of_property_read_u32(np, "clock-frequency", &freq)) max_freq = max(max_freq, freq); } - of_node_put(cpus); - if (!max_freq) return; -- 2.17.1
next prev parent reply other threads:[~2018-09-05 19:37 UTC|newest] Thread overview: 97+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-09-05 19:37 [PATCH 00/21] DT cpu node iterator Rob Herring 2018-09-05 19:37 ` [OpenRISC] " Rob Herring 2018-09-05 19:37 ` Rob Herring 2018-09-05 19:37 ` Rob Herring 2018-09-05 19:37 ` Rob Herring 2018-09-05 19:37 ` Rob Herring 2018-09-05 19:37 ` Rob Herring 2018-09-05 19:37 ` [PATCH 01/21] of: Add cpu node iterator for_each_of_cpu_node() Rob Herring 2018-09-06 8:45 ` Geert Uytterhoeven 2018-09-06 8:45 ` Geert Uytterhoeven 2018-10-30 14:18 ` Michael Ellerman 2018-10-30 14:20 ` Michael Ellerman 2018-10-30 15:00 ` Rob Herring 2018-10-30 15:00 ` Rob Herring 2018-11-01 10:52 ` Michael Ellerman 2018-11-01 10:52 ` Michael Ellerman 2018-11-01 15:12 ` Segher Boessenkool 2018-11-01 15:12 ` Segher Boessenkool 2018-11-01 15:57 ` Rob Herring 2018-11-01 15:57 ` Rob Herring 2018-09-05 19:37 ` [PATCH 02/21] of: Support matching cpu nodes with no 'reg' property Rob Herring 2018-09-05 19:37 ` [PATCH 03/21] ARM: use for_each_of_cpu_node iterator Rob Herring 2018-09-05 19:37 ` Rob Herring 2018-09-05 19:37 ` [PATCH 04/21] ARM: topology: remove unneeded check for /cpus node Rob Herring 2018-09-05 19:37 ` Rob Herring 2018-09-05 19:37 ` Rob Herring [this message] 2018-09-05 19:37 ` [PATCH 05/21] ARM: shmobile: use for_each_of_cpu_node iterator Rob Herring 2018-09-06 8:52 ` Geert Uytterhoeven 2018-09-06 8:52 ` Geert Uytterhoeven 2018-09-06 8:52 ` Geert Uytterhoeven 2018-09-06 8:56 ` Simon Horman 2018-09-06 8:56 ` Simon Horman 2018-09-05 19:37 ` [PATCH 06/21] arm64: " Rob Herring 2018-09-05 19:37 ` Rob Herring 2018-09-06 10:04 ` Will Deacon 2018-09-06 10:04 ` Will Deacon 2018-09-05 19:37 ` [PATCH 07/21] c6x: " Rob Herring 2018-09-05 19:37 ` [PATCH 08/21] microblaze: get cpu node with of_get_cpu_node Rob Herring 2018-09-10 14:56 ` Michal Simek 2018-09-10 14:56 ` Michal Simek 2018-09-10 20:49 ` Rob Herring 2018-09-11 12:15 ` Michal Simek 2018-09-11 12:15 ` Michal Simek 2018-09-05 19:37 ` [PATCH 09/21] nios2: " Rob Herring 2018-09-05 19:37 ` [PATCH 10/21] openrisc: use for_each_of_cpu_node iterator Rob Herring 2018-09-05 19:37 ` [OpenRISC] " Rob Herring 2018-09-06 9:12 ` Stafford Horne 2018-09-06 9:12 ` [OpenRISC] " Stafford Horne 2018-09-05 19:37 ` [PATCH 11/21] powerpc: " Rob Herring 2018-09-05 19:37 ` [PATCH 12/21] powerpc: 4xx: get cpu node with of_get_cpu_node Rob Herring 2018-09-05 19:37 ` [PATCH 13/21] powerpc: 8xx: " Rob Herring 2018-09-05 19:37 ` [PATCH 14/21] riscv: use for_each_of_cpu_node iterator Rob Herring 2018-09-05 19:37 ` Rob Herring 2018-09-10 13:37 ` Christoph Hellwig 2018-09-10 13:37 ` Christoph Hellwig 2018-09-10 13:51 ` Rob Herring 2018-09-10 13:51 ` Rob Herring 2018-09-18 22:53 ` Palmer Dabbelt 2018-09-18 22:53 ` Palmer Dabbelt 2018-09-05 19:37 ` [PATCH 15/21] SH: " Rob Herring 2018-09-05 19:37 ` Rob Herring 2018-09-05 19:37 ` [PATCH 16/21] x86: DT: " Rob Herring 2018-09-06 8:15 ` Thomas Gleixner 2018-09-05 19:37 ` [PATCH 17/21] clk: mvebu: " Rob Herring 2018-09-06 1:47 ` Stephen Boyd 2018-09-06 1:47 ` Stephen Boyd 2018-09-05 19:37 ` [PATCH 18/21] edac: cpc925: " Rob Herring 2018-09-05 19:37 ` [18/21] " Rob Herring 2018-09-06 8:35 ` [PATCH 18/21] " Borislav Petkov 2018-09-06 8:35 ` [18/21] " Borislav Petkov 2018-09-06 11:12 ` [PATCH 18/21] " Rob Herring 2018-09-06 11:12 ` [18/21] " Rob Herring 2018-09-06 12:20 ` [PATCH 18/21] " Borislav Petkov 2018-09-06 12:20 ` [18/21] " Borislav Petkov 2018-09-05 19:37 ` [PATCH 19/21] iommu: fsl_pamu: " Rob Herring 2018-09-05 19:37 ` Rob Herring 2018-09-05 19:37 ` [PATCH 20/21] of: " Rob Herring 2018-10-31 12:46 ` NXP P50XX/e5500 secondary CPUs not onlined with current mainline (was [PATCH 20/21] of: use for_each_of_cpu_node iterator) Michael Ellerman 2018-10-31 14:25 ` Rob Herring 2018-11-01 10:55 ` Michael Ellerman 2018-11-01 10:55 ` Michael Ellerman 2018-09-05 19:37 ` [PATCH 21/21] fbdev: fsl-diu: get cpu node with of_get_cpu_node Rob Herring 2018-09-05 19:37 ` Rob Herring 2018-09-05 19:37 ` Rob Herring 2018-09-11 3:34 ` Timur Tabi 2018-09-11 3:34 ` Timur Tabi 2018-09-11 3:34 ` Timur Tabi [not found] ` <20180905193738.19325-1-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> 2018-09-07 12:54 ` [PATCH 00/21] DT cpu node iterator Michal Simek 2018-09-07 12:54 ` [OpenRISC] " Michal Simek 2018-09-07 12:54 ` Michal Simek 2018-09-07 13:58 ` Rob Herring 2018-09-07 13:58 ` [OpenRISC] " Rob Herring 2018-09-07 13:58 ` Rob Herring 2018-09-07 13:58 ` Rob Herring 2018-09-07 13:58 ` Rob Herring 2018-09-07 13:58 ` Rob Herring 2018-09-07 13:58 ` Rob Herring
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180905193738.19325-6-robh@kernel.org \ --to=robh@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=horms@verge.net.au \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=magnus.damm@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.