From: Christoph Hellwig <hch@lst.de>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: iommu@lists.linux-foundation.org,
Robin Murphy <robin.murphy@arm.com>,
Christoph Hellwig <hch@lst.de>,
linux-renesas-soc@vger.kernel.org,
Marek Szyprowski <m.szyprowski@samsung.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 2/3] dma-mapping: clear dma_ops pointer also on ARM
Date: Fri, 14 Sep 2018 15:12:04 +0200 [thread overview]
Message-ID: <20180914131204.GA27141@lst.de> (raw)
In-Reply-To: <20180913151716.6333-3-wsa+renesas@sang-engineering.com>
On Thu, Sep 13, 2018 at 05:17:15PM +0200, Wolfram Sang wrote:
> The generic fallback of arch_teardown_dma_ops() clears the dma_ops
> pointer but the ARM specific version does not. Rename the generic one,
> so it can be called from ARM specific one, too. This will ensure
> consistent behaviour.
Hmm. I'd rather remove your new generic version entirely and move
the ops clearing into the two callers.
WARNING: multiple messages have this Message-ID (diff)
From: hch@lst.de (Christoph Hellwig)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 2/3] dma-mapping: clear dma_ops pointer also on ARM
Date: Fri, 14 Sep 2018 15:12:04 +0200 [thread overview]
Message-ID: <20180914131204.GA27141@lst.de> (raw)
In-Reply-To: <20180913151716.6333-3-wsa+renesas@sang-engineering.com>
On Thu, Sep 13, 2018 at 05:17:15PM +0200, Wolfram Sang wrote:
> The generic fallback of arch_teardown_dma_ops() clears the dma_ops
> pointer but the ARM specific version does not. Rename the generic one,
> so it can be called from ARM specific one, too. This will ensure
> consistent behaviour.
Hmm. I'd rather remove your new generic version entirely and move
the ops clearing into the two callers.
next prev parent reply other threads:[~2018-09-14 13:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-13 15:17 [RFC PATCH 0/3] dma-mapping: clear dangling pointers consistently Wolfram Sang
2018-09-13 15:17 ` Wolfram Sang
2018-09-13 15:17 ` [RFC PATCH 1/3] ARM: dma-mapping: update comment about handling dma_ops when detaching from IOMMU Wolfram Sang
2018-09-13 15:17 ` Wolfram Sang
2018-09-14 12:15 ` Geert Uytterhoeven
2018-09-14 12:15 ` Geert Uytterhoeven
2018-09-14 16:11 ` Wolfram Sang
2018-09-14 16:11 ` Wolfram Sang
2018-09-14 16:11 ` Wolfram Sang
2018-09-13 15:17 ` [RFC PATCH 2/3] dma-mapping: clear dma_ops pointer also on ARM Wolfram Sang
2018-09-13 15:17 ` Wolfram Sang
2018-09-14 13:12 ` Christoph Hellwig [this message]
2018-09-14 13:12 ` Christoph Hellwig
2018-09-13 15:17 ` [RFC PATCH 3/3] dma-mapping: clear dma_parms on teardown, too Wolfram Sang
2018-09-13 15:17 ` Wolfram Sang
2018-09-14 13:12 ` Christoph Hellwig
2018-09-14 13:12 ` Christoph Hellwig
2018-09-14 13:23 ` Robin Murphy
2018-09-14 13:23 ` Robin Murphy
2018-09-14 15:57 ` Wolfram Sang
2018-09-14 15:57 ` Wolfram Sang
2018-09-14 15:57 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180914131204.GA27141@lst.de \
--to=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robin.murphy@arm.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.