From: Mark Brown <broonie@kernel.org>
To: Lubomir Rintel <lkundrak@v3.sk>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-spi@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH v2 1/5] dt-bindings: spi/spi-pxa2xx: add PXA2xx SSP SPI Controller
Date: Tue, 18 Sep 2018 10:43:03 -0700 [thread overview]
Message-ID: <20180918174303.GU2471@sirena.org.uk> (raw)
In-Reply-To: <54f5d070c8b0615baa26983e97e2a22401973096.camel@v3.sk>
[-- Attachment #1: Type: text/plain, Size: 709 bytes --]
On Tue, Sep 18, 2018 at 02:15:12PM +0200, Lubomir Rintel wrote:
> On Mon, 2018-09-17 at 10:57 -0700, Mark Brown wrote:
> > > Changes since v1:
> > > - s/ssp@d4035000/spi@d4035000/
> > As covered in SubmittingPatches please put inter-version changelogs
> > after the --- so they don't end up in the commits.
> Will do. I was actually not sure about that, so I took a short look at
> the git log, and it seemed to me that commit messages with the
> changelogs are quite common.
For various reasons the drm subsystem explicitly does the opposite
thing and it does leak out in other places (eg, when someone does it and
then it doesn't get fixed up), it's a bit unfortunate that there's some
divergence here.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/5] dt-bindings: spi/spi-pxa2xx: add PXA2xx SSP SPI Controller
Date: Tue, 18 Sep 2018 10:43:03 -0700 [thread overview]
Message-ID: <20180918174303.GU2471@sirena.org.uk> (raw)
In-Reply-To: <54f5d070c8b0615baa26983e97e2a22401973096.camel@v3.sk>
On Tue, Sep 18, 2018 at 02:15:12PM +0200, Lubomir Rintel wrote:
> On Mon, 2018-09-17 at 10:57 -0700, Mark Brown wrote:
> > > Changes since v1:
> > > - s/ssp at d4035000/spi at d4035000/
> > As covered in SubmittingPatches please put inter-version changelogs
> > after the --- so they don't end up in the commits.
> Will do. I was actually not sure about that, so I took a short look at
> the git log, and it seemed to me that commit messages with the
> changelogs are quite common.
For various reasons the drm subsystem explicitly does the opposite
thing and it does leak out in other places (eg, when someone does it and
then it doesn't get fixed up), it's a bit unfortunate that there's some
divergence here.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180918/067c4843/attachment.sig>
next prev parent reply other threads:[~2018-09-18 17:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-17 11:35 [PATCH v2 0/5] Make SPI work on DT MMP2 Lubomir Rintel
2018-09-17 11:35 ` Lubomir Rintel
2018-09-17 11:35 ` [PATCH v2 1/5] dt-bindings: spi/spi-pxa2xx: add PXA2xx SSP SPI Controller Lubomir Rintel
2018-09-17 11:35 ` Lubomir Rintel
2018-09-17 17:57 ` Mark Brown
2018-09-17 17:57 ` Mark Brown
2018-09-18 12:15 ` Lubomir Rintel
2018-09-18 12:15 ` Lubomir Rintel
2018-09-18 15:42 ` Mark Brown
2018-09-18 15:42 ` Mark Brown
2018-09-18 17:43 ` Mark Brown [this message]
2018-09-18 17:43 ` Mark Brown
2018-09-17 11:35 ` [PATCH v2 2/5] PCI: Provide pci_match_id() with CONFIG_PCI=n Lubomir Rintel
2018-09-17 11:35 ` Lubomir Rintel
2018-09-17 11:35 ` [PATCH v2 3/5] spi: pxa2xx: Use an enum for type Lubomir Rintel
2018-09-17 11:35 ` Lubomir Rintel
2018-09-17 11:35 ` [PATCH v2 4/5] spi: pxa2xx: Add devicetree support Lubomir Rintel
2018-09-17 11:35 ` Lubomir Rintel
2018-09-17 11:35 ` [PATCH v2 5/5] DT: marvell,mmp2: Add SSP1 and SSP3 Lubomir Rintel
2018-09-17 11:35 ` Lubomir Rintel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180918174303.GU2471@sirena.org.uk \
--to=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=lkundrak@v3.sk \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.