From: Rob Herring <robh@kernel.org>
To: Leilk Liu <leilk.liu@mediatek.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Sascha Hauer <s.hauer@pengutronix.de>,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
yt.shen@mediatek.com, Mark Brown <broonie@kernel.org>,
linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/3] spis: mediatek: add bindings for Mediatek MT2712 soc platform
Date: Wed, 26 Sep 2018 17:33:18 -0500 [thread overview]
Message-ID: <20180926223318.GA18703@bogus> (raw)
In-Reply-To: <1537150762-7072-2-git-send-email-leilk.liu@mediatek.com>
On Mon, Sep 17, 2018 at 10:19:20AM +0800, Leilk Liu wrote:
> This patch adds a DT binding documentation for the MT2712 soc.
>
> Signed-off-by: Leilk Liu <leilk.liu@mediatek.com>
> ---
> .../devicetree/bindings/spi/spi-slave-mt27xx.txt | 32 ++++++++++++++++++++
> 1 file changed, 32 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/spi/spi-slave-mt27xx.txt
>
> diff --git a/Documentation/devicetree/bindings/spi/spi-slave-mt27xx.txt b/Documentation/devicetree/bindings/spi/spi-slave-mt27xx.txt
> new file mode 100644
> index 0000000..09cb2c4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/spi/spi-slave-mt27xx.txt
> @@ -0,0 +1,32 @@
> +Binding for MTK SPI Slave controller
> +
> +Required properties:
> +- compatible: should be one of the following.
> + - mediatek,mt2712-spi-slave: for mt2712 platforms
> +- reg: Address and length of the register set for the device.
> +- interrupts: Should contain spi interrupt.
> +- clocks: phandles to input clocks.
> + It's clock gate, and should be <&infracfg CLK_INFRA_AO_SPI1>.
> +- clock-names: should be "spi" for the clock gate.
> +
> +Optional properties:
> +- assigned-clocks: it's mux clock, should be <&topckgen CLK_TOP_SPISLV_SEL>.
> +- assigned-clock-parents: parent of mux clock.
> + It's PLL, and should be on of the following.
s/on/one/
With that fixed,
Reviewed-by: Rob Herring <robh@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: robh@kernel.org (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/3] spis: mediatek: add bindings for Mediatek MT2712 soc platform
Date: Wed, 26 Sep 2018 17:33:18 -0500 [thread overview]
Message-ID: <20180926223318.GA18703@bogus> (raw)
In-Reply-To: <1537150762-7072-2-git-send-email-leilk.liu@mediatek.com>
On Mon, Sep 17, 2018 at 10:19:20AM +0800, Leilk Liu wrote:
> This patch adds a DT binding documentation for the MT2712 soc.
>
> Signed-off-by: Leilk Liu <leilk.liu@mediatek.com>
> ---
> .../devicetree/bindings/spi/spi-slave-mt27xx.txt | 32 ++++++++++++++++++++
> 1 file changed, 32 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/spi/spi-slave-mt27xx.txt
>
> diff --git a/Documentation/devicetree/bindings/spi/spi-slave-mt27xx.txt b/Documentation/devicetree/bindings/spi/spi-slave-mt27xx.txt
> new file mode 100644
> index 0000000..09cb2c4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/spi/spi-slave-mt27xx.txt
> @@ -0,0 +1,32 @@
> +Binding for MTK SPI Slave controller
> +
> +Required properties:
> +- compatible: should be one of the following.
> + - mediatek,mt2712-spi-slave: for mt2712 platforms
> +- reg: Address and length of the register set for the device.
> +- interrupts: Should contain spi interrupt.
> +- clocks: phandles to input clocks.
> + It's clock gate, and should be <&infracfg CLK_INFRA_AO_SPI1>.
> +- clock-names: should be "spi" for the clock gate.
> +
> +Optional properties:
> +- assigned-clocks: it's mux clock, should be <&topckgen CLK_TOP_SPISLV_SEL>.
> +- assigned-clock-parents: parent of mux clock.
> + It's PLL, and should be on of the following.
s/on/one/
With that fixed,
Reviewed-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2018-09-26 22:33 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-17 2:19 [PATCH v3 0/3] Add Mediatek SPI slave driver Leilk Liu
2018-09-17 2:19 ` Leilk Liu
2018-09-17 2:19 ` Leilk Liu
2018-09-17 2:19 ` Leilk Liu
2018-09-17 2:19 ` [PATCH v3 1/3] spis: mediatek: add bindings for Mediatek MT2712 soc platform Leilk Liu
2018-09-17 2:19 ` Leilk Liu
2018-09-17 2:19 ` Leilk Liu
2018-09-26 22:33 ` Rob Herring [this message]
2018-09-26 22:33 ` Rob Herring
2018-09-27 1:12 ` lei liu
2018-09-27 1:12 ` lei liu
2018-09-27 1:12 ` lei liu
2018-09-17 2:19 ` [PATCH v3 2/3] spis: mediatek: add spi slave for Mediatek MT2712 Leilk Liu
2018-09-17 2:19 ` Leilk Liu
2018-09-17 2:19 ` Leilk Liu
2018-09-18 16:30 ` Mark Brown
2018-09-18 16:30 ` Mark Brown
2018-09-19 5:50 ` lei liu
2018-09-19 5:50 ` lei liu
2018-09-19 5:50 ` lei liu
2018-09-17 2:19 ` [PATCH v3 3/3] arm64: dts: Add spi slave dts Leilk Liu
2018-09-17 2:19 ` Leilk Liu
2018-09-17 2:19 ` Leilk Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180926223318.GA18703@bogus \
--to=robh@kernel.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=leilk.liu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=s.hauer@pengutronix.de \
--cc=yt.shen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.