From: Borislav Petkov <bp@alien8.de>
To: James Morse <james.morse@arm.com>
Cc: jonathan.zhang@cavium.com, Rafael Wysocki <rjw@rjwysocki.net>,
Tony Luck <tony.luck@intel.com>,
linux-mm@kvack.org, Marc Zyngier <marc.zyngier@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Tyler Baicar <tbaicar@codeaurora.org>,
Will Deacon <will.deacon@arm.com>,
Dongjiu Geng <gengdongjiu@huawei.com>,
linux-acpi@vger.kernel.org, Punit Agrawal <punit.agrawal@arm.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org, Len Brown <lenb@kernel.org>
Subject: Re: [PATCH v6 05/18] ACPI / APEI: Make estatus queue a Kconfig symbol
Date: Mon, 1 Oct 2018 19:59:56 +0200 [thread overview]
Message-ID: <20181001175956.GF7269@zn.tnic> (raw)
In-Reply-To: <20180921221705.6478-6-james.morse@arm.com>
On Fri, Sep 21, 2018 at 11:16:52PM +0100, James Morse wrote:
> Now that there are two users of the estatus queue, and likely to be more,
> make it a Kconfig symbol selected by the appropriate notification. We
> can move the ARCH_HAVE_NMI_SAFE_CMPXCHG checks in here too.
Ok, question: why do we need to complicate things at all? I mean, why do
we even need a Kconfig symbol?
This code is being used by two arches now so why not simply build it in
unconditionally and be done with it. The couple of KB saved are simply
not worth the effort, especially if it is going to end up being enabled
on 99% of the setups...
Or?
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <bp@alien8.de>
To: James Morse <james.morse@arm.com>
Cc: linux-acpi@vger.kernel.org, kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org,
Marc Zyngier <marc.zyngier@arm.com>,
Christoffer Dall <christoffer.dall@arm.com>,
Will Deacon <will.deacon@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Rafael Wysocki <rjw@rjwysocki.net>, Len Brown <lenb@kernel.org>,
Tony Luck <tony.luck@intel.com>,
Tyler Baicar <tbaicar@codeaurora.org>,
Dongjiu Geng <gengdongjiu@huawei.com>,
Xie XiuQi <xiexiuqi@huawei.com>,
Punit Agrawal <punit.agrawal@arm.com>,
jonathan.zhang@cavium.com
Subject: Re: [PATCH v6 05/18] ACPI / APEI: Make estatus queue a Kconfig symbol
Date: Mon, 1 Oct 2018 19:59:56 +0200 [thread overview]
Message-ID: <20181001175956.GF7269@zn.tnic> (raw)
In-Reply-To: <20180921221705.6478-6-james.morse@arm.com>
On Fri, Sep 21, 2018 at 11:16:52PM +0100, James Morse wrote:
> Now that there are two users of the estatus queue, and likely to be more,
> make it a Kconfig symbol selected by the appropriate notification. We
> can move the ARCH_HAVE_NMI_SAFE_CMPXCHG checks in here too.
Ok, question: why do we need to complicate things at all? I mean, why do
we even need a Kconfig symbol?
This code is being used by two arches now so why not simply build it in
unconditionally and be done with it. The couple of KB saved are simply
not worth the effort, especially if it is going to end up being enabled
on 99% of the setups...
Or?
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
WARNING: multiple messages have this Message-ID (diff)
From: bp@alien8.de (Borislav Petkov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 05/18] ACPI / APEI: Make estatus queue a Kconfig symbol
Date: Mon, 1 Oct 2018 19:59:56 +0200 [thread overview]
Message-ID: <20181001175956.GF7269@zn.tnic> (raw)
In-Reply-To: <20180921221705.6478-6-james.morse@arm.com>
On Fri, Sep 21, 2018 at 11:16:52PM +0100, James Morse wrote:
> Now that there are two users of the estatus queue, and likely to be more,
> make it a Kconfig symbol selected by the appropriate notification. We
> can move the ARCH_HAVE_NMI_SAFE_CMPXCHG checks in here too.
Ok, question: why do we need to complicate things at all? I mean, why do
we even need a Kconfig symbol?
This code is being used by two arches now so why not simply build it in
unconditionally and be done with it. The couple of KB saved are simply
not worth the effort, especially if it is going to end up being enabled
on 99% of the setups...
Or?
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2018-10-01 17:59 UTC|newest]
Thread overview: 123+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-21 22:16 [PATCH v6 00/18] APEI in_nmi() rework James Morse
2018-09-21 22:16 ` James Morse
2018-09-21 22:16 ` James Morse
2018-09-21 22:16 ` [PATCH v6 01/18] ACPI / APEI: Move the estatus queue code up, and under its own ifdef James Morse
2018-09-21 22:16 ` James Morse
2018-09-21 22:16 ` James Morse
2018-09-21 22:16 ` [PATCH v6 02/18] ACPI / APEI: Generalise the estatus queue's add/remove and notify code James Morse
2018-09-21 22:16 ` James Morse
2018-09-21 22:16 ` James Morse
2018-09-21 22:16 ` [PATCH v6 03/18] ACPI / APEI: don't wait to serialise with oops messages when panic()ing James Morse
2018-09-21 22:16 ` James Morse
2018-09-21 22:16 ` James Morse
2018-09-21 22:16 ` [PATCH v6 04/18] ACPI / APEI: Switch NOTIFY_SEA to use the estatus queue James Morse
2018-09-21 22:16 ` James Morse
2018-09-21 22:16 ` James Morse
2018-09-28 17:04 ` Borislav Petkov
2018-09-28 17:04 ` Borislav Petkov
2018-09-28 17:04 ` Borislav Petkov
2018-09-21 22:16 ` [PATCH v6 05/18] ACPI / APEI: Make estatus queue a Kconfig symbol James Morse
2018-09-21 22:16 ` James Morse
2018-09-21 22:16 ` James Morse
2018-10-01 17:59 ` Borislav Petkov [this message]
2018-10-01 17:59 ` Borislav Petkov
2018-10-01 17:59 ` Borislav Petkov
2018-10-03 17:50 ` James Morse
2018-10-03 17:50 ` James Morse
2018-10-03 17:50 ` James Morse
2018-10-04 17:34 ` Borislav Petkov
2018-10-04 17:34 ` Borislav Petkov
2018-10-04 17:34 ` Borislav Petkov
2018-10-12 17:17 ` James Morse
2018-10-12 17:17 ` James Morse
2018-10-12 17:17 ` James Morse
2018-10-12 18:10 ` Borislav Petkov
2018-10-12 18:10 ` Borislav Petkov
2018-10-12 18:10 ` Borislav Petkov
2018-09-21 22:16 ` [PATCH v6 06/18] KVM: arm/arm64: Add kvm_ras.h to collect kvm specific RAS plumbing James Morse
2018-09-21 22:16 ` James Morse
2018-09-21 22:16 ` James Morse
2018-10-12 9:57 ` Borislav Petkov
2018-10-12 9:57 ` Borislav Petkov
2018-10-12 9:57 ` Borislav Petkov
2018-10-12 17:18 ` James Morse
2018-10-12 17:18 ` James Morse
2018-10-12 17:18 ` James Morse
2018-09-21 22:16 ` [PATCH v6 07/18] arm64: KVM/mm: Move SEA handling behind a single 'claim' interface James Morse
2018-09-21 22:16 ` James Morse
2018-09-21 22:16 ` James Morse
2018-10-12 10:02 ` Borislav Petkov
2018-10-12 10:02 ` Borislav Petkov
2018-10-12 10:02 ` Borislav Petkov
2018-10-12 17:18 ` James Morse
2018-10-12 17:18 ` James Morse
2018-10-12 17:18 ` James Morse
2018-09-21 22:16 ` [PATCH v6 08/18] ACPI / APEI: Move locking to the notification helper James Morse
2018-09-21 22:16 ` James Morse
2018-09-21 22:16 ` James Morse
2018-10-12 11:08 ` Borislav Petkov
2018-10-12 11:08 ` Borislav Petkov
2018-10-12 11:08 ` Borislav Petkov
2018-09-21 22:16 ` [PATCH v6 09/18] ACPI / APEI: Let the notification helper specify the fixmap slot James Morse
2018-09-21 22:16 ` James Morse
2018-09-21 22:16 ` James Morse
2018-10-12 11:14 ` Borislav Petkov
2018-10-12 11:14 ` Borislav Petkov
2018-10-12 11:14 ` Borislav Petkov
2018-09-21 22:16 ` [PATCH v6 10/18] ACPI / APEI: preparatory split of ghes->estatus James Morse
2018-09-21 22:16 ` James Morse
2018-09-21 22:16 ` James Morse
2018-10-12 16:37 ` Borislav Petkov
2018-10-12 16:37 ` Borislav Petkov
2018-10-12 16:37 ` Borislav Petkov
2018-09-21 22:16 ` [PATCH v6 11/18] ACPI / APEI: Remove silent flag from ghes_read_estatus() James Morse
2018-09-21 22:16 ` James Morse
2018-09-21 22:16 ` James Morse
2018-10-12 16:55 ` Borislav Petkov
2018-10-12 16:55 ` Borislav Petkov
2018-10-12 16:55 ` Borislav Petkov
2018-09-21 22:16 ` [PATCH v6 12/18] ACPI / APEI: Don't store CPER records physical address in struct ghes James Morse
2018-09-21 22:16 ` James Morse
2018-09-21 22:16 ` James Morse
2018-09-21 22:17 ` [PATCH v6 13/18] ACPI / APEI: Don't update struct ghes' flags in read/clear estatus James Morse
2018-09-21 22:17 ` James Morse
2018-09-21 22:17 ` James Morse
2018-10-12 17:14 ` Borislav Petkov
2018-10-12 17:14 ` Borislav Petkov
2018-10-12 17:14 ` Borislav Petkov
2018-09-21 22:17 ` [PATCH v6 14/18] ACPI / APEI: Split ghes_read_estatus() to read CPER length James Morse
2018-09-21 22:17 ` James Morse
2018-09-21 22:17 ` James Morse
2018-10-12 17:25 ` Borislav Petkov
2018-10-12 17:25 ` Borislav Petkov
2018-10-12 17:25 ` Borislav Petkov
2018-09-21 22:17 ` [PATCH v6 15/18] ACPI / APEI: Only use queued estatus entry during _in_nmi_notify_one() James Morse
2018-09-21 22:17 ` James Morse
2018-09-21 22:17 ` James Morse
2018-10-12 17:34 ` Borislav Petkov
2018-10-12 17:34 ` Borislav Petkov
2018-10-12 17:34 ` Borislav Petkov
2018-09-21 22:17 ` [PATCH v6 16/18] ACPI / APEI: Split fixmap pages for arm64 NMI-like notifications James Morse
2018-09-21 22:17 ` James Morse
2018-09-21 22:17 ` James Morse
2018-09-21 22:17 ` [PATCH v6 17/18] mm/memory-failure: increase queued recovery work's priority James Morse
2018-09-21 22:17 ` James Morse
2018-09-21 22:17 ` James Morse
2018-10-15 16:49 ` Borislav Petkov
2018-10-15 16:49 ` Borislav Petkov
2018-10-15 16:49 ` Borislav Petkov
2018-10-16 7:43 ` Peter Zijlstra
2018-10-16 7:43 ` Peter Zijlstra
2018-10-16 7:43 ` Peter Zijlstra
2018-09-21 22:17 ` [PATCH v6 18/18] arm64: acpi: Make apei_claim_sea() synchronise with APEI's irq work James Morse
2018-09-21 22:17 ` James Morse
2018-09-21 22:17 ` James Morse
2018-09-25 12:45 ` [PATCH v6 00/18] APEI in_nmi() rework Borislav Petkov
2018-09-25 12:45 ` Borislav Petkov
2018-09-25 12:45 ` Borislav Petkov
2018-10-03 17:50 ` James Morse
2018-10-03 17:50 ` James Morse
2018-10-03 17:50 ` James Morse
2018-10-04 15:15 ` Borislav Petkov
2018-10-04 15:15 ` Borislav Petkov
2018-10-04 15:15 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181001175956.GF7269@zn.tnic \
--to=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=gengdongjiu@huawei.com \
--cc=james.morse@arm.com \
--cc=jonathan.zhang@cavium.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mm@kvack.org \
--cc=marc.zyngier@arm.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=punit.agrawal@arm.com \
--cc=rjw@rjwysocki.net \
--cc=tbaicar@codeaurora.org \
--cc=tony.luck@intel.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.