All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: "Vokáč Michal" <Michal.Vokac@ysoft.com>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Fabio Estevam <fabio.estevam@nxp.com>,
	Rob Herring <robh+dt@kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>
Subject: Re: [RESEND PATCH v2 3/3] ARM: dts: imx28-cfa10036: Fix the reset gpio signal polarity
Date: Tue, 9 Oct 2018 08:20:33 +0800	[thread overview]
Message-ID: <20181009002031.GU3587@dragon> (raw)
In-Reply-To: <68f4da21-6f0d-5bf9-b352-cdc423269080@ysoft.com>

On Mon, Oct 08, 2018 at 11:45:36AM +0000, Vokáč Michal wrote:
> On 27.9.2018 11:24, Michal Vokáč wrote:
> > The reset signal of the SSD1306 OLED display is actually active-low.
> > Adapt the DT to reflect the real world.
> > 
> > Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com>
> > ---
> > v2 changes: New patch in the series
> 
> Bartlomiej just queued the first two patches for v4.20.
> Will somebody take this one? Otherwise this SoM will end up with
> broken OLED display reset.

Well, it means the change breaks the ABI between kernel and device tree,
e.g. the new kernel will not work with existing/installed DTBs.

Shawn

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: "Vokáč Michal" <Michal.Vokac@ysoft.com>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Fabio Estevam <fabio.estevam@nxp.com>,
	Rob Herring <robh+dt@kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>
Subject: Re: [RESEND PATCH v2 3/3] ARM: dts: imx28-cfa10036: Fix the reset gpio signal polarity
Date: Tue, 09 Oct 2018 00:20:33 +0000	[thread overview]
Message-ID: <20181009002031.GU3587@dragon> (raw)
In-Reply-To: <68f4da21-6f0d-5bf9-b352-cdc423269080@ysoft.com>

On Mon, Oct 08, 2018 at 11:45:36AM +0000, Vokáč Michal wrote:
> On 27.9.2018 11:24, Michal Vokáč wrote:
> > The reset signal of the SSD1306 OLED display is actually active-low.
> > Adapt the DT to reflect the real world.
> > 
> > Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com>
> > ---
> > v2 changes: New patch in the series
> 
> Bartlomiej just queued the first two patches for v4.20.
> Will somebody take this one? Otherwise this SoM will end up with
> broken OLED display reset.

Well, it means the change breaks the ABI between kernel and device tree,
e.g. the new kernel will not work with existing/installed DTBs.

Shawn

  reply	other threads:[~2018-10-09  0:20 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20180927092738epcas5p28c53516b73fe7747133914f40c84d6c4@epcas5p2.samsung.com>
2018-09-27  9:24 ` [RESEND PATCH v2 1/3] video: ssd1307fb: Use gpiod_set_value_cansleep() for reset Michal Vokáč
2018-09-27  9:24   ` Michal Vokáč
2018-09-27  9:24   ` [RESEND PATCH v2 2/3] video: ssd1307fb: Do not hard code active-low reset sequence Michal Vokáč
2018-09-27  9:24     ` Michal Vokáč
2018-10-08 10:53     ` Bartlomiej Zolnierkiewicz
2018-10-08 10:53       ` Bartlomiej Zolnierkiewicz
2018-09-27  9:24   ` [RESEND PATCH v2 3/3] ARM: dts: imx28-cfa10036: Fix the reset gpio signal polarity Michal Vokáč
2018-09-27  9:24     ` Michal Vokáč
2018-10-08 11:45     ` Vokáč Michal
2018-10-08 11:45       ` Vokáč Michal
2018-10-09  0:20       ` Shawn Guo [this message]
2018-10-09  0:20         ` Shawn Guo
2018-10-09  7:51         ` Bartlomiej Zolnierkiewicz
2018-10-09  7:51           ` Bartlomiej Zolnierkiewicz
2018-10-09  8:29           ` Vokáč Michal
2018-10-09  8:29             ` Vokáč Michal
2018-10-09 12:36             ` Fabio Estevam
2018-10-09 12:36               ` Fabio Estevam
2018-10-09 12:36               ` Fabio Estevam
2018-10-09 13:18               ` Vokáč Michal
2018-10-09 13:18                 ` Vokáč Michal
2018-10-09 13:18                 ` Vokáč Michal
2018-10-09 13:30                 ` Bartlomiej Zolnierkiewicz
2018-10-09 13:30                   ` Bartlomiej Zolnierkiewicz
2018-10-09 13:30                   ` Bartlomiej Zolnierkiewicz
2018-10-08 10:53   ` [RESEND PATCH v2 1/3] video: ssd1307fb: Use gpiod_set_value_cansleep() for reset Bartlomiej Zolnierkiewicz
2018-10-08 10:53     ` Bartlomiej Zolnierkiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181009002031.GU3587@dragon \
    --to=shawnguo@kernel.org \
    --cc=Michal.Vokac@ysoft.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fabio.estevam@nxp.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.