From: Christoph Hellwig <hch@lst.de> To: Damien Le Moal <damien.lemoal@wdc.com> Cc: linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>, linux-scsi@vger.kernel.org, "Martin K . Petersen" <martin.petersen@oracle.com>, dm-devel@redhat.com, Mike Snitzer <snitzer@redhat.com>, Christoph Hellwig <hch@lst.de>, Matias Bjorling <matias.bjorling@wdc.com> Subject: Re: [PATCH 11/11] block: Introduce revalidate_disk_zones() Date: Wed, 10 Oct 2018 15:34:31 +0200 [thread overview] Message-ID: <20181010133431.GJ22273@lst.de> (raw) In-Reply-To: <20181010015239.24930-12-damien.lemoal@wdc.com> > +static inline unsigned long *__alloc_zone_bitmap(int node, > + unsigned int nr_zones) > +{ > + return kcalloc_node(BITS_TO_LONGS(nr_zones), sizeof(unsigned long), > + GFP_NOIO | __GFP_ZERO, node); kcalloc already implies GFP_NOIO. > +/* > + * Allocate an array of struct blk_zone to get nr_zones zone information. > + * The allocated array may be smaller than nr_zones. > + */ > +static struct blk_zone *__alloc_zones(int node, unsigned int *nr_zones) Any reason to have the __ prefix for these two functions? A blk_ one would seem more sensible. > +/** > + * revalidate_disk_zones - (re)allocate and initialize zone bitmaps > + * @disk: Target disk > + * > + * Description: > + * Helper function for low-level device drivers to (re) allocate and > + * initialize a disk request queue zone bitmaps. This functions should > + * normally be called within the disk ->revalidate method. > + * For BIO based queues, no zone bitmap is allocated. > + */ > +int revalidate_disk_zones(struct gendisk *disk) Add a blk_ prefix? Also no need for the Description: header in the kerneldoc comment.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de> To: Damien Le Moal <damien.lemoal@wdc.com> Cc: Jens Axboe <axboe@kernel.dk>, "Martin K . Petersen" <martin.petersen@oracle.com>, Mike Snitzer <snitzer@redhat.com>, linux-block@vger.kernel.org, dm-devel@redhat.com, linux-scsi@vger.kernel.org, Christoph Hellwig <hch@lst.de>, Matias Bjorling <matias.bjorling@wdc.com> Subject: Re: [PATCH 11/11] block: Introduce revalidate_disk_zones() Date: Wed, 10 Oct 2018 15:34:31 +0200 [thread overview] Message-ID: <20181010133431.GJ22273@lst.de> (raw) In-Reply-To: <20181010015239.24930-12-damien.lemoal@wdc.com> > +static inline unsigned long *__alloc_zone_bitmap(int node, > + unsigned int nr_zones) > +{ > + return kcalloc_node(BITS_TO_LONGS(nr_zones), sizeof(unsigned long), > + GFP_NOIO | __GFP_ZERO, node); kcalloc already implies GFP_NOIO. > +/* > + * Allocate an array of struct blk_zone to get nr_zones zone information. > + * The allocated array may be smaller than nr_zones. > + */ > +static struct blk_zone *__alloc_zones(int node, unsigned int *nr_zones) Any reason to have the __ prefix for these two functions? A blk_ one would seem more sensible. > +/** > + * revalidate_disk_zones - (re)allocate and initialize zone bitmaps > + * @disk: Target disk > + * > + * Description: > + * Helper function for low-level device drivers to (re) allocate and > + * initialize a disk request queue zone bitmaps. This functions should > + * normally be called within the disk ->revalidate method. > + * For BIO based queues, no zone bitmap is allocated. > + */ > +int revalidate_disk_zones(struct gendisk *disk) Add a blk_ prefix? Also no need for the Description: header in the kerneldoc comment.
next prev parent reply other threads:[~2018-10-10 13:34 UTC|newest] Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-10-10 1:52 [PATCH 00/11] Zoned block device support improvements Damien Le Moal 2018-10-10 1:52 ` [PATCH 01/11] scsi: sd_zbc: Rearrange code Damien Le Moal 2018-10-10 13:25 ` Christoph Hellwig 2018-10-10 13:25 ` Christoph Hellwig 2018-10-10 1:52 ` [PATCH 02/11] scsi: sd_zbc: Reduce boot device scan and revalidate time Damien Le Moal 2018-10-10 13:26 ` Christoph Hellwig 2018-10-10 13:26 ` Christoph Hellwig 2018-10-10 1:52 ` [PATCH 03/11] scsi: sd_zbc: Fix sd_zbc_check_zones() error checks Damien Le Moal 2018-10-10 13:26 ` Christoph Hellwig 2018-10-10 13:26 ` Christoph Hellwig 2018-10-10 1:52 ` [PATCH 04/11] block: Introduce blkdev_nr_zones() helper Damien Le Moal 2018-10-10 13:26 ` Christoph Hellwig 2018-10-10 13:26 ` Christoph Hellwig 2018-10-10 1:52 ` [PATCH 05/11] block: Limit allocation of zone descriptors for report zones Damien Le Moal 2018-10-10 13:27 ` Christoph Hellwig 2018-10-10 13:27 ` Christoph Hellwig 2018-10-10 1:52 ` [PATCH 06/11] block: Introduce BLKGETZONESZ ioctl Damien Le Moal 2018-10-10 13:27 ` Christoph Hellwig 2018-10-10 13:27 ` Christoph Hellwig 2018-10-10 16:53 ` [dm-devel] " Bart Van Assche 2018-10-10 16:53 ` Bart Van Assche 2018-10-10 16:53 ` Bart Van Assche 2018-10-10 1:52 ` [PATCH 07/11] block: Introduce BLKGETNRZONES ioctl Damien Le Moal 2018-10-10 13:27 ` Christoph Hellwig 2018-10-10 13:27 ` Christoph Hellwig 2018-10-10 1:52 ` [PATCH 08/11] block: Improve zone reset execution Damien Le Moal 2018-10-10 13:28 ` Christoph Hellwig 2018-10-10 13:28 ` Christoph Hellwig 2018-10-10 1:52 ` [PATCH 09/11] block: Expose queue nr_zones in sysfs Damien Le Moal 2018-10-10 13:28 ` Christoph Hellwig 2018-10-10 13:28 ` Christoph Hellwig 2018-10-10 14:05 ` kbuild test robot 2018-10-10 14:05 ` kbuild test robot 2018-10-10 18:44 ` kbuild test robot 2018-10-10 18:44 ` kbuild test robot 2018-10-10 1:52 ` [PATCH 10/11] block: add a report_zones method Damien Le Moal 2018-10-10 14:15 ` Mike Snitzer 2018-10-10 14:15 ` Mike Snitzer 2018-10-10 16:15 ` Mike Snitzer 2018-10-10 16:15 ` Mike Snitzer 2018-10-10 14:40 ` kbuild test robot 2018-10-10 14:40 ` kbuild test robot 2018-10-10 15:34 ` Mike Snitzer 2018-10-10 15:34 ` Mike Snitzer 2018-10-10 16:25 ` kbuild test robot 2018-10-10 16:25 ` kbuild test robot 2018-10-10 1:52 ` [PATCH 11/11] block: Introduce revalidate_disk_zones() Damien Le Moal 2018-10-10 13:34 ` Christoph Hellwig [this message] 2018-10-10 13:34 ` Christoph Hellwig
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181010133431.GJ22273@lst.de \ --to=hch@lst.de \ --cc=axboe@kernel.dk \ --cc=damien.lemoal@wdc.com \ --cc=dm-devel@redhat.com \ --cc=linux-block@vger.kernel.org \ --cc=linux-scsi@vger.kernel.org \ --cc=martin.petersen@oracle.com \ --cc=matias.bjorling@wdc.com \ --cc=snitzer@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.