From: Andrew Morton <akpm@linux-foundation.org>
To: John Hubbard <jhubbard@nvidia.com>
Cc: Jan Kara <jack@suse.cz>,
john.hubbard@gmail.com, Matthew Wilcox <willy@infradead.org>,
Michal Hocko <mhocko@kernel.org>,
Christopher Lameter <cl@linux.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
Dan Williams <dan.j.williams@intel.com>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>,
linux-rdma <linux-rdma@vger.kernel.org>,
linux-fsdevel@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>,
Jerome Glisse <jglisse@redhat.com>,
Christoph Hellwig <hch@infradead.org>,
Ralph Campbell <rcampbell@nvidia.com>
Subject: Re: [PATCH v4 2/3] mm: introduce put_user_page*(), placeholder versions
Date: Wed, 10 Oct 2018 16:43:59 -0700 [thread overview]
Message-ID: <20181010164359.292d938b51cbd57b38a1bd99@linux-foundation.org> (raw)
In-Reply-To: <62492f47-d51f-5c41-628c-ff17de21829e@nvidia.com>
On Tue, 9 Oct 2018 17:32:16 -0700 John Hubbard <jhubbard@nvidia.com> wrote:
> > I'm not really understanding. Patch 3/3 changes just one infiniband
> > driver to use put_user_page(). But the changelogs here imply (to me)
> > that every user of get_user_pages() needs to be converted to
> > s/put_page/put_user_page/.
> >
> > Methinks a bit more explanation is needed in these changelogs?
> >
>
> OK, yes, it does sound like the explanation is falling short. I'll work on something
> clearer. Did the proposed steps in the changelogs, such as:
>
> [2] https://lkml.kernel.org/r/20180709080554.21931-1-jhubbard@nvidia.com
> Proposed steps for fixing get_user_pages() + DMA problems.
>
> help at all, or is it just too many references, and I should write the words
> directly in the changelog?
>
> Anyway, patch 3/3 is a just a working example (which we do want to submit, though), and
> many more conversions will follow. But they don't have to be done all upfront--they
> can be done in follow up patchsets.
>
> The put_user_page*() routines are, at this point, not going to significantly change
> behavior.
>
> I'm working on an RFC that will show what the long-term fix to get_user_pages and
> put_user_pages will look like. But meanwhile it's good to get started on converting
> all of the call sites.
I see. Yes, please do put all of it into the changelog[s].
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: John Hubbard <jhubbard@nvidia.com>
Cc: Jan Kara <jack@suse.cz>, <john.hubbard@gmail.com>,
Matthew Wilcox <willy@infradead.org>,
Michal Hocko <mhocko@kernel.org>,
Christopher Lameter <cl@linux.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
Dan Williams <dan.j.williams@intel.com>, <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-rdma <linux-rdma@vger.kernel.org>,
<linux-fsdevel@vger.kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Jerome Glisse <jglisse@redhat.com>,
Christoph Hellwig <hch@infradead.org>,
Ralph Campbell <rcampbell@nvidia.com>
Subject: Re: [PATCH v4 2/3] mm: introduce put_user_page*(), placeholder versions
Date: Wed, 10 Oct 2018 16:43:59 -0700 [thread overview]
Message-ID: <20181010164359.292d938b51cbd57b38a1bd99@linux-foundation.org> (raw)
In-Reply-To: <62492f47-d51f-5c41-628c-ff17de21829e@nvidia.com>
On Tue, 9 Oct 2018 17:32:16 -0700 John Hubbard <jhubbard@nvidia.com> wrote:
> > I'm not really understanding. Patch 3/3 changes just one infiniband
> > driver to use put_user_page(). But the changelogs here imply (to me)
> > that every user of get_user_pages() needs to be converted to
> > s/put_page/put_user_page/.
> >
> > Methinks a bit more explanation is needed in these changelogs?
> >
>
> OK, yes, it does sound like the explanation is falling short. I'll work on something
> clearer. Did the proposed steps in the changelogs, such as:
>
> [2] https://lkml.kernel.org/r/20180709080554.21931-1-jhubbard@nvidia.com
> Proposed steps for fixing get_user_pages() + DMA problems.
>
> help at all, or is it just too many references, and I should write the words
> directly in the changelog?
>
> Anyway, patch 3/3 is a just a working example (which we do want to submit, though), and
> many more conversions will follow. But they don't have to be done all upfront--they
> can be done in follow up patchsets.
>
> The put_user_page*() routines are, at this point, not going to significantly change
> behavior.
>
> I'm working on an RFC that will show what the long-term fix to get_user_pages and
> put_user_pages will look like. But meanwhile it's good to get started on converting
> all of the call sites.
I see. Yes, please do put all of it into the changelog[s].
next prev parent reply other threads:[~2018-10-10 23:43 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-08 21:16 [PATCH v4 0/3] get_user_pages*() and RDMA: first steps john.hubbard
2018-10-08 21:16 ` [PATCH v4 1/3] mm: get_user_pages: consolidate error handling john.hubbard
2018-10-09 0:05 ` Andrew Morton
2018-10-08 21:16 ` [PATCH v4 2/3] mm: introduce put_user_page*(), placeholder versions john.hubbard
2018-10-09 0:14 ` Andrew Morton
2018-10-09 8:30 ` Jan Kara
2018-10-09 23:20 ` Andrew Morton
2018-10-10 0:32 ` John Hubbard
2018-10-10 0:32 ` John Hubbard
2018-10-10 23:43 ` Andrew Morton [this message]
2018-10-10 23:43 ` Andrew Morton
2018-10-10 0:42 ` John Hubbard
2018-10-10 0:42 ` John Hubbard
2018-10-10 8:59 ` Jan Kara
2018-10-10 23:23 ` John Hubbard
2018-10-10 23:23 ` John Hubbard
2018-10-11 8:42 ` Jan Kara
2018-10-10 23:45 ` Andrew Morton
2018-10-10 23:45 ` Andrew Morton
2018-10-11 8:49 ` Jan Kara
2018-10-11 13:20 ` Jason Gunthorpe
2018-10-12 1:23 ` John Hubbard
2018-10-12 1:23 ` John Hubbard
2018-10-12 3:53 ` John Hubbard
2018-10-12 3:53 ` John Hubbard
2018-10-18 10:19 ` Jan Kara
2018-11-05 7:25 ` John Hubbard
2018-11-05 7:25 ` John Hubbard
2018-10-22 19:43 ` Jason Gunthorpe
2018-11-05 7:17 ` John Hubbard
2018-11-05 7:17 ` John Hubbard
2018-11-05 8:37 ` Jan Kara
2018-10-08 21:16 ` [PATCH v4 3/3] infiniband/mm: convert put_page() to put_user_page*() john.hubbard
2018-10-09 9:52 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181010164359.292d938b51cbd57b38a1bd99@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=dan.j.williams@intel.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=jgg@ziepe.ca \
--cc=jglisse@redhat.com \
--cc=jhubbard@nvidia.com \
--cc=john.hubbard@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mhocko@kernel.org \
--cc=rcampbell@nvidia.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.