From: Mark Brown <broonie@kernel.org>
To: Olivier Moysan <olivier.moysan@st.com>
Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
mcoquelin.stm32@gmail.com, alexandre.torgue@st.com,
alsa-devel@alsa-project.org,
linux-arm-kernel@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-kernel@vger.kernel.org, arnaud.pouliquen@st.com,
benjamin.gaignard@st.com
Subject: Re: [PATCH 1/1] ASoC: cs42l51: fix mclk support
Date: Fri, 19 Oct 2018 17:06:22 +0100 [thread overview]
Message-ID: <20181019160622.GO5895@sirena.org.uk> (raw)
In-Reply-To: <1539964595-23758-1-git-send-email-olivier.moysan@st.com>
[-- Attachment #1: Type: text/plain, Size: 591 bytes --]
On Fri, Oct 19, 2018 at 05:56:35PM +0200, Olivier Moysan wrote:
> Fixes: 5e8d63a726f8 ("ASoC: cs42l51: add mclk support")
>
> The MCLK clock is made optional for cs42l51 codec.
> However, ASoC DAPM clock supply widget, expects the clock to be defined
> unconditionally.
> Register MCLK DAPM conditionally in codec driver,
> depending on clock presence in DT.
I've applied this but TBH I think we should be doing this in the core -
I actually thought we had handling for that but I can't see it so I'm
obviously imagining things. It's something that can be done later
anyway.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Olivier Moysan <olivier.moysan@st.com>
Cc: alsa-devel@alsa-project.org, alexandre.torgue@st.com,
linux-kernel@vger.kernel.org, arnaud.pouliquen@st.com,
tiwai@suse.com, lgirdwood@gmail.com, mcoquelin.stm32@gmail.com,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org, benjamin.gaignard@st.com
Subject: Re: [PATCH 1/1] ASoC: cs42l51: fix mclk support
Date: Fri, 19 Oct 2018 17:06:22 +0100 [thread overview]
Message-ID: <20181019160622.GO5895@sirena.org.uk> (raw)
In-Reply-To: <1539964595-23758-1-git-send-email-olivier.moysan@st.com>
[-- Attachment #1.1: Type: text/plain, Size: 591 bytes --]
On Fri, Oct 19, 2018 at 05:56:35PM +0200, Olivier Moysan wrote:
> Fixes: 5e8d63a726f8 ("ASoC: cs42l51: add mclk support")
>
> The MCLK clock is made optional for cs42l51 codec.
> However, ASoC DAPM clock supply widget, expects the clock to be defined
> unconditionally.
> Register MCLK DAPM conditionally in codec driver,
> depending on clock presence in DT.
I've applied this but TBH I think we should be doing this in the core -
I actually thought we had handling for that but I can't see it so I'm
obviously imagining things. It's something that can be done later
anyway.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] ASoC: cs42l51: fix mclk support
Date: Fri, 19 Oct 2018 17:06:22 +0100 [thread overview]
Message-ID: <20181019160622.GO5895@sirena.org.uk> (raw)
In-Reply-To: <1539964595-23758-1-git-send-email-olivier.moysan@st.com>
On Fri, Oct 19, 2018 at 05:56:35PM +0200, Olivier Moysan wrote:
> Fixes: 5e8d63a726f8 ("ASoC: cs42l51: add mclk support")
>
> The MCLK clock is made optional for cs42l51 codec.
> However, ASoC DAPM clock supply widget, expects the clock to be defined
> unconditionally.
> Register MCLK DAPM conditionally in codec driver,
> depending on clock presence in DT.
I've applied this but TBH I think we should be doing this in the core -
I actually thought we had handling for that but I can't see it so I'm
obviously imagining things. It's something that can be done later
anyway.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20181019/76b59e53/attachment.sig>
next prev parent reply other threads:[~2018-10-19 16:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-19 15:56 [PATCH 1/1] ASoC: cs42l51: fix mclk support Olivier Moysan
2018-10-19 15:56 ` Olivier Moysan
2018-10-19 15:56 ` Olivier Moysan
2018-10-19 16:06 ` Mark Brown [this message]
2018-10-19 16:06 ` Mark Brown
2018-10-19 16:06 ` Mark Brown
2018-10-19 16:06 ` Applied "ASoC: cs42l51: fix mclk support" to the asoc tree Mark Brown
2018-10-19 16:06 ` Mark Brown
2018-10-19 16:06 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181019160622.GO5895@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alexandre.torgue@st.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnaud.pouliquen@st.com \
--cc=benjamin.gaignard@st.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=olivier.moysan@st.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.