From: Bjorn Andersson <bjorn.andersson@linaro.org> To: Benjamin Gaignard <benjamin.gaignard@linaro.org> Cc: ohad@wizery.com, robh+dt@kernel.org, mark.rutland@arm.com, alexandre.torgue@st.com, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Benjamin Gaignard <benjamin.gaignard@st.com> Subject: Re: [PATCH 1/5] dt-bindings: hwlock: Document STM32 hwspinlock bindings Date: Wed, 7 Nov 2018 22:49:59 -0800 [thread overview] Message-ID: <20181108064959.GC12063@builder> (raw) In-Reply-To: <20181031093032.20386-2-benjamin.gaignard@st.com> On Wed 31 Oct 02:30 PDT 2018, Benjamin Gaignard wrote: > Add bindings for STM32 hardware spinlock device > > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com> > --- > .../bindings/hwlock/st,stm32-hwspinlock.txt | 23 ++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwlock/st,stm32-hwspinlock.txt > > diff --git a/Documentation/devicetree/bindings/hwlock/st,stm32-hwspinlock.txt b/Documentation/devicetree/bindings/hwlock/st,stm32-hwspinlock.txt > new file mode 100644 > index 000000000000..7a999479d802 > --- /dev/null > +++ b/Documentation/devicetree/bindings/hwlock/st,stm32-hwspinlock.txt > @@ -0,0 +1,23 @@ > +STM32 Hardware Spinlock Device Binding > +------------------------------------- > + > +Required properties : > +- compatible : should be "st,stm32-hwspinlock". > +- reg : the register address of hwspinlock. > +- #hwlock-cells : hwlock users only use the hwlock id to represent a specific > + hwlock, so the number of cells should be <1> here. > +- clock-names : Must contain "hwspinlock". This is supposed to be the name of the clock signal of this hardware block, is it really named "hwspinlock"? Note that you can probably omit the clock-names property, as you only have a single clock... Apart from that, I think the binding looks good. Regards, Bjorn > +- clocks : Must contain a phandle entry for the clock in clock-names, see the > + common clock bindings. > + > +Please look at the generic hwlock binding for usage information for consumers, > +"Documentation/devicetree/bindings/hwlock/hwlock.txt" > + > +Example of hwlock provider: > + hwspinlock@4c000000 { > + compatible = "st,stm32-hwspinlock"; > + #hwlock-cells = <1>; > + reg = <0x4c000000 0x400>; > + clocks = <&rcc HSEM>; > + clock-names = "hwspinlock"; > + }; > -- > 2.15.0 >
WARNING: multiple messages have this Message-ID (diff)
From: bjorn.andersson@linaro.org (Bjorn Andersson) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/5] dt-bindings: hwlock: Document STM32 hwspinlock bindings Date: Wed, 7 Nov 2018 22:49:59 -0800 [thread overview] Message-ID: <20181108064959.GC12063@builder> (raw) In-Reply-To: <20181031093032.20386-2-benjamin.gaignard@st.com> On Wed 31 Oct 02:30 PDT 2018, Benjamin Gaignard wrote: > Add bindings for STM32 hardware spinlock device > > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com> > --- > .../bindings/hwlock/st,stm32-hwspinlock.txt | 23 ++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwlock/st,stm32-hwspinlock.txt > > diff --git a/Documentation/devicetree/bindings/hwlock/st,stm32-hwspinlock.txt b/Documentation/devicetree/bindings/hwlock/st,stm32-hwspinlock.txt > new file mode 100644 > index 000000000000..7a999479d802 > --- /dev/null > +++ b/Documentation/devicetree/bindings/hwlock/st,stm32-hwspinlock.txt > @@ -0,0 +1,23 @@ > +STM32 Hardware Spinlock Device Binding > +------------------------------------- > + > +Required properties : > +- compatible : should be "st,stm32-hwspinlock". > +- reg : the register address of hwspinlock. > +- #hwlock-cells : hwlock users only use the hwlock id to represent a specific > + hwlock, so the number of cells should be <1> here. > +- clock-names : Must contain "hwspinlock". This is supposed to be the name of the clock signal of this hardware block, is it really named "hwspinlock"? Note that you can probably omit the clock-names property, as you only have a single clock... Apart from that, I think the binding looks good. Regards, Bjorn > +- clocks : Must contain a phandle entry for the clock in clock-names, see the > + common clock bindings. > + > +Please look at the generic hwlock binding for usage information for consumers, > +"Documentation/devicetree/bindings/hwlock/hwlock.txt" > + > +Example of hwlock provider: > + hwspinlock at 4c000000 { > + compatible = "st,stm32-hwspinlock"; > + #hwlock-cells = <1>; > + reg = <0x4c000000 0x400>; > + clocks = <&rcc HSEM>; > + clock-names = "hwspinlock"; > + }; > -- > 2.15.0 >
next prev parent reply other threads:[~2018-11-08 6:49 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-10-31 9:30 [PATCH 0/5] Add support of STM32 hwspinlock Benjamin Gaignard 2018-10-31 9:30 ` Benjamin Gaignard 2018-10-31 9:30 ` [PATCH 1/5] dt-bindings: hwlock: Document STM32 hwspinlock bindings Benjamin Gaignard 2018-10-31 9:30 ` Benjamin Gaignard 2018-11-08 6:49 ` Bjorn Andersson [this message] 2018-11-08 6:49 ` Bjorn Andersson 2018-10-31 9:30 ` [PATCH 2/5] hwspinlock: add STM32 hwspinlock device Benjamin Gaignard 2018-10-31 9:30 ` Benjamin Gaignard 2018-11-08 6:47 ` Bjorn Andersson 2018-11-08 6:47 ` Bjorn Andersson 2018-10-31 9:30 ` [PATCH 3/5] ARM: dts: stm32: Add hwspinlock node for stm32mp157 SoC Benjamin Gaignard 2018-10-31 9:30 ` Benjamin Gaignard 2018-11-08 6:51 ` Bjorn Andersson 2018-11-08 6:51 ` Bjorn Andersson 2018-10-31 9:30 ` [PATCH 4/5] ARM: dts: stm32: enable hwspinlock on stm32mp157c-ed1 Benjamin Gaignard 2018-10-31 9:30 ` Benjamin Gaignard 2018-10-31 9:30 ` [PATCH 5/5] hwspinlock: Add test module Benjamin Gaignard 2018-10-31 9:30 ` Benjamin Gaignard 2018-11-08 7:06 ` Bjorn Andersson 2018-11-08 7:06 ` Bjorn Andersson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181108064959.GC12063@builder \ --to=bjorn.andersson@linaro.org \ --cc=alexandre.torgue@st.com \ --cc=benjamin.gaignard@linaro.org \ --cc=benjamin.gaignard@st.com \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-remoteproc@vger.kernel.org \ --cc=linux-stm32@st-md-mailman.stormreply.com \ --cc=mark.rutland@arm.com \ --cc=ohad@wizery.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.