From: Will Deacon <will.deacon@arm.com>
To: Douglas Anderson <dianders@chromium.org>
Cc: Jason Wessel <jason.wessel@windriver.com>,
Daniel Thompson <daniel.thompson@linaro.org>,
kgdb-bugreport@lists.sourceforge.net,
Peter Zijlstra <peterz@infradead.org>,
linux-mips@linux-mips.org, linux-sh@vger.kernel.org,
Borislav Petkov <bp@alien8.de>,
linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org,
Catalin Marinas <catalin.marinas@arm.com>,
James Hogan <jhogan@kernel.org>,
linux-hexagon@vger.kernel.org, x86@kernel.org,
Vineet Gupta <vgupta@synopsys.com>,
Thomas Gleixner <tglx@linutronix.de>,
Michal Hocko <mhocko@suse.com>,
Ralf Baechle <ralf@linux-mips.org>,
linux-snps-arc@lists.infradead.org,
Andrew Morton <akpm@linux-foundation.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Burton <paul.burton@mips.com>,
Ingo Molnar <mingo@redhat.com>,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org,
Christophe Leroy <christophe.leroy@c-s.fr>,
Huang Ying <ying.huang@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Rich Felker <dalias@libc.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Mike Rapoport <rppt@linux.vnet.ibm.com>,
Paul Mackerras <paulus@samba.org>,
Richard Kuo <rkuo@codeaurora.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v4 1/4] kgdb: Remove irq flags from roundup
Date: Wed, 14 Nov 2018 21:51:13 +0000 [thread overview]
Message-ID: <20181114215112.GA4044@brain-police> (raw)
In-Reply-To: <20181112182659.245726-2-dianders@chromium.org>
On Mon, Nov 12, 2018 at 10:26:55AM -0800, Douglas Anderson wrote:
> The function kgdb_roundup_cpus() was passed a parameter that was
> documented as:
>
> > the flags that will be used when restoring the interrupts. There is
> > local_irq_save() call before kgdb_roundup_cpus().
>
> Nobody used those flags. Anyone who wanted to temporarily turn on
> interrupts just did local_irq_enable() and local_irq_disable() without
> looking at them. So we can definitely remove the flags.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
Acked-by: Will Deacon <will.deacon@arm.com>
I'm hopeful that you'll keep hacking on kgdb, because it definitely needs
some love in its current state.
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 1/4] kgdb: Remove irq flags from roundup
Date: Wed, 14 Nov 2018 21:51:13 +0000 [thread overview]
Message-ID: <20181114215112.GA4044@brain-police> (raw)
In-Reply-To: <20181112182659.245726-2-dianders@chromium.org>
On Mon, Nov 12, 2018 at 10:26:55AM -0800, Douglas Anderson wrote:
> The function kgdb_roundup_cpus() was passed a parameter that was
> documented as:
>
> > the flags that will be used when restoring the interrupts. There is
> > local_irq_save() call before kgdb_roundup_cpus().
>
> Nobody used those flags. Anyone who wanted to temporarily turn on
> interrupts just did local_irq_enable() and local_irq_disable() without
> looking at them. So we can definitely remove the flags.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
Acked-by: Will Deacon <will.deacon@arm.com>
I'm hopeful that you'll keep hacking on kgdb, because it definitely needs
some love in its current state.
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Douglas Anderson <dianders@chromium.org>
Cc: linux-mips@linux-mips.org, Michal Hocko <mhocko@suse.com>,
linux-sh@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Rich Felker <dalias@libc.org>, Paul Mackerras <paulus@samba.org>,
"H. Peter Anvin" <hpa@zytor.com>,
sparclinux@vger.kernel.org,
Daniel Thompson <daniel.thompson@linaro.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
linux-hexagon@vger.kernel.org, x86@kernel.org,
Russell King <linux@armlinux.org.uk>,
Ingo Molnar <mingo@redhat.com>,
kgdb-bugreport@lists.sourceforge.net,
James Hogan <jhogan@kernel.org>,
linux-snps-arc@lists.infradead.org,
Huang Ying <ying.huang@intel.com>,
Mike Rapoport <rppt@linux.vnet.ibm.com>,
Borislav Petkov <bp@alien8.de>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org,
Vineet Gupta <vgupta@synopsys.com>,
linux-kernel@vger.kernel.org, Ralf Baechle <ralf@linux-mips.org>,
Richard Kuo <rkuo@codeaurora.org>,
Paul Burton <paul.burton@mips.com>,
Jason Wessel <jason.wessel@windriver.com>,
Andrew Morton <akpm@linux-foundation.org>,
linuxppc-dev@lists.ozlabs.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v4 1/4] kgdb: Remove irq flags from roundup
Date: Wed, 14 Nov 2018 21:51:13 +0000 [thread overview]
Message-ID: <20181114215112.GA4044@brain-police> (raw)
In-Reply-To: <20181112182659.245726-2-dianders@chromium.org>
On Mon, Nov 12, 2018 at 10:26:55AM -0800, Douglas Anderson wrote:
> The function kgdb_roundup_cpus() was passed a parameter that was
> documented as:
>
> > the flags that will be used when restoring the interrupts. There is
> > local_irq_save() call before kgdb_roundup_cpus().
>
> Nobody used those flags. Anyone who wanted to temporarily turn on
> interrupts just did local_irq_enable() and local_irq_disable() without
> looking at them. So we can definitely remove the flags.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
Acked-by: Will Deacon <will.deacon@arm.com>
I'm hopeful that you'll keep hacking on kgdb, because it definitely needs
some love in its current state.
Will
WARNING: multiple messages have this Message-ID (diff)
From: will.deacon@arm.com (Will Deacon)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH v4 1/4] kgdb: Remove irq flags from roundup
Date: Wed, 14 Nov 2018 21:51:13 +0000 [thread overview]
Message-ID: <20181114215112.GA4044@brain-police> (raw)
In-Reply-To: <20181112182659.245726-2-dianders@chromium.org>
On Mon, Nov 12, 2018@10:26:55AM -0800, Douglas Anderson wrote:
> The function kgdb_roundup_cpus() was passed a parameter that was
> documented as:
>
> > the flags that will be used when restoring the interrupts. There is
> > local_irq_save() call before kgdb_roundup_cpus().
>
> Nobody used those flags. Anyone who wanted to temporarily turn on
> interrupts just did local_irq_enable() and local_irq_disable() without
> looking at them. So we can definitely remove the flags.
>
> Signed-off-by: Douglas Anderson <dianders at chromium.org>
> ---
Acked-by: Will Deacon <will.deacon at arm.com>
I'm hopeful that you'll keep hacking on kgdb, because it definitely needs
some love in its current state.
Will
WARNING: multiple messages have this Message-ID (diff)
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 1/4] kgdb: Remove irq flags from roundup
Date: Wed, 14 Nov 2018 21:51:13 +0000 [thread overview]
Message-ID: <20181114215112.GA4044@brain-police> (raw)
In-Reply-To: <20181112182659.245726-2-dianders@chromium.org>
On Mon, Nov 12, 2018 at 10:26:55AM -0800, Douglas Anderson wrote:
> The function kgdb_roundup_cpus() was passed a parameter that was
> documented as:
>
> > the flags that will be used when restoring the interrupts. There is
> > local_irq_save() call before kgdb_roundup_cpus().
>
> Nobody used those flags. Anyone who wanted to temporarily turn on
> interrupts just did local_irq_enable() and local_irq_disable() without
> looking at them. So we can definitely remove the flags.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
Acked-by: Will Deacon <will.deacon@arm.com>
I'm hopeful that you'll keep hacking on kgdb, because it definitely needs
some love in its current state.
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Douglas Anderson <dianders@chromium.org>
Cc: Jason Wessel <jason.wessel@windriver.com>,
Daniel Thompson <daniel.thompson@linaro.org>,
kgdb-bugreport@lists.sourceforge.net,
Peter Zijlstra <peterz@infradead.org>,
linux-mips@linux-mips.org, linux-sh@vger.kernel.org,
Borislav Petkov <bp@alien8.de>,
linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org,
Catalin Marinas <catalin.marinas@arm.com>,
James Hogan <jhogan@kernel.org>,
linux-hexagon@vger.kernel.org, x86@kernel.org,
Vineet Gupta <vgupta@synopsys.com>,
Thomas Gleixner <tglx@linutronix.de>,
Michal Hocko <mhocko@suse.com>,
Ralf Baechle <ralf@linux-mips.org>,
linux-snps-arc@lists.infradead.org,
Andrew Morton <akpm@linux-foundation.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Benjamin Herrenschmidt <benh>
Subject: Re: [PATCH v4 1/4] kgdb: Remove irq flags from roundup
Date: Wed, 14 Nov 2018 21:51:13 +0000 [thread overview]
Message-ID: <20181114215112.GA4044@brain-police> (raw)
In-Reply-To: <20181112182659.245726-2-dianders@chromium.org>
On Mon, Nov 12, 2018 at 10:26:55AM -0800, Douglas Anderson wrote:
> The function kgdb_roundup_cpus() was passed a parameter that was
> documented as:
>
> > the flags that will be used when restoring the interrupts. There is
> > local_irq_save() call before kgdb_roundup_cpus().
>
> Nobody used those flags. Anyone who wanted to temporarily turn on
> interrupts just did local_irq_enable() and local_irq_disable() without
> looking at them. So we can definitely remove the flags.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
Acked-by: Will Deacon <will.deacon@arm.com>
I'm hopeful that you'll keep hacking on kgdb, because it definitely needs
some love in its current state.
Will
next prev parent reply other threads:[~2018-11-14 21:52 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-12 18:26 [PATCH v4 0/4] kgdb: Fix kgdb_roundup_cpus() Douglas Anderson
2018-11-12 18:26 ` Douglas Anderson
2018-11-12 18:26 ` Douglas Anderson
2018-11-12 18:26 ` Douglas Anderson
2018-11-12 18:26 ` Douglas Anderson
2018-11-12 18:26 ` Douglas Anderson
2018-11-12 18:26 ` [PATCH v4 1/4] kgdb: Remove irq flags from roundup Douglas Anderson
2018-11-12 18:26 ` Douglas Anderson
2018-11-12 18:26 ` Douglas Anderson
2018-11-12 18:26 ` Douglas Anderson
2018-11-12 18:26 ` Douglas Anderson
2018-11-12 18:26 ` Douglas Anderson
2018-11-14 21:51 ` Will Deacon [this message]
2018-11-14 21:51 ` Will Deacon
2018-11-14 21:51 ` Will Deacon
2018-11-14 21:51 ` Will Deacon
2018-11-14 21:51 ` Will Deacon
2018-11-14 21:51 ` Will Deacon
2018-11-12 18:26 ` [PATCH v4 2/4] kgdb: Fix kgdb_roundup_cpus() for arches who used smp_call_function() Douglas Anderson
2018-11-12 18:26 ` Douglas Anderson
2018-11-12 18:26 ` Douglas Anderson
2018-11-12 18:26 ` Douglas Anderson
2018-11-12 18:26 ` Douglas Anderson
2018-11-12 18:26 ` Douglas Anderson
2018-11-14 22:07 ` Will Deacon
2018-11-14 22:07 ` Will Deacon
2018-11-14 22:07 ` Will Deacon
2018-11-14 22:07 ` Will Deacon
2018-11-14 22:07 ` Will Deacon
2018-11-14 22:07 ` Will Deacon
2018-11-27 3:52 ` Doug Anderson
2018-11-27 3:52 ` Doug Anderson
2018-11-27 3:52 ` Doug Anderson
2018-11-27 3:52 ` Doug Anderson
2018-11-27 3:52 ` Doug Anderson
2018-11-27 3:52 ` Doug Anderson
2018-11-12 18:26 ` [PATCH v4 3/4] kgdb: Don't round up a CPU that failed rounding up before Douglas Anderson
2018-11-12 18:26 ` [PATCH v4 4/4] kdb: Don't back trace on a cpu that didn't round up Douglas Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181114215112.GA4044@brain-police \
--to=will.deacon@arm.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=christophe.leroy@c-s.fr \
--cc=dalias@libc.org \
--cc=daniel.thompson@linaro.org \
--cc=davem@davemloft.net \
--cc=dianders@chromium.org \
--cc=hpa@zytor.com \
--cc=jason.wessel@windriver.com \
--cc=jhogan@kernel.org \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mhocko@suse.com \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=paul.burton@mips.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=ralf@linux-mips.org \
--cc=rkuo@codeaurora.org \
--cc=rppt@linux.vnet.ibm.com \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=vgupta@synopsys.com \
--cc=x86@kernel.org \
--cc=ying.huang@intel.com \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.