From: Thierry Reding <thierry.reding@gmail.com>
To: Vladimir Zapolskiy <vz@mleia.com>
Cc: linux-pwm@vger.kernel.org, kernel@pengutronix.de,
linux-arm-kernel@lists.infradead.org,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH] pwm: lpc18xx-sct: don't reconfigure PWM in .request and .free
Date: Fri, 16 Nov 2018 11:01:14 +0100 [thread overview]
Message-ID: <20181116100114.GB28631@ulmo> (raw)
In-Reply-To: <1391bbe1-75b5-c86e-ed3a-1e1afb393917@mleia.com>
[-- Attachment #1.1: Type: text/plain, Size: 952 bytes --]
On Fri, Nov 16, 2018 at 11:22:49AM +0200, Vladimir Zapolskiy wrote:
> Hello Uwe,
>
> On 11/16/2018 08:52 AM, Uwe Kleine-König wrote:
> > Regarding the .request case: The consumer might be interested in taking
> > over the configured state from the boot loader. So the initially
> > configured state should be retained.
> >
> > For the free case the PWM consumer is responsible to disable the PWM
> > before calling pwm_release and there are three subcases to consider:
> >
>
> the changes are fine per se, but please split them into two.
>
> Probably pwm_disable() misusage began spreading from commit 54b2a999a1675.
It's not really misusage to call pwm_disable(). It's basically just a
shortcut for ->disable() or the atomic equivalent for it. So I think the
commit that you point to is doing exactly the right thing. Also note
that that commit was made 6 years ago, and a lot of things have changed
since then.
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: thierry.reding@gmail.com (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pwm: lpc18xx-sct: don't reconfigure PWM in .request and .free
Date: Fri, 16 Nov 2018 11:01:14 +0100 [thread overview]
Message-ID: <20181116100114.GB28631@ulmo> (raw)
In-Reply-To: <1391bbe1-75b5-c86e-ed3a-1e1afb393917@mleia.com>
On Fri, Nov 16, 2018 at 11:22:49AM +0200, Vladimir Zapolskiy wrote:
> Hello Uwe,
>
> On 11/16/2018 08:52 AM, Uwe Kleine-K?nig wrote:
> > Regarding the .request case: The consumer might be interested in taking
> > over the configured state from the boot loader. So the initially
> > configured state should be retained.
> >
> > For the free case the PWM consumer is responsible to disable the PWM
> > before calling pwm_release and there are three subcases to consider:
> >
>
> the changes are fine per se, but please split them into two.
>
> Probably pwm_disable() misusage began spreading from commit 54b2a999a1675.
It's not really misusage to call pwm_disable(). It's basically just a
shortcut for ->disable() or the atomic equivalent for it. So I think the
commit that you point to is doing exactly the right thing. Also note
that that commit was made 6 years ago, and a lot of things have changed
since then.
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20181116/94ce7e09/attachment.sig>
next prev parent reply other threads:[~2018-11-16 10:01 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-25 19:45 is pwm_put supposed to stop a PWM? Uwe Kleine-König
2018-10-29 11:48 ` Thierry Reding
2018-11-03 14:49 ` Uwe Kleine-König
2018-11-14 9:30 ` Uwe Kleine-König
2018-11-14 11:50 ` Thierry Reding
2018-11-15 8:42 ` Uwe Kleine-König
2018-11-15 15:43 ` Thierry Reding
2018-11-15 20:46 ` Uwe Kleine-König
2018-11-16 6:52 ` [PATCH] pwm: lpc18xx-sct: don't reconfigure PWM in .request and .free Uwe Kleine-König
2018-11-16 6:52 ` Uwe Kleine-König
2018-11-16 7:02 ` Uwe Kleine-König
2018-11-16 7:02 ` Uwe Kleine-König
2018-11-16 9:22 ` Vladimir Zapolskiy
2018-11-16 9:22 ` Vladimir Zapolskiy
2018-11-16 9:48 ` Uwe Kleine-König
2018-11-16 9:48 ` Uwe Kleine-König
2018-11-16 10:01 ` Thierry Reding [this message]
2018-11-16 10:01 ` Thierry Reding
2018-11-16 10:45 ` Uwe Kleine-König
2018-11-16 10:45 ` Uwe Kleine-König
2018-11-16 10:05 ` Thierry Reding
2018-11-16 10:05 ` Thierry Reding
2018-11-19 19:55 ` Uwe Kleine-König
2018-11-19 19:55 ` Uwe Kleine-König
2018-11-20 15:42 ` Thierry Reding
2018-11-20 15:42 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181116100114.GB28631@ulmo \
--to=thierry.reding@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.