From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Phil Edworthy <phil.edworthy@renesas.com>
Cc: Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Russell King <linux@armlinux.org.uk>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-renesas-soc@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 1/6] clk: Add of_clk_get_by_name_optional() function
Date: Fri, 16 Nov 2018 17:11:22 +0100 [thread overview]
Message-ID: <20181116161122.hhvslbzdujxpk3up@pengutronix.de> (raw)
In-Reply-To: <20181116160128.pkuya6rwqm4schdn@pengutronix.de>
On Fri, Nov 16, 2018 at 05:01:28PM +0100, Uwe Kleine-König wrote:
> Other than that I think the patch is fine
Thinking again, I wonder why not just do:
static inline struct clk *clk_get_optional(struct device *dev, const char *id)
{
struct clk *c = clk_get(dev, id);
if (c == ERR_PTR(-ENOENT))
return NULL;
else
return c;
}
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
WARNING: multiple messages have this Message-ID (diff)
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Phil Edworthy <phil.edworthy@renesas.com>
Cc: Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Russell King <linux@armlinux.org.uk>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-renesas-soc@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 1/6] clk: Add of_clk_get_by_name_optional() function
Date: Fri, 16 Nov 2018 17:11:22 +0100 [thread overview]
Message-ID: <20181116161122.hhvslbzdujxpk3up@pengutronix.de> (raw)
In-Reply-To: <20181116160128.pkuya6rwqm4schdn@pengutronix.de>
On Fri, Nov 16, 2018 at 05:01:28PM +0100, Uwe Kleine-K�nig wrote:
> Other than that I think the patch is fine
Thinking again, I wonder why not just do:
static inline struct clk *clk_get_optional(struct device *dev, const char *id)
{
struct clk *c = clk_get(dev, id);
if (c == ERR_PTR(-ENOENT))
return NULL;
else
return c;
}
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K�nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
WARNING: multiple messages have this Message-ID (diff)
From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 1/6] clk: Add of_clk_get_by_name_optional() function
Date: Fri, 16 Nov 2018 17:11:22 +0100 [thread overview]
Message-ID: <20181116161122.hhvslbzdujxpk3up@pengutronix.de> (raw)
In-Reply-To: <20181116160128.pkuya6rwqm4schdn@pengutronix.de>
On Fri, Nov 16, 2018 at 05:01:28PM +0100, Uwe Kleine-K?nig wrote:
> Other than that I think the patch is fine
Thinking again, I wonder why not just do:
static inline struct clk *clk_get_optional(struct device *dev, const char *id)
{
struct clk *c = clk_get(dev, id);
if (c == ERR_PTR(-ENOENT))
return NULL;
else
return c;
}
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2018-11-16 16:11 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-16 14:59 [PATCH v6 0/6] clk: Add functions to get optional clocks Phil Edworthy
2018-11-16 14:59 ` Phil Edworthy
2018-11-16 14:59 ` [PATCH v6 1/6] clk: Add of_clk_get_by_name_optional() function Phil Edworthy
2018-11-16 14:59 ` Phil Edworthy
2018-11-16 16:01 ` Uwe Kleine-König
2018-11-16 16:01 ` Uwe Kleine-König
2018-11-16 16:01 ` Uwe Kleine-König
2018-11-16 16:11 ` Uwe Kleine-König [this message]
2018-11-16 16:11 ` Uwe Kleine-König
2018-11-16 16:11 ` Uwe Kleine-König
2018-11-19 10:41 ` Phil Edworthy
2018-11-19 10:41 ` Phil Edworthy
2018-11-19 10:41 ` Phil Edworthy
2018-11-19 10:46 ` Uwe Kleine-König
2018-11-19 10:46 ` Uwe Kleine-König
2018-11-19 10:46 ` Uwe Kleine-König
2018-11-19 12:53 ` Phil Edworthy
2018-11-19 12:53 ` Phil Edworthy
2018-11-19 12:53 ` Phil Edworthy
2018-11-19 12:58 ` Uwe Kleine-König
2018-11-19 12:58 ` Uwe Kleine-König
2018-11-19 12:58 ` Uwe Kleine-König
2018-11-19 13:41 ` Phil Edworthy
2018-11-19 13:41 ` Phil Edworthy
2018-11-19 13:41 ` Phil Edworthy
2018-11-16 14:59 ` [PATCH v6 2/6] clk: Add (devm_)clk_get_optional() functions Phil Edworthy
2018-11-16 14:59 ` Phil Edworthy
2018-11-16 14:59 ` [PATCH v6 3/6] m68k: coldfire: Add clk_get_optional() function Phil Edworthy
2018-11-29 11:54 ` Greg Ungerer
2018-11-29 12:02 ` Phil Edworthy
2018-11-29 12:02 ` Phil Edworthy
2018-11-29 12:10 ` Greg Ungerer
2018-11-29 12:10 ` Greg Ungerer
2018-11-29 16:32 ` Christoph Hellwig
2018-12-03 12:29 ` Greg Ungerer
2018-11-16 14:59 ` [PATCH v6 4/6] MIPS: AR7: " Phil Edworthy
2018-11-16 14:59 ` [PATCH v6 5/6] MIPS: Loongson 2F: " Phil Edworthy
2018-11-16 14:59 ` [PATCH v6 6/6] arch/unicore32/kernel/clock.c: " Phil Edworthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181116161122.hhvslbzdujxpk3up@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=geert@linux-m68k.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mturquette@baylibre.com \
--cc=phil.edworthy@renesas.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.