From: Ming Lei <ming.lei@redhat.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: Mike Snitzer <snitzer@redhat.com>,
linux-mm@kvack.org, dm-devel@redhat.com,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
"Darrick J . Wong" <darrick.wong@oracle.com>,
Omar Sandoval <osandov@fb.com>,
cluster-devel@redhat.com, linux-ext4@vger.kernel.org,
Shaohua Li <shli@kernel.org>,
Kent Overstreet <kent.overstreet@gmail.com>,
Boaz Harrosh <ooo@electrozaur.com>,
Gao Xiang <gaoxiang25@huawei.com>, Coly Li <colyli@suse.de>,
linux-raid@vger.kernel.org, Bob Peterson <rpeterso@redhat.com>,
linux-bcache@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
Dave Chinner <dchinner@redhat.com>,
David Sterba <dsterba@suse.com>, Ming Lei <ming.lei@redhat.com>,
linux-block@vger.kernel.org, Theodore Ts'o <tytso@mit.edu>,
linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: [PATCH V11 01/19] block: don't use bio->bi_vcnt to figure out segment number
Date: Wed, 21 Nov 2018 11:23:09 +0800 [thread overview]
Message-ID: <20181121032327.8434-2-ming.lei@redhat.com> (raw)
In-Reply-To: <20181121032327.8434-1-ming.lei@redhat.com>
It is wrong to use bio->bi_vcnt to figure out how many segments
there are in the bio even though CLONED flag isn't set on this bio,
because this bio may be splitted or advanced.
So always use bio_segments() in blk_recount_segments(), and it shouldn't
cause any performance loss now because the physical segment number is figured
out in blk_queue_split() and BIO_SEG_VALID is set meantime since
bdced438acd83ad83a6c ("block: setup bi_phys_segments after splitting").
Reviewed-by: Christoph Hellwig <hch@lst.de>
Fixes: 76d8137a3113 ("blk-merge: recaculate segment if it isn't less than max segments")
Signed-off-by: Ming Lei <ming.lei@redhat.com>
---
block/blk-merge.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/block/blk-merge.c b/block/blk-merge.c
index b1df622cbd85..f52400ce2187 100644
--- a/block/blk-merge.c
+++ b/block/blk-merge.c
@@ -368,13 +368,7 @@ void blk_recalc_rq_segments(struct request *rq)
void blk_recount_segments(struct request_queue *q, struct bio *bio)
{
- unsigned short seg_cnt;
-
- /* estimate segment number by bi_vcnt for non-cloned bio */
- if (bio_flagged(bio, BIO_CLONED))
- seg_cnt = bio_segments(bio);
- else
- seg_cnt = bio->bi_vcnt;
+ unsigned short seg_cnt = bio_segments(bio);
if (test_bit(QUEUE_FLAG_NO_SG_MERGE, &q->queue_flags) &&
(seg_cnt < queue_max_segments(q)))
--
2.9.5
WARNING: multiple messages have this Message-ID (diff)
From: Ming Lei <ming.lei@redhat.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, Theodore Ts'o <tytso@mit.edu>,
Omar Sandoval <osandov@fb.com>, Sagi Grimberg <sagi@grimberg.me>,
Dave Chinner <dchinner@redhat.com>,
Kent Overstreet <kent.overstreet@gmail.com>,
Mike Snitzer <snitzer@redhat.com>,
dm-devel@redhat.com, Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, Shaohua Li <shli@kernel.org>,
linux-raid@vger.kernel.org, David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org,
"Darrick J . Wong" <darrick.wong@oracle.com>,
linux-xfs@vger.kernel.org, Gao Xiang <gaoxiang25@huawei.com>,
Christoph Hellwig <hch@lst.de>,
linux-ext4@vger.kernel.org, Coly Li <colyli@suse.de>,
linux-bcache@vger.kernel.org, Boaz Harrosh <ooo@electrozaur.com>,
Bob Peterson <rpeterso@redhat.com>,
cluster-devel@redhat.com, Ming Lei <ming.lei@redhat.com>
Subject: [PATCH V11 01/19] block: don't use bio->bi_vcnt to figure out segment number
Date: Wed, 21 Nov 2018 11:23:09 +0800 [thread overview]
Message-ID: <20181121032327.8434-2-ming.lei@redhat.com> (raw)
In-Reply-To: <20181121032327.8434-1-ming.lei@redhat.com>
It is wrong to use bio->bi_vcnt to figure out how many segments
there are in the bio even though CLONED flag isn't set on this bio,
because this bio may be splitted or advanced.
So always use bio_segments() in blk_recount_segments(), and it shouldn't
cause any performance loss now because the physical segment number is figured
out in blk_queue_split() and BIO_SEG_VALID is set meantime since
bdced438acd83ad83a6c ("block: setup bi_phys_segments after splitting").
Reviewed-by: Christoph Hellwig <hch@lst.de>
Fixes: 76d8137a3113 ("blk-merge: recaculate segment if it isn't less than max segments")
Signed-off-by: Ming Lei <ming.lei@redhat.com>
---
block/blk-merge.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/block/blk-merge.c b/block/blk-merge.c
index b1df622cbd85..f52400ce2187 100644
--- a/block/blk-merge.c
+++ b/block/blk-merge.c
@@ -368,13 +368,7 @@ void blk_recalc_rq_segments(struct request *rq)
void blk_recount_segments(struct request_queue *q, struct bio *bio)
{
- unsigned short seg_cnt;
-
- /* estimate segment number by bi_vcnt for non-cloned bio */
- if (bio_flagged(bio, BIO_CLONED))
- seg_cnt = bio_segments(bio);
- else
- seg_cnt = bio->bi_vcnt;
+ unsigned short seg_cnt = bio_segments(bio);
if (test_bit(QUEUE_FLAG_NO_SG_MERGE, &q->queue_flags) &&
(seg_cnt < queue_max_segments(q)))
--
2.9.5
WARNING: multiple messages have this Message-ID (diff)
From: Ming Lei <ming.lei@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH V11 01/19] block: don't use bio->bi_vcnt to figure out segment number
Date: Wed, 21 Nov 2018 11:23:09 +0800 [thread overview]
Message-ID: <20181121032327.8434-2-ming.lei@redhat.com> (raw)
In-Reply-To: <20181121032327.8434-1-ming.lei@redhat.com>
It is wrong to use bio->bi_vcnt to figure out how many segments
there are in the bio even though CLONED flag isn't set on this bio,
because this bio may be splitted or advanced.
So always use bio_segments() in blk_recount_segments(), and it shouldn't
cause any performance loss now because the physical segment number is figured
out in blk_queue_split() and BIO_SEG_VALID is set meantime since
bdced438acd83ad83a6c ("block: setup bi_phys_segments after splitting").
Reviewed-by: Christoph Hellwig <hch@lst.de>
Fixes: 76d8137a3113 ("blk-merge: recaculate segment if it isn't less than max segments")
Signed-off-by: Ming Lei <ming.lei@redhat.com>
---
block/blk-merge.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/block/blk-merge.c b/block/blk-merge.c
index b1df622cbd85..f52400ce2187 100644
--- a/block/blk-merge.c
+++ b/block/blk-merge.c
@@ -368,13 +368,7 @@ void blk_recalc_rq_segments(struct request *rq)
void blk_recount_segments(struct request_queue *q, struct bio *bio)
{
- unsigned short seg_cnt;
-
- /* estimate segment number by bi_vcnt for non-cloned bio */
- if (bio_flagged(bio, BIO_CLONED))
- seg_cnt = bio_segments(bio);
- else
- seg_cnt = bio->bi_vcnt;
+ unsigned short seg_cnt = bio_segments(bio);
if (test_bit(QUEUE_FLAG_NO_SG_MERGE, &q->queue_flags) &&
(seg_cnt < queue_max_segments(q)))
--
2.9.5
next prev parent reply other threads:[~2018-11-21 3:23 UTC|newest]
Thread overview: 177+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-21 3:23 [PATCH V11 00/19] block: support multi-page bvec Ming Lei
2018-11-21 3:23 ` [Cluster-devel] " Ming Lei
2018-11-21 3:23 ` Ming Lei
2018-11-21 3:23 ` Ming Lei [this message]
2018-11-21 3:23 ` [Cluster-devel] [PATCH V11 01/19] block: don't use bio->bi_vcnt to figure out segment number Ming Lei
2018-11-21 3:23 ` Ming Lei
2018-11-21 3:23 ` [PATCH V11 02/19] block: introduce multi-page bvec helpers Ming Lei
2018-11-21 3:23 ` [Cluster-devel] " Ming Lei
2018-11-21 3:23 ` Ming Lei
2018-11-21 13:19 ` Christoph Hellwig
2018-11-21 13:19 ` [Cluster-devel] " Christoph Hellwig
2018-11-21 13:19 ` Christoph Hellwig
2018-11-21 15:06 ` Ming Lei
2018-11-21 15:06 ` [Cluster-devel] " Ming Lei
2018-11-21 15:06 ` Ming Lei
2018-11-21 16:08 ` Christoph Hellwig
2018-11-21 16:08 ` [Cluster-devel] " Christoph Hellwig
2018-11-21 16:08 ` Christoph Hellwig
2018-11-22 1:09 ` Ming Lei
2018-11-22 1:09 ` [Cluster-devel] " Ming Lei
2018-11-22 1:09 ` Ming Lei
2018-11-21 3:23 ` [PATCH V11 03/19] block: introduce bio_for_each_bvec() Ming Lei
2018-11-21 3:23 ` [Cluster-devel] " Ming Lei
2018-11-21 3:23 ` Ming Lei
2018-11-21 13:32 ` Christoph Hellwig
2018-11-21 13:32 ` [Cluster-devel] " Christoph Hellwig
2018-11-21 13:32 ` Christoph Hellwig
2018-11-21 15:31 ` Ming Lei
2018-11-21 15:31 ` [Cluster-devel] " Ming Lei
2018-11-21 15:31 ` Ming Lei
2018-11-21 16:10 ` Christoph Hellwig
2018-11-21 16:10 ` [Cluster-devel] " Christoph Hellwig
2018-11-21 16:10 ` Christoph Hellwig
2018-11-21 17:12 ` Christoph Hellwig
2018-11-21 17:12 ` [Cluster-devel] " Christoph Hellwig
2018-11-21 17:12 ` Christoph Hellwig
2018-11-22 10:15 ` Ming Lei
2018-11-22 10:15 ` [Cluster-devel] " Ming Lei
2018-11-22 10:15 ` Ming Lei
2018-11-22 10:23 ` Christoph Hellwig
2018-11-22 10:23 ` [Cluster-devel] " Christoph Hellwig
2018-11-22 10:23 ` Christoph Hellwig
2018-11-22 10:30 ` Christoph Hellwig
2018-11-22 10:30 ` [Cluster-devel] " Christoph Hellwig
2018-11-22 10:30 ` Christoph Hellwig
2018-11-22 14:57 ` Ming Lei
2018-11-22 14:57 ` [Cluster-devel] " Ming Lei
2018-11-22 14:57 ` Ming Lei
2018-11-22 1:17 ` Ming Lei
2018-11-22 1:17 ` [Cluster-devel] " Ming Lei
2018-11-22 1:17 ` Ming Lei
2018-11-21 3:23 ` [PATCH V11 04/19] block: use bio_for_each_bvec() to compute multi-page bvec count Ming Lei
2018-11-21 3:23 ` [Cluster-devel] " Ming Lei
2018-11-21 3:23 ` Ming Lei
2018-11-21 3:23 ` [PATCH V11 05/19] block: use bio_for_each_bvec() to map sg Ming Lei
2018-11-21 3:23 ` [Cluster-devel] " Ming Lei
2018-11-21 3:23 ` Ming Lei
2018-11-21 3:23 ` [PATCH V11 06/19] block: introduce bvec_last_segment() Ming Lei
2018-11-21 3:23 ` [Cluster-devel] " Ming Lei
2018-11-21 3:23 ` Ming Lei
2018-11-21 3:23 ` [PATCH V11 07/19] fs/buffer.c: use bvec iterator to truncate the bio Ming Lei
2018-11-21 3:23 ` [Cluster-devel] " Ming Lei
2018-11-21 3:23 ` Ming Lei
2018-11-22 10:58 ` Christoph Hellwig
2018-11-22 10:58 ` [Cluster-devel] " Christoph Hellwig
2018-11-22 10:58 ` Christoph Hellwig
2018-11-23 1:48 ` Ming Lei
2018-11-23 1:48 ` [Cluster-devel] " Ming Lei
2018-11-23 1:48 ` Ming Lei
2018-11-21 3:23 ` [PATCH V11 08/19] btrfs: use bvec_last_segment to get bio's last page Ming Lei
2018-11-21 3:23 ` [Cluster-devel] " Ming Lei
2018-11-21 3:23 ` Ming Lei
2018-11-21 3:23 ` [PATCH V11 09/19] btrfs: move bio_pages_all() to btrfs Ming Lei
2018-11-21 3:23 ` [Cluster-devel] " Ming Lei
2018-11-21 3:23 ` Ming Lei
2018-11-21 3:23 ` [PATCH V11 10/19] block: loop: pass multi-page bvec to iov_iter Ming Lei
2018-11-21 3:23 ` [Cluster-devel] " Ming Lei
2018-11-21 3:23 ` Ming Lei
2018-11-21 14:00 ` Christoph Hellwig
2018-11-21 14:00 ` [Cluster-devel] " Christoph Hellwig
2018-11-21 14:00 ` Christoph Hellwig
2018-11-21 3:23 ` [PATCH V11 11/19] bcache: avoid to use bio_for_each_segment_all() in bch_bio_alloc_pages() Ming Lei
2018-11-21 3:23 ` [Cluster-devel] " Ming Lei
2018-11-21 3:23 ` Ming Lei
2018-11-21 14:01 ` Christoph Hellwig
2018-11-21 14:01 ` [Cluster-devel] " Christoph Hellwig
2018-11-21 14:01 ` Christoph Hellwig
2018-11-21 3:23 ` [PATCH V11 12/19] block: allow bio_for_each_segment_all() to iterate over multi-page bvec Ming Lei
2018-11-21 3:23 ` [Cluster-devel] " Ming Lei
2018-11-21 3:23 ` Ming Lei
2018-11-21 14:02 ` Christoph Hellwig
2018-11-21 14:02 ` [Cluster-devel] " Christoph Hellwig
2018-11-21 14:02 ` Christoph Hellwig
2018-11-22 11:03 ` Christoph Hellwig
2018-11-22 11:03 ` [Cluster-devel] " Christoph Hellwig
2018-11-22 11:03 ` Christoph Hellwig
2018-11-23 2:19 ` Ming Lei
2018-11-23 2:19 ` [Cluster-devel] " Ming Lei
2018-11-23 2:19 ` Ming Lei
2018-11-21 3:23 ` [PATCH V11 13/19] block: move bounce_clone_bio into bio.c Ming Lei
2018-11-21 3:23 ` [Cluster-devel] " Ming Lei
2018-11-21 3:23 ` Ming Lei
2018-11-21 3:23 ` [PATCH V11 14/19] block: handle non-cluster bio out of blk_bio_segment_split Ming Lei
2018-11-21 3:23 ` [Cluster-devel] " Ming Lei
2018-11-21 3:23 ` Ming Lei
2018-11-21 14:33 ` Christoph Hellwig
2018-11-21 14:33 ` [Cluster-devel] " Christoph Hellwig
2018-11-21 14:33 ` Christoph Hellwig
2018-11-21 15:37 ` Ming Lei
2018-11-21 15:37 ` [Cluster-devel] " Ming Lei
2018-11-21 15:37 ` Ming Lei
2018-11-21 16:11 ` Christoph Hellwig
2018-11-21 16:11 ` [Cluster-devel] " Christoph Hellwig
2018-11-21 16:11 ` Christoph Hellwig
2018-11-21 17:46 ` Christoph Hellwig
2018-11-21 17:46 ` [Cluster-devel] " Christoph Hellwig
2018-11-21 17:46 ` Christoph Hellwig
2018-11-21 17:46 ` Christoph Hellwig
2018-11-21 17:46 ` Christoph Hellwig
2018-11-22 9:33 ` Ming Lei
2018-11-22 9:33 ` [Cluster-devel] " Ming Lei
2018-11-22 9:33 ` Ming Lei
2018-11-22 10:04 ` Christoph Hellwig
2018-11-22 10:04 ` [Cluster-devel] " Christoph Hellwig
2018-11-22 10:04 ` Christoph Hellwig
2018-11-22 10:26 ` Ming Lei
2018-11-22 10:26 ` [Cluster-devel] " Ming Lei
2018-11-22 10:26 ` Ming Lei
2018-11-22 10:40 ` Christoph Hellwig
2018-11-22 10:40 ` [Cluster-devel] " Christoph Hellwig
2018-11-22 10:40 ` Christoph Hellwig
2018-11-22 10:32 ` Ming Lei
2018-11-22 10:32 ` [Cluster-devel] " Ming Lei
2018-11-22 10:32 ` Ming Lei
2018-11-22 10:41 ` Christoph Hellwig
2018-11-22 10:41 ` [Cluster-devel] " Christoph Hellwig
2018-11-22 10:41 ` Christoph Hellwig
2018-11-22 10:46 ` Ming Lei
2018-11-22 10:46 ` [Cluster-devel] " Ming Lei
2018-11-22 10:46 ` Ming Lei
2018-11-22 10:47 ` Christoph Hellwig
2018-11-22 10:47 ` [Cluster-devel] " Christoph Hellwig
2018-11-22 10:47 ` Christoph Hellwig
2018-11-21 3:23 ` [PATCH V11 15/19] block: enable multipage bvecs Ming Lei
2018-11-21 3:23 ` [Cluster-devel] " Ming Lei
2018-11-21 3:23 ` Ming Lei
2018-11-21 14:55 ` Christoph Hellwig
2018-11-21 14:55 ` [Cluster-devel] " Christoph Hellwig
2018-11-21 14:55 ` Christoph Hellwig
2018-11-21 15:48 ` Ming Lei
2018-11-21 15:48 ` [Cluster-devel] " Ming Lei
2018-11-21 15:48 ` Ming Lei
2018-11-21 16:12 ` Christoph Hellwig
2018-11-21 16:12 ` [Cluster-devel] " Christoph Hellwig
2018-11-21 16:12 ` Christoph Hellwig
2018-11-23 10:50 ` Ming Lei
2018-11-23 10:50 ` [Cluster-devel] " Ming Lei
2018-11-23 10:50 ` Ming Lei
2018-11-21 3:23 ` [PATCH V11 16/19] block: always define BIO_MAX_PAGES as 256 Ming Lei
2018-11-21 3:23 ` [Cluster-devel] " Ming Lei
2018-11-21 3:23 ` Ming Lei
2018-11-21 3:23 ` [PATCH V11 17/19] block: document usage of bio iterator helpers Ming Lei
2018-11-21 3:23 ` [Cluster-devel] " Ming Lei
2018-11-21 3:23 ` Ming Lei
2018-11-21 7:45 ` Nikolay Borisov
2018-11-21 7:45 ` [Cluster-devel] " Nikolay Borisov
2018-11-21 7:45 ` Nikolay Borisov
2018-11-21 7:45 ` Nikolay Borisov
2018-11-21 14:34 ` Christoph Hellwig
2018-11-21 14:34 ` [Cluster-devel] " Christoph Hellwig
2018-11-21 14:34 ` Christoph Hellwig
2018-11-21 3:23 ` [PATCH V11 18/19] block: kill QUEUE_FLAG_NO_SG_MERGE Ming Lei
2018-11-21 3:23 ` [Cluster-devel] " Ming Lei
2018-11-21 3:23 ` Ming Lei
2018-11-21 3:23 ` [PATCH V11 19/19] block: kill BLK_MQ_F_SG_MERGE Ming Lei
2018-11-21 3:23 ` [Cluster-devel] " Ming Lei
2018-11-21 3:23 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181121032327.8434-2-ming.lei@redhat.com \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=cluster-devel@redhat.com \
--cc=colyli@suse.de \
--cc=darrick.wong@oracle.com \
--cc=dchinner@redhat.com \
--cc=dm-devel@redhat.com \
--cc=dsterba@suse.com \
--cc=gaoxiang25@huawei.com \
--cc=hch@lst.de \
--cc=kent.overstreet@gmail.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ooo@electrozaur.com \
--cc=osandov@fb.com \
--cc=rpeterso@redhat.com \
--cc=sagi@grimberg.me \
--cc=shli@kernel.org \
--cc=snitzer@redhat.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.