From: Paul Gortmaker <paul.gortmaker@windriver.com> To: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: Robin Murphy <robin.murphy@arm.com>, Joerg Roedel <joro@8bytes.org>, <iommu@lists.linux-foundation.org>, <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 5/9] iommu: ipmmu-vmsa: make it explicitly non-modular Date: Wed, 28 Nov 2018 17:10:55 -0500 [thread overview] Message-ID: <20181128221054.GJ14659@windriver.com> (raw) In-Reply-To: <7671106.x9S16LaZuq@avalon> [Re: [PATCH 5/9] iommu: ipmmu-vmsa: make it explicitly non-modular] On 28/11/2018 (Wed 19:22) Laurent Pinchart wrote: > Hi Paul, > > On Wednesday, 28 November 2018 17:32:05 EET Paul Gortmaker wrote: > > [Re: [PATCH 5/9] iommu: ipmmu-vmsa: make it explicitly non-modular] On > 28/11/2018 (Wed 12:50) Robin Murphy wrote: > > > On 26/11/2018 22:31, Paul Gortmaker wrote: > > [...] > > > > >> diff --git a/drivers/iommu/ipmmu-vmsa.c b/drivers/iommu/ipmmu-vmsa.c > > >> index 9e2655f1c1bf..de39ef992d8a 100644 > > >> --- a/drivers/iommu/ipmmu-vmsa.c > > >> +++ b/drivers/iommu/ipmmu-vmsa.c > > >> @@ -1,6 +1,8 @@ > > >> > > >> // SPDX-License-Identifier: GPL-2.0 > > >> /* > > >> * IPMMU VMSA > > > > > > Nit: this line doesn't convey any information that the module description > > > below doesn't also say far more clearly, so you may as well just replace > > > it entirely. > > > > No problem. Will do in v2. > > With that change, the blank line after MODULE_DEVICE_TABLE() removed, and > <linux/init.h> moved to keep alphabetical order sorting of the includes, > please add > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Updated and review tag added for v2. Paul. -- > > to v2. Thank you for the patch. > > > > >+ * IOMMU API for Renesas VMSA-compatible IPMMU > > > >+ * Author: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > > [...] > > -- > Regards, > > Laurent Pinchart > > >
WARNING: multiple messages have this Message-ID (diff)
From: Paul Gortmaker <paul.gortmaker-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org> To: Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org> Cc: Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org>, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: Re: [PATCH 5/9] iommu: ipmmu-vmsa: make it explicitly non-modular Date: Wed, 28 Nov 2018 17:10:55 -0500 [thread overview] Message-ID: <20181128221054.GJ14659@windriver.com> (raw) In-Reply-To: <7671106.x9S16LaZuq@avalon> [Re: [PATCH 5/9] iommu: ipmmu-vmsa: make it explicitly non-modular] On 28/11/2018 (Wed 19:22) Laurent Pinchart wrote: > Hi Paul, > > On Wednesday, 28 November 2018 17:32:05 EET Paul Gortmaker wrote: > > [Re: [PATCH 5/9] iommu: ipmmu-vmsa: make it explicitly non-modular] On > 28/11/2018 (Wed 12:50) Robin Murphy wrote: > > > On 26/11/2018 22:31, Paul Gortmaker wrote: > > [...] > > > > >> diff --git a/drivers/iommu/ipmmu-vmsa.c b/drivers/iommu/ipmmu-vmsa.c > > >> index 9e2655f1c1bf..de39ef992d8a 100644 > > >> --- a/drivers/iommu/ipmmu-vmsa.c > > >> +++ b/drivers/iommu/ipmmu-vmsa.c > > >> @@ -1,6 +1,8 @@ > > >> > > >> // SPDX-License-Identifier: GPL-2.0 > > >> /* > > >> * IPMMU VMSA > > > > > > Nit: this line doesn't convey any information that the module description > > > below doesn't also say far more clearly, so you may as well just replace > > > it entirely. > > > > No problem. Will do in v2. > > With that change, the blank line after MODULE_DEVICE_TABLE() removed, and > <linux/init.h> moved to keep alphabetical order sorting of the includes, > please add > > Reviewed-by: Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org> Updated and review tag added for v2. Paul. -- > > to v2. Thank you for the patch. > > > > >+ * IOMMU API for Renesas VMSA-compatible IPMMU > > > >+ * Author: Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org> > > > > [...] > > -- > Regards, > > Laurent Pinchart > > >
next prev parent reply other threads:[~2018-11-28 22:13 UTC|newest] Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-11-26 22:31 [PATCH 0/9] iommu: clean up/remove modular stuff from non-modules Paul Gortmaker 2018-11-26 22:31 ` Paul Gortmaker 2018-11-26 22:31 ` Paul Gortmaker 2018-11-26 22:31 ` [PATCH 1/9] iommu: audit and remove any unnecessary uses of module.h Paul Gortmaker 2018-11-26 22:31 ` Paul Gortmaker 2018-11-26 22:31 ` [PATCH 2/9] iommu: rockchip: make it explicitly non-modular Paul Gortmaker 2018-11-26 22:31 ` Paul Gortmaker 2018-11-26 22:31 ` Paul Gortmaker 2018-11-26 23:37 ` Heiko Stuebner 2018-11-26 23:37 ` Heiko Stuebner 2018-11-26 23:37 ` Heiko Stuebner 2018-11-26 22:31 ` [PATCH 3/9] iommu: msm_iommu: " Paul Gortmaker 2018-11-26 22:31 ` Paul Gortmaker 2018-11-26 22:31 ` [PATCH 4/9] iommu: mtk_iommu: " Paul Gortmaker 2018-11-26 22:31 ` Paul Gortmaker 2018-11-27 1:25 ` Honghui Zhang 2018-11-27 1:25 ` Honghui Zhang 2018-11-26 22:31 ` [PATCH 5/9] iommu: ipmmu-vmsa: " Paul Gortmaker 2018-11-26 22:31 ` Paul Gortmaker 2018-11-28 12:50 ` Robin Murphy 2018-11-28 15:32 ` Paul Gortmaker 2018-11-28 15:32 ` Paul Gortmaker 2018-11-28 17:22 ` Laurent Pinchart 2018-11-28 22:10 ` Paul Gortmaker [this message] 2018-11-28 22:10 ` Paul Gortmaker [not found] ` <1543271498-28966-1-git-send-email-paul.gortmaker-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org> 2018-11-26 22:31 ` [PATCH 6/9] iommu: qcom_iommu: " Paul Gortmaker 2018-11-26 22:31 ` Paul Gortmaker 2018-11-26 22:31 ` [PATCH 7/9] iommu: tegra-gart: " Paul Gortmaker 2018-11-26 22:31 ` Paul Gortmaker 2018-11-27 14:18 ` Thierry Reding 2018-11-26 22:31 ` [PATCH 8/9] iommu: arm-smmu: " Paul Gortmaker 2018-11-26 22:31 ` Paul Gortmaker 2018-11-26 22:31 ` Paul Gortmaker 2018-11-28 12:42 ` Robin Murphy 2018-11-28 12:42 ` Robin Murphy 2018-11-28 15:24 ` Paul Gortmaker 2018-11-28 15:24 ` Paul Gortmaker 2018-11-28 15:24 ` Paul Gortmaker 2018-11-28 17:28 ` Robin Murphy 2018-11-28 17:28 ` Robin Murphy 2018-11-26 22:31 ` [PATCH 9/9] iommu: arm-smmu-v3: " Paul Gortmaker 2018-11-26 22:31 ` Paul Gortmaker 2018-11-26 22:31 ` Paul Gortmaker 2018-11-28 12:44 ` Robin Murphy 2018-11-28 12:44 ` Robin Murphy 2018-11-28 12:44 ` Robin Murphy 2018-11-27 10:11 ` [PATCH 0/9] iommu: clean up/remove modular stuff from non-modules Joerg Roedel 2018-11-27 10:11 ` Joerg Roedel 2018-11-27 10:11 ` Joerg Roedel [not found] ` <20181127101156.GA12298-zLv9SwRftAIdnm+yROfE0A@public.gmane.org> 2018-11-27 14:39 ` Paul Gortmaker 2018-11-27 14:39 ` Paul Gortmaker 2018-11-27 14:39 ` Paul Gortmaker
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181128221054.GJ14659@windriver.com \ --to=paul.gortmaker@windriver.com \ --cc=iommu@lists.linux-foundation.org \ --cc=joro@8bytes.org \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-kernel@vger.kernel.org \ --cc=robin.murphy@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.