From: Catalin Marinas <catalin.marinas@arm.com>
To: Andrey Konovalov <andreyknvl@google.com>
Cc: Will Deacon <will.deacon@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Robin Murphy <robin.murphy@arm.com>,
Kees Cook <keescook@chromium.org>,
Kate Stewart <kstewart@linuxfoundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Shuah Khan <shuah@kernel.org>,
linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org,
linux-mm@kvack.org, linux-arch@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Chintan Pandya <cpandya@codeaurora.org>,
Jacob Bramley <Jacob.Bramley@arm.com>,
Ruben Ayrapetyan <Ruben.Ayrapetyan@arm.com>,
Lee Smith <Lee.Smith@arm.com>, Kostya Serebryany <kcc@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
Ramana Radhakrishnan <Ramana.Radhakrishnan@arm.com>,
Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
Evgeniy Stepanov <eugenis@google.com>
Subject: Re: [PATCH v8 2/8] uaccess: add untagged_addr definition for other arches
Date: Thu, 29 Nov 2018 18:23:24 +0000 [thread overview]
Message-ID: <20181129182323.GI22027@arrakis.emea.arm.com> (raw)
In-Reply-To: <c9028422854fb5bfb79d798397b30d4701207062.1541687720.git.andreyknvl@google.com>
On Thu, Nov 08, 2018 at 03:36:09PM +0100, Andrey Konovalov wrote:
> diff --git a/include/linux/uaccess.h b/include/linux/uaccess.h
> index efe79c1cdd47..c045b4eff95e 100644
> --- a/include/linux/uaccess.h
> +++ b/include/linux/uaccess.h
> @@ -13,6 +13,10 @@
>
> #include <asm/uaccess.h>
>
> +#ifndef untagged_addr
> +#define untagged_addr(addr) addr
> +#endif
Nitpick: add braces around (addr). Otherwise:
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
WARNING: multiple messages have this Message-ID (diff)
From: catalin.marinas at arm.com (Catalin Marinas)
Subject: [PATCH v8 2/8] uaccess: add untagged_addr definition for other arches
Date: Thu, 29 Nov 2018 18:23:24 +0000 [thread overview]
Message-ID: <20181129182323.GI22027@arrakis.emea.arm.com> (raw)
In-Reply-To: <c9028422854fb5bfb79d798397b30d4701207062.1541687720.git.andreyknvl@google.com>
On Thu, Nov 08, 2018 at 03:36:09PM +0100, Andrey Konovalov wrote:
> diff --git a/include/linux/uaccess.h b/include/linux/uaccess.h
> index efe79c1cdd47..c045b4eff95e 100644
> --- a/include/linux/uaccess.h
> +++ b/include/linux/uaccess.h
> @@ -13,6 +13,10 @@
>
> #include <asm/uaccess.h>
>
> +#ifndef untagged_addr
> +#define untagged_addr(addr) addr
> +#endif
Nitpick: add braces around (addr). Otherwise:
Acked-by: Catalin Marinas <catalin.marinas at arm.com>
WARNING: multiple messages have this Message-ID (diff)
From: catalin.marinas@arm.com (Catalin Marinas)
Subject: [PATCH v8 2/8] uaccess: add untagged_addr definition for other arches
Date: Thu, 29 Nov 2018 18:23:24 +0000 [thread overview]
Message-ID: <20181129182323.GI22027@arrakis.emea.arm.com> (raw)
Message-ID: <20181129182324.mF4vysl1Eg6a6GAiWFQxeTNbllPdFdRa4QPfTjxrjE8@z> (raw)
In-Reply-To: <c9028422854fb5bfb79d798397b30d4701207062.1541687720.git.andreyknvl@google.com>
On Thu, Nov 08, 2018@03:36:09PM +0100, Andrey Konovalov wrote:
> diff --git a/include/linux/uaccess.h b/include/linux/uaccess.h
> index efe79c1cdd47..c045b4eff95e 100644
> --- a/include/linux/uaccess.h
> +++ b/include/linux/uaccess.h
> @@ -13,6 +13,10 @@
>
> #include <asm/uaccess.h>
>
> +#ifndef untagged_addr
> +#define untagged_addr(addr) addr
> +#endif
Nitpick: add braces around (addr). Otherwise:
Acked-by: Catalin Marinas <catalin.marinas at arm.com>
WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Andrey Konovalov <andreyknvl@google.com>
Cc: Will Deacon <will.deacon@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Robin Murphy <robin.murphy@arm.com>,
Kees Cook <keescook@chromium.org>,
Kate Stewart <kstewart@linuxfoundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Shuah Khan <shuah@kernel.org>,
linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org,
linux-mm@kvack.org, linux-arch@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Chintan Pandya <cpandya@codeaurora.org>,
Jacob Bramley <Jacob.Bramley@arm.com>,
Ruben Ayrapetyan <Ruben.Ayrapetyan@arm.com>,
Lee Smith <Lee.Smith@arm.com>, Kostya Serebryany <kcc@goog>
Subject: Re: [PATCH v8 2/8] uaccess: add untagged_addr definition for other arches
Date: Thu, 29 Nov 2018 18:23:24 +0000 [thread overview]
Message-ID: <20181129182323.GI22027@arrakis.emea.arm.com> (raw)
In-Reply-To: <c9028422854fb5bfb79d798397b30d4701207062.1541687720.git.andreyknvl@google.com>
On Thu, Nov 08, 2018 at 03:36:09PM +0100, Andrey Konovalov wrote:
> diff --git a/include/linux/uaccess.h b/include/linux/uaccess.h
> index efe79c1cdd47..c045b4eff95e 100644
> --- a/include/linux/uaccess.h
> +++ b/include/linux/uaccess.h
> @@ -13,6 +13,10 @@
>
> #include <asm/uaccess.h>
>
> +#ifndef untagged_addr
> +#define untagged_addr(addr) addr
> +#endif
Nitpick: add braces around (addr). Otherwise:
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Andrey Konovalov <andreyknvl@google.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Kate Stewart <kstewart@linuxfoundation.org>,
linux-doc@vger.kernel.org, Will Deacon <will.deacon@arm.com>,
Kostya Serebryany <kcc@google.com>,
linux-kselftest@vger.kernel.org,
Chintan Pandya <cpandya@codeaurora.org>,
Shuah Khan <shuah@kernel.org>, Ingo Molnar <mingo@kernel.org>,
linux-arch@vger.kernel.org, Jacob Bramley <Jacob.Bramley@arm.com>,
Dmitry Vyukov <dvyukov@google.com>,
Evgeniy Stepanov <eugenis@google.com>,
Kees Cook <keescook@chromium.org>,
Ruben Ayrapetyan <Ruben.Ayrapetyan@arm.com>,
Ramana Radhakrishnan <Ramana.Radhakrishnan@arm.com>,
linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
Lee Smith <Lee.Smith@arm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Robin Murphy <robin.murphy@arm.com>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>
Subject: Re: [PATCH v8 2/8] uaccess: add untagged_addr definition for other arches
Date: Thu, 29 Nov 2018 18:23:24 +0000 [thread overview]
Message-ID: <20181129182323.GI22027@arrakis.emea.arm.com> (raw)
In-Reply-To: <c9028422854fb5bfb79d798397b30d4701207062.1541687720.git.andreyknvl@google.com>
On Thu, Nov 08, 2018 at 03:36:09PM +0100, Andrey Konovalov wrote:
> diff --git a/include/linux/uaccess.h b/include/linux/uaccess.h
> index efe79c1cdd47..c045b4eff95e 100644
> --- a/include/linux/uaccess.h
> +++ b/include/linux/uaccess.h
> @@ -13,6 +13,10 @@
>
> #include <asm/uaccess.h>
>
> +#ifndef untagged_addr
> +#define untagged_addr(addr) addr
> +#endif
Nitpick: add braces around (addr). Otherwise:
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-11-29 18:23 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 14:36 [PATCH v8 0/8] arm64: untag user pointers passed to the kernel Andrey Konovalov
2018-11-08 14:36 ` Andrey Konovalov
2018-11-08 14:36 ` Andrey Konovalov
2018-11-08 14:36 ` Andrey Konovalov
2018-11-08 14:36 ` andreyknvl
2018-11-08 14:36 ` [PATCH v8 1/8] arm64: add type casts to untagged_addr macro Andrey Konovalov
2018-11-08 14:36 ` Andrey Konovalov
2018-11-08 14:36 ` Andrey Konovalov
2018-11-08 14:36 ` andreyknvl
2018-11-29 18:22 ` Catalin Marinas
2018-11-29 18:22 ` Catalin Marinas
2018-11-29 18:22 ` Catalin Marinas
2018-11-29 18:22 ` Catalin Marinas
2018-11-29 18:22 ` catalin.marinas
2018-12-06 12:34 ` Andrey Konovalov
2018-12-06 12:34 ` Andrey Konovalov
2018-12-06 12:34 ` Andrey Konovalov
2018-12-06 12:34 ` Andrey Konovalov
2018-12-06 12:34 ` Andrey Konovalov
2018-12-06 12:34 ` andreyknvl
2018-11-08 14:36 ` [PATCH v8 2/8] uaccess: add untagged_addr definition for other arches Andrey Konovalov
2018-11-08 14:36 ` Andrey Konovalov
2018-11-08 14:36 ` Andrey Konovalov
2018-11-08 14:36 ` andreyknvl
2018-11-29 18:23 ` Catalin Marinas [this message]
2018-11-29 18:23 ` Catalin Marinas
2018-11-29 18:23 ` Catalin Marinas
2018-11-29 18:23 ` Catalin Marinas
2018-11-29 18:23 ` catalin.marinas
2018-12-06 12:36 ` Andrey Konovalov
2018-12-06 12:36 ` Andrey Konovalov
2018-12-06 12:36 ` Andrey Konovalov
2018-12-06 12:36 ` Andrey Konovalov
2018-12-06 12:36 ` Andrey Konovalov
2018-12-06 12:36 ` andreyknvl
2018-11-08 14:36 ` [PATCH v8 3/8] arm64: untag user addresses in access_ok and __uaccess_mask_ptr Andrey Konovalov
2018-11-08 14:36 ` Andrey Konovalov
2018-11-08 14:36 ` Andrey Konovalov
2018-11-08 14:36 ` andreyknvl
2018-11-29 18:24 ` Catalin Marinas
2018-11-29 18:24 ` Catalin Marinas
2018-11-29 18:24 ` Catalin Marinas
2018-11-29 18:24 ` Catalin Marinas
2018-11-29 18:24 ` catalin.marinas
2018-11-08 14:36 ` [PATCH v8 4/8] mm, arm64: untag user addresses in mm/gup.c Andrey Konovalov
2018-11-08 14:36 ` Andrey Konovalov
2018-11-08 14:36 ` Andrey Konovalov
2018-11-08 14:36 ` andreyknvl
2018-11-08 14:36 ` [PATCH v8 5/8] lib, arm64: untag addrs passed to strncpy_from_user and strnlen_user Andrey Konovalov
2018-11-08 14:36 ` Andrey Konovalov
2018-11-08 14:36 ` Andrey Konovalov
2018-11-08 14:36 ` andreyknvl
2018-11-08 14:36 ` [PATCH v8 6/8] fs, arm64: untag user address in copy_mount_options Andrey Konovalov
2018-11-08 14:36 ` Andrey Konovalov
2018-11-08 14:36 ` Andrey Konovalov
2018-11-08 14:36 ` andreyknvl
2018-11-08 14:36 ` [PATCH v8 7/8] arm64: update Documentation/arm64/tagged-pointers.txt Andrey Konovalov
2018-11-08 14:36 ` Andrey Konovalov
2018-11-08 14:36 ` Andrey Konovalov
2018-11-08 14:36 ` andreyknvl
2018-11-08 14:36 ` [PATCH v8 8/8] selftests, arm64: add a selftest for passing tagged pointers to kernel Andrey Konovalov
2018-11-08 14:36 ` Andrey Konovalov
2018-11-08 14:36 ` Andrey Konovalov
2018-11-08 14:36 ` andreyknvl
2018-11-08 14:48 ` [PATCH v8 0/8] arm64: untag user pointers passed to the kernel Andrey Konovalov
2018-11-08 14:48 ` Andrey Konovalov
2018-11-08 14:48 ` Andrey Konovalov
2018-11-08 14:48 ` Andrey Konovalov
2018-11-08 14:48 ` Andrey Konovalov
2018-11-08 14:48 ` andreyknvl
2018-11-29 18:16 ` Catalin Marinas
2018-11-29 18:16 ` Catalin Marinas
2018-11-29 18:16 ` Catalin Marinas
2018-11-29 18:16 ` Catalin Marinas
2018-11-29 18:16 ` Catalin Marinas
2018-11-29 18:16 ` catalin.marinas
2018-12-06 12:44 ` Andrey Konovalov
2018-12-06 12:44 ` Andrey Konovalov
2018-12-06 12:44 ` Andrey Konovalov
2018-12-06 12:44 ` Andrey Konovalov
2018-12-06 12:44 ` Andrey Konovalov
2018-12-06 12:44 ` andreyknvl
2018-12-06 14:08 ` Catalin Marinas
2018-12-06 14:08 ` Catalin Marinas
2018-12-06 14:08 ` Catalin Marinas
2018-12-06 14:08 ` Catalin Marinas
2018-12-06 14:08 ` Catalin Marinas
2018-12-06 14:08 ` catalin.marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181129182323.GI22027@arrakis.emea.arm.com \
--to=catalin.marinas@arm.com \
--cc=Jacob.Bramley@arm.com \
--cc=Lee.Smith@arm.com \
--cc=Ramana.Radhakrishnan@arm.com \
--cc=Ruben.Ayrapetyan@arm.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@google.com \
--cc=cpandya@codeaurora.org \
--cc=dvyukov@google.com \
--cc=eugenis@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=kcc@google.com \
--cc=keescook@chromium.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luc.vanoostenryck@gmail.com \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=robin.murphy@arm.com \
--cc=shuah@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.