From: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
To: dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Cc: Maxime Ripard <maxime.ripard@bootlin.com>,
David Airlie <airlied@linux.ie>, Chen-Yu Tsai <wens@csie.org>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Sean Paul <sean@poorly.run>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
linux-sunxi@googlegroups.com, Daniel Vetter <daniel@ffwll.ch>,
Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Subject: [PATCH v4 15/22] drm/sun4i: layer: Add tiled modifier support and helper
Date: Wed, 5 Dec 2018 09:36:56 +0100 [thread overview]
Message-ID: <20181205083703.21488-16-paul.kocialkowski@bootlin.com> (raw)
In-Reply-To: <20181205083703.21488-1-paul.kocialkowski@bootlin.com>
This introduces a list of supported modifiers for the driver, that
includes the Allwinner tiled modifier, as well as a format_mod_supported
callback.
The callback uses both the backend and frontend helpers to indicate
per-format modifier support (including for the linear modifier).
Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>
---
drivers/gpu/drm/sun4i/sun4i_layer.c | 16 +++++++++++++++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/sun4i/sun4i_layer.c b/drivers/gpu/drm/sun4i/sun4i_layer.c
index 8cf8ca997b1d..c5a999ca1d72 100644
--- a/drivers/gpu/drm/sun4i/sun4i_layer.c
+++ b/drivers/gpu/drm/sun4i/sun4i_layer.c
@@ -114,6 +114,13 @@ static void sun4i_backend_layer_atomic_update(struct drm_plane *plane,
sun4i_backend_layer_enable(backend, layer->id, true);
}
+static bool sun4i_layer_format_mod_supported(struct drm_plane *plane,
+ uint32_t format, uint64_t modifier)
+{
+ return sun4i_backend_format_is_supported(format, modifier) ||
+ sun4i_frontend_format_is_supported(format, modifier);
+}
+
static const struct drm_plane_helper_funcs sun4i_backend_layer_helper_funcs = {
.prepare_fb = drm_gem_fb_prepare_fb,
.atomic_disable = sun4i_backend_layer_atomic_disable,
@@ -127,6 +134,7 @@ static const struct drm_plane_funcs sun4i_backend_layer_funcs = {
.disable_plane = drm_atomic_helper_disable_plane,
.reset = sun4i_backend_layer_reset,
.update_plane = drm_atomic_helper_update_plane,
+ .format_mod_supported = sun4i_layer_format_mod_supported,
};
static const uint32_t sun4i_layer_formats[] = {
@@ -157,6 +165,12 @@ static const uint32_t sun4i_layer_formats[] = {
DRM_FORMAT_YVYU,
};
+static const uint64_t sun4i_layer_modifiers[] = {
+ DRM_FORMAT_MOD_LINEAR,
+ DRM_FORMAT_MOD_ALLWINNER_TILED,
+ DRM_FORMAT_MOD_INVALID
+};
+
static struct sun4i_layer *sun4i_layer_init_one(struct drm_device *drm,
struct sun4i_backend *backend,
enum drm_plane_type type)
@@ -173,7 +187,7 @@ static struct sun4i_layer *sun4i_layer_init_one(struct drm_device *drm,
&sun4i_backend_layer_funcs,
sun4i_layer_formats,
ARRAY_SIZE(sun4i_layer_formats),
- NULL, type, NULL);
+ sun4i_layer_modifiers, type, NULL);
if (ret) {
dev_err(drm->dev, "Couldn't initialize layer\n");
return ERR_PTR(ret);
--
2.19.2
WARNING: multiple messages have this Message-ID (diff)
From: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
To: dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Cc: Daniel Vetter <daniel@ffwll.ch>,
Maxime Ripard <maxime.ripard@bootlin.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
linux-sunxi@googlegroups.com,
Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
David Airlie <airlied@linux.ie>, Chen-Yu Tsai <wens@csie.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Sean Paul <sean@poorly.run>
Subject: [PATCH v4 15/22] drm/sun4i: layer: Add tiled modifier support and helper
Date: Wed, 5 Dec 2018 09:36:56 +0100 [thread overview]
Message-ID: <20181205083703.21488-16-paul.kocialkowski@bootlin.com> (raw)
In-Reply-To: <20181205083703.21488-1-paul.kocialkowski@bootlin.com>
This introduces a list of supported modifiers for the driver, that
includes the Allwinner tiled modifier, as well as a format_mod_supported
callback.
The callback uses both the backend and frontend helpers to indicate
per-format modifier support (including for the linear modifier).
Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>
---
drivers/gpu/drm/sun4i/sun4i_layer.c | 16 +++++++++++++++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/sun4i/sun4i_layer.c b/drivers/gpu/drm/sun4i/sun4i_layer.c
index 8cf8ca997b1d..c5a999ca1d72 100644
--- a/drivers/gpu/drm/sun4i/sun4i_layer.c
+++ b/drivers/gpu/drm/sun4i/sun4i_layer.c
@@ -114,6 +114,13 @@ static void sun4i_backend_layer_atomic_update(struct drm_plane *plane,
sun4i_backend_layer_enable(backend, layer->id, true);
}
+static bool sun4i_layer_format_mod_supported(struct drm_plane *plane,
+ uint32_t format, uint64_t modifier)
+{
+ return sun4i_backend_format_is_supported(format, modifier) ||
+ sun4i_frontend_format_is_supported(format, modifier);
+}
+
static const struct drm_plane_helper_funcs sun4i_backend_layer_helper_funcs = {
.prepare_fb = drm_gem_fb_prepare_fb,
.atomic_disable = sun4i_backend_layer_atomic_disable,
@@ -127,6 +134,7 @@ static const struct drm_plane_funcs sun4i_backend_layer_funcs = {
.disable_plane = drm_atomic_helper_disable_plane,
.reset = sun4i_backend_layer_reset,
.update_plane = drm_atomic_helper_update_plane,
+ .format_mod_supported = sun4i_layer_format_mod_supported,
};
static const uint32_t sun4i_layer_formats[] = {
@@ -157,6 +165,12 @@ static const uint32_t sun4i_layer_formats[] = {
DRM_FORMAT_YVYU,
};
+static const uint64_t sun4i_layer_modifiers[] = {
+ DRM_FORMAT_MOD_LINEAR,
+ DRM_FORMAT_MOD_ALLWINNER_TILED,
+ DRM_FORMAT_MOD_INVALID
+};
+
static struct sun4i_layer *sun4i_layer_init_one(struct drm_device *drm,
struct sun4i_backend *backend,
enum drm_plane_type type)
@@ -173,7 +187,7 @@ static struct sun4i_layer *sun4i_layer_init_one(struct drm_device *drm,
&sun4i_backend_layer_funcs,
sun4i_layer_formats,
ARRAY_SIZE(sun4i_layer_formats),
- NULL, type, NULL);
+ sun4i_layer_modifiers, type, NULL);
if (ret) {
dev_err(drm->dev, "Couldn't initialize layer\n");
return ERR_PTR(ret);
--
2.19.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Paul Kocialkowski <paul.kocialkowski-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org>
To: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Maxime Ripard
<maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org>,
David Airlie <airlied-cv59FeDIM0c@public.gmane.org>,
Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
Maarten Lankhorst
<maarten.lankhorst-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Sean Paul <sean-p7yTbzM4H96eqtR555YLDQ@public.gmane.org>,
Thomas Petazzoni
<thomas.petazzoni-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org>,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
Daniel Vetter <daniel-/w4YWyX8dFk@public.gmane.org>,
Paul Kocialkowski
<paul.kocialkowski-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org>
Subject: [PATCH v4 15/22] drm/sun4i: layer: Add tiled modifier support and helper
Date: Wed, 5 Dec 2018 09:36:56 +0100 [thread overview]
Message-ID: <20181205083703.21488-16-paul.kocialkowski@bootlin.com> (raw)
In-Reply-To: <20181205083703.21488-1-paul.kocialkowski-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org>
This introduces a list of supported modifiers for the driver, that
includes the Allwinner tiled modifier, as well as a format_mod_supported
callback.
The callback uses both the backend and frontend helpers to indicate
per-format modifier support (including for the linear modifier).
Signed-off-by: Paul Kocialkowski <paul.kocialkowski-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org>
Acked-by: Maxime Ripard <maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org>
---
drivers/gpu/drm/sun4i/sun4i_layer.c | 16 +++++++++++++++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/sun4i/sun4i_layer.c b/drivers/gpu/drm/sun4i/sun4i_layer.c
index 8cf8ca997b1d..c5a999ca1d72 100644
--- a/drivers/gpu/drm/sun4i/sun4i_layer.c
+++ b/drivers/gpu/drm/sun4i/sun4i_layer.c
@@ -114,6 +114,13 @@ static void sun4i_backend_layer_atomic_update(struct drm_plane *plane,
sun4i_backend_layer_enable(backend, layer->id, true);
}
+static bool sun4i_layer_format_mod_supported(struct drm_plane *plane,
+ uint32_t format, uint64_t modifier)
+{
+ return sun4i_backend_format_is_supported(format, modifier) ||
+ sun4i_frontend_format_is_supported(format, modifier);
+}
+
static const struct drm_plane_helper_funcs sun4i_backend_layer_helper_funcs = {
.prepare_fb = drm_gem_fb_prepare_fb,
.atomic_disable = sun4i_backend_layer_atomic_disable,
@@ -127,6 +134,7 @@ static const struct drm_plane_funcs sun4i_backend_layer_funcs = {
.disable_plane = drm_atomic_helper_disable_plane,
.reset = sun4i_backend_layer_reset,
.update_plane = drm_atomic_helper_update_plane,
+ .format_mod_supported = sun4i_layer_format_mod_supported,
};
static const uint32_t sun4i_layer_formats[] = {
@@ -157,6 +165,12 @@ static const uint32_t sun4i_layer_formats[] = {
DRM_FORMAT_YVYU,
};
+static const uint64_t sun4i_layer_modifiers[] = {
+ DRM_FORMAT_MOD_LINEAR,
+ DRM_FORMAT_MOD_ALLWINNER_TILED,
+ DRM_FORMAT_MOD_INVALID
+};
+
static struct sun4i_layer *sun4i_layer_init_one(struct drm_device *drm,
struct sun4i_backend *backend,
enum drm_plane_type type)
@@ -173,7 +187,7 @@ static struct sun4i_layer *sun4i_layer_init_one(struct drm_device *drm,
&sun4i_backend_layer_funcs,
sun4i_layer_formats,
ARRAY_SIZE(sun4i_layer_formats),
- NULL, type, NULL);
+ sun4i_layer_modifiers, type, NULL);
if (ret) {
dev_err(drm->dev, "Couldn't initialize layer\n");
return ERR_PTR(ret);
--
2.19.2
next prev parent reply other threads:[~2018-12-05 8:38 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-05 8:36 [PATCH v4 00/22] drm/sun4i: Support for linear and tiled YUV formats with the frontend Paul Kocialkowski
2018-12-05 8:36 ` Paul Kocialkowski
2018-12-05 8:36 ` Paul Kocialkowski
2018-12-05 8:36 ` [PATCH v4 01/22] drm/fourcc: Add format info helpers for checking YUV planes disposition Paul Kocialkowski
2018-12-05 8:36 ` Paul Kocialkowski
2018-12-05 8:36 ` Paul Kocialkowski
2018-12-05 8:36 ` [PATCH v4 02/22] drm/fourcc: Add format info helpers for checking YUV sub-sampling Paul Kocialkowski
2018-12-05 8:36 ` Paul Kocialkowski
2018-12-05 8:36 ` Paul Kocialkowski
2018-12-05 8:36 ` [PATCH v4 03/22] drm/sun4i: backend: Use explicit fourcc helpers for packed YUV422 check Paul Kocialkowski
2018-12-05 8:36 ` Paul Kocialkowski
2018-12-05 8:36 ` Paul Kocialkowski
2018-12-05 8:36 ` [PATCH v4 04/22] drm/sun4i: frontend: Pass DRM format info to input format helpers Paul Kocialkowski
2018-12-05 8:36 ` Paul Kocialkowski
2018-12-05 8:36 ` Paul Kocialkowski
2018-12-05 15:35 ` Maxime Ripard
2018-12-05 15:35 ` Maxime Ripard
2018-12-05 15:35 ` Maxime Ripard
2018-12-05 8:36 ` [PATCH v4 05/22] drm/sun4i: frontend: Determine input format based on colorspace Paul Kocialkowski
2018-12-05 8:36 ` Paul Kocialkowski
2018-12-05 8:36 ` Paul Kocialkowski
2018-12-05 15:39 ` Maxime Ripard
2018-12-05 15:39 ` Maxime Ripard
2018-12-05 15:39 ` Maxime Ripard
2018-12-05 8:36 ` [PATCH v4 06/22] drm/sun4i: Move the BT.601 CSC coefficients to the frontend Paul Kocialkowski
2018-12-05 8:36 ` Paul Kocialkowski
2018-12-05 8:36 ` Paul Kocialkowski
2018-12-05 15:38 ` Maxime Ripard
2018-12-05 15:38 ` Maxime Ripard
2018-12-05 15:38 ` Maxime Ripard
2018-12-05 8:36 ` [PATCH v4 07/22] drm/sun4i: frontend: Configure and enable YUV to RGB CSC when needed Paul Kocialkowski
2018-12-05 8:36 ` Paul Kocialkowski
2018-12-05 8:36 ` Paul Kocialkowski
2018-12-05 15:38 ` Maxime Ripard
2018-12-05 15:38 ` Maxime Ripard
2018-12-05 15:38 ` Maxime Ripard
2018-12-05 8:36 ` [PATCH v4 08/22] drm/sun4i: frontend: Add support for packed YUV422 input formats Paul Kocialkowski
2018-12-05 8:36 ` Paul Kocialkowski
2018-12-05 8:36 ` Paul Kocialkowski
2018-12-05 8:36 ` [PATCH v4 09/22] drm/sun4i: frontend: Add support for semi-planar YUV " Paul Kocialkowski
2018-12-05 8:36 ` Paul Kocialkowski
2018-12-05 8:36 ` Paul Kocialkowski
2018-12-05 8:36 ` [PATCH v4 10/22] drm/sun4i: frontend: Add support for planar " Paul Kocialkowski
2018-12-05 8:36 ` Paul Kocialkowski
2018-12-05 8:36 ` Paul Kocialkowski
2018-12-05 8:36 ` [PATCH v4 11/22] drm/fourcc: Add definitions for Allwinner vendor and VPU tiled format Paul Kocialkowski
2018-12-05 8:36 ` Paul Kocialkowski
2018-12-05 8:36 ` Paul Kocialkowski
2018-12-05 8:36 ` [PATCH v4 12/22] drm/sun4i: frontend: Add support for tiled YUV input mode configuration Paul Kocialkowski
2018-12-05 8:36 ` Paul Kocialkowski
2018-12-05 8:36 ` Paul Kocialkowski
2018-12-05 8:36 ` [PATCH v4 13/22] drm/sun4i: Add buffer stride and offset configuration for tiling mode Paul Kocialkowski
2018-12-05 8:36 ` Paul Kocialkowski
2018-12-05 8:36 ` Paul Kocialkowski
2018-12-05 15:44 ` Maxime Ripard
2018-12-05 15:44 ` Maxime Ripard
2018-12-05 8:36 ` [PATCH v4 14/22] drm/sun4i: frontend: Add and use helper for checking tiling support Paul Kocialkowski
2018-12-05 8:36 ` Paul Kocialkowski
2018-12-05 8:36 ` Paul Kocialkowski
2018-12-05 8:36 ` Paul Kocialkowski [this message]
2018-12-05 8:36 ` [PATCH v4 15/22] drm/sun4i: layer: Add tiled modifier support and helper Paul Kocialkowski
2018-12-05 8:36 ` Paul Kocialkowski
2018-12-05 8:36 ` [PATCH v4 16/22] drm/sun4i: drv: Allow framebuffer modifiers in mode config Paul Kocialkowski
2018-12-05 8:36 ` Paul Kocialkowski
2018-12-05 8:36 ` Paul Kocialkowski
2018-12-05 8:36 ` [PATCH v4 17/22] drm/sun4i: Move access control before setting the register as documented Paul Kocialkowski
2018-12-05 8:36 ` Paul Kocialkowski
2018-12-05 8:36 ` Paul Kocialkowski
2018-12-05 8:36 ` [PATCH v4 18/22] drm/sun4i: frontend: Add a quirk structure Paul Kocialkowski
2018-12-05 8:36 ` Paul Kocialkowski
2018-12-05 8:36 ` Paul Kocialkowski
2018-12-05 8:37 ` [PATCH v4 19/22] drm/sun4i: Set the coef_rdy bit right after the coef have been set Paul Kocialkowski
2018-12-05 8:37 ` Paul Kocialkowski
2018-12-05 8:37 ` Paul Kocialkowski
2018-12-05 8:37 ` [PATCH v4 20/22] drm/sun4i: Make COEF_RDY conditional Paul Kocialkowski
2018-12-05 8:37 ` Paul Kocialkowski
2018-12-05 8:37 ` Paul Kocialkowski
2018-12-05 8:37 ` [PATCH v4 21/22] drm/sun4i: frontend: Move the FIR filter phases to our quirks Paul Kocialkowski
2018-12-05 8:37 ` Paul Kocialkowski
2018-12-05 8:37 ` Paul Kocialkowski
2018-12-05 8:37 ` [PATCH v4 22/22] drm/sun4i: frontend: Add A20-specific device-tree compatible and quirks Paul Kocialkowski
2018-12-05 8:37 ` Paul Kocialkowski
2018-12-05 8:37 ` Paul Kocialkowski
2019-01-03 10:10 ` [PATCH v4 00/22] drm/sun4i: Support for linear and tiled YUV formats with the frontend Paul Kocialkowski
2019-01-03 10:10 ` Paul Kocialkowski
2019-01-03 10:10 ` Paul Kocialkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181205083703.21488-16-paul.kocialkowski@bootlin.com \
--to=paul.kocialkowski@bootlin.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=maxime.ripard@bootlin.com \
--cc=sean@poorly.run \
--cc=thomas.petazzoni@bootlin.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.