From: Pavel Machek <pavel@ucw.cz>
To: Chanwoo Choi <cw00.choi@samsung.com>
Cc: Lukasz Luba <l.luba@partner.samsung.com>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
tjakobi@math.uni-bielefeld.de, myungjoo.ham@samsung.com,
kyungmin.park@samsung.com, rjw@rjwysocki.net,
len.brown@intel.com, gregkh@linuxfoundation.org,
keescook@chromium.org, anton@enomsg.org, ccross@android.com,
tony.luck@intel.com, robh+dt@kernel.org, mark.rutland@arm.com,
kgene@kernel.org, krzk@kernel.org, m.szyprowski@samsung.com,
b.zolnierkie@samsung.com
Subject: Re: [PATCH v2 2/5] devfreq: add support for suspend/resume of a devfreq device
Date: Sun, 9 Dec 2018 10:00:07 +0100 [thread overview]
Message-ID: <20181209090007.GD7561@amd> (raw)
In-Reply-To: <5C06124B.5030409@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 956 bytes --]
On Tue 2018-12-04 14:36:11, Chanwoo Choi wrote:
> Hi Lukasz,
>
> Looks good to me. But, I add the some comments.
> If you will fix it, feel free to add my tag:
> Reviewed-by: Chanwoo choi <cw00.choi@samsung.com>
>
> On 2018년 12월 03일 23:31, Lukasz Luba wrote:
> > The patch prepares devfreq device for handling suspend/resume
> > functionality. The new fields will store needed information during this
>
> nitpick. Remove unneeded space. There are two spaces between '.' and 'The new'.
Yes. And that's because two spaces are okay at that place.
https://www.writersdigest.com/online-editor/how-many-spaces-after-a-period
Please don't cause unneeded noise on the list with trivial
comments. If the patch is okay, apply the patch, no need to find
trivial nit everywhere.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Chanwoo Choi <cw00.choi@samsung.com>
Cc: mark.rutland@arm.com, anton@enomsg.org, len.brown@intel.com,
Lukasz Luba <l.luba@partner.samsung.com>,
m.szyprowski@samsung.com, linux-samsung-soc@vger.kernel.org,
b.zolnierkie@samsung.com, krzk@kernel.org,
myungjoo.ham@samsung.com, devicetree@vger.kernel.org,
keescook@chromium.org, linux-pm@vger.kernel.org,
robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org,
tony.luck@intel.com, gregkh@linuxfoundation.org,
rjw@rjwysocki.net, linux-kernel@vger.kernel.org,
tjakobi@math.uni-bielefeld.de, kyungmin.park@samsung.com,
kgene@kernel.org, ccross@android.com
Subject: Re: [PATCH v2 2/5] devfreq: add support for suspend/resume of a devfreq device
Date: Sun, 9 Dec 2018 10:00:07 +0100 [thread overview]
Message-ID: <20181209090007.GD7561@amd> (raw)
In-Reply-To: <5C06124B.5030409@samsung.com>
[-- Attachment #1.1: Type: text/plain, Size: 956 bytes --]
On Tue 2018-12-04 14:36:11, Chanwoo Choi wrote:
> Hi Lukasz,
>
> Looks good to me. But, I add the some comments.
> If you will fix it, feel free to add my tag:
> Reviewed-by: Chanwoo choi <cw00.choi@samsung.com>
>
> On 2018년 12월 03일 23:31, Lukasz Luba wrote:
> > The patch prepares devfreq device for handling suspend/resume
> > functionality. The new fields will store needed information during this
>
> nitpick. Remove unneeded space. There are two spaces between '.' and 'The new'.
Yes. And that's because two spaces are okay at that place.
https://www.writersdigest.com/online-editor/how-many-spaces-after-a-period
Please don't cause unneeded noise on the list with trivial
comments. If the patch is okay, apply the patch, no need to find
trivial nit everywhere.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-12-09 9:00 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20181203143127eucas1p2604fc066139a32fdffe996212b42b40e@eucas1p2.samsung.com>
2018-12-03 14:31 ` [PATCH v2 0/5] devfreq: handle suspend/resume Lukasz Luba
2018-12-03 14:31 ` Lukasz Luba
[not found] ` <CGME20181203143129eucas1p2955b6becc60ee57110cbc52f6e4f60c5@eucas1p2.samsung.com>
2018-12-03 14:31 ` [PATCH v2 1/5] devfreq: refactor set_target frequency function Lukasz Luba
2018-12-03 14:31 ` Lukasz Luba
2018-12-04 4:39 ` Chanwoo Choi
2018-12-04 4:39 ` Chanwoo Choi
2018-12-04 5:43 ` Chanwoo Choi
2018-12-04 5:43 ` Chanwoo Choi
2018-12-04 9:36 ` Lukasz Luba
2018-12-04 9:36 ` Lukasz Luba
[not found] ` <CGME20181203143131eucas1p217f22ac6d19682a54a57658a06980914@eucas1p2.samsung.com>
2018-12-03 14:31 ` [PATCH v2 2/5] devfreq: add support for suspend/resume of a devfreq device Lukasz Luba
2018-12-03 14:31 ` Lukasz Luba
2018-12-04 5:36 ` Chanwoo Choi
2018-12-04 5:36 ` Chanwoo Choi
2018-12-04 5:43 ` Chanwoo Choi
2018-12-04 5:43 ` Chanwoo Choi
2018-12-04 6:10 ` Chanwoo Choi
2018-12-04 6:10 ` Chanwoo Choi
2018-12-04 9:53 ` Lukasz Luba
2018-12-04 9:53 ` Lukasz Luba
2018-12-05 0:09 ` Chanwoo Choi
2018-12-05 0:09 ` Chanwoo Choi
2018-12-05 11:07 ` Lukasz Luba
2018-12-05 11:07 ` Lukasz Luba
2018-12-04 9:39 ` Lukasz Luba
2018-12-04 9:39 ` Lukasz Luba
2018-12-09 9:00 ` Pavel Machek [this message]
2018-12-09 9:00 ` Pavel Machek
[not found] ` <CGME20181203143132eucas1p128c029a7c7461e1127924a08e4a71811@eucas1p1.samsung.com>
2018-12-03 14:31 ` [PATCH v2 3/5] devfreq: add devfreq_suspend/resume() functions Lukasz Luba
2018-12-03 14:31 ` Lukasz Luba
2018-12-04 6:19 ` Chanwoo Choi
2018-12-04 6:19 ` Chanwoo Choi
2018-12-04 9:44 ` Lukasz Luba
2018-12-04 9:44 ` Lukasz Luba
[not found] ` <CGME20181203143134eucas1p1edd70b0f4dca115f6f154555d8829427@eucas1p1.samsung.com>
2018-12-03 14:31 ` [PATCH v2 4/5] drivers: power: suspend: call devfreq suspend/resume Lukasz Luba
2018-12-03 14:31 ` Lukasz Luba
[not found] ` <CGME20181203143135eucas1p165fe6183ae90de7906f9683cb41ff4c1@eucas1p1.samsung.com>
2018-12-03 14:31 ` [PATCH v2 5/5] arm: dts: exynos4: opp-suspend in DMC and leftbus Lukasz Luba
2018-12-03 14:31 ` Lukasz Luba
2018-12-03 17:22 ` Krzysztof Kozlowski
2018-12-03 17:22 ` Krzysztof Kozlowski
2018-12-03 17:48 ` Lukasz Luba
2018-12-03 17:48 ` Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181209090007.GD7561@amd \
--to=pavel@ucw.cz \
--cc=anton@enomsg.org \
--cc=b.zolnierkie@samsung.com \
--cc=ccross@android.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=l.luba@partner.samsung.com \
--cc=len.brown@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=myungjoo.ham@samsung.com \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=tjakobi@math.uni-bielefeld.de \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.