From: "Dmitry V. Levin" <ldv@altlinux.org> To: Michael Ellerman <mpe@ellerman.id.au>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, Paul Mackerras <paulus@samba.org>, Oleg Nesterov <oleg@redhat.com>, Andy Lutomirski <luto@kernel.org> Cc: Elvira Khabirova <lineprinter@altlinux.org>, Eugene Syromyatnikov <esyr@redhat.com>, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 16/25] powerpc: define syscall_get_error() Date: Mon, 10 Dec 2018 07:30:26 +0300 [thread overview] Message-ID: <20181210043026.GP6131@altlinux.org> (raw) In-Reply-To: 20181210042352.GA6092@altlinux.org syscall_get_error() is required to be implemented on this architecture in addition to already implemented syscall_get_nr(), syscall_get_arguments(), syscall_get_return_value(), and syscall_get_arch() functions in order to extend the generic ptrace API with PTRACE_GET_SYSCALL_INFO request. Cc: Michael Ellerman <mpe@ellerman.id.au> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: Paul Mackerras <paulus@samba.org> Cc: Oleg Nesterov <oleg@redhat.com> Cc: Andy Lutomirski <luto@kernel.org> Cc: Elvira Khabirova <lineprinter@altlinux.org> Cc: Eugene Syromyatnikov <esyr@redhat.com> Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Dmitry V. Levin <ldv@altlinux.org> --- Notes: This change has been tested with tools/testing/selftests/ptrace/get_syscall_info.c and strace, so it's correct from PTRACE_GET_SYSCALL_INFO point of view. This cast doubts on commit v4.3-rc1~86^2~81 that changed syscall_set_return_value() in a way that doesn't quite match syscall_get_error(), but syscall_set_return_value() is out of scope of this series, so I just air my concerns. arch/powerpc/include/asm/syscall.h | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/arch/powerpc/include/asm/syscall.h b/arch/powerpc/include/asm/syscall.h index ab9f3f0a8637..1d03e753391d 100644 --- a/arch/powerpc/include/asm/syscall.h +++ b/arch/powerpc/include/asm/syscall.h @@ -39,6 +39,16 @@ static inline void syscall_rollback(struct task_struct *task, regs->gpr[3] = regs->orig_gpr3; } +static inline long syscall_get_error(struct task_struct *task, + struct pt_regs *regs) +{ + /* + * If the system call failed, + * regs->gpr[3] contains a positive ERRORCODE. + */ + return (regs->ccr & 0x10000000UL) ? -regs->gpr[3] : 0; +} + static inline long syscall_get_return_value(struct task_struct *task, struct pt_regs *regs) { -- ldv
WARNING: multiple messages have this Message-ID (diff)
From: "Dmitry V. Levin" <ldv@altlinux.org> To: Michael Ellerman <mpe@ellerman.id.au>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, Paul Mackerras <paulus@samba.org>, Oleg Nesterov <oleg@redhat.com>, Andy Lutomirski <luto@kernel.org> Cc: Elvira Khabirova <lineprinter@altlinux.org>, linuxppc-dev@lists.ozlabs.org, Eugene Syromyatnikov <esyr@redhat.com>, linux-kernel@vger.kernel.org Subject: [PATCH v5 16/25] powerpc: define syscall_get_error() Date: Mon, 10 Dec 2018 07:30:26 +0300 [thread overview] Message-ID: <20181210043026.GP6131@altlinux.org> (raw) In-Reply-To: 20181210042352.GA6092@altlinux.org syscall_get_error() is required to be implemented on this architecture in addition to already implemented syscall_get_nr(), syscall_get_arguments(), syscall_get_return_value(), and syscall_get_arch() functions in order to extend the generic ptrace API with PTRACE_GET_SYSCALL_INFO request. Cc: Michael Ellerman <mpe@ellerman.id.au> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: Paul Mackerras <paulus@samba.org> Cc: Oleg Nesterov <oleg@redhat.com> Cc: Andy Lutomirski <luto@kernel.org> Cc: Elvira Khabirova <lineprinter@altlinux.org> Cc: Eugene Syromyatnikov <esyr@redhat.com> Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Dmitry V. Levin <ldv@altlinux.org> --- Notes: This change has been tested with tools/testing/selftests/ptrace/get_syscall_info.c and strace, so it's correct from PTRACE_GET_SYSCALL_INFO point of view. This cast doubts on commit v4.3-rc1~86^2~81 that changed syscall_set_return_value() in a way that doesn't quite match syscall_get_error(), but syscall_set_return_value() is out of scope of this series, so I just air my concerns. arch/powerpc/include/asm/syscall.h | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/arch/powerpc/include/asm/syscall.h b/arch/powerpc/include/asm/syscall.h index ab9f3f0a8637..1d03e753391d 100644 --- a/arch/powerpc/include/asm/syscall.h +++ b/arch/powerpc/include/asm/syscall.h @@ -39,6 +39,16 @@ static inline void syscall_rollback(struct task_struct *task, regs->gpr[3] = regs->orig_gpr3; } +static inline long syscall_get_error(struct task_struct *task, + struct pt_regs *regs) +{ + /* + * If the system call failed, + * regs->gpr[3] contains a positive ERRORCODE. + */ + return (regs->ccr & 0x10000000UL) ? -regs->gpr[3] : 0; +} + static inline long syscall_get_return_value(struct task_struct *task, struct pt_regs *regs) { -- ldv
next prev parent reply other threads:[~2018-12-10 4:30 UTC|newest] Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-12-10 4:23 [PATCH v5 00/25] ptrace: add PTRACE_GET_SYSCALL_INFO request Dmitry V. Levin 2018-12-10 4:23 ` Dmitry V. Levin 2018-12-10 4:23 ` Dmitry V. Levin 2018-12-10 4:23 ` [OpenRISC] " Dmitry V. Levin 2018-12-10 4:23 ` Dmitry V. Levin 2018-12-10 4:23 ` Dmitry V. Levin 2018-12-10 4:23 ` Dmitry V. Levin 2018-12-10 4:27 ` [PATCH v5 01/25] alpha: define remaining syscall_get_* functions Dmitry V. Levin 2018-12-10 4:28 ` [PATCH v5 02/25] Move EM_ARCOMPACT and EM_ARCV2 to uapi/linux/elf-em.h Dmitry V. Levin 2018-12-10 4:28 ` Dmitry V. Levin 2018-12-10 4:29 ` [PATCH v5 03/25] arc: define syscall_get_arch() Dmitry V. Levin 2018-12-10 4:29 ` Dmitry V. Levin 2018-12-10 4:29 ` [PATCH v5 04/25] c6x: " Dmitry V. Levin 2018-12-11 22:40 ` Mark Salter 2018-12-10 4:29 ` [PATCH v5 05/25] elf-em.h: add EM_CSKY Dmitry V. Levin 2018-12-10 4:29 ` [PATCH v5 06/25] csky: define syscall_get_arch() Dmitry V. Levin 2018-12-10 4:29 ` [PATCH v5 07/25] h8300: define remaining syscall_get_* functions Dmitry V. Levin 2018-12-10 4:29 ` [PATCH v5 08/25] Move EM_HEXAGON to uapi/linux/elf-em.h Dmitry V. Levin 2018-12-10 4:29 ` [PATCH v5 09/25] hexagon: define remaining syscall_get_* functions Dmitry V. Levin 2018-12-10 4:29 ` [PATCH v5 10/25] Move EM_NDS32 to uapi/linux/elf-em.h Dmitry V. Levin 2018-12-10 4:29 ` [PATCH v5 11/25] nds32: define syscall_get_arch() Dmitry V. Levin 2018-12-10 4:30 ` [PATCH v5 12/25] nios2: " Dmitry V. Levin 2018-12-10 4:30 ` [PATCH v5 13/25] m68k: add asm/syscall.h Dmitry V. Levin 2018-12-10 8:45 ` Geert Uytterhoeven 2018-12-10 12:40 ` Dmitry V. Levin 2018-12-10 13:06 ` Geert Uytterhoeven 2018-12-10 13:30 ` Dmitry V. Levin 2018-12-12 8:55 ` Dmitry V. Levin 2018-12-12 9:01 ` Geert Uytterhoeven 2018-12-12 9:27 ` Dmitry V. Levin 2018-12-12 9:43 ` Geert Uytterhoeven 2018-12-12 12:04 ` Dmitry V. Levin 2018-12-12 12:27 ` Geert Uytterhoeven 2018-12-12 12:37 ` Dmitry V. Levin 2018-12-12 12:54 ` Geert Uytterhoeven 2018-12-12 13:07 ` Dmitry V. Levin 2018-12-12 23:12 ` Dmitry V. Levin 2019-03-29 22:04 ` Dmitry V. Levin 2019-03-30 20:57 ` Geert Uytterhoeven 2018-12-10 4:30 ` [PATCH v5 14/25] mips: define syscall_get_error() Dmitry V. Levin 2018-12-10 4:30 ` [PATCH v5 15/25] parisc: " Dmitry V. Levin 2018-12-10 4:30 ` Dmitry V. Levin [this message] 2018-12-10 4:30 ` [PATCH v5 16/25] powerpc: " Dmitry V. Levin 2018-12-10 4:30 ` [PATCH v5 17/25] riscv: define syscall_get_arch() Dmitry V. Levin 2018-12-10 4:30 ` Dmitry V. Levin 2018-12-10 4:30 ` [PATCH v5 18/25] Move EM_XTENSA to uapi/linux/elf-em.h Dmitry V. Levin 2018-12-10 4:30 ` [PATCH v5 19/25] xtensa: define syscall_get_* functions Dmitry V. Levin 2018-12-10 5:02 ` Max Filippov 2018-12-10 12:53 ` Dmitry V. Levin 2018-12-10 20:14 ` Max Filippov 2018-12-10 20:24 ` Dmitry V. Levin 2018-12-10 20:30 ` Dmitry V. Levin 2018-12-10 21:29 ` Max Filippov 2018-12-12 10:45 ` kbuild test robot 2018-12-19 5:58 ` kbuild test robot 2018-12-10 4:30 ` [PATCH v5 20/25] Move EM_UNICORE to uapi/linux/elf-em.h Dmitry V. Levin 2018-12-10 4:30 ` [PATCH v5 21/25] unicore32: add asm/syscall.h Dmitry V. Levin 2018-12-10 4:31 ` [PATCH v5 22/25] syscall_get_arch: add "struct task_struct *" argument Dmitry V. Levin 2018-12-10 4:31 ` [OpenRISC] " Dmitry V. Levin 2018-12-10 4:31 ` Dmitry V. Levin 2018-12-10 4:31 ` Dmitry V. Levin 2018-12-10 4:31 ` Dmitry V. Levin 2018-12-10 4:31 ` Dmitry V. Levin 2018-12-10 4:31 ` Dmitry V. Levin 2018-12-10 17:29 ` Kees Cook 2018-12-11 22:44 ` Mark Salter 2018-12-10 4:31 ` [PATCH v5 23/25] powerpc/ptrace: replace ptrace_report_syscall() with a tracehook call Dmitry V. Levin 2018-12-10 4:31 ` Dmitry V. Levin 2018-12-10 4:31 ` [PATCH v5 24/25] ptrace: add PTRACE_GET_SYSCALL_INFO request Dmitry V. Levin 2018-12-10 4:31 ` Dmitry V. Levin 2018-12-10 14:11 ` Oleg Nesterov 2018-12-10 16:21 ` Dmitry V. Levin 2018-12-10 16:21 ` Dmitry V. Levin 2018-12-11 15:29 ` Oleg Nesterov 2018-12-11 16:23 ` Dmitry V. Levin 2018-12-11 16:23 ` Dmitry V. Levin 2018-12-11 20:27 ` Dmitry V. Levin 2018-12-12 18:00 ` Oleg Nesterov 2018-12-10 14:26 ` kbuild test robot 2018-12-10 16:09 ` Dmitry V. Levin 2018-12-10 16:09 ` Dmitry V. Levin 2018-12-10 18:04 ` Paul Burton 2018-12-10 21:04 ` Palmer Dabbelt 2018-12-10 19:38 ` Andy Lutomirski 2018-12-10 19:38 ` Andy Lutomirski 2018-12-10 17:44 ` Kees Cook 2018-12-12 9:28 ` kbuild test robot 2018-12-10 4:31 ` [PATCH v5 25/25] selftests/ptrace: add a test case for PTRACE_GET_SYSCALL_INFO Dmitry V. Levin 2018-12-10 4:31 ` Dmitry V. Levin 2018-12-10 4:31 ` ldv
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181210043026.GP6131@altlinux.org \ --to=ldv@altlinux.org \ --cc=benh@kernel.crashing.org \ --cc=esyr@redhat.com \ --cc=lineprinter@altlinux.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=luto@kernel.org \ --cc=mpe@ellerman.id.au \ --cc=oleg@redhat.com \ --cc=paulus@samba.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.