From: "Niklas Söderlund" <niklas.soderlund@ragnatech.se> To: Jacopo Mondi <jacopo+renesas@jmondi.org> Cc: laurent.pinchart@ideasonboard.com, kieran.bingham@ideasonboard.com, linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH] media: rcar-csi2: Fix PHTW table values for E3/V3M Date: Mon, 10 Dec 2018 16:24:50 +0100 [thread overview] Message-ID: <20181210152450.GJ17972@bigcity.dyn.berto.se> (raw) In-Reply-To: <1544453635-16359-1-git-send-email-jacopo+renesas@jmondi.org> Hi Jacopo, Thanks for fixing this. On 2018-12-10 15:53:55 +0100, Jacopo Mondi wrote: > The PHTW selection algorithm implemented in rcsi2_phtw_write_mbps() checks for > lower bound of the interval used to match the desired bandwidth. Use that > in place of the currently used upport bound. > > Fixes: 10c08812fe60 ("media: rcar: rcar-csi2: Update V3M/E3 PHTW tables") > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> Acked-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > --- > drivers/media/platform/rcar-vin/rcar-csi2.c | 62 ++++++++++++++--------------- > 1 file changed, 31 insertions(+), 31 deletions(-) > > diff --git a/drivers/media/platform/rcar-vin/rcar-csi2.c b/drivers/media/platform/rcar-vin/rcar-csi2.c > index 80ad906d1136..7e9cb8bcfe70 100644 > --- a/drivers/media/platform/rcar-vin/rcar-csi2.c > +++ b/drivers/media/platform/rcar-vin/rcar-csi2.c > @@ -152,37 +152,37 @@ static const struct rcsi2_mbps_reg phtw_mbps_h3_v3h_m3n[] = { > }; > > static const struct rcsi2_mbps_reg phtw_mbps_v3m_e3[] = { > - { .mbps = 89, .reg = 0x00 }, > - { .mbps = 99, .reg = 0x20 }, > - { .mbps = 109, .reg = 0x40 }, > - { .mbps = 129, .reg = 0x02 }, > - { .mbps = 139, .reg = 0x22 }, > - { .mbps = 149, .reg = 0x42 }, > - { .mbps = 169, .reg = 0x04 }, > - { .mbps = 179, .reg = 0x24 }, > - { .mbps = 199, .reg = 0x44 }, > - { .mbps = 219, .reg = 0x06 }, > - { .mbps = 239, .reg = 0x26 }, > - { .mbps = 249, .reg = 0x46 }, > - { .mbps = 269, .reg = 0x08 }, > - { .mbps = 299, .reg = 0x28 }, > - { .mbps = 329, .reg = 0x0a }, > - { .mbps = 359, .reg = 0x2a }, > - { .mbps = 399, .reg = 0x4a }, > - { .mbps = 449, .reg = 0x0c }, > - { .mbps = 499, .reg = 0x2c }, > - { .mbps = 549, .reg = 0x0e }, > - { .mbps = 599, .reg = 0x2e }, > - { .mbps = 649, .reg = 0x10 }, > - { .mbps = 699, .reg = 0x30 }, > - { .mbps = 749, .reg = 0x12 }, > - { .mbps = 799, .reg = 0x32 }, > - { .mbps = 849, .reg = 0x52 }, > - { .mbps = 899, .reg = 0x72 }, > - { .mbps = 949, .reg = 0x14 }, > - { .mbps = 999, .reg = 0x34 }, > - { .mbps = 1049, .reg = 0x54 }, > - { .mbps = 1099, .reg = 0x74 }, > + { .mbps = 80, .reg = 0x00 }, > + { .mbps = 90, .reg = 0x20 }, > + { .mbps = 100, .reg = 0x40 }, > + { .mbps = 110, .reg = 0x02 }, > + { .mbps = 130, .reg = 0x22 }, > + { .mbps = 140, .reg = 0x42 }, > + { .mbps = 150, .reg = 0x04 }, > + { .mbps = 170, .reg = 0x24 }, > + { .mbps = 180, .reg = 0x44 }, > + { .mbps = 200, .reg = 0x06 }, > + { .mbps = 220, .reg = 0x26 }, > + { .mbps = 240, .reg = 0x46 }, > + { .mbps = 250, .reg = 0x08 }, > + { .mbps = 270, .reg = 0x28 }, > + { .mbps = 300, .reg = 0x0a }, > + { .mbps = 330, .reg = 0x2a }, > + { .mbps = 360, .reg = 0x4a }, > + { .mbps = 400, .reg = 0x0c }, > + { .mbps = 450, .reg = 0x2c }, > + { .mbps = 500, .reg = 0x0e }, > + { .mbps = 550, .reg = 0x2e }, > + { .mbps = 600, .reg = 0x10 }, > + { .mbps = 650, .reg = 0x30 }, > + { .mbps = 700, .reg = 0x12 }, > + { .mbps = 750, .reg = 0x32 }, > + { .mbps = 800, .reg = 0x52 }, > + { .mbps = 850, .reg = 0x72 }, > + { .mbps = 900, .reg = 0x14 }, > + { .mbps = 950, .reg = 0x34 }, > + { .mbps = 1000, .reg = 0x54 }, > + { .mbps = 1050, .reg = 0x74 }, > { .mbps = 1125, .reg = 0x16 }, > { /* sentinel */ }, > }; > -- > 2.7.4 > -- Regards, Niklas Söderlund
WARNING: multiple messages have this Message-ID (diff)
From: "Niklas Söderlund" <niklas.soderlund@ragnatech.se> To: Jacopo Mondi <jacopo+renesas@jmondi.org> Cc: laurent.pinchart@ideasonboard.com, kieran.bingham@ideasonboard.com, linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH] media: rcar-csi2: Fix PHTW table values for E3/V3M Date: Mon, 10 Dec 2018 16:24:50 +0100 [thread overview] Message-ID: <20181210152450.GJ17972@bigcity.dyn.berto.se> (raw) In-Reply-To: <1544453635-16359-1-git-send-email-jacopo+renesas@jmondi.org> Hi Jacopo, Thanks for fixing this. On 2018-12-10 15:53:55 +0100, Jacopo Mondi wrote: > The PHTW selection algorithm implemented in rcsi2_phtw_write_mbps() checks for > lower bound of the interval used to match the desired bandwidth. Use that > in place of the currently used upport bound. > > Fixes: 10c08812fe60 ("media: rcar: rcar-csi2: Update V3M/E3 PHTW tables") > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> Acked-by: Niklas S�derlund <niklas.soderlund+renesas@ragnatech.se> > --- > drivers/media/platform/rcar-vin/rcar-csi2.c | 62 ++++++++++++++--------------- > 1 file changed, 31 insertions(+), 31 deletions(-) > > diff --git a/drivers/media/platform/rcar-vin/rcar-csi2.c b/drivers/media/platform/rcar-vin/rcar-csi2.c > index 80ad906d1136..7e9cb8bcfe70 100644 > --- a/drivers/media/platform/rcar-vin/rcar-csi2.c > +++ b/drivers/media/platform/rcar-vin/rcar-csi2.c > @@ -152,37 +152,37 @@ static const struct rcsi2_mbps_reg phtw_mbps_h3_v3h_m3n[] = { > }; > > static const struct rcsi2_mbps_reg phtw_mbps_v3m_e3[] = { > - { .mbps = 89, .reg = 0x00 }, > - { .mbps = 99, .reg = 0x20 }, > - { .mbps = 109, .reg = 0x40 }, > - { .mbps = 129, .reg = 0x02 }, > - { .mbps = 139, .reg = 0x22 }, > - { .mbps = 149, .reg = 0x42 }, > - { .mbps = 169, .reg = 0x04 }, > - { .mbps = 179, .reg = 0x24 }, > - { .mbps = 199, .reg = 0x44 }, > - { .mbps = 219, .reg = 0x06 }, > - { .mbps = 239, .reg = 0x26 }, > - { .mbps = 249, .reg = 0x46 }, > - { .mbps = 269, .reg = 0x08 }, > - { .mbps = 299, .reg = 0x28 }, > - { .mbps = 329, .reg = 0x0a }, > - { .mbps = 359, .reg = 0x2a }, > - { .mbps = 399, .reg = 0x4a }, > - { .mbps = 449, .reg = 0x0c }, > - { .mbps = 499, .reg = 0x2c }, > - { .mbps = 549, .reg = 0x0e }, > - { .mbps = 599, .reg = 0x2e }, > - { .mbps = 649, .reg = 0x10 }, > - { .mbps = 699, .reg = 0x30 }, > - { .mbps = 749, .reg = 0x12 }, > - { .mbps = 799, .reg = 0x32 }, > - { .mbps = 849, .reg = 0x52 }, > - { .mbps = 899, .reg = 0x72 }, > - { .mbps = 949, .reg = 0x14 }, > - { .mbps = 999, .reg = 0x34 }, > - { .mbps = 1049, .reg = 0x54 }, > - { .mbps = 1099, .reg = 0x74 }, > + { .mbps = 80, .reg = 0x00 }, > + { .mbps = 90, .reg = 0x20 }, > + { .mbps = 100, .reg = 0x40 }, > + { .mbps = 110, .reg = 0x02 }, > + { .mbps = 130, .reg = 0x22 }, > + { .mbps = 140, .reg = 0x42 }, > + { .mbps = 150, .reg = 0x04 }, > + { .mbps = 170, .reg = 0x24 }, > + { .mbps = 180, .reg = 0x44 }, > + { .mbps = 200, .reg = 0x06 }, > + { .mbps = 220, .reg = 0x26 }, > + { .mbps = 240, .reg = 0x46 }, > + { .mbps = 250, .reg = 0x08 }, > + { .mbps = 270, .reg = 0x28 }, > + { .mbps = 300, .reg = 0x0a }, > + { .mbps = 330, .reg = 0x2a }, > + { .mbps = 360, .reg = 0x4a }, > + { .mbps = 400, .reg = 0x0c }, > + { .mbps = 450, .reg = 0x2c }, > + { .mbps = 500, .reg = 0x0e }, > + { .mbps = 550, .reg = 0x2e }, > + { .mbps = 600, .reg = 0x10 }, > + { .mbps = 650, .reg = 0x30 }, > + { .mbps = 700, .reg = 0x12 }, > + { .mbps = 750, .reg = 0x32 }, > + { .mbps = 800, .reg = 0x52 }, > + { .mbps = 850, .reg = 0x72 }, > + { .mbps = 900, .reg = 0x14 }, > + { .mbps = 950, .reg = 0x34 }, > + { .mbps = 1000, .reg = 0x54 }, > + { .mbps = 1050, .reg = 0x74 }, > { .mbps = 1125, .reg = 0x16 }, > { /* sentinel */ }, > }; > -- > 2.7.4 > -- Regards, Niklas S�derlund
next prev parent reply other threads:[~2018-12-10 15:24 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-12-10 14:53 [PATCH] media: rcar-csi2: Fix PHTW table values for E3/V3M Jacopo Mondi 2018-12-10 15:24 ` Niklas Söderlund [this message] 2018-12-10 15:24 ` Niklas Söderlund 2018-12-10 20:16 ` Laurent Pinchart 2018-12-11 2:01 ` Niklas Söderlund 2018-12-11 2:01 ` Niklas Söderlund 2018-12-11 7:49 ` Laurent Pinchart 2018-12-11 11:33 ` jacopo mondi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181210152450.GJ17972@bigcity.dyn.berto.se \ --to=niklas.soderlund@ragnatech.se \ --cc=jacopo+renesas@jmondi.org \ --cc=kieran.bingham@ideasonboard.com \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-media@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.